[Bug 832810] New: Review Request: perl-Method-Signatures - Method and function declarations with signatures and no source filter

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=832810

Bug ID: 832810
        QA Contact: [e-mail]
          Severity: medium
           Version: rawhide
          Priority: medium
                CC: [e-mail],
                    [e-mail]
          Assignee: [e-mail]
           Summary: Review Request: perl-Method-Signatures - Method and
                    function declarations with signatures and no source
                    filter
        Regression: ---
      Story Points: ---
    Classification: Fedora
                OS: Linux
          Reporter: [e-mail]
              Type: ---
     Documentation: ---
          Hardware: All
        Mount Type: ---
            Status: NEW
         Component: Package Review
           Product: Fedora

Spec URL: http://fedorapeople.org/~iarnell/review/perl-Method-Signatures.spec
SRPM URL:
http://fedorapeople.org/~iarnell/review/perl-Method-Signatures-20120523-1.fc...
Description: 
Provides two new keywords, func and method, so that you can write
subroutines with signatures.

Koji URL: https://koji.fedoraproject.org/koji/taskinfo?taskID=4172212

[Bug 832810] Review Request: perl-Method-Signatures - Method and function declarations with signatures and no source filter

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=832810

Petr Šabata  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

[Bug 832810] Review Request: perl-Method-Signatures - Method and function declarations with signatures and no source filter

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=832810

Petr Šabata  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #1 from Petr Šabata  ---
The fedora-review reports are getting insanely long; I guess I'll just stop
pasting them :)

Anyhow, after going through your package...

TODO: Missing BRs: perl(base), perl(Exporter), perl(Role::Basic), and possibly
even perl(MooseX::Declare::Syntax::Keyword::Method) and
perl(MooseX::Declare::Syntax::Keyword::MethodModifier) to be on the safe side.
TODO: Remove underspecified runtime deps, perl(Data::Alias),
perl(Devel::Pragma), and perl(Sub::Name)

No blockers, approving.

[Bug 832810] Review Request: perl-Method-Signatures - Method and function declarations with signatures and no source filter

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=832810

Iain Arnell  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-cvs?

--- Comment #2 from Iain Arnell  ---
New Package SCM Request
=======================
Package Name: perl-Method-Signatures
Short Description: Method and function declarations with signatures and no
source filter
Owners: iarnell
Branches: f16 f17
InitialCC: perl-sig

[Bug 832810] Review Request: perl-Method-Signatures - Method and function declarations with signatures and no source filter

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=832810

--- Comment #3 from Jon Ciesla  ---
Git done (by process-git-requests).

[Bug 832810] Review Request: perl-Method-Signatures - Method and function declarations with signatures and no source filter

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=832810

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED

[Bug 832810] Review Request: perl-Method-Signatures - Method and function declarations with signatures and no source filter

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=832810

--- Comment #4 from Fedora Update System  ---
perl-Method-Signatures-20120523-2.fc17 has been submitted as an update for
Fedora 17.
https://admin.fedoraproject.org/updates/perl-Method-Signatures-20120523-2.fc...

[Bug 832810] Review Request: perl-Method-Signatures - Method and function declarations with signatures and no source filter

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=832810

--- Comment #5 from Fedora Update System  ---
perl-Method-Signatures-20120523-2.fc16 has been submitted as an update for
Fedora 16.
https://admin.fedoraproject.org/updates/perl-Method-Signatures-20120523-2.fc...

[Bug 832810] Review Request: perl-Method-Signatures - Method and function declarations with signatures and no source filter

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=832810

--- Comment #6 from Iain Arnell  ---
Thanks for the review, Petr. I've added the additional BRs, except Role::Basic
which we don't (yet) have. Upstream notes in the test, though, that Role::Basic
support isn't really a viable use case.

[Bug 832810] Review Request: perl-Method-Signatures - Method and function declarations with signatures and no source filter

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=832810

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #7 from Fedora Update System  ---
perl-Method-Signatures-20120523-2.fc16 has been pushed to the Fedora 16 testing
repository.

[Bug 832810] Review Request: perl-Method-Signatures - Method and function declarations with signatures and no source filter

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=832810

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2012-07-07 17:53:52

--- Comment #8 from Fedora Update System  ---
perl-Method-Signatures-20120523-2.fc16 has been pushed to the Fedora 16 stable
repository.

[Bug 832810] Review Request: perl-Method-Signatures - Method and function declarations with signatures and no source filter

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=832810

--- Comment #9 from Fedora Update System  ---
perl-Method-Signatures-20120523-2.fc17 has been pushed to the Fedora 17 stable
repository.