commit 3d1dcaca50bceda1354cb397cd407d0c3089f24f
Author: Pierre-Yves Chibon <pingou(a)pingoured.fr>
Date: Tue Dec 1 12:11:23 2015 +0100
Check if the person approving the review is the same as the one creating it
Fixes
https://github.com/fedora-infra/packagedb-cli/issues/56
pkgdb2client/utils.py | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
---
diff --git a/pkgdb2client/utils.py b/pkgdb2client/utils.py
index e543336..c19dcf9 100644
--- a/pkgdb2client/utils.py
+++ b/pkgdb2client/utils.py
@@ -257,6 +257,10 @@ def check_package_creation(info, bugid, pkgdbclient):
messages["bad"].append(
'Review approved by non-packager {0}'.format(
flag_setter))
+ if flag_setter == bug.comments[0].author:
+ messages["bad"].append(
+ 'Review approved by the person creating '
+ 'the ticket {0}'.format(flag_setter))
else:
messages["bad"].append(
'Review not approved, flag set to: {0}'.format(