Re: [Fedora-packaging] Merge-review questions....

[Kevin Fenzi]

On Mon, 27 Jul 2009 11:37:37 +0530
Parag N(पराग़) <panemade(a)gmail.com&gt; wrote:

>  Hi,
>      I got some questions on Merge-reviews
>  1) If as per review guidelines merge-review of any package does not
>  got any blocker but missing to follow some packaging guidelines like
>  missing to follow timestamps, should I just ask in review and approve
>  that merge-review or wait for developer to fix spec file? 
I would ask them if they minded if you just commited those fixes, then
you could mark it fixed. If they are not review blockers, then you
could also just mark it approved and leave it at that. 

>  2) If developer does not replies within a month time or asking me as
> a
>  reviewer to commit in cvs what should I do for merge-review (Assume I
>  am always there to help and complete merge-review)? 
I would send them a personal email, wait a bit more, then note this to
fedora-devel, then perhaps wait a bit more and bring it up to fesco. 

There seems to be lots of questions that come up on merge reviews. ;( 

To help this out, I have started a wiki page at: 

https://fedoraproject.org/wiki/Merge_Reviews

Perhaps we can polish that up and note it to interested Merge
reviewers? 

Feedback welcome. 

>  Thanks & Regards,
>  Parag. 
kevin