Re: [Fedora-packaging] jpopelka pushed to hplip (master). "merge hpijs into main package (#1033952#14)"

[Dominik 'Rathann' Mierzejewski]

Hello,

On Wednesday, 29 July 2015 at 18:56, notifications(a)fedoraproject.org wrote:
>  From 2ef869366f07cbddb2d5a9d91b5b3ac80a62a5a6 Mon Sep 17 00:00:00
> 2001
>  From: Jiri Popelka <jpopelka(a)redhat.com&gt;
>  Date: Wed, 29 Jul 2015 15:39:14 +0200
>  Subject: merge hpijs into main package (#1033952#14)
>  
>  
>  diff --git a/hplip.spec b/hplip.spec
>  index 281d46e..87a98ee 100644
>  --- a/hplip.spec
>  +++ b/hplip.spec 
[...]  
>  +# hpijs was merged into main package in 3.15.7-2
>  +Obsoletes: hpijs
>  +Provides:  hpijs 
This is wrong. You should use versioned Obsoletes and Provides.
Otherwise all kinds of mysterious side effects may occur. For example,
triggers with conditions on hpijs don't work correctly anymore.

Regards,
Dominik
-- 
Fedora http://fedoraproject.org/wiki/User:Rathann
RPMFusion http://rpmfusion.org
"Faith manages."
        -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"

jpopelka pushed to hplip (master). "merge hpijs into main package (#1033952#14)"

[Jiri Popelka]

On 29.7.2015 22:55, Dominik Mierzejewski wrote:
>  Hello,
>  
>  On Wednesday, 29 July 2015 at 18:56, notifications(a)fedoraproject.org wrote:
> > From 2ef869366f07cbddb2d5a9d91b5b3ac80a62a5a6 Mon Sep 17 00:00:00 2001
> > From: Jiri Popelka <jpopelka(a)redhat.com&gt;
> > Date: Wed, 29 Jul 2015 15:39:14 +0200
> > Subject: merge hpijs into main package (#1033952#14)
> >
> >
> > diff --git a/hplip.spec b/hplip.spec
> > index 281d46e..87a98ee 100644
> > --- a/hplip.spec
> > +++ b/hplip.spec
>  [...]  
> > +# hpijs was merged into main package in 3.15.7-2
> > +Obsoletes: hpijs
> > +Provides:  hpijs
>  
>  This is wrong. You should use versioned Obsoletes and Provides.
>  Otherwise all kinds of mysterious side effects may occur. For example,
>  triggers with conditions on hpijs don't work correctly anymore. 
Thanks

http://pkgs.fedoraproject.org/cgit/hplip.git/commit/?id=8effff4f8d14a79c1...

--
Jiri