Removing of unwanted compiler flags from $RPM_OPT_FLAGS

[Jochen Schmitt]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello,

becouse I have to find out, that some packages like blender have
trouble if you are specify $RPM_OPT_FLAGS I have tried to search
a method to remove selected compiler options from $RPM_OPT_FLAGS.

My suggestion to solve this problem you may find at

http://www.fedoraproject.org/wiki/JochenSchmitt/RemoveCFlagsFromRpmOptFla...

I will be happy for any comment and improvements.

Best Regards:

Jochen Schmitt

> -----BEGIN PGP SIGNATURE-----
> Version: PGP Desktop 9.0.2 (Build 2424)
>
> iQA/AwUBRQWfq09gByurcX4MEQJ6sgCg2XjHBWBAJww22r44/5RhqiP6JIAAoI+K
> PRZSyaFRredlXj4YLKXW2XwC
> =jsLk
> -----END PGP SIGNATURE-----

[Tom Callaway]

On Mon, 2006-09-11 at 19:40 +0200, Jochen Schmitt wrote:
>  -----BEGIN PGP SIGNED MESSAGE-----
>  Hash: SHA1
>  
>  Hello,
>  
>  becouse I have to find out, that some packages like blender have
>  trouble if you are specify $RPM_OPT_FLAGS I have tried to search
>  a method to remove selected compiler options from $RPM_OPT_FLAGS.
>  
>  My suggestion to solve this problem you may find at
>  
>  http://www.fedoraproject.org/wiki/JochenSchmitt/RemoveCFlagsFromRpmOptFla...
>  
>  I will be happy for any comment and improvements. 
That seems like serious overkill. Gambas can't build with the
FORTIFY_SOURCE flag, so I remove it like this:

# Gambas can't deal with -Wp,-D_FORTIFY_SOURCE=2
CFLAGS=`echo $RPM_OPT_FLAGS | sed -e 's/-Wp,-D_FORTIFY_SOURCE=2//g'

Thats it. No extra shell scripts necessary. :)

~spot
-- 
Tom "spot" Callaway || Red Hat || Fedora || Aurora || GPG ID: 93054260

"We must not confuse dissent with disloyalty. We must remember always
that accusation is not proof and that conviction depends upon evidence
and due process of law. We will not walk in fear, one of another. We
will not be driven by fear into an age of unreason, if we dig deep in
our history and our doctrine, and remember that we are not descended
from fearful men -- not from men who feared to write, to speak, to
associate and to defend causes that were, for the moment, unpopular."
-- Edward R. Murrow, March 9, 1954

[Ralf Corsepius]

On Mon, 2006-09-11 at 13:12 -0500, Tom 'spot' Callaway wrote:
>  On Mon, 2006-09-11 at 19:40 +0200, Jochen Schmitt wrote:
>  > -----BEGIN PGP SIGNED MESSAGE-----
>  > Hash: SHA1
>  > 
>  > Hello,
>  > 
>  > becouse I have to find out, that some packages like blender have
>  > trouble if you are specify $RPM_OPT_FLAGS I have tried to search
>  > a method to remove selected compiler options from $RPM_OPT_FLAGS.
>  > 
>  > My suggestion to solve this problem you may find at
>  > 
>  > http://www.fedoraproject.org/wiki/JochenSchmitt/RemoveCFlagsFromRpmOptFla...
>  > 
>  > I will be happy for any comment and improvements. 
IMO, a package that can't build with fortify enabled is broken and ought
to be fixed.

>  That seems like serious overkill. Gambas can't build with the
>  FORTIFY_SOURCE flag, so I remove it like this:
>  
>  # Gambas can't deal with -Wp,-D_FORTIFY_SOURCE=2
>  CFLAGS=`echo $RPM_OPT_FLAGS | sed -e 's/-Wp,-D_FORTIFY_SOURCE=2//g'
>  
>  Thats it. No extra shell scripts necessary. :) 
That's acceptable as a temporary work-around, but ... a package not
being able to deal with fortify is very likely to be plain broken (and
harmful, likely to be suffering from memory leaks), which means you are
playing with symptoms and not providing a cure.

Ralf

[Enrico Scholz]

Jochen(a)herr-schmitt.de (Jochen Schmitt) writes:

>  becouse I have to find out, that some packages like blender have
>  trouble if you are specify $RPM_OPT_FLAGS I have tried to search
>  a method to remove selected compiler options from $RPM_OPT_FLAGS.
>
>  My suggestion to solve this problem you may find at
>
>  http://www.fedoraproject.org/wiki/JochenSchmitt/RemoveCFlagsFromRpmOptFla...
The

|        RPM_OPT_FLAGS=$(echo $RPM_OPT_FLAGS | sed -e "s/\S*$i\S*//")

stuff can be written shorter as

| RPM_OPT_FLAGS=${RPM_OPT_FLAGS/-D.../}

or perhaps

| RPM_OPT_FLAGS="$RPM_OPT_FLAGS -fno-protector"


I do not think that it is worth to create extra scriptlets for this case;
packages which do not build with $RPM_OPT_FLAGS are usually broken.



Enrico