Package Cleanup Service

[Jason L Tibbitts III]

So I made this thing:  https://pagure.io/package-cleanup-service

I have no idea if anyone would either want to help with cleanup, or
would want anyone to actually do cleanup on their packages.  But we have
Pagure and pull requests now, which means that this stuff is far easier
to do than before.

So, if you want to help, let me know and I'll add you to the project and
we'll see if any tickets come in.  If you think it's a stupid idea, let
me know and... I guess I won't add you to the project.  If you want
someone to have a look at one of your packages, go ahead and be the
first to file a ticket.  At this point I can't promise any kind of
response time, but we'll see how it goes.

One thing I did add there was a distillation of a packaging style guide
that I've tinkered with on and off for years now.  I'm sure that
something there will annoy someone, but we're only offering cleanups and
even then only when someone asks for them, so I do hope to avoid
flamewars there but I do also welcome constructive feedback and ideas
for improvement.

- J<

[Jason L Tibbitts III]

And since I've already been asked, yes, many things should be
automated.  I don't disagree.  But there's a lot of stuff that is
difficult for a program to do which would be relatively easy for a human
to do, and so there's still a point to having human-based cleanups in
parallel to automated cleanups (which I'm also working on when I get the
time).

This seemed to be an easy way to leverage the fact that we have pull
requests against packages now, so I figured it was worth a try.

_ J<

[Igor Gnatenko]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On Wed, 2017-09-06 at 17:15 -0500, Jason L Tibbitts III wrote:
> So I made this thing:  https://pagure.io/package-cleanup-service
>
> I have no idea if anyone would either want to help with cleanup, or
> would want anyone to actually do cleanup on their packages.  But we
> have
> Pagure and pull requests now, which means that this stuff is far
> easier
> to do than before.
>
> So, if you want to help, let me know and I'll add you to the project
> and
> we'll see if any tickets come in.  If you think it's a stupid idea,
> let
> me know and... I guess I won't add you to the project.  If you want
> someone to have a look at one of your packages, go ahead and be the
> first to file a ticket.  At this point I can't promise any kind of
> response time, but we'll see how it goes.

I would like to help!
> One thing I did add there was a distillation of a packaging style
> guide
> that I've tinkered with on and off for years now.  I'm sure that
> something there will annoy someone, but we're only offering cleanups
> and
> even then only when someone asks for them, so I do hope to avoid
> flamewars there but I do also welcome constructive feedback and ideas
> for improvement.
> J<
>
> packaging mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail].o
> rg

- -- 
- -Igor Gnatenko
> -----BEGIN PGP SIGNATURE-----
>
> iQIzBAEBCAAdFiEEhLFO09aHZVqO+CM6aVcUvRu8X0wFAlmxBmwACgkQaVcUvRu8
> X0xJPg//WCdUBv+L4t0z80vAnRqk72jjCkP/H3AEZbzkI83AjkiaDCJnra1+ZgDL
> me2CWrg+3+n2KxE/geC73oUEamTz0zFbbIZzW9LArRird/Wd+4iYlnnKhQ49FOI7
> zfo6nvBx+yg9+6+MxfQDcypx4CzbU5T7zfKZvYmVCDl/xQBq1bmscOjwfyapdiTE
> Ub/racO4p2qcpQekSwtKeCL662TLLYqYeOKKqICdS+mIuxZOPYEpLDDumJD5A4h/
> oIrLKAeC+wqlJcZO+iQAC9FvDFWjWeulGN/uLuY6MRPqVdIj9CIO7EaN9BTDfdkH
> UbNTHeH7Qy/EUjg7+GRMpUxyBf3+Q/pKUh2kR/On1GNz7DM2kh0tacLEwmrUILmW
> 8Yz9deVcuIovgTOvUYxY4418n5047hkC6ruq5uTbN+SZEvcfB4eM9+8ZEkq+cJmj
> IOEqV5q0O0DCWuLZUSGr4xyo+UDxdc4BXFFYMCX1sbwr58OPkR9He/ydmNQ6rM1t
> xb3d7xr0EykiCUzTzatrWRAMZdGw4lyPDyyoS/BzJtlnYo5EsGRHwIoxk9Cu/H3g
> JL5iAAAJ/Jnli5g0dqUH3l4avNZLBOMC/HsbilRKQOCHrNAKk445/U4ohuIgJJuc
> 64HqjjoeRfG591CD2TZsf0FA3TGAG95vnC+JaSXNXgusR9cAPTI=
> =XsnJ
> -----END PGP SIGNATURE-----

[Robert-André Mauchin]

Le mercredi 06 sept. 2017 à 17:15:16 (-0500), Jason L Tibbitts III a écrit :
> So I made this thing:  https://pagure.io/package-cleanup-service
>
> I have no idea if anyone would either want to help with cleanup, or
> would want anyone to actually do cleanup on their packages.  But we have
> Pagure and pull requests now, which means that this stuff is far easier
> to do than before.
>
> So, if you want to help, let me know and I'll add you to the project and
> we'll see if any tickets come in.  If you think it's a stupid idea, let
> me know and... I guess I won't add you to the project.  If you want
> someone to have a look at one of your packages, go ahead and be the
> first to file a ticket.  At this point I can't promise any kind of
> response time, but we'll see how it goes.
>
> One thing I did add there was a distillation of a packaging style guide
> that I've tinkered with on and off for years now.  I'm sure that
> something there will annoy someone, but we're only offering cleanups and
> even then only when someone asks for them, so I do hope to avoid
> flamewars there but I do also welcome constructive feedback and ideas
> for improvement.
> J<

This is great. Does it also include the removal of old scriptlets that
shouldn't be included in Fedora >= 24, as shown in an older revision of 
this page: https://fedoraproject.org/w/index.php?title=Packaging:Scriptlets&oldid=4...
I still seem some people using them while doing reviews.

Best regards,

Robert-André

[Igor Gnatenko]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On Thu, 2017-09-07 at 12:24 +0200, Robert-André Mauchin wrote:
> Le mercredi 06 sept. 2017 à 17:15:16 (-0500), Jason L Tibbitts III a
> écrit :
> > So I made this thing:  https://pagure.io/package-cleanup-service
> >
> > I have no idea if anyone would either want to help with cleanup, or
> > would want anyone to actually do cleanup on their packages.  But we
> > have
> > Pagure and pull requests now, which means that this stuff is far
> > easier
> > to do than before.
> >
> > So, if you want to help, let me know and I'll add you to the
> > project and
> > we'll see if any tickets come in.  If you think it's a stupid idea,
> > let
> > me know and... I guess I won't add you to the project.  If you want
> > someone to have a look at one of your packages, go ahead and be the
> > first to file a ticket.  At this point I can't promise any kind of
> > response time, but we'll see how it goes.
> >
> > One thing I did add there was a distillation of a packaging style
> > guide
> > that I've tinkered with on and off for years now.  I'm sure that
> > something there will annoy someone, but we're only offering
> > cleanups and
> > even then only when someone asks for them, so I do hope to avoid
> > flamewars there but I do also welcome constructive feedback and
> > ideas
> > for improvement.
> > J<
>
> This is great. Does it also include the removal of old scriptlets
> that
> shouldn't be included in Fedora >= 24, as shown in an older revision
> of 
> this page: https://fedoraproject.org/w/index.php?title=Packaging:Scri
> ptlets&oldid=481889
> I still seem some people using them while doing reviews.

To my understanding, yes. Obviously, unless people asked for EPEL
compatibility (in which case person should add some if condition to
spec).
> Best regards,
>
> Robert-André
> _______________________________________________
> packaging mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail].o
> rg

- -- 
- -Igor Gnatenko
> -----BEGIN PGP SIGNATURE-----
>
> iQIzBAEBCAAdFiEEhLFO09aHZVqO+CM6aVcUvRu8X0wFAlmxOSQACgkQaVcUvRu8
> X0yUjhAAnLiBUE/fTXIkeIzkSQeEp5vXCj3Q1RDakeJ3dJpyQUbAf+rVHMuF/LQ+
> 4vORR86q56bEE9AvA6vsItni5eqsHIPYbYBn8L9V1fAomDyu973QI9K7sbx8SHG5
> 7isdf9eSuBnyHKuZI+ZBqi6Z/E9X0IRdhiTAe/Q34OTFH5mExjt39WQVqFI2fPFj
> jin0ayfmeLXBugg10cEd5SdnFT/SKmKH6MlQ9CU/vUZRxZjooEdCMgyUmqYtnoUM
> nvxy1IfnmMrGA9zYUMiwR3/BIuN4UTlcyDcpW31k9FjUoOE39r92moQJEOaQ9MKI
> I5o8vqx1NE8Y+vANG0xwMfHdV4BzCilUahYZC1rdAbs2rhbqhwuJe3aMso+O1QMc
> TzF3rBsURxqWc8nHRFn35GJJ4ODWLyCYAZB9yo/CQswMIRKIG4jcrx4tr0QGB+ht
> PqWjElD47NT2wTKgTVB6sFPWTvFyEi2pbpFRpInLrgDfhQCue9KfFjopI2qLyHOe
> wlD5jcHF49a8PPukpWCpgmWaNeBwAEcWt2FfnDtw+WgyXQZAz7lMeq8yNl5fWTd4
> xJG8RuOSoBVyjG9Xroz7sgeg48hXkeUUHjQWSPi64CjYMy/1aSQLEg6nsEkAzgKj
> PI9b6tIuArINewLuj+P3gz04QN6VQGqcpdM2zFmkxRR3Hiw7SPQ=
> =8WHy
> -----END PGP SIGNATURE-----

[Jason L Tibbitts III]

> > > > > "RM" == Robert-André Mauchin  writes:

RM> Does it also include the removal of old scriptlets
RM> that shouldn't be included in Fedora >= 24

Yes, that should be a thing.  Obviously that's a candidate for
automation as well, but you have to start somewhere.  We also have
significant scriptlet work in the pipeline which should make this
simpler, so stay tuned.  (I still need to open an FPC ticket to start
work on that.)

- J<

[Mat Booth]

On 6 September 2017 at 23:15, Jason L Tibbitts III 
wrote:
> So I made this thing:  https://pagure.io/package-cleanup-service
>
> I have no idea if anyone would either want to help with cleanup, or
> would want anyone to actually do cleanup on their packages.  But we have
> Pagure and pull requests now, which means that this stuff is far easier
> to do than before.
>
> So, if you want to help, let me know and I'll add you to the project and
> we'll see if any tickets come in.

Please add me :-)
> If you think it's a stupid idea, let
> me know and... I guess I won't add you to the project.  If you want
> someone to have a look at one of your packages, go ahead and be the
> first to file a ticket.  At this point I can't promise any kind of
> response time, but we'll see how it goes.
>
> One thing I did add there was a distillation of a packaging style guide
> that I've tinkered with on and off for years now.  I'm sure that
> something there will annoy someone, but we're only offering cleanups and
> even then only when someone asks for them, so I do hope to avoid
> flamewars there but I do also welcome constructive feedback and ideas
> for improvement.
> J<
>
> packaging mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]

[Jason L Tibbitts III]

> > > > > "MB" == Mat Booth  writes:

MB> Please add me :-)

So far I've added all who asked (as admins, so you can all add anyone
else who wants to help.  Now I guess we see if there is any demand, so
feel free to publicize the service.

- J<

[Matthew Miller]

On Wed, Sep 06, 2017 at 05:15:16PM -0500, Jason L Tibbitts III wrote:
> I have no idea if anyone would either want to help with cleanup, or
> would want anyone to actually do cleanup on their packages.  But we have
> Pagure and pull requests now, which means that this stuff is far easier
> to do than before.

As a casual/moderate Fedora packager, how do I know if my packages need
cleanup? Possibly if I thought there were problems I would have done it
already. Is there some sort of quick check people can run on their own
packages to even know if they might be candidates to ask for help?

[Igor Gnatenko]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On Fri, 2017-09-08 at 11:21 -0400, Matthew Miller wrote:
> On Wed, Sep 06, 2017 at 05:15:16PM -0500, Jason L Tibbitts III wrote:
> > I have no idea if anyone would either want to help with cleanup, or
> > would want anyone to actually do cleanup on their packages.  But we
> > have
> > Pagure and pull requests now, which means that this stuff is far
> > easier
> > to do than before.
>
> As a casual/moderate Fedora packager, how do I know if my packages
> need
> cleanup? Possibly if I thought there were problems I would have done
> it
> already. Is there some sort of quick check people can run on their
> own
> packages to even know if they might be candidates to ask for help?

That's great question! I would say like "if you don't know how your
spec works, it feels messy, hard to understand -- it needs cleanup" 😉
> -- 
> Matthew Miller
>
> Fedora Project Leader
> _______________________________________________
> packaging mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail].o
> rg

- -- 
- -Igor Gnatenko
> -----BEGIN PGP SIGNATURE-----
>
> iQIzBAEBCAAdFiEEhLFO09aHZVqO+CM6aVcUvRu8X0wFAlmzmw0ACgkQaVcUvRu8
> X0zqrg/+NXKAysyW50LrJGjUq+GVaA4E3qJTI4hLwEc8DT4SxmQffXaMT4R/0WWX
> NhnlwgWjlN04Zm7wnsMrMO2YSbrEkm6v8jk4tiAdc7BFzt6Nn9aDPab75gerVkr5
> 7kE0PhZ467mxPrmeTFa3JeU91CpAI6ut/G6c3QPGMZo0CZsXVQuuiEVTypDTKqR7
> fE4m+vwX7HogWw7B/pLvyiG1J8n3kXwYq5Lov2uY3A4Dh51D9fwa0f1XfuoMg1Te
> mbgBJDA/ORlZcV1/wwMq3y1xBR1BBPx205weYEd2bFPSfmwAa+j5J7F6hRewAN4h
> HtTS1h7QJ2yPLRRRxaxBkWV5hxuEUSc24tdCe9XkiyLXJWkQkmLCWeewVG3Bm2YP
> PA3zlJaJ1coM2zsKwysnRMYwUZ9+WoTlrbQcpjftm33GNhqUz4Kq3WvbznUd9Hg3
> mZTEUwWhaqG6fs6En2jBLtCDJGpGrColWXQiapIWljH1EI6k5DQiuKywRrMVwkMh
> 9lGaRpgx8nvf8iNLmVWe1NDF47u7wVyPNqwXJ0wzen83deDlLSF2ae81QAM1qH3f
> NPNVrtzR4HA0MwoFfN/8ukC1yEySsHP/6QjrzxN0ZIY+Wer1ryp6OPKkBVXTU6yV
> ZifKV9JPwKUlvZNYC7FdUc4XZxakAR8atlnPa2ppJXpbNVeuC50=
> =SpZR
> -----END PGP SIGNATURE-----

[Ben Rosser]

On Sat, Sep 9, 2017 at 3:41 AM, Igor Gnatenko
 wrote:
> > As a casual/moderate Fedora packager, how do I know if my packages
> > need
> > cleanup? Possibly if I thought there were problems I would have done
> > it
> > already. Is there some sort of quick check people can run on their
> > own
> > packages to even know if they might be candidates to ask for help?
>
> That's great question! I would say like "if you don't know how your
> spec works, it feels messy, hard to understand -- it needs cleanup" 😉

Perhaps a more automated way to check would be to have a script that
checks for certain deprecated syntax in a RPM spec?

For example, I imagine specs with a "defattr" in their files section
likely need to be cleaned up. Or a Group tag. Or no %license macro.
This suggests that the package probably needs to be modernized and may
have other things that need to be cleaned up.

Ben Rosser

[Laurent Tréguier]

Le samedi 09 septembre 2017 à 13:07 -0400, Ben Rosser a écrit :
> Perhaps a more automated way to check would be to have a script that
> checks for certain deprecated syntax in a RPM spec?
>
> For example, I imagine specs with a "defattr" in their files section
> likely need to be cleaned up. Or a Group tag. Or no %license macro.
> This suggests that the package probably needs to be modernized and may
> have other things that need to be cleaned up.
>
> Ben Rosser

Maybe the rpmlint command could help detect some deprecated syntaxes ? It doesn't check for missing %license macros and such, but does check for Group tags for
example.
On a side note, what's wrong with using "defattr" in %files ? I've never seen anything wrong with it up until now...

[Michael Schwendt]

On Sat, 09 Sep 2017 20:09:28 +0200, Laurent Tréguier wrote:
> On a side note, what's wrong with using "defattr" in %files ? I've never seen anything wrong with it up until now...

There are global defaults for file permissions, and if you don't change those
defaults, you don't need to use %defattr:

https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions

There are also spec files, which set wrong file permissions because of
a wrong %defattr instead of fixing %install.

[Charalampos Stratakis]

I'd gladly join as well.

Charalampos Stratakis
Software Engineer
Python Maintenance Team, Red Hat

----- Original Message -----
From: "Jason L Tibbitts III" 
To: [e-mail]
Sent: Thursday, September 7, 2017 12:15:16 AM
Subject: [Fedora-packaging] Package Cleanup Service

So I made this thing:  https://pagure.io/package-cleanup-service

I have no idea if anyone would either want to help with cleanup, or
would want anyone to actually do cleanup on their packages.  But we have
Pagure and pull requests now, which means that this stuff is far easier
to do than before.

So, if you want to help, let me know and I'll add you to the project and
we'll see if any tickets come in.  If you think it's a stupid idea, let
me know and... I guess I won't add you to the project.  If you want
someone to have a look at one of your packages, go ahead and be the
first to file a ticket.  At this point I can't promise any kind of
response time, but we'll see how it goes.

One thing I did add there was a distillation of a packaging style guide
that I've tinkered with on and off for years now.  I'm sure that
something there will annoy someone, but we're only offering cleanups and
even then only when someone asks for them, so I do hope to avoid
flamewars there but I do also welcome constructive feedback and ideas
for improvement.

- J<
_______________________________________________
packaging mailing list -- [e-mail]
To unsubscribe send an email to [e-mail]