question about rpmlint E: non-executable-script

[chedi toueiti]

Hi,

I'm reviewing a new package
https://bugzilla.redhat.com/show_bug.cgi?id=1810902

this package have bash scripts that are under /usr/lib and starting with a
shebang, rpmlint is detecting the error

E: non-executable-script

rpkg-macros.noarch: E: non-executable-script
/usr/lib/rpkg.macros.d/all.bash 644 /bin/bash
rpkg-macros.noarch: E: non-executable-script
/usr/lib/rpkg.macros.d/git.bash 644 /bin/bash
rpkg-macros.noarch: E: non-executable-script
/usr/lib/rpkg.macros.d/library/log.bash 644 /bin/bash
rpkg-macros.noarch: E: non-executable-script
/usr/lib/rpkg.macros.d/library/output.bash 644 /bin/bash
rpkg-macros.noarch: E: non-executable-script
/usr/lib/rpkg.macros.d/library/query.bash 644 /bin/bash
rpkg-macros.noarch: E: non-executable-script
/usr/lib/rpkg.macros.d/library/utils.bash 644 /bin/bash

The author desire to keep the shebang and not set the execution bit as the
files are not meant to be executable.

Should I consider the package valid or not in this case.

[Neal Gompa]

On Mon, Mar 9, 2020 at 8:54 AM chedi toueiti  wrote:
> Hi,
>
> I'm reviewing a new package
> https://bugzilla.redhat.com/show_bug.cgi?id=1810902
>
> this package have bash scripts that are under /usr/lib and starting with a shebang, rpmlint is detecting the error
>
> E: non-executable-script
>
> rpkg-macros.noarch: E: non-executable-script /usr/lib/rpkg.macros.d/all.bash 644 /bin/bash
> rpkg-macros.noarch: E: non-executable-script /usr/lib/rpkg.macros.d/git.bash 644 /bin/bash
> rpkg-macros.noarch: E: non-executable-script /usr/lib/rpkg.macros.d/library/log.bash 644 /bin/bash
> rpkg-macros.noarch: E: non-executable-script /usr/lib/rpkg.macros.d/library/output.bash 644 /bin/bash
> rpkg-macros.noarch: E: non-executable-script /usr/lib/rpkg.macros.d/library/query.bash 644 /bin/bash
> rpkg-macros.noarch: E: non-executable-script /usr/lib/rpkg.macros.d/library/utils.bash 644 /bin/bash
>
> The author desire to keep the shebang and not set the execution bit as the files are not meant to be executable.
>
> Should I consider the package valid or not in this case.

In the current case, this is not acceptable. These are the two choices
I would offer:

* Those should be in /usr/share if they are architecture-independent
scripts that aren't executed (shebangs should be purged)
* Those should be in /usr/libexec in any other case

--
真実はいつも一つ！/ Always, there's only one truth!

[Miroslav Suchý]

Dne 09. 03. 20 v 13:54 chedi toueiti napsal(a):
> The author desire to keep the shebang and not set the execution bit as the files are not meant to be executable.

You have to choose one or the other:
1) Either it is not meant to be executable, then remove the shebang. If the upstream hesitate to do that, it is fine to
do that during %build in spec file
2) It is meant to be executable, then add the execution bit.