This patch updates configure.in to use more recent interface for initialization of libtool as there seem to be some problem on recent libtool with using the old AC_PROG_LIBTOOL. There are also other minor changes. OK to commit?
On Thu, Sep 06, 2012 at 11:20:07AM +0200, Tomas Mraz wrote:
This patch updates configure.in to use more recent interface for initialization of libtool as there seem to be some problem on recent libtool with using the old AC_PROG_LIBTOOL.
What kind of problem?
There are also other minor changes. OK to commit?
Looks OK for me.
On Thu, 2012-09-06 at 16:10 +0400, Dmitry V. Levin wrote:
On Thu, Sep 06, 2012 at 11:20:07AM +0200, Tomas Mraz wrote:
This patch updates configure.in to use more recent interface for initialization of libtool as there seem to be some problem on recent libtool with using the old AC_PROG_LIBTOOL.
What kind of problem?
For some unknown reason the generated libtool script (and also the part of configure that generates it) did not contain the build_libtool_libs assignment and so the shared libraries could not be built.
On Thu, Sep 06, 2012 at 02:42:07PM +0200, Tomas Mraz wrote:
On Thu, 2012-09-06 at 16:10 +0400, Dmitry V. Levin wrote:
On Thu, Sep 06, 2012 at 11:20:07AM +0200, Tomas Mraz wrote:
This patch updates configure.in to use more recent interface for initialization of libtool as there seem to be some problem on recent libtool with using the old AC_PROG_LIBTOOL.
What kind of problem?
For some unknown reason the generated libtool script (and also the part of configure that generates it) did not contain the build_libtool_libs assignment and so the shared libraries could not be built.
Well, that's strange, in my case ./autogen.sh does the right thing, and I believe my libtool version 2.4.2 is recent enough.
On Thu, 2012-09-06 at 16:51 +0400, Dmitry V. Levin wrote:
On Thu, Sep 06, 2012 at 02:42:07PM +0200, Tomas Mraz wrote:
On Thu, 2012-09-06 at 16:10 +0400, Dmitry V. Levin wrote:
On Thu, Sep 06, 2012 at 11:20:07AM +0200, Tomas Mraz wrote:
This patch updates configure.in to use more recent interface for initialization of libtool as there seem to be some problem on recent libtool with using the old AC_PROG_LIBTOOL.
What kind of problem?
For some unknown reason the generated libtool script (and also the part of configure that generates it) did not contain the build_libtool_libs assignment and so the shared libraries could not be built.
Well, that's strange, in my case ./autogen.sh does the right thing, and I believe my libtool version 2.4.2 is recent enough.
Yes, it was strange and very hard to reproduce and I do not know what was the real culprit of the bug. Calling autogen.sh did not help. The only thing that helped was the change to LT_INIT.
On Thu, Sep 06, Tomas Mraz wrote:
This patch updates configure.in to use more recent interface for initialization of libtool as there seem to be some problem on recent libtool with using the old AC_PROG_LIBTOOL. There are also other minor changes. OK to commit?
I don't have problems with libtool, but I'm fine with the changes.
Thorsten
-- Tomas Mraz No matter how far down the wrong road you've gone, turn back. Turkish proverb
diff --git a/configure.in b/configure.in index ae762a2..515b301 100644 --- a/configure.in +++ b/configure.in @@ -3,7 +3,8 @@ AC_INIT AC_CONFIG_SRCDIR([conf/pam_conv1/pam_conv_y.y]) AC_CONFIG_AUX_DIR([build-aux]) AM_INIT_AUTOMAKE("Linux-PAM", 1.1.6) -AC_PREREQ(2.61) +LT_INIT([disable-static]) +AC_PREREQ([2.61]) AC_CONFIG_HEADERS([config.h]) AC_CONFIG_MACRO_DIR([m4]) AC_CANONICAL_HOST @@ -82,7 +83,6 @@ AM_PROG_LEX AC_PROG_INSTALL AC_PROG_LN_S AC_PROG_MAKE_SET -AC_PROG_LIBTOOL AM_PROG_CC_C_O PAM_LD_AS_NEEDED PAM_LD_NO_UNDEFINED @@ -532,7 +532,7 @@ AC_CHECK_FUNCS(unshare, [UNSHARE=yes], [UNSHARE=no]) AM_CONDITIONAL([HAVE_UNSHARE], [test "$UNSHARE" = yes])
AC_ARG_ENABLE([regenerate-docu],
- AC_HELP_STRING([--disable-regenerate-docu], [Don't re-build documentation from XML souces]),
- AS_HELP_STRING([--disable-regenerate-docu],[Don't re-build documentation from XML sources]), [enable_docu=$enableval], [enable_docu=yes])
dnl dnl Check for xsltproc
Pam-developers mailing list Pam-developers@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/pam-developers
pam-developers@lists.fedorahosted.org