#46: Fix build with musl libc ----------------------+------------------------------ Reporter: yousong | Owner: pam-developers@… Type: defect | Status: new Priority: major | Component: library Version: | Keywords: Blocked By: | Blocking: ----------------------+------------------------------ Hi, patch files in the attachments are produced when building libpam within OpenWrt. Not long ago, OpenWrt switched to musl as the default libc which is relatively and different from other implementations, e.g. crypt() function is part of musl-libc itself, many old functions are dropped from the implementation, etc.
#46: Fix build with musl libc --------------------+------------------------------- Reporter: yousong | Owner: pam-developers@… Type: defect | Status: new Priority: major | Component: library Version: | Resolution: Keywords: | Blocked By: Blocking: | --------------------+-------------------------------
Comment (by tmraz):
Most of the patches should be fine to apply but the two patches about docs are problematic. They seem to overload the ENABLE_REGENERATE_MAN option.
#46: Fix build with musl libc --------------------+------------------------------- Reporter: yousong | Owner: pam-developers@… Type: defect | Status: new Priority: major | Component: library Version: | Resolution: Keywords: | Blocked By: Blocking: | --------------------+-------------------------------
Comment (by yousong):
Hi,
The problem they tried to solve is that when building from git repository make would complain that there was `no rule to make target pam_access.8` and such errors. The cause of this should be that `ENABLE_REGENERATE_MAN` was not enabled because of missing xsltproc program so that `Make.xml.rules` was not included.
There is no such error when building from release tarballs as those files were already built and included there. And I though because of this those 2 patches can be safely dropped if you prefer it.
BTW. I just found that the ninth patch about replacing `strndupa()` was not secure. An updated version was attached.
#46: Fix build with musl libc --------------------+------------------------------- Reporter: yousong | Owner: pam-developers@… Type: defect | Status: new Priority: major | Component: library Version: | Resolution: Keywords: | Blocked By: Blocking: | --------------------+-------------------------------
Comment (by yousong):
Hi, any new comments on this?
#46: Fix build with musl libc --------------------+------------------------------- Reporter: yousong | Owner: pam-developers@… Type: defect | Status: closed Priority: major | Component: library Version: | Resolution: fixed Keywords: | Blocked By: Blocking: | --------------------+------------------------------- Changes (by kukuk):
* status: new => closed * resolution: => fixed
Comment:
Patches 1, 4 and 7 are part of Linux-PAM git now.
For patches 2 and 3: please disable the modules in the same way as done for pam_selinux.
For patches 5 and 6: if somebody builds directly from git and not from tar archive, he should have all tools to build the minimal documentation. Else there is the docs tar archive. We will not make changes for this code with the risk of breaking something for others.
Patch 0008: this patch is wrong, and it is not clear what this patch should fix. rpc/rpc.h will still be included with this patch.
pam-developers@lists.fedorahosted.org
-
fedora-badges