[Bug 1068706] New: Password prompt matching requires colon, which may be missing
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1068706
Bug ID: 1068706
Summary: Password prompt matching requires colon, which may be
missing
Product: Fedora
Version: 20
Component: perl-Net-SFTP-Foreign
Severity: low
Assignee: fedorapkg(a)rule.lv
Reporter: ejtr(a)layer3.co.uk
QA Contact: extras-qa(a)fedoraproject.org
CC: fedorapkg(a)rule.lv, perl-devel(a)lists.fedoraproject.org
Description of problem:
Net::SFTP::Foreign's password prompt matching code goes into a permanent loop
when the remote server supplies a prompt without a trailing colon.
Version-Release number of selected component (if applicable):
perl-Net-SFTP-Foreign-1.75-3.fc20.noarch.rpm
How reproducible:
When testing Net::SFTP::Foreign against an "unusual" host which supported
keyboard-interactive authentication, and thus generated a server-supplied
password prompt, it was found that the host in question had a prompt of the
form "username's password", rather than the more usual "username@host's
password: " as seen from OpenSSH client code supporting the password
authentication mode.
As a consequence, the Net::SFTP::Foreign module simply sulked waiting for a
colon.
Looking at the relevant
/usr/share/perl5/vendor_perl/Net/SFTP/Foreign/Backend/Unix.pm code file, we
find the following code fragment:
.....
debug and $debug & 65536 and _debug "looking for user/password prompt";
my $re = ( defined $password_prompt
? $password_prompt
: qr/(user|name|login)?[:?]\s*$/i );
$debug and $debug & 65536 and _debug "matching against $re";
if (substr($buffer, $at) =~ $re) {
if ($ask_for_username_at_login and
($ask_for_username_at_login ne 'auto' or defined $1)) {
$debug and $debug & 65536 and _debug "sending username";
print $pty "$user\n";
undef $ask_for_username_at_login;
}
else {
$debug and $debug & 65536 and _debug "sending password";
print $pty "$pass\n";
$password_sent = 1;
}
$at = length $buffer;
}
.....
In the absence of the $password_prompt setting, $re only matches a password
prompt containing the string "password" if it contains a colon or question-mark
after the word "password".
The code is also questionable in being capable of sending a password in
response to a prompt which contains only a colon followed by whitespace; I feel
it ought to at least see the word "password" or "passphrase".
The code also uses the $password_prompt variable to match against a potential
username prompt, which is questionable.
I believe it would be better to more completely separate the user and password
prompt matching with different Regex's, and avoid being able to match against
the short ":" string alone, and cope with the unusual condition of a missing
colon.
This recoding of the relevant block is a potential solution:
.....
$debug and $debug & 65536 and _debug "looking for user/password prompt";
my $reuser = qr/(user|name|login)([:?])?\s*$/i;
my $repass = ( defined $password_prompt ?
$password_prompt : qr/(password|passphrase)([:?])?\s*$/i );
if (substr($buffer, $at) =~ $reuser) {
$debug and $debug & 65536 and _debug "matched against $reuser";
if ($ask_for_username_at_login and
($ask_for_username_at_login ne 'auto' or defined $1)) {
$debug and $debug & 65536 and _debug "sending username";
print $pty "$user\n";
undef $ask_for_username_at_login;
}
$at = length $buffer;
} elsif (substr($buffer, $at) =~ $repass) {
$debug and $debug & 65536 and _debug "matched against $repass";
$debug and $debug & 65536 and _debug "sending password";
print $pty "$pass\n";
$password_sent = 1;
$at = length $buffer;
}
....
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SXtN9EENTL&a=cc_unsubscribe
8 years, 10 months
[Bug 1039268] New: png images not displayed
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1039268
Bug ID: 1039268
Summary: png images not displayed
Product: Fedora
Version: 20
Component: perl-Tk
Assignee: andreas.bierfert(a)lowlatency.de
Reporter: eserte12(a)yahoo.de
QA Contact: extras-qa(a)fedoraproject.org
CC: andreas.bierfert(a)lowlatency.de,
perl-devel(a)lists.fedoraproject.org
External Bug ID: CPAN 87016
Description of problem:
png images cannot be displayed anymore using perl-Tk's Tk::PNG module. This is
probably related to https://rt.cpan.org/Public/Bug/Display.html?id=87016
The problem does not appear anymore with a development release of Perl/Tk, e.g.
SREZIC/Tk-804.031_502.tar.gz
Version-Release number of selected component (if applicable):
perl-Tk-804.031-4.fc20.i686
How reproducible:
Steps to Reproduce:
1. Try the following oneliner with a random png image: perl -MTk -MTk::PNG -e
'$mw=tkinit;$mw->Label(-image => $mw->Photo(-file => shift))->pack; MainLoop'
pngtest.png
2.
3.
Actual results:
Error message "invalid after png_start_read_image or png_read_update_info at
/usr/lib/perl5/vendor_perl/Tk/Image.pm line 21.", no png image is displayed
Expected results:
png image should be visible in a X11 window, like it's the case with fedora 19.
Additional info:
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AqqyR7Q0Bx&a=cc_unsubscribe
8 years, 10 months
[Bug 919030] New: perl-Glib-Object-Introspection seems to have a big-endian problem, self tests fail on s390* and ppc*
by Red Hat Bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=919030
Bug ID: 919030
Summary: perl-Glib-Object-Introspection seems to have a
big-endian problem, self tests fail on s390* and ppc*
Product: Fedora
Version: rawhide
Component: perl-Glib-Object-Introspection
Severity: high
Priority: medium
Reporter: karsten(a)redhat.com
Description of problem:
# Failed test at t/00-basic-types.t line 15.
# got: '-1'
# expected: '-127'
# Failed test at t/00-basic-types.t line 16.
# got: '0'
# expected: '255'
# Failed test at t/00-basic-types.t line 17.
# got: '-1'
# expected: '-32767'
# Failed test at t/00-basic-types.t line 18.
# got: '0'
# expected: '65535'
# Looks like you failed 4 tests of 34.
t/00-basic-types.t ............
Dubious, test returned 4 (wstat 1024, 0x400)
Failed 4/34 subtests
# Failed test at t/arg-checks.t line 11.
# got: '-1'
# expected: '-127'
# Failed test at t/arg-checks.t line 21.
# got: '0'
# expected: '127'
# Looks like you failed 2 tests of 5.
t/arg-checks.t ................
Dubious, test returned 2 (wstat 512, 0x200)
Version-Release number of selected component (if applicable):
perl-Glib-Object-Introspection-0.015-1.fc19
How reproducible:
always
Steps to Reproduce:
1. ppc-koji build --scratch f19
perl-Glib-Object-Introspection-0.015-1.fc19.src.rpm
2.
3.
Actual results:
http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=973021
Expected results:
Additional info:
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YIO2oILrQB&a=cc_unsubscribe
8 years, 10 months