https://bugzilla.redhat.com/show_bug.cgi?id=1716324
Bug ID: 1716324 Summary: perl-Text-Xslate-3.5.6-5.fc30 is not linked to libperl.so Product: Fedora Version: 30 Status: NEW Component: perl-Text-Xslate Assignee: jplesnik@redhat.com Reporter: ppisar@redhat.com QA Contact: extras-qa@fedoraproject.org CC: i@cicku.me, jplesnik@redhat.com, perl-devel@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
perl-Text-Xslate-3.5.6-5.fc30 lost a dependency on libperl.so since -Wl,--as-needed was added to distribution-wide linker flags:
$ scanelf -n blib/arch/auto/Text/Xslate/Xslate.so TYPE NEEDED FILE ET_DYN libc.so.6 blib/arch/auto/Text/Xslate/Xslate.so
$ ldd -r blib/arch/auto/Text/Xslate/Xslate.so linux-vdso.so.1 (0x00007fff0d5cb000) libc.so.6 => /lib64/libc.so.6 (0x00007f948b9a1000) /lib64/ld-linux-x86-64.so.2 (0x00007f948bb8f000) undefined symbol: Perl_sv_cmp (blib/arch/auto/Text/Xslate/Xslate.so) undefined symbol: PL_ppaddr (blib/arch/auto/Text/Xslate/Xslate.so) [...]
Xslate.so is built like this:
gcc -lpthread -shared -Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -L/usr/local/lib -fstack-protector-strong -lperl -o blib/arch/auto/Text/Xslate/Xslate.so lib/Text/Xslate.o src/xslate_methods.o
The cause is that -Wl,--as-needed takes effect when library is supplied and considering only preceding object files and ignoring and following object files. A correct linker command must list all object files before -l flags. Like this:
gcc lib/Text/Xslate.o src/xslate_methods.o -lpthread -shared -Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -L/usr/local/lib -fstack-protector-strong -lperl -o blib/arch/auto/Text/Xslate/Xslate.so
Either there is bug in perl-Text-Xslate build script or in Module::Build::XSUtil that it uses.
https://bugzilla.redhat.com/show_bug.cgi?id=1716324
--- Comment #1 from Ben Cotton bcotton@redhat.com --- This message is a reminder that Fedora 30 is nearing its end of life. Fedora will stop maintaining and issuing updates for Fedora 30 on 2020-05-26. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '30'.
Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version.
Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 30 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above.
Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete.
https://bugzilla.redhat.com/show_bug.cgi?id=1716324
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|30 |31
--- Comment #2 from Petr Pisar ppisar@redhat.com --- Still issue in F33.
https://bugzilla.redhat.com/show_bug.cgi?id=1716324
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mmaslano@redhat.com, | |paul@city-fan.org, | |steve@silug.org Component|perl-Text-Xslate |perl-Module-Build Summary|perl-Text-Xslate-3.5.6-5.fc |Module::Build lists the |30 is not linked to |object files after the |libperl.so |linker flags, causing | |underlinking with | |-Wl,--as-needed
--- Comment #3 from Petr Pisar ppisar@redhat.com --- I read Module::Build::XSUtil, and it does not do anything special regarding the order of object files and linker flags. Module::Build::XSUtil inherits from Module::Build. I checked perl-RPM2 that also uses Module::Build, and the issue manifests there either:
gcc -lpthread -shared -Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -L/usr/local/lib -fstack-protector-strong -lperl -o blib/arch/auto/RPM2/RPM2.so lib/RPM2.o -lrpm -lrpmio
I conclude this is a bug in perl-Module-Build.
https://bugzilla.redhat.com/show_bug.cgi?id=1716324
Paul Howarth paul@city-fan.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jose.p.oliveira.oss@gmail.c | |om, ppisar@redhat.com, | |tcallawa@redhat.com Component|perl-Module-Build |perl-ExtUtils-CBuilder Assignee|jplesnik@redhat.com |ppisar@redhat.com
--- Comment #4 from Paul Howarth paul@city-fan.org --- I think the problem may actually lie within ExtUtils::CBuilder (which Module::Build delegates the processes of compiling and linking to), and more specifically to the patch we added to get the linking to libperl to happen in the first place. In that patch, $cf->{lddlflags} has "-lperl" appended to it, and that goes before the object files in the linker command. On the other hand, the ExtUtils::CBuilder::Platform::android module already has code to add libperl to the mix, and does it by fiddling with $args{extra_linker_flags} instead. Maybe our patch should do the same?
https://bugzilla.redhat.com/show_bug.cgi?id=1716324
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|ppisar@redhat.com |jplesnik@redhat.com
--- Comment #5 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- This package has changed maintainer in the Fedora. Reassigning to the new maintainer of this component.
https://bugzilla.redhat.com/show_bug.cgi?id=1716324
--- Comment #6 from Ben Cotton bcotton@redhat.com --- This message is a reminder that Fedora 31 is nearing its end of life. Fedora will stop maintaining and issuing updates for Fedora 31 on 2020-11-24. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '31'.
Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version.
Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 31 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above.
Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete.
https://bugzilla.redhat.com/show_bug.cgi?id=1716324
Paul Howarth paul@city-fan.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|31 |rawhide
https://bugzilla.redhat.com/show_bug.cgi?id=1716324
--- Comment #8 from Ben Cotton bcotton@redhat.com --- This message is a reminder that Fedora Linux 34 is nearing its end of life. Fedora will stop maintaining and issuing updates for Fedora Linux 34 on 2022-06-07. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a 'version' of '34'.
Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, change the 'version' to a later Fedora Linux version.
Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora Linux 34 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora Linux, you are encouraged to change the 'version' to a later version prior to this bug being closed.
https://bugzilla.redhat.com/show_bug.cgi?id=1716324
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|34 |35
--- Comment #9 from Petr Pisar ppisar@redhat.com --- Based on perl-Text-Xslate package in F35, this is still an issue.
https://bugzilla.redhat.com/show_bug.cgi?id=1716324
--- Comment #10 from Ben Cotton bcotton@redhat.com --- This message is a reminder that Fedora Linux 35 is nearing its end of life. Fedora will stop maintaining and issuing updates for Fedora Linux 35 on 2022-12-13. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a 'version' of '35'.
Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, change the 'version' to a later Fedora Linux version.
Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora Linux 35 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora Linux, you are encouraged to change the 'version' to a later version prior to this bug being closed.
https://bugzilla.redhat.com/show_bug.cgi?id=1716324
Paul Howarth paul@city-fan.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|35 |36
--- Comment #11 from Paul Howarth paul@city-fan.org --- No activity this cycle, presumably still an issue.
https://bugzilla.redhat.com/show_bug.cgi?id=1716324
Michal Josef Spacek mspacek@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mspacek@redhat.com
--- Comment #12 from Michal Josef Spacek mspacek@redhat.com --- (In reply to Paul Howarth from comment #4)
On the other hand, the ExtUtils::CBuilder::Platform::android module already has code to add libperl to the mix, and does it by fiddling with $args{extra_linker_flags} instead. Maybe our patch should do the same?
I think yes.
This issue isn't related to Fedora settings. The same situation is in Debian or a fresh install of the Text::Xslate. There are many similar issues in Fedora: like perl-Data-MessagePack
https://bugzilla.redhat.com/show_bug.cgi?id=1716324
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|36 |38
https://bugzilla.redhat.com/show_bug.cgi?id=1716324
--- Comment #13 from Aoife Moloney amoloney@redhat.com --- This message is a reminder that Fedora Linux 38 is nearing its end of life. Fedora will stop maintaining and issuing updates for Fedora Linux 38 on 2024-05-21. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a 'version' of '38'.
Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, change the 'version' to a later Fedora Linux version. Note that the version field may be hidden. Click the "Show advanced fields" button if you do not see it.
Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora Linux 38 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora Linux, you are encouraged to change the 'version' to a later version prior to this bug being closed.
https://bugzilla.redhat.com/show_bug.cgi?id=1716324
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|38 |39
perl-devel@lists.fedoraproject.org