zdohnal opened a new pull-request against the project: `perl-Font-AFM` that you are following: `` Use NimbusSans-Bold font for afm font metrics testing ``
To reply, visit the link below https://src.fedoraproject.org/rpms/perl-Font-AFM/pull-request/1
xavierb commented on the pull-request: `Use NimbusSans-Bold font for afm font metrics testing` that you are following: `` Wouldn't it be better to BR: the package providing the file rather than the file itself ? `BuildRequires: urw-base35-nimbus-sans-fonts` rather than `BuildRequires: %{_datadir}/fonts/urw-base35/NimbusSans-Bold.afm`
File requires are most costly to resolve than package requires and I'm not sure why this was a file requires in the first place.
``
To reply, visit the link below https://src.fedoraproject.org/rpms/perl-Font-AFM/pull-request/1
zdohnal commented on the pull-request: `Use NimbusSans-Bold font for afm font metrics testing` that you are following: `` Hi @xavierb ,
yes, that can be done. I'll update the PR. ``
To reply, visit the link below https://src.fedoraproject.org/rpms/perl-Font-AFM/pull-request/1
zdohnal commented on the pull-request: `Use NimbusSans-Bold font for afm font metrics testing` that you are following: `` Or rather open a new - I can't find a way how to rebase a PR in pagure... ``
To reply, visit the link below https://src.fedoraproject.org/rpms/perl-Font-AFM/pull-request/1
ppisar commented on the pull-request: `Use NimbusSans-Bold font for afm font metrics testing` that you are following: `` By force pushing (git push -f)? ``
To reply, visit the link below https://src.fedoraproject.org/rpms/perl-Font-AFM/pull-request/1
zdohnal commented on the pull-request: `Use NimbusSans-Bold font for afm font metrics testing` that you are following: `` @ppisar actually I didn't clone my fork to my machine, just forked pagure project and made changes there via Web UI. It looked quicker. ``
To reply, visit the link below https://src.fedoraproject.org/rpms/perl-Font-AFM/pull-request/1
xavierb commented on the pull-request: `Use NimbusSans-Bold font for afm font metrics testing` that you are following: `` This PR should fix: - https://bugzilla.redhat.com/show_bug.cgi?id=1581656 (dependency on a2ps) - https://bugzilla.redhat.com/show_bug.cgi?id=1731721 (file dependency) ``
To reply, visit the link below https://src.fedoraproject.org/rpms/perl-Font-AFM/pull-request/1
corsepiu commented on the pull-request: `Use NimbusSans-Bold font for afm font metrics testing` that you are following: `` I do not agree with any of these patches and will not apply them
Rationale: I consider using package deps instead of file deps to be insane and not helpful.
``
To reply, visit the link below https://src.fedoraproject.org/rpms/perl-Font-AFM/pull-request/1
xavierb commented on the pull-request: `Use NimbusSans-Bold font for afm font metrics testing` that you are following: `` About the file dependency, here's the guideline: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directo... This is a SHOULD NOT, not a MUST NOT, but this guideline was the reason why I suggested to use a package dependency rather than a file dependency. Could you explain why you consider this to be insane and not helpful ?
Also, I'm not sure why you are objecting to the removal of the dependency on a2ps. You seem to agree to this removal in https://bugzilla.redhat.com/show_bug.cgi?id=1581656#c2 ``
To reply, visit the link below https://src.fedoraproject.org/rpms/perl-Font-AFM/pull-request/1
zdohnal commented on the pull-request: `Use NimbusSans-Bold font for afm font metrics testing` that you are following: `` @corsepiu I'm willing to use a file dependency if it is required.
Please let me know if I should change something else.
I understand you want the best for your package as its maintainer and I truly thinks Font-AFM benefits from using NimbusSans-Bold instead of phvr, assuring font metric from Font-AFM works with the current fonts.
Thank you for reviewing the merge request and your work as a packager so far, Ralf! ``
To reply, visit the link below https://src.fedoraproject.org/rpms/perl-Font-AFM/pull-request/1
zdohnal commented on the pull-request: `Use NimbusSans-Bold font for afm font metrics testing` that you are following: `` @corsepiu I'll wait with changing PR till you and Xavier finish the discussion.
In my humble opinion I prefer a package dependency too - it will clearly tell the spec file reader what package you bring into buildroot/system.
However, you are the package maintainer, I'm willing to change the PR as you see fit. ``
To reply, visit the link below https://src.fedoraproject.org/rpms/perl-Font-AFM/pull-request/1
zdohnal commented on the pull-request: `Use NimbusSans-Bold font for afm font metrics testing` that you are following: `` Creating a new PR. ``
To reply, visit the link below https://src.fedoraproject.org/rpms/perl-Font-AFM/pull-request/1
zdohnal closed without merging a pull-request against the project: `perl-Font-AFM` that you are following.
Closed pull-request:
`` Use NimbusSans-Bold font for afm font metrics testing ``
https://src.fedoraproject.org/rpms/perl-Font-AFM/pull-request/1
perl-devel@lists.fedoraproject.org
-
Petr Pisar -
Ralf Corsépius
-
Xavier Bachelot
-
Zdenek Dohnal