[Bug 1749126] New: perl-Glib-Object-Introspection should depend on perl-Gtk3

https://bugzilla.redhat.com/show_bug.cgi?id=1749126

Bug ID: 1749126
           Summary: perl-Glib-Object-Introspection should depend on
                    perl-Gtk3
           Product: Fedora
           Version: 30
            Status: NEW
         Component: perl-Glib-Object-Introspection
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail], [e-mail],
                    [e-mail]
  Target Milestone: ---
    Classification: Fedora

Description of problem: perli11ndoc script from perl-Glib-Object-Introspection
package fails to work if no perl-Gtk3 is installed. Please consider adding
runtime dependency on perl-Gtk3.

Version-Release number of selected component (if applicable):
perl-Glib-Object-Introspection-0.047-1.fc30.x86_64

How reproducible: always

Steps to Reproduce:
1. dnf remove perl-Gtk3
2. dnf install perl-Glib-Object-Introspection
3. perli11ndoc

Actual results:
Usage: perli11ndoc <library name>[::<element name>[::<element name>]] at
/usr/bin/perli11ndoc line 31.

[Bug 1749126] perl-Glib-Object-Introspection should depend on perl-Gtk3

https://bugzilla.redhat.com/show_bug.cgi?id=1749126

Petr Pisar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Petr Pisar  ---
I'd rather recommend subpackaging the script. There is no reason why Glib
should depend on Gtk.

[Bug 1749126] perl-Glib-Object-Introspection should depend on perl-Gtk3

https://bugzilla.redhat.com/show_bug.cgi?id=1749126

--- Comment #2 from Vadim Raskhozhev  ---
(In reply to Petr Pisar from comment #1)
> I'd rather recommend subpackaging the script. There is no reason why Glib
> should depend on Gtk.

From the user point of view it doesn't matter much as long as the script is
usable out of the box. From the packager point of view you definitely right.
AFAIU, there should be no problem doing something like

%package -n perli18ndoc
Requires: perl(Gtk3)
Requires: perl(Glib::Object::Introspection)

%files perli18ndoc
%{_bindir}/%{name}

[Bug 1749126] perl-Glib-Object-Introspection should depend on perl-Gtk3

https://bugzilla.redhat.com/show_bug.cgi?id=1749126

--- Comment #3 from Petr Pisar  ---
From user point of view there would a bloat of dependencies. Glib does not
require X11. Gtk does. That's the reasoning.

[Bug 1749126] perl-Glib-Object-Introspection should depend on perl-Gtk3

https://bugzilla.redhat.com/show_bug.cgi?id=1749126

--- Comment #4 from Vadim Raskhozhev  ---
(In reply to Petr Pisar from comment #3)
> From user point of view there would a bloat of dependencies. Glib does not
> require X11. Gtk does. That's the reasoning.

I finally got your point now. You're right.

[Bug 1749126] perl-Glib-Object-Introspection should depend on perl-Gtk3

https://bugzilla.redhat.com/show_bug.cgi?id=1749126

--- Comment #5 from Vadim Raskhozhev  ---
Created attachment 1614108
  --> https://bugzilla.redhat.com/attachment.cgi?id=1614108&action=edit
A patch to address this issue

Proposing the patch to address this issue. Also it narrows down some wildcards
in %files in order to make /usr/lib64/perl5/vendor_perl/Glib/ belong to
perl-Glib only.

[Bug 1749126] perl-Glib-Object-Introspection should depend on perl-Gtk3

https://bugzilla.redhat.com/show_bug.cgi?id=1749126

Sergio Monteiro Basto  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Sergio Monteiro Basto  ---
perl-gtk3 depends on perl-Glib-Object-Introspection to build

[Bug 1749126] perl-Glib-Object-Introspection should depend on perl-Gtk3

https://bugzilla.redhat.com/show_bug.cgi?id=1749126

--- Comment #7 from Ben Cotton  ---
This message is a reminder that Fedora 30 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 30 on 2020-05-26.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with
a
Fedora 'version' of '30'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 30 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

[Bug 1749126] perl-Glib-Object-Introspection should depend on perl-Gtk3

https://bugzilla.redhat.com/show_bug.cgi?id=1749126

Vadim Raskhozhev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|30                          |32

[Bug 1749126] perl-Glib-Object-Introspection should depend on perl-Gtk3

https://bugzilla.redhat.com/show_bug.cgi?id=1749126

Petr Pisar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|[e-mail]         |[e-mail]

--- Comment #8 from Petr Pisar  ---
I read the perli11ndoc code, and the dependency on Perl Gtk3 is intentionally
optional. A GUI is only used if perli11ndoc is called without any arguments and
Perl Gtk3 is available. Otherwise the program insists on specifying a GIR name
and the GUI is never used. Hence the most suitable fix is adding a soft
dependency on Perl Gtk3.

Subpackaging perli11ndoc is still good because it's the only reason why
XML::LibXML is needed.

Because we did not see any word from the maintainer, I will do it in Rawhide.

[Bug 1749126] perl-Glib-Object-Introspection should depend on perl-Gtk3

https://bugzilla.redhat.com/show_bug.cgi?id=1749126

Petr Pisar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
   Fixed In Version|                            |perl-Glib-Object-Introspect
                   |                            |ion-0.048-3.fc33
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2020-05-11 10:40:53

[Bug 1749126] perl-Glib-Object-Introspection should depend on perl-Gtk3

https://bugzilla.redhat.com/show_bug.cgi?id=1749126

--- Comment #9 from Vadim Raskhozhev  ---
Petr, thank you, `sudo dnf --allowerasing --setopt=install_weak_deps=1 install
https://kojipkgs.fedoraproject.org//packages/perl-Glib-Object-Introspection/...
https://kojipkgs.fedoraproject.org//packages/perl-Glib-Object-Introspection/...
installs perl-Gtk3 altogether. Can you take a look at
https://bugzilla.redhat.com/show_bug.cgi?id=1749132, please?