https://bugzilla.redhat.com/show_bug.cgi?id=1678623
--- Comment #5 from Petr Pisar <ppisar(a)redhat.com> ---
Neal seems interested in reviewing this package. Thus only few notes from me:
The URL value point to an umbrella project, not the the strip-nondeterminism
itself. I'd rather use
<
https://salsa.debian.org/reproducible-builds/strip-nondeterminism> as the URL
value.
The Makefile.PL has some dependencies you missed. Please build-require
"perl(strict)" and "perl(warnings)".
The perl-File-StripNondeterminism subpackage delivers Perl modules into a
standard Perl look-up path. That means the subpackage must run-require
perl(:MODULE_COPMAT...). See
<
https://docs.fedoraproject.org/en-US/packaging-guidelines/Perl/#_versione...
for the specific spec code to use.
The perl-File-StripNondeterminism package must own the File subdirectory. Use
"%{perl_vendorlib}/*" instead of "%{perl_vendorlib}/File/*" in the
%files
sections.
You should execute tests. Add %check section with "make test" and build-require
"make" and all the Perl modules used when running the tests (e.g.
"perl(Test::More)". Don't forget the tests execute some scripts, e.g.
bin/strip-nondeterminism, so you also need build-require their dependencies. We
have a "tangerine" tool that can help you to scan the files for the used Perl
modules.
--
You are receiving this mail because:
You are on the CC list for the bug.