[Bug 1575520] New: abi-compliance-checker doesn't work under F28

https://bugzilla.redhat.com/show_bug.cgi?id=1575520

            Bug ID: 1575520
           Summary: abi-compliance-checker doesn't work under F28
           Product: Fedora
           Version: 28
         Component: abi-compliance-checker
          Assignee: hobbes1069(a)gmail.com
          Reporter: nmavrogi(a)redhat.com
        QA Contact: extras-qa(a)fedoraproject.org
                CC: hobbes1069(a)gmail.com, orion(a)nwra.com,
                    perl-devel(a)lists.fedoraproject.org



Description of problem:
After updating gnutls CI to F28, abi-compliance-checker fails with the
following error:

```
Temporary header file '/tmp/nfVOd0EPJl/dump1.h' with the following content will
be compiled to create GCC translation unit dump:

  // add includes
  #include
"/builds/gnutls/gnutls/gnutls-prev-abi.tmp/lib/includes/gnutls/gnutls.h"
  #include
"/builds/gnutls/gnutls/gnutls-prev-abi.tmp/lib/includes/gnutls/gnutlsxx.h"
  #include
"/builds/gnutls/gnutls/gnutls-prev-abi.tmp/lib/includes/gnutls/abstract.h"
  #include
"/builds/gnutls/gnutls/gnutls-prev-abi.tmp/lib/includes/gnutls/compat.h"
  #include
"/builds/gnutls/gnutls/gnutls-prev-abi.tmp/lib/includes/gnutls/crypto.h"
  #include
"/builds/gnutls/gnutls/gnutls-prev-abi.tmp/lib/includes/gnutls/dtls.h"
  #include
"/builds/gnutls/gnutls/gnutls-prev-abi.tmp/lib/includes/gnutls/ocsp.h"
  #include
"/builds/gnutls/gnutls/gnutls-prev-abi.tmp/lib/includes/gnutls/openpgp.h"
  #include
"/builds/gnutls/gnutls/gnutls-prev-abi.tmp/lib/includes/gnutls/pkcs11.h"
  #include
"/builds/gnutls/gnutls/gnutls-prev-abi.tmp/lib/includes/gnutls/pkcs12.h"
  #include
"/builds/gnutls/gnutls/gnutls-prev-abi.tmp/lib/includes/gnutls/pkcs7.h"
  #include
"/builds/gnutls/gnutls/gnutls-prev-abi.tmp/lib/includes/gnutls/self-test.h"
  #include
"/builds/gnutls/gnutls/gnutls-prev-abi.tmp/lib/includes/gnutls/socket.h"
  #include
"/builds/gnutls/gnutls/gnutls-prev-abi.tmp/lib/includes/gnutls/system-keys.h"
  #include
"/builds/gnutls/gnutls/gnutls-prev-abi.tmp/lib/includes/gnutls/tpm.h"
  #include
"/builds/gnutls/gnutls/gnutls-prev-abi.tmp/lib/includes/gnutls/urls.h"
  #include
"/builds/gnutls/gnutls/gnutls-prev-abi.tmp/lib/includes/gnutls/x509.h"
  #include
"/builds/gnutls/gnutls/gnutls-prev-abi.tmp/lib/includes/gnutls/x509-ext.h"

The GCC parameters:
  gcc -fdump-translation-unit -fkeep-inline-functions -c -x c++-header
-fpermissive -w "/tmp/nfVOd0EPJl/dump1.h" 
-I/builds/gnutls/gnutls/gnutls-prev-abi.tmp/lib/includes

cc1plus: error: unrecognized command line option '-fdump-translation-unit'
```

It seems it relies on a gcc flag which is no longer available.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1575520] abi-compliance-checker doesn't work under F28

https://bugzilla.redhat.com/show_bug.cgi?id=1575520



--- Comment #1 from Nikos Mavrogiannopoulos <nmavrogi(a)redhat.com&gt; ---
This seems to be addressed upstream:
https://github.com/lvc/abi-compliance-checker/commit/bcc9a7679a772135260c...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1575520] abi-compliance-checker doesn't work under F28

https://bugzilla.redhat.com/show_bug.cgi?id=1575520

Richard Shaw <hobbes1069(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED



--- Comment #2 from Richard Shaw <hobbes1069(a)gmail.com&gt; ---
I'll try to keep an eye out for the new release but feel free to let me know if
you see it first.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1575520] abi-compliance-checker doesn't work under F28

https://bugzilla.redhat.com/show_bug.cgi?id=1575520



--- Comment #3 from Nikos Mavrogiannopoulos <nmavrogi(a)redhat.com&gt; ---
Why not backport this specific patch? Without it abi-compliance-checker is
broken in fedora28.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1575520] abi-compliance-checker doesn't work under F28

https://bugzilla.redhat.com/show_bug.cgi?id=1575520



--- Comment #4 from Richard Shaw <hobbes1069(a)gmail.com&gt; ---
Since he's already committed the change in version I assume the new release
will happen very soon. If not, I'll make a patch from the commit.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1575520] abi-compliance-checker doesn't work under F28

https://bugzilla.redhat.com/show_bug.cgi?id=1575520



--- Comment #5 from Richard Shaw <hobbes1069(a)gmail.com&gt; ---
I noticed the commit was over a month ago so I have emailed the author to see
if the lack of release was intentional or not.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1575520] abi-compliance-checker doesn't work under F28

https://bugzilla.redhat.com/show_bug.cgi?id=1575520



--- Comment #6 from Richard Shaw <hobbes1069(a)gmail.com&gt; ---
Ok, the commit does not apply cleanly and appears to be dependent on other
commits. If you want to create a clean patch I'll review it, otherwise I'm
going to wait on the 2.3 release.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1575520] abi-compliance-checker doesn't work under F28

https://bugzilla.redhat.com/show_bug.cgi?id=1575520

Emmanuel Seyman <emmanuel(a)seyman.fr&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |emmanuel(a)seyman.fr



--- Comment #7 from Emmanuel Seyman <emmanuel(a)seyman.fr&gt; ---
Created attachment 1433613
  --> https://bugzilla.redhat.com/attachment.cgi?id=1433613&action=edit
gcc8 compatibility for abi-compliance-checker

I rebased the patch but don't use abi-compliance-checker. Can someone check
that this fixes the issue?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1575520] abi-compliance-checker doesn't work under F28

https://bugzilla.redhat.com/show_bug.cgi?id=1575520



--- Comment #8 from Richard Shaw <hobbes1069(a)gmail.com&gt; ---
Here's a test package based on the patch, please confirm it fixes the problem.
When I get a second I'll check that it still works on my F27 system w/ GCC 7.

https://kojipkgs.fedoraproject.org//work/tasks/6903/26856903/abi-complian...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1575520] abi-compliance-checker doesn't work under F28

https://bugzilla.redhat.com/show_bug.cgi?id=1575520



--- Comment #9 from Nikos Mavrogiannopoulos <nmavrogi(a)redhat.com&gt; ---
It works for me minus the dependency issue on findutils (reported separately).
May I suggest the following sanity check (as CI/Test
https://fedoraproject.org/wiki/CI/Tests ), if there is no other testsuite for
that?


cat >c.c <<_EOF_
#include <stdio.h>

int apicall(int a)
{
printf("hello world %d\n", a);
return 0;
}
_EOF_

$ mkdir -p api-ok
$ mkdir -p api-broken

cat >api-ok/c.h <<_EOF_

int apicall(int a);
_EOF_

cat >api-broken/c.h <<_EOF_

int apicall(int a, void *ptr);
_EOF_


$ gcc -g -c -Wall -Werror -fpic c.c
$ gcc -shared -o libfoo.so c.o
$ cp libfoo.so api-ok/
$ cp libfoo.so api-broken/
$ abi-dumper libfoo.so

$ abi-compliance-checker -l foo -old api-ok -new ABI.dump # ok
$ abi-compliance-checker -l foo -old api-broken -new ABI.dump # fails

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1575520] abi-compliance-checker doesn't work under F28

https://bugzilla.redhat.com/show_bug.cgi?id=1575520



--- Comment #10 from Richard Shaw <hobbes1069(a)gmail.com&gt; ---
I'll consider adding a test in the future but it's not something I've done
before and don't have the spare cycles right now to figure it out.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1575520] abi-compliance-checker doesn't work under F28

https://bugzilla.redhat.com/show_bug.cgi?id=1575520



--- Comment #11 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
abi-compliance-checker-2.2-3.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-a727930b7f

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1575520] abi-compliance-checker doesn't work under F28

https://bugzilla.redhat.com/show_bug.cgi?id=1575520



--- Comment #12 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
abi-compliance-checker-2.2-3.fc28 has been submitted as an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-8de33c103f

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1575520] abi-compliance-checker doesn't work under F28

https://bugzilla.redhat.com/show_bug.cgi?id=1575520



--- Comment #13 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
abi-compliance-checker-2.2-3.el7 has been submitted as an update to Fedora EPEL
7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-1171f003c1

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1575520] abi-compliance-checker doesn't work under F28

https://bugzilla.redhat.com/show_bug.cgi?id=1575520

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA



--- Comment #14 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
abi-compliance-checker-2.2-3.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-a727930b7f

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1575520] abi-compliance-checker doesn't work under F28

https://bugzilla.redhat.com/show_bug.cgi?id=1575520



--- Comment #15 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
abi-compliance-checker-2.2-3.fc28 has been pushed to the Fedora 28 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-8de33c103f

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1575520] abi-compliance-checker doesn't work under F28

https://bugzilla.redhat.com/show_bug.cgi?id=1575520



--- Comment #16 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
abi-compliance-checker-2.2-3.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-1171f003c1

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1575520] abi-compliance-checker doesn't work under F28

https://bugzilla.redhat.com/show_bug.cgi?id=1575520



--- Comment #17 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
abi-compliance-checker-2.3-1.fc28 has been submitted as an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-f38c8d8188

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1575520] abi-compliance-checker doesn't work under F28

https://bugzilla.redhat.com/show_bug.cgi?id=1575520



--- Comment #18 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
abi-compliance-checker-2.3-1.el7 has been submitted as an update to Fedora EPEL
7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-b68f0ba2c0

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1575520] abi-compliance-checker doesn't work under F28

https://bugzilla.redhat.com/show_bug.cgi?id=1575520



--- Comment #19 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
abi-compliance-checker-2.3-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-21e393fe5c

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1575520] abi-compliance-checker doesn't work under F28

https://bugzilla.redhat.com/show_bug.cgi?id=1575520

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA



--- Comment #20 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
abi-compliance-checker-2.3-1.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-21e393fe5c

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1575520] abi-compliance-checker doesn't work under F28

https://bugzilla.redhat.com/show_bug.cgi?id=1575520



--- Comment #21 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
abi-compliance-checker-2.3-1.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-b68f0ba2c0

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1575520] abi-compliance-checker doesn't work under F28

https://bugzilla.redhat.com/show_bug.cgi?id=1575520



--- Comment #22 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
abi-compliance-checker-2.3-1.fc28 has been pushed to the Fedora 28 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-f38c8d8188

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1575520] abi-compliance-checker doesn't work under F28

https://bugzilla.redhat.com/show_bug.cgi?id=1575520

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
   Fixed In Version|                            |abi-compliance-checker-2.3-
                   |                            |1.fc28
         Resolution|---                         |ERRATA
        Last Closed|                            |2018-05-24 09:56:08



--- Comment #23 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
abi-compliance-checker-2.3-1.fc28 has been pushed to the Fedora 28 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1575520] abi-compliance-checker doesn't work under F28

https://bugzilla.redhat.com/show_bug.cgi?id=1575520

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|abi-compliance-checker-2.3- |abi-compliance-checker-2.3-
                   |1.fc28                      |1.fc28
                   |                            |abi-compliance-checker-2.3-
                   |                            |1.fc27



--- Comment #24 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
abi-compliance-checker-2.3-1.fc27 has been pushed to the Fedora 27 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1575520] abi-compliance-checker doesn't work under F28

https://bugzilla.redhat.com/show_bug.cgi?id=1575520

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|abi-compliance-checker-2.3- |abi-compliance-checker-2.3-
                   |1.fc28                      |1.fc28
                   |abi-compliance-checker-2.3- |abi-compliance-checker-2.3-
                   |1.fc27                      |1.fc27
                   |                            |abi-compliance-checker-2.3-
                   |                            |1.el7



--- Comment #25 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
abi-compliance-checker-2.3-1.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.