Changes to 'make install' in PHP 5.2.3

[Jeff Sheltren]

Hi, just thought I'd give a heads up to prevent people from dealing  
with the same problem I just went through...

I built PHP 5.2.3 by re-using the spec from the PHP SRPM in devel and  
bumping the version.  The problem is that as of 5.2.3, they've  
changed the way 'make install' installs the cgi and cli binaries.   
There is no longer a need to call 'make install-cli' separately as  
now if you've configured for cgi, then both the cgi and cli versions  
get installed with a 'make install'.  Doing the install the old way  
(as in the 5.2.2 RPM) leaves you with /usr/bin/php and /usr/bin/php- 
cgi as the same binary which is the CLI and not the CGI.

To fix this, I changed the spec slightly, from:
# Install everything from the CGI SAPI build
pushd build-cgi
make install INSTALL_ROOT=$RPM_BUILD_ROOT
mv $RPM_BUILD_ROOT%{_bindir}/php $RPM_BUILD_ROOT%{_bindir}/php-cgi
# Install the CLI SAPI as /usr/bin/php
make install-cli INSTALL_ROOT=$RPM_BUILD_ROOT
popd

to:
# Install everything from the CGI SAPI build
pushd build-cgi
make install INSTALL_ROOT=$RPM_BUILD_ROOT
popd

That installs both /usr/bin/php (cli) and /usr/bin/php-cgi correctly.

-Jeff

[Tim Jackson]

Jeff Sheltren wrote:

>  Hi, just thought I'd give a heads up to prevent people from
> dealing with
>  the same problem I just went through... 
Thanks a lot Jeff. Did you have to change/add/remove any of the patches
from 5.2.2-4?

Thanks,

Tim

[Jeff Sheltren]

On Jun 8, 2007, at 8:49 AM, Tim Jackson wrote:

>  Jeff Sheltren wrote:
>
> > Hi, just thought I'd give a heads up to prevent people from  
> > dealing with
> > the same problem I just went through...
>
>  Thanks a lot Jeff. Did you have to change/add/remove any of the  
>  patches
>  from 5.2.2-4? 
Hi Tim, nope, I didn't touch any of the patches.  All of the patches  
in the 5.2.2-4 RPM applied cleanly, and I'm not aware of any other  
patches being needed.

-Jeff

[Joe Orton]

On Wed, Jun 06, 2007 at 09:43:58AM -0400, Jeff Sheltren wrote:
>  To fix this, I changed the spec slightly, from: 
Thanks for sending that in, Jeff! 5.2.3 is now built for Raw Hide:

http://koji.fedoraproject.org/koji/taskinfo?taskID=31097

joe

[Jeff Sheltren]

On Jun 8, 2007, at 1:47 PM, Joe Orton wrote:

>  On Wed, Jun 06, 2007 at 09:43:58AM -0400, Jeff Sheltren wrote:
> > To fix this, I changed the spec slightly, from:
>
>  Thanks for sending that in, Jeff! 5.2.3 is now built for Raw Hide:
>
>  http://koji.fedoraproject.org/koji/taskinfo?taskID=31097
>
>  joe 
Cool, I like your updated spec better than what I suggested! :)
'make -C' seems much cleaner than doing the pushd/popd dance.

-Jeff