[PATCH] An empty task list for backlog items should say "No tasks were found". #80

[LAN-SUN-LUK Benjamin]

Signed-off-by: Benjamin LAN-SUN-LUK <benjamin.lan-sun-luk(a)supinfo.com&gt;
---
 app/controllers/items_controller.rb |   11 ++++++++---
 1 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/app/controllers/items_controller.rb
b/app/controllers/items_controller.rb
index fa68ad0..82a12a8 100644
--- a/app/controllers/items_controller.rb
+++ b/app/controllers/items_controller.rb
@@ -38,9 +38,14 @@ class ItemsController < ApplicationController
 
   # GET /products/1/sprints/1/items/1
   def show
-    @title = "Backlog Item (#{(a)backlog_item.user_story.title})&quot;
-    respond_to do |format|
-      format.html
+    if @tasks.empty?
+      flash[:message] = "No tasks were found for
#{(a)backlog_item.user_story.title}&quot;
+      redirect_to product_sprint_path(@product, @sprint)
+    else
+      @title = "Backlog Item (#{(a)backlog_item.user_story.title})&quot;
+      respond_to do |format|
+        format.html
+      end
     end
   end
 
-- 
1.6.0.2

[Darryl L. Pierce]

On Thu, Dec 18, 2008 at 11:36 AM, LAN-SUN-LUK Benjamin
<Benjamin.LAN-SUN-LUK(a)supinfo.com&gt; wrote:
>  Signed-off-by: Benjamin LAN-SUN-LUK <benjamin.lan-sun-luk(a)supinfo.com&gt;
>  ---
>   app/controllers/items_controller.rb |   11 ++++++++---
>   1 files changed, 8 insertions(+), 3 deletions(-)
>
>  diff --git a/app/controllers/items_controller.rb
>  b/app/controllers/items_controller.rb
>  index fa68ad0..82a12a8 100644
>  --- a/app/controllers/items_controller.rb
>  +++ b/app/controllers/items_controller.rb
>  @@ -38,9 +38,14 @@ class ItemsController < ApplicationController
>
>    # GET /products/1/sprints/1/items/1
>    def show
>  -    @title = "Backlog Item (#{(a)backlog_item.user_story.title})&quot;
>  -    respond_to do |format|
>  -      format.html
>  +    if @tasks.empty?
>  +      flash[:message] = "No tasks were found for
>  #{(a)backlog_item.user_story.title}&quot;
>  +      redirect_to product_sprint_path(@product, @sprint)
>  +    else
>  +      @title = "Backlog Item (#{(a)backlog_item.user_story.title})&quot;
>  +      respond_to do |format|
>  +        format.html
>  +      end
>      end
>    end 
NAK.

The controller shouldn't be affected by this: having no backlog items
isn't an error condition. Instead, change the items/_list.html.erb so
that it shows a message that says "No backlog items found..." if the
list is empty.

-- 
Darryl L. Pierce <mcpierce(a)gmail.com&gt;
Visit the Infobahn Offramp: <http://mcpierce.multiply.com>
"Bury me next to my wife. Nothing too fancy..." - Ulysses S. Grant

[Darryl L. Pierce]

On Thu, Dec 18, 2008 at 11:36 AM, LAN-SUN-LUK Benjamin
<Benjamin.LAN-SUN-LUK(a)supinfo.com&gt; wrote:
>  Signed-off-by: Benjamin LAN-SUN-LUK <benjamin.lan-sun-luk(a)supinfo.com&gt;
>  ---
>   app/controllers/items_controller.rb |   11 ++++++++---
>   1 files changed, 8 insertions(+), 3 deletions(-)
>
>  diff --git a/app/controllers/items_controller.rb
>  b/app/controllers/items_controller.rb
>  index fa68ad0..82a12a8 100644
>  --- a/app/controllers/items_controller.rb
>  +++ b/app/controllers/items_controller.rb
>  @@ -38,9 +38,14 @@ class ItemsController < ApplicationController
>
>    # GET /products/1/sprints/1/items/1
>    def show
>  -    @title = "Backlog Item (#{(a)backlog_item.user_story.title})&quot;
>  -    respond_to do |format|
>  -      format.html
>  +    if @tasks.empty?
>  +      flash[:message] = "No tasks were found for
>  #{(a)backlog_item.user_story.title}&quot;
>  +      redirect_to product_sprint_path(@product, @sprint)
>  +    else
>  +      @title = "Backlog Item (#{(a)backlog_item.user_story.title})&quot;
>  +      respond_to do |format|
>  +        format.html
>  +      end
>      end
>    end
>
>  --
>  1.6.0.2
>
>
>  _______________________________________________
>  projxp-devel mailing list
>  projxp-devel(a)lists.fedorahosted.org
>  https://fedorahosted.org/mailman/listinfo/projxp-devel
>  
In testing the code, I see that this ticket was apparently already
fixed but never closed. An empty backlog is showing the expected
message in the table. So I'm going to go ahead and mark this as
closed.


-- 
Darryl L. Pierce <mcpierce(a)gmail.com&gt;
Visit the Infobahn Offramp: <http://mcpierce.multiply.com>
"Bury me next to my wife. Nothing too fancy..." - Ulysses S. Grant