[PATCH] Use urllib unquote to allow boolean support for e.g. spaces

[Paul W. Frields]

I don't recall if I sent this patch in earlier, but it's quite useful
to be able to use spaces in certain fields like whiteboard.

[PATCH] Use urllib unquote to allow boolean support for e.g. spaces in values

[Paul W. Frields]

From: "Paul W. Frields"

---
 bugzilla/rhbugzilla.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/bugzilla/rhbugzilla.py b/bugzilla/rhbugzilla.py
index 399ecb0..3fac011 100644
--- a/bugzilla/rhbugzilla.py
+++ b/bugzilla/rhbugzilla.py
@@ -12,7 +12,7 @@

from bugzilla import log
 from bugzilla.bugzilla4 import Bugzilla44 as _parent
-
+from urllib import urlunquote as urllib_unquote

class RHBugzilla(_parent):
     '''
@@ -281,7 +281,7 @@ class RHBugzilla(_parent):
                         typ = args[1]
                         fval = None
                         if len(args) == 3:
-                            fval = args[2]
+                            fval = urllib_unquote(args[2])
                     else:
                         field = key

[PATCH] Use urllib unquote to allow boolean support for e.g. spaces in values

[Cole Robinson]

On 03/20/2014 03:58 PM, [e-mail] wrote:
> From: "Paul W. Frields"
>
> bugzilla/rhbugzilla.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/bugzilla/rhbugzilla.py b/bugzilla/rhbugzilla.py
> index 399ecb0..3fac011 100644
> --- a/bugzilla/rhbugzilla.py
> +++ b/bugzilla/rhbugzilla.py
> @@ -12,7 +12,7 @@
>
> from bugzilla import log
>  from bugzilla.bugzilla4 import Bugzilla44 as _parent
>
> +from urllib import urlunquote as urllib_unquote
>
> class RHBugzilla(_parent):
>      '''
> @@ -281,7 +281,7 @@ class RHBugzilla(_parent):
>                          typ = args[1]
>                          fval = None
>                          if len(args) == 3:
>                        fval = args[2]
>                        fval = urllib_unquote(args[2])
>                else:
>                    field = key

Thanks for the patch. Can you give an API or command line example where this
fixes things? So I can ensure it's tested.

- Cole

[PATCH] Use urllib unquote to allow boolean support for e.g. spaces in values

[Paul W. Frields]

On Thu, Mar 20, 2014 at 04:04:33PM -0400, Cole Robinson wrote:
> On 03/20/2014 03:58 PM, [e-mail] wrote:
> > From: "Paul W. Frields"
> >
> > bugzilla/rhbugzilla.py | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/bugzilla/rhbugzilla.py b/bugzilla/rhbugzilla.py
> > index 399ecb0..3fac011 100644
> > --- a/bugzilla/rhbugzilla.py
> > +++ b/bugzilla/rhbugzilla.py
> > @@ -12,7 +12,7 @@
> >
> > from bugzilla import log
> >  from bugzilla.bugzilla4 import Bugzilla44 as _parent
> >
> > +from urllib import urlunquote as urllib_unquote
> >
> > class RHBugzilla(_parent):
> >      '''
> > @@ -281,7 +281,7 @@ class RHBugzilla(_parent):
> >                          typ = args[1]
> >                          fval = None
> >                          if len(args) == 3:
> >                        fval = args[2]
> >                        fval = urllib_unquote(args[2])
> >                else:
> >                    field = key
>
> Thanks for the patch. Can you give an API or command line example where this
> fixes things? So I can ensure it's tested.

Hold off for now, I found a stupid error in an old patch and posted
this prematurely.  Sorry for the noise on the list.  I am ashame. ;-)

[PATCH] Use urllib unquote to allow boolean support for e.g. spaces in values

[Paul W. Frields]

On Thu, Mar 20, 2014 at 06:20:48PM -0400, Paul W. Frields wrote:
> On Thu, Mar 20, 2014 at 04:04:33PM -0400, Cole Robinson wrote:
> > On 03/20/2014 03:58 PM, [e-mail] wrote:
> > > From: "Paul W. Frields"
> > >
> > > bugzilla/rhbugzilla.py | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/bugzilla/rhbugzilla.py b/bugzilla/rhbugzilla.py
> > > index 399ecb0..3fac011 100644
> > > --- a/bugzilla/rhbugzilla.py
> > > +++ b/bugzilla/rhbugzilla.py
> > > @@ -12,7 +12,7 @@
> > >
> > > from bugzilla import log
> > >  from bugzilla.bugzilla4 import Bugzilla44 as _parent
> > >
> > > +from urllib import urlunquote as urllib_unquote
> > >
> > > class RHBugzilla(_parent):
> > >      '''
> > > @@ -281,7 +281,7 @@ class RHBugzilla(_parent):
> > >                          typ = args[1]
> > >                          fval = None
> > >                          if len(args) == 3:
> > >                        fval = args[2]
> > >                        fval = urllib_unquote(args[2])
> > >                else:
> > >                    field = key
> >
> > Thanks for the patch. Can you give an API or command line example where this
> > fixes things? So I can ensure it's tested.
>
> Hold off for now, I found a stupid error in an old patch and posted
> this prematurely.  Sorry for the noise on the list.  I am ashame. ;-)

And worse yet, I found that my tests to verify the fix was needed to
deal with spaces turned out to be using an invalid (old) version of
the binary.  Go back to your homes, nothing to see here...