On 06. 02. 19 22:16, Tadej Janež wrote:
Hi,
On Wed, 2019-02-06 at 15:04 +0100, Miro Hrončok wrote:
I've grepped the usage and skimmed trough specs, destining the following list of packages that fail to properly set both flags.
I've also found that one of my packages was settings CFLAGS to %{optflags} and fixed it: https://src.fedoraproject.org/rpms/bup/c/e960755aa88e1dcf84463faa66c9806a350...
Nope, you've actually unfixed that.
Fedora packages should use %{build_cflags} (historically available as %{optflags}). They should also use %{build_ldflags}.
Fedora packages should not use %{extension_cflags} or %{extension_ldlags}.
See https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/master/f/buildflag...