krop and python3

[Raphael Groner]

Hi,

I need some help to fix a bug ¹ with python3 and site-packages.

>  cd /usr/lib/python3.4/site-packages/krop/ 
>  python2 -c 'import krop ; krop.main()' 
→ dialog

>  python3 -c 'import krop ; krop.main()' 
Traceback (most
recent call last):
  File "<string>", line 1, in <module>
  File "/usr/lib/python3.4/site-packages/krop/krop.py", line 25, in main
    formatter_class=RawTextHelpFormatter)
TypeError: __init__() got an unexpected keyword argument 'version'

Besides that error, the start script in %{_bindir}/krop is b0rken and should just work for
users clicking on the desktop icon.

¹ https://bugzilla.redhat.com/show_bug.cgi?id=1321376

[Avram Lubkin]

Based on the error and looking at the source, you should just need to fix
the line in /usr/lib/python3.4/site-packages/krop/krop.py:

    parser = ArgumentParser(description=__doc__, version=__version__,

with

    parser = ArgumentParser(description=__doc__,

ArgumentParser does not accept a version keyword
It doesn't in 2.7 either, but it may handle it in in a way that wouldn't
cause an errror.

On Sun, Apr 24, 2016 at 12:38 PM, Raphael Groner <raphgro(a)fedoraproject.org&gt;
wrote:

>  Hi,
>
>  I need some help to fix a bug ¹ with python3 and site-packages.
>
>  > cd /usr/lib/python3.4/site-packages/krop/
>
>  > python2 -c 'import krop ; krop.main()'
>  → dialog
>
>  > python3 -c 'import krop ; krop.main()'
>  Traceback (most recent call last):
>    File "<string>", line 1, in <module>
>    File "/usr/lib/python3.4/site-packages/krop/krop.py", line 25, in main
>      formatter_class=RawTextHelpFormatter)
>  TypeError: __init__() got an unexpected keyword argument 'version'
>
>  Besides that error, the start script in %{_bindir}/krop is b0rken and
>  should just work for users clicking on the desktop icon.
>
>  ¹ https://bugzilla.redhat.com/show_bug.cgi?id=1321376
>  _______________________________________________
>  python-devel mailing list
>  python-devel(a)lists.fedoraproject.org
>
>  http://lists.fedoraproject.org/admin/lists/[e-mail]...
>

[Avram Lubkin]

Looks like the version argument was deprecated and later removed. The
version of argparse 2.7 is using includes it with a deprecation warning and
the version for 3.4 has it removed.


On Sun, Apr 24, 2016 at 1:21 PM, Avram Lubkin <aviso(a)rockhopper.net&gt; wrote:

>  Based on the error and looking at the source, you should just need to
> fix
>  the line in /usr/lib/python3.4/site-packages/krop/krop.py:
>
>      parser = ArgumentParser(description=__doc__, version=__version__,
>
>  with
>
>      parser = ArgumentParser(description=__doc__,
>
>  ArgumentParser does not accept a version keyword
>  It doesn't in 2.7 either, but it may handle it in in a way that wouldn't
>  cause an errror.
>
>  On Sun, Apr 24, 2016 at 12:38 PM, Raphael Groner <
>  raphgro(a)fedoraproject.org&gt; wrote:
>
> > Hi,
> >
> > I need some help to fix a bug ¹ with python3 and site-packages.
> >
> > > cd /usr/lib/python3.4/site-packages/krop/
> >
> > > python2 -c 'import krop ; krop.main()'
> > → dialog
> >
> > > python3 -c 'import krop ; krop.main()'
> > Traceback (most recent call last):
> >   File "<string>", line 1, in <module>
> >   File "/usr/lib/python3.4/site-packages/krop/krop.py", line 25, in main
> >     formatter_class=RawTextHelpFormatter)
> > TypeError: __init__() got an unexpected keyword argument 'version'
> >
> > Besides that error, the start script in %{_bindir}/krop is b0rken and
> > should just work for users clicking on the desktop icon.
> >
> > ¹ https://bugzilla.redhat.com/show_bug.cgi?id=1321376
> > _______________________________________________
> > python-devel mailing list
> > python-devel(a)lists.fedoraproject.org
> >
> > http://lists.fedoraproject.org/admin/lists/[e-mail]...
> >
>
>

[Avram Lubkin]

From the looks of things the source is a mess, It got a -3.26/10 with
pylint and -9.29/10 with python3-pylint. While some of those are style
issues, many are functional. I think you're going to find one problem after
another. It looks like you moved it to use python3 last month. If it's
working with python2, then I would revert to use python2 for Fedora 23 and
work with upstream to get it cleaned up for Fedora 24.


On Sun, Apr 24, 2016 at 1:28 PM, Avram Lubkin <aviso(a)rockhopper.net&gt; wrote:

>  Looks like the version argument was deprecated and later removed.
> The
>  version of argparse 2.7 is using includes it with a deprecation warning and
>  the version for 3.4 has it removed.
>
>
>  On Sun, Apr 24, 2016 at 1:21 PM, Avram Lubkin <aviso(a)rockhopper.net&gt;
>  wrote:
>
> > Based on the error and looking at the source, you should just need to fix
> > the line in /usr/lib/python3.4/site-packages/krop/krop.py:
> >
> >     parser = ArgumentParser(description=__doc__, version=__version__,
> >
> > with
> >
> >     parser = ArgumentParser(description=__doc__,
> >
> > ArgumentParser does not accept a version keyword
> > It doesn't in 2.7 either, but it may handle it in in a way that wouldn't
> > cause an errror.
> >
> > On Sun, Apr 24, 2016 at 12:38 PM, Raphael Groner <
> > raphgro(a)fedoraproject.org&gt; wrote:
> >
> >> Hi,
> >>
> >> I need some help to fix a bug ¹ with python3 and site-packages.
> >>
> >> > cd /usr/lib/python3.4/site-packages/krop/
> >>
> >> > python2 -c 'import krop ; krop.main()'
> >> → dialog
> >>
> >> > python3 -c 'import krop ; krop.main()'
> >> Traceback (most recent call last):
> >>   File "<string>", line 1, in <module>
> >>   File "/usr/lib/python3.4/site-packages/krop/krop.py", line 25, in
> main
> >>     formatter_class=RawTextHelpFormatter)
> >> TypeError: __init__() got an unexpected keyword argument 'version'
> >>
> >> Besides that error, the start script in %{_bindir}/krop is b0rken and
> >> should just work for users clicking on the desktop icon.
> >>
> >> ¹ https://bugzilla.redhat.com/show_bug.cgi?id=1321376
> >> _______________________________________________
> >> python-devel mailing list
> >> python-devel(a)lists.fedoraproject.org
> >>
> >> http://lists.fedoraproject.org/admin/lists/[e-mail]...
> >>
> >
> >
>

[Raphael Groner]

Reverted to python2, in rawhide, f24 and f23.

When those updates are in stable, I tend to orphan krop. There's also an (indirect)
dependency to Qt4 cause of python-poppler-qt4 that makes it even harder to maintain cause
of a generally dead development branch for any qt4 related packages.

[Raphael Groner]

https://bugzilla.redhat.com/show_bug.cgi?id=1346380