On Mon, Sep 4, 2017 at 9:27 AM Petr Viktorin <pviktori(a)redhat.com> wrote:
On 09/04/2017 03:37 PM, Miro Hrončok wrote:
>
>
> On 4.9.2017 15:34, Troy Curtis Jr wrote:
>> On Mon, Sep 4, 2017 at 7:52 AM Miro Hrončok <mhroncok(a)redhat.com
>> <mailto:mhroncok@redhat.com>> wrote:
>>
>>
>>
>> On 4.9.2017 14:49, Troy Curtis Jr wrote:
>> >
>> >
>> > On Mon, Sep 4, 2017 at 3:54 AM Petr Viktorin <
pviktori(a)redhat.com
>> <mailto:pviktori@redhat.com>
>> > <mailto:pviktori@redhat.com
<mailto:pviktori@redhat.com>>>
wrote:
>> >
>> > On 09/04/2017 06:21 AM, Troy Curtis Jr wrote:
>> > > I have a version of the gpsd package which I believe
>> addresses this
>> > > ticket
>>
https://bugzilla.redhat.com/show_bug.cgi?id=1390812. I've
>> > been
>> > > looking around about the right way to submit. I thought
>> it would
>> > be by
>> > > using a pull request from within the pagure instance at
>> > >
src.fedoraproject.org <
http://src.fedoraproject.org>
>> <
http://src.fedoraproject.org>
>> > <
http://src.fedoraproject.org>. However, I cannot
>> > > authenticate with my ssh key. There is no where to add it
>> within
>> > > pagure, and my FAS key doesn't seem to be sufficient.
So
>> perhaps
>> > this
>> > > isn't they way? Then I was reading through
>> > >
>> >
>>
>>
http://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Cre...
>>
>> > > , but it seems a bit geared toward brand new packages, so
>> I was
>> > not sure
>> > > if that was in fact the proper coarse.
>> > >
>> > > I'd appreciate any pointers as to the proper direction
to
>> get this
>> > > updated package updated. In the meantime, I'll fix the
>> rpmlint
>> > warnings
>> > > I just found!
>> >
>> > That shouldn't be happening.
>> > What's your FAS username?
>> >
>> > troycurtisjr
Thanks!
I see in FAS that you're not yet a packager. That's probably the reason
you don't have Pagure write access.
That's a bit unfortunate, and I guess it should be solved with remote
pull requests, but as you found out those seem broken at the time. (It's
all a pretty new system, so it's not unreasonable to think no one tried
remote PRs here yet.)
I've made a PR for you:
https://pagure.io/fedora-infrastructure/issue/6332
Could you please comment there? :)
Great! I put a comment in on the PR, and also pointed to the targeted
bugzilla ticket (as well as commenting on the ticket pointing back to the
PR). I had gathered it was a new method, which was why I was thinking the
wiki was still describing the old way. No matter, I'm new to all this as
well!
>> >
>> >
>> > If you can push the changes to another public Git repository
>> (e.g.
>> > GitHub), that could be a workaround while we get Pagure
access
>> > sorted out.
>> >
>> >
>> > Ok so Pagure is the right way to go then. I tried importing my
>> key
>> > again, but I'm still getting denied. I can use the same key on a
>> > different linux host as well as with
gitlab.com
>> <
http://gitlab.com> <
http://gitlab.com>, so
>> > I'm fairly confident my local configuration is correct. I assume
>> this
>> > is unrelated, but I also can't seem to tie my FAS account
>> correctly to the
... the rest of the sentence seems missing.
*sigh* Sorry, but I saved as draft and then went to try something else to
see if I could resolve the issue. I had intended to say I was also having
trouble linking my pagure account with
www.libravatar.org as well.
However, I incorrectly assumed that using the FAS OpenID login at
libravatar would import my email for association. Just explicitly adding
the appropriate email was enough to resolve that issue. I forgot that I
had left a dangling sentence out there.
> >
>> > For the time being then, I've pushed my changes to
>> >
https://gitlab.com/troycurtisjr/fedora-pkg-gpsd.git under the
>> > 'python2-packaging' branch for review. Additionally, I used
>> copr to
>> > build for several releases, which you can find at
>> >
>>
>>
https://copr.fedorainfracloud.org/coprs/troycurtisjr/gpsd/build/597872/
>>
>>
>> Now you should be able to send a pull request from gitlab in here:
>>
https://src.fedoraproject.org/rpms/gpsd/diff/remote
>>
>>
>> Remote pull requests, that is a great feature!
>>
>> Unfortunately I can't seem to get it to work either.
>>
>> I've tried using the
gitlab.com <
http://gitlab.com> repo, then I
>> pushed to github and tried from there, same error. Then I wondered if
>> it didn't like having a hyphen in the branch name so I changed that.
>> I even removed the hash from the ticket reference in the title. In
>> all cases I get: "Fatal Error (500)" in response. I am using the
>> https repo url, and have cloned on another machine to ensure the urls
>> are publically available.
>
> I guess that sounds like a thing that needs a report at
>
https://pagure.io/fedora-infrastructure/issues
I've reported it:
https://pagure.io/fedora-infrastructure/issue/6332
I also put a comment on this issue with a bit of additional information.
Thanks for the help Petr!
--
Troy
--
Petr Viktorin