I propose sphinx no longer Requires sphinxcontrib-{applehelp,devhelp,jsmath,htmlhelp,serializinghtml,qthelp}

[Miro Hrončok]

Hello Pythonistas.

In https://src.fedoraproject.org/rpms/python-sphinx/pull-request/59 I propose a 
change that would make the runtime requirements of:

- python3-sphinxcontrib-applehelp
  - python3-sphinxcontrib-devhelp
  - python3-sphinxcontrib-jsmath
  - python3-sphinxcontrib-htmlhelp
  - python3-sphinxcontrib-serializinghtml
  - python3-sphinxcontrib-qthelp

...optional (Recommends) in python3-sphinx.

Packages that need those would need to BuildRequire them specifically, as 
proposed in:

- https://src.fedoraproject.org/rpms/xca/pull-request/1
  - https://src.fedoraproject.org/rpms/python-django-haystack/pull-request/1
  - https://src.fedoraproject.org/rpms/pykka/pull-request/3
  - https://src.fedoraproject.org/rpms/extra-cmake-modules/pull-request/2

The change has been offered upstream, but I suppose it will take a while before 
it is actually landed there.

Let me know if you think this needs more discussion before shipping it.

(The change is only intended for Fedora 40+ and ELN.)

[Neal Gompa]

On Wed, Nov 8, 2023 at 6:56 AM Miro Hrončok  wrote:
> Hello Pythonistas.
>
> In https://src.fedoraproject.org/rpms/python-sphinx/pull-request/59 I propose a
> change that would make the runtime requirements of:
> python3-sphinxcontrib-applehelp
> python3-sphinxcontrib-devhelp
> python3-sphinxcontrib-jsmath
> python3-sphinxcontrib-htmlhelp
> python3-sphinxcontrib-serializinghtml
> python3-sphinxcontrib-qthelp
>
> ...optional (Recommends) in python3-sphinx.
>
> Packages that need those would need to BuildRequire them specifically, as
> proposed in:
> https://src.fedoraproject.org/rpms/xca/pull-request/1
> https://src.fedoraproject.org/rpms/python-django-haystack/pull-request/1
> https://src.fedoraproject.org/rpms/pykka/pull-request/3
> https://src.fedoraproject.org/rpms/extra-cmake-modules/pull-request/2
>
> The change has been offered upstream, but I suppose it will take a while before
> it is actually landed there.
>
> Let me know if you think this needs more discussion before shipping it.
>
> (The change is only intended for Fedora 40+ and ELN.)

Do we know what the impact of this is going to be beyond those four?

[Miro Hrončok]

On 08. 11. 23 12:57, Neal Gompa wrote:
> > Packages that need those would need to BuildRequire them specifically, as
> > proposed in:
> >
> > -https://src.fedoraproject.org/rpms/xca/pull-request/1
> >    -https://src.fedoraproject.org/rpms/python-django-haystack/pull-request/1
> >    -https://src.fedoraproject.org/rpms/pykka/pull-request/3
> >    -https://src.fedoraproject.org/rpms/extra-cmake-modules/pull-request/2
> >
> > The change has been offered upstream, but I suppose it will take a while before
> > it is actually landed there.
> >
> > Let me know if you think this needs more discussion before shipping it.
> >
> > (The change is only intended for Fedora 40+ and ELN.)
>
> Do we know what the impact of this is going to be beyond those four?

All Fedora packages that BuildRequire python3-sphinx (even transitively) were 
tested. Those that successfully built before this change are known not to be 
impacted, except for the listed 4 and 
https://src.fedoraproject.org/rpms/python-fastavro/pull-request/12 (which is 
special, because the removal only uncovered a bug in tests).

This was tested in 
https://copr.fedorainfracloud.org/coprs/churchyard/sphinxcontrib-optional/bu... 
and 
https://copr.fedorainfracloud.org/coprs/churchyard/sphinxcontrib-mandaotry/b...

A handful of packages timed out after 5 hours in Copr, happy to fix them later 
if they they are impacted. Same for the packages that FTBFS now for unrelated 
reasons.

[Neal Gompa]

On Wed, Nov 8, 2023 at 7:02 AM Miro Hrončok  wrote:
> On 08. 11. 23 12:57, Neal Gompa wrote:
> > > Packages that need those would need to BuildRequire them specifically, as
> > > proposed in:
> > >
> > > -https://src.fedoraproject.org/rpms/xca/pull-request/1
> > >    -https://src.fedoraproject.org/rpms/python-django-haystack/pull-request/1
> > >    -https://src.fedoraproject.org/rpms/pykka/pull-request/3
> > >    -https://src.fedoraproject.org/rpms/extra-cmake-modules/pull-request/2
> > >
> > > The change has been offered upstream, but I suppose it will take a while before
> > > it is actually landed there.
> > >
> > > Let me know if you think this needs more discussion before shipping it.
> > >
> > > (The change is only intended for Fedora 40+ and ELN.)
> >
> > Do we know what the impact of this is going to be beyond those four?
>
> All Fedora packages that BuildRequire python3-sphinx (even transitively) were
> tested. Those that successfully built before this change are known not to be
> impacted, except for the listed 4 and
> https://src.fedoraproject.org/rpms/python-fastavro/pull-request/12 (which is
> special, because the removal only uncovered a bug in tests).
>
> This was tested in
> https://copr.fedorainfracloud.org/coprs/churchyard/sphinxcontrib-optional/bu...
> and
> https://copr.fedorainfracloud.org/coprs/churchyard/sphinxcontrib-mandaotry/b...
>
> A handful of packages timed out after 5 hours in Copr, happy to fix them later
> if they they are impacted. Same for the packages that FTBFS now for unrelated
> reasons.

Then I'm fine with this, let's do it. :)

[Miro Hrončok]

On 08. 11. 23 13:02, Miro Hrončok wrote:
> On 08. 11. 23 12:57, Neal Gompa wrote:
> > > Packages that need those would need to BuildRequire them specifically, as
> > > proposed in:
> > >
> > > -https://src.fedoraproject.org/rpms/xca/pull-request/1
> > >    -https://src.fedoraproject.org/rpms/python-django-haystack/pull-request/1
> > >    -https://src.fedoraproject.org/rpms/pykka/pull-request/3
> > >    -https://src.fedoraproject.org/rpms/extra-cmake-modules/pull-request/2
> > >
> > > The change has been offered upstream, but I suppose it will take a while before
> > > it is actually landed there.
> > >
> > > Let me know if you think this needs more discussion before shipping it.
> > >
> > > (The change is only intended for Fedora 40+ and ELN.)
> >
> > Do we know what the impact of this is going to be beyond those four?
>
> All Fedora packages that BuildRequire python3-sphinx (even transitively) were 
> tested. Those that successfully built before this change are known not to be 
> impacted, except for the listed 4 and 
> https://src.fedoraproject.org/rpms/python-fastavro/pull-request/12 (which is 
> special, because the removal only uncovered a bug in tests).
>
> This was tested in 
> https://copr.fedorainfracloud.org/coprs/churchyard/sphinxcontrib-optional/bu... and https://copr.fedorainfracloud.org/coprs/churchyard/sphinxcontrib-mandaotry/b...
>
> A handful of packages timed out after 5 hours in Copr, happy to fix them later 
> if they they are impacted. Same for the packages that FTBFS now for unrelated 
> reasons.

Another impacted package:

https://src.fedoraproject.org/rpms/buildstream/pull-request/4