.egg-link?

[Igor Gnatenko]

$ cat /usr/lib/python3.5/site-packages/Flask.egg-link
/builddir/build/BUILD/python3-python-flask-0.10.1-9.fc25
.

I think we should exclude all egg-links from distribution.. Also
question comes what we should do from RPM generator.
Neal proposed for now to just skip it[0]..

[0] https://github.com/rpm-software-management/rpm/pull/80

[Nick Coghlan]

On 21 August 2016 at 01:13, Igor Gnatenko  wrote:
> $ cat /usr/lib/python3.5/site-packages/Flask.egg-link
> /builddir/build/BUILD/python3-python-flask-0.10.1-9.fc25
> .
>
> I think we should exclude all egg-links from distribution..

+1 - if these show up, it's likely to be due to a call to "pip -e" or
"setup.py develop", and those kinds of operations shouldn't be used as
part of an RPM build.
> Also
> question comes what we should do from RPM generator.
> Neal proposed for now to just skip it[0]..
>
> [0] https://github.com/rpm-software-management/rpm/pull/80

Is that the PR you intended to link? It doesn't seem to be related to
the problem of .egg-link files appearing in the RPM contents.

Cheers,
Nick.

[Igor Gnatenko]

On Sun, Aug 21, 2016 at 8:28 AM, Nick Coghlan  wrote:
> On 21 August 2016 at 01:13, Igor Gnatenko  wrote:
> > $ cat /usr/lib/python3.5/site-packages/Flask.egg-link
> > /builddir/build/BUILD/python3-python-flask-0.10.1-9.fc25
> > .
> >
> > I think we should exclude all egg-links from distribution..
>
> +1 - if these show up, it's likely to be due to a call to "pip -e" or
> "setup.py develop", and those kinds of operations shouldn't be used as
> part of an RPM build.
> > Also
> > question comes what we should do from RPM generator.
> > Neal proposed for now to just skip it[0]..
> >
> > [0] https://github.com/rpm-software-management/rpm/pull/80
>
> Is that the PR you intended to link? It doesn't seem to be related to
> the problem of .egg-link files appearing in the RPM contents.

It is. Think is that once you use
pkg_resources.Distribution.from_location() on egg-link file it returns
object, but obj.py_version returns None (though it shows warning that
it can't read version from egg-link file).
> Cheers,
> Nick.
>
> --
> Nick Coghlan   |   [e-mail]   |   Brisbane, Australia
> _______________________________________________
> python-devel mailing list
> [e-mail]
> https://lists.fedoraproject.org/admin/lists/[e-mail]...

[Petr Viktorin]

On 08/20/2016 05:13 PM, Igor Gnatenko wrote:
> $ cat /usr/lib/python3.5/site-packages/Flask.egg-link
> /builddir/build/BUILD/python3-python-flask-0.10.1-9.fc25
> .
>
> I think we should exclude all egg-links from distribution.. Also
> question comes what we should do from RPM generator.
> Neal proposed for now to just skip it[0]..

Thankfully they don't seem to be too widespread:

$ dnf repoquery --enablerepo=rawhide '*/*.egg-link'
python-flask-1:0.10.1-8.fc24.noarch
python-flask-1:0.10.1-9.fc25.noarch
python3-flask-1:0.10.1-8.fc24.noarch
python3-flask-1:0.10.1-9.fc25.noarch

+1 to removing them, though.