On 10/31/21 02:45, Miro Hrončok wrote:
Would we upstream that? I think that the "staying close to upstream
projects" policy suggests that we should. And, personally, I don't
think we should patch source without at least asking the upstream
project if that is the best solution.
In the case of mako, specifically, it probably isn't, since the PyPI
tarball does include the test suite (and the generated documentation
that's missing from the git tarball.)
(it doesn't even use git snapshot, but upstream release tarball).
In my opinion, calling it an "upstream release tarball" implies intent
that is not in evidence. GitHub's release tarballs are a side-effect of
declaring a release for a project that can't be disabled (last time I
looked). For any project whose release process is more complex than
simply tarring up the git repo (for example, any project that includes
sub-modules in their intentional release archive), GitHub's automatic
archive isn't a suitable substitute for the archive that developers