-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/37/
-----------------------------------------------------------
Review request for blockerbugs.
Repository: blockerbugs
Description
-------
commit abf5fe2abbcfbce45d103864f5ba40fc89f233fa
Author: Martin Krizek <mkrizek(a)redhat.com>
Date: Tue Jul 16 13:57:28 2013 +0200
Fix sequences in alembic
Sequences need to be created separately. The patch also fixes a few
typos.
https://bitbucket.org/zzzeek/alembic/issue/73/more-pg-nextval-it-needs-the-…
Diffs
-----
alembic/versions/487cb8ccce92_dropping_flask_login.py e64dacb2e3b1a3d14bf38e1116df183ded9793d9
alembic/versions/1d12b74d12bd_add_userinfo_table.py 86dc390ed5e49b0a3ca058e163bc02b070d3d294
Diff: http://reviewboard-tflink.rhcloud.com/r/37/diff/
Testing
-------
Thanks,
Martin Krizek
#381: Bug and Update syncs shouldn't be halted by an isolated problem with one
update or bug
--------------------------------------+----------------------------------
Reporter: tflink | Owner: tflink
Type: enhancement | Status: new
Priority: major | Milestone: Undetermined Future
Component: Blocker bug tracker page | Version:
Keywords: | Blocked By:
Blocking: |
--------------------------------------+----------------------------------
= problem =
The current bug and update sync algorithms are very fragile in that one
error will stop the entire sync algorithm, leaving stuff out of sync with
bodhi or bugzilla. This has caused problems in the past
= analysis =
This could be solved by better error handling in the sync process such
that an error is logged but doesn't bubble up to the main sync code and
halt the entire process.
--
Ticket URL: <https://fedorahosted.org/fedora-qa/ticket/381>
Fedora QA <http://fedorahosted.org/fedora-qa>
Fedora Quality Assurance
#384: Improve documentation
--------------------------------------+------------------------
Reporter: tflink | Owner: tflink
Type: enhancement | Status: new
Priority: major | Milestone: Fedora 20
Component: Blocker bug tracker page | Version:
Keywords: | Blocked By:
Blocking: |
--------------------------------------+------------------------
= problem =
At the moment, our documentation is out of date and somewhat incomplete.
= analysis =
Update the docs and find an appropriate place for them to live.
--
Ticket URL: <https://fedorahosted.org/fedora-qa/ticket/384>
Fedora QA <http://fedorahosted.org/fedora-qa>
Fedora Quality Assurance
#387: Updates pending stable show as stable
--------------------------------------+---------------------
Reporter: kparal | Owner: tflink
Type: defect | Status: new
Priority: minor | Milestone:
Component: Blocker bug tracker page | Version:
Keywords: | Blocked By:
Blocking: |
--------------------------------------+---------------------
A package that is in updates-testing and is pending stable is shown as
[stable] in the app. That can cause some confusion (i.e. one of us can
close a related bug by assuming the package is already stable, and the
package push can be cancelled afterwards).
I think the app should display the repository the package is currently in,
not the repository the package in pending to. What do you think?
--
Ticket URL: <https://fedorahosted.org/fedora-qa/ticket/387>
Fedora QA <http://fedorahosted.org/fedora-qa>
Fedora Quality Assurance
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/45/
-----------------------------------------------------------
Review request for blockerbugs.
Bugs: 357
https://fedorahosted.org/fedora-qa/ticket/357
Repository: blockerbugs
Description
-------
commit d86f88d7f9da899ffef44ad617a8a831327b7d80
Author: Martin Krizek <mkrizek(a)redhat.com>
Date: Mon Aug 12 16:40:16 2013 +0200
Improve asset management
Fixes: #357
I have not minified two js files in milestone_stats.html template as I am not sure it's worth it, any objections?
Diffs
-----
requirements.txt 09e0318bc189512f5d324bda8879ad74c4763f95
blockerbugs/templates/layout.html 49cdbd70ef8347965dfca93971449688f9cd6cb0
blockerbugs/__init__.py bd9973579e80fc859f3e8d22c35753fbd024c5f0
Diff: http://reviewboard-tflink.rhcloud.com/r/45/diff/
Testing
-------
Loaded pages, seems like css and js work as expected after being minified.
Thanks,
Martin Krizek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/42/
-----------------------------------------------------------
Review request for blockerbugs.
Bugs: 316
https://fedorahosted.org/fedora-qa/ticket/316
Repository: blockerbugs
Description
-------
This patch adds a needinfo field into the Bug table. The field is filed with the name of a user that the info is needed from, or empty string if needinfo is not set. If needinfo is set, an icon is displayed in bug list in the same way as the 'recently modified' icon -- any ideas on how to display the information better?
Diffs
-----
sass/app.scss 061016495d9c46aef0efb5dcfc9e3a5eab43f72c
blockerbugs/util/bug_sync.py 49cce49740cd6f5b1f430f58c8d1b522e1f0b7e3
blockerbugs/templates/blocker_list.html 17cdc74d5cac7be3d3843196eeda9e01f1c91ff3
blockerbugs/static/css/app.css 99b6fbc81b231c7f876f1365cfc63f6eade1217e
blockerbugs/static/css/app-foundation.css 852272bf1bd1c629b30933b451daceec31812de7
blockerbugs/models/bug.py 095cf7294a5b0a5b3fb9979abf9e669e4acd157c
alembic/versions/23cc8daafea8_add_needinfo_to_bug.py PRE-CREATION
Diff: http://reviewboard-tflink.rhcloud.com/r/42/diff/
Testing
-------
Run db sync, one of the bugs had needinfo flag set, everything worked as expected.
Thanks,
Martin Krizek
#386: Update URLs should comtain the update ID when possible
--------------------------------------+----------------------------------
Reporter: tflink | Owner: tflink
Type: enhancement | Status: new
Priority: minor | Milestone: Undetermined Future
Component: Blocker bug tracker page | Version:
Keywords: | Blocked By:
Blocking: |
--------------------------------------+----------------------------------
= problem =
The update URLs fetched from bodhi are most reliable when they are based
off of the update ID which is generated when the update is pushed to
testing. However, the blocker tracking app generally grabs the URL before
this happens and thus, end up with the preliminary url based on update
contents.
= analysis =
The update sync process should look to replace any update URLs which are
not based on the update ID when the sync runs against bodhi.
--
Ticket URL: <https://fedorahosted.org/fedora-qa/ticket/386>
Fedora QA <http://fedorahosted.org/fedora-qa>
Fedora Quality Assurance
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/44/
-----------------------------------------------------------
Review request for blockerbugs.
Bugs: 386
https://fedorahosted.org/fedora-qa/ticket/386
Repository: blockerbugs
Description
-------
commit be73d7514172ad122ec969b74a1bac37f14f28f4
Author: Martin Krizek <mkrizek(a)redhat.com>
Date: Mon Aug 12 14:52:39 2013 +0200
Update URLs should comtain the update ID when possible
Fixes: #386
Diffs
-----
blockerbugs/util/update_sync.py d664839ec1c5979dce980e7baad58154f4622e11
Diff: http://reviewboard-tflink.rhcloud.com/r/44/diff/
Testing
-------
Run sync without the fix to fetch urls with title in them. Then I run sync with the fix, the sync process updated the urls to contain updateid instead of title.
Thanks,
Martin Krizek
#411: don't emit messages about what kind of logging is being done
--------------------------------------+------------------------
Reporter: tflink | Owner: tflink
Type: defect | Status: new
Priority: major | Milestone: Fedora 20
Component: Blocker bug tracker page | Version:
Keywords: | Blocked By:
Blocking: |
--------------------------------------+------------------------
= bug description =
On every sync, a "using X logging" message is emitted, sending an email
from production. This makes it more difficult to determine when there's a
problem during sync.
Change it so that message is only emitted if debug is enabled.
--
Ticket URL: <https://fedorahosted.org/fedora-qa/ticket/411>
Fedora QA <http://fedorahosted.org/fedora-qa>
Fedora Quality Assurance
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/47/
-----------------------------------------------------------
Review request for blockerbugs.
Bugs: 411
https://fedorahosted.org/fedora-qa/ticket/411
Repository: blockerbugs
Description
-------
This is a simple change to get rid of the cron noise on sync in production so that it's easier to see and detect issues. The messages are changed from print statements to debug log messages.
Diffs
-----
blockerbugs/__init__.py e8283612c785459fc461d223dc6908187d2ab3f1
Diff: http://reviewboard-tflink.rhcloud.com/r/47/diff/
Testing
-------
I've done testing in my local env but the change itself is trivial and shouldn't cause problems
Thanks,
Tim Flink
#443: Update repoinfo.conf - Add branch
-------------------------+------------------------
Reporter: ausil | Owner:
Type: task | Status: new
Priority: critical | Milestone: Hot issues
Component: production | Keywords:
Blocked By: | Blocking:
-------------------------+------------------------
We have branched for f20 per
https://fedoraproject.org/wiki/Mass_Branching_SOP i am filling a ticket
{{{
Update AutoQA repoinfo.conf
The AutoQA project maintains a config file (repoinfo.conf) that describes
available package repositories and their inheritance. In order to have
automated testing of Branched package builds, the repoinfo.conf file needs
to be updated. Please file an autoqa ticket to modify the repoinfo.conf
file to include pointers to the new release
}}}
--
Ticket URL: <https://fedorahosted.org/autoqa/ticket/443>
AutoQA <http://autoqa.fedorahosted.org>
Automated QA project
#316: Indicate bugs that are needinfo
---------------------------------------+---------------------
Reporter: adamwill | Owner: mkrizek
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: Blocker bug tracker page | Version:
Resolution: | Keywords:
Blocked By: | Blocking:
---------------------------------------+---------------------
Comment (by tflink):
When I do a sync against F19, I get the following TB:
{{{
[bug.py:90] 2013-08-20 13:14:25 DEBUG Bug 909473 missing attribute
'flags' - doing refresh()
Traceback (most recent call last):
File "run_cli.py", line 5, in <module>
exit = cli.main()
File "/home/tflink/code/blockerbugs/blockerbugs/cli.py", line 218, in
main
sync_bugs(fullsync=options.full, docheck=options.check)
File "/home/tflink/code/blockerbugs/blockerbugs/cli.py", line 161, in
sync_bugs
sync.update_active(full_sync=fullsync)
File "/home/tflink/code/blockerbugs/blockerbugs/util/bug_sync.py", line
165, in update_active
self.update_milestone(milestone, 'FreezeException', last_sync_time)
File "/home/tflink/code/blockerbugs/blockerbugs/util/bug_sync.py", line
99, in update_milestone
newbuginfo = self.extract_information(newbug, tracker_type)
File "/home/tflink/code/blockerbugs/blockerbugs/util/bug_sync.py", line
64, in extract_information
needinfo = bug.get_flags('needinfo')[0] if bug.flags else False
TypeError: 'NoneType' object has no attribute '__getitem__'
}}}
--
Ticket URL: <https://fedorahosted.org/fedora-qa/ticket/316#comment:3>
Fedora QA <http://fedorahosted.org/fedora-qa>
Fedora Quality Assurance
#392: ReSTful API
--------------------------------------+-------------------------
Reporter: islamgulov | Owner: islamgulov
Type: enhancement | Status: new
Priority: major | Milestone: Fedora 20
Component: Blocker bug tracker page | Version:
Keywords: | Blocked By:
Blocking: |
--------------------------------------+-------------------------
= problem =
At the moment, Blocker bug tracker app has not API.
= analysis =
API is defined as RESTful HTTP service.
API support JSON data serialization request and response formats.
`application/json` in the Content-Type header required in the request.
Time is specified as an ISO 8601 dateTime (2011-01-24T17:08Z).
List operations return all items at a time (no paging).
Endpoints:
1) Lists bugs associated with a milestone.
GET /api/v<api version>/miletstone/<rel_num>/<version>/bug?type=type&
To filter the list of bugs, you can specify the following optional URI
parameters:
- type=type& - Filters the list of bugs by type.
List bugs response fields:
- bzid: Bugzilla bug id
- url
- summary
- status
- component
- active
- type
Possible values for the bug type attribute include: 'proposed_blocker',
'proposed_fe', 'accepted_blocker', 'accepted_fe', 'rejected_blocker',
'rejected_fe'.
2) Lists updates associated with a milestone.
GET /api/v<api
version>/miletstone/<rel_num>/<version>/update?bugtype=bugtype&
Parameters:
- bugtype=bugtype& - Filters the list of update by type of bugs.
List updates response fields:
- title
- url
- karma
- stable_karma
- status
- pending
- bugs:
- bzid
- type
- release
- milestones:
- version
3) Lists spins associated with a milestone.
GET /api/v<api version>/miletstone/<rel_num>/<version>/spin/
List spins response fields:
- id
- name
- state
- url
- date_requested
- date_created
- spin_type
- updates:
- title
- status
- url
- succeeds:
- id
- milestone
--
Ticket URL: <https://fedorahosted.org/fedora-qa/ticket/392>
Fedora QA <http://fedorahosted.org/fedora-qa>
Fedora Quality Assurance
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/38/
-----------------------------------------------------------
Review request for blockerbugs.
Repository: blockerbugs
Description
-------
commit e08c8ee1085bb0beb71b4a5c98c9d2e2497773cb
Author: Martin Krizek <mkrizek(a)redhat.com>
Date: Mon Jul 15 11:28:09 2013 +0200
Use fake login only in DEV environment
commit 8f175a28ae43b764e52435d174d73e2dc384bd6b
Author: Martin Krizek <mkrizek(a)redhat.com>
Date: Thu Jul 4 11:14:40 2013 +0200
Add developer login
This patch allows a fake login when DEV or TEST is set so we don't
access FAS server each time we log in.
TODO this will be merged with changes made in other review request dealing with fas-openid migrations.
Diffs
-----
blockerbugs/util/login.py PRE-CREATION
blockerbugs/templates/layout.html 8dc6deacd5e7a71757ed2564fb224b3cd92bfad5
blockerbugs/controllers/users.py 6f89a0b29143a9c09fcf25d97d875a01b9955fa4
blockerbugs/controllers/main.py a8082121576015a86c31bc76ebc17e982062a08b
blockerbugs/__init__.py 798fc6ecd562d1e13fbba26f804f74e6da670120
Diff: http://reviewboard-tflink.rhcloud.com/r/38/diff/
Testing
-------
Thanks,
Martin Krizek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/41/
-----------------------------------------------------------
Review request for blockerbugs.
Repository: blockerbugs
Description
-------
commit 5d646f767451cdc5c544b2c5b9bdbbf572628bf3
Author: Martin Krizek <mkrizek(a)redhat.com>
Date: Thu Aug 1 11:21:21 2013 +0200
Redirect to the previous url after login from the main page
The patch also cleans up a login form that is no longer used.
Diffs
-----
blockerbugs/templates/layout.html 8dc6deacd5e7a71757ed2564fb224b3cd92bfad5
blockerbugs/controllers/users.py e14c6c5f0f73404a3a61949c554815f89c2e028d
Diff: http://reviewboard-tflink.rhcloud.com/r/41/diff/
Testing
-------
Logging in via the button in the header works and redirects to the previous page according to my testing.
Thanks,
Martin Krizek