Re: Review Request 44: Update URLs should contain the update ID when possible

[Martin Krizek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/44/#review66
-----------------------------------------------------------

Does this work with ilgiz's update_sync code? Is anything other than the display code relying on having the URL? ie, what else could break by suddenly changing the update url during sync?

- Tim Flink

On Aug. 12, 2013, 12:57 p.m., Martin Krizek wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-tflink.rhcloud.com/r/44/
>
> (Updated Aug. 12, 2013, 12:57 p.m.)
>
> Review request for blockerbugs.
>
> Bugs: 386
>     https://fedorahosted.org/fedora-qa/ticket/386
>
> Repository: blockerbugs
> Description
>
> commit be73d7514172ad122ec969b74a1bac37f14f28f4
> Author: Martin Krizek 
> Date:   Mon Aug 12 14:52:39 2013 +0200
> Update URLs should comtain the update ID when possible
>
> Fixes: #386
>
>
> Diffs
>
> blockerbugs/util/update_sync.py d664839ec1c5979dce980e7baad58154f4622e11
>
> Diff: http://reviewboard-tflink.rhcloud.com/r/44/diff/
> Testing
>
> Run sync without the fix to fetch urls with title in them. Then I run sync with the fix, the sync process updated the urls to contain updateid instead of title.
>
> Thanks,
>
> Martin Krizek