| This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/17/ |
Looks great overall. I had a few more comments but they're minor and I don't think that their fixes will require another review - feel free to merge into develop after you're done with the comments unless you have concerns about them.
| blockerbugs/controllers/users.py (Diff revision 2) | |||
|---|---|---|---|
| 55 | flash('Logged In Successfully as %s!' % login_form.username.data) |
57 | flash('Logged In Successfully as %s!' % login_form.username.data) |
I don't think this is enough to stop these changes but we should probably start using the flash messages in other places than the bz association page. If you've logged in and out before doing the association, the flash messages pile up and you end up with multiple login successful messages on the bz account association page
| blockerbugs/templates/fas_bugzilla.html (Diff revision 2) | |||
|---|---|---|---|
| 15 | <h2>Associate your FAS login with your BugZilla e-mail</h2> |
||
I'm being a little nit-picky here but the wording of this title is a bit akward. What about "Link your FAS and Red Hat Bugzilla Accounts"?
| blockerbugs/templates/fas_bugzilla.html (Diff revision 2) | |||
|---|---|---|---|
| 30 | <fieldset id="bugzilla-credentials"> |
||
can you either remove the fieldset around this login or add it to the FAS login page to make them consistent?
| blockerbugs/templates/fas_bugzilla.html (Diff revision 2) | |||
|---|---|---|---|
| 80 | </form> |
||
Can you stick a bit of text at the end of this which says: "Your Red Hat bugzilla password is used only to verify that you control the account which will be linked to your FAS account. Your password will <b>NOT</b> be stored anywhere in this application."
- Tim
On March 14th, 2013, 11:24 a.m. UTC, Martin Krizek wrote:
|
Review request for blockerbugs.
By Martin Krizek.
Updated March 14, 2013, 11:24 a.m.
Bugs:
347
Repository:
blockerbugs
Description
Diffs
|