On December 10th, 2013, 5:58 p.m. UTC, Tim Flink wrote:

blockerbugs/models/update.py (Diff revision 1)
class Update(db.Model):
55	order_by=date_submitted.desc()))	55	order_by=(status.desc(), pending.desc())))

Why is this sort order change an improvement? If an older update is pending while a newer update is stable, we'd want to show the newer update

On December 11th, 2013, 2:59 p.m. UTC, Martin Krizek wrote:

But wouldn't the older update be marked as obsolete?

It should be but for example, if you look at the tracking app right now, there are 2 anaconda/blivet updates - one of which has been deleted in bodhi but still shows up.

This issue was supposed to be fixed but obviously, it's not. Filed as https://phab.qadevel.cloud.fedoraproject.org/T27

I think that the problem of phantom updates are the root cause of the problem as reported, but I'll ask in bug to be sure.

- Tim

On December 10th, 2013, 3:54 p.m. UTC, Martin Krizek wrote:

commit 911781af9cc06e27c0a8580f07f7673c90e7329d
Author: Martin Krizek <mkrizek@redhat.com>
Date:   Tue Dec 10 16:28:52 2013 +0100

    Sort updates by (status.desc(), pending.desc())
    
    This way an update label is correctly set when multiple updates fix a
    bug. The label is chosen by the following order (the lowest one):
    
    pending testing < testing < pending stable < stable
    
    Fixes: #438

Note: the rest of the issues with displaying label is handled outside this ticket in https://phab.qadevel.cloud.fedoraproject.org/T21

Sorting seems to be working as expected.