This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/36/ |
On August 2nd, 2013, 2:58 p.m. UTC, Tim Flink wrote:
blockerbugs/util/update_sync.py (Diff revision 2) 37 if not bodhi_interface:37 if bodhi_interface:I don't understand the reason for this change - it seems purely stylistic
yes, it's stylistic only changes. As for me `if cond: ... else ...` Is more explicit than: `if not cond: ... else ... `
On August 2nd, 2013, 2:58 p.m. UTC, Tim Flink wrote:
testing/testfunc_update_sync.py (Diff revision 2) 47 update1_for_bug_3000 = Bunch(I don't understand why all this update data is being defined statically - couldn't you get the same effect by generating almost identical updates and just changing the bits that you need to change?
Indeed, I can extract a common part.
- Ilgiz
On July 19th, 2013, 7:05 p.m. UTC, Ilgiz Islamgulov wrote:
Review request for blockerbugs.
By Ilgiz Islamgulov.
Updated July 19, 2013, 7:05 p.m.
Repository:
blockerbugs
Description
Testing
Diffs
|