On May 2nd, 2013, 5:09 a.m. UTC, Tim Flink wrote:

testing/test_bugchange.py (Diff revision 2)
		85	test_bz._do_proposal = exception_raiser(Fault(50, 'not 51 exception'))

I realize that I'm being picky here but why are you effectively monkeypatching the do_proposal method and creating a Dingus that effectively does nothing in this case?

Wouldn't it be closer to actual behavior to have the Dingus throw a fault instead of swapping out the do_proposal method?

Either way, I'd rather see one approach or the other - creating mock-ish objects that aren't actually used is not a good practice to get into

Good point. Patch updated.

- Martin

On May 2nd, 2013, 10:27 a.m. UTC, Martin Krizek wrote:

This patch wraps bugzilla faults in a BugzillaError and prevents them from not being logged and generating http 500 server error.