This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/18/

On April 19th, 2013, 4:27 p.m. UTC, Tim Flink wrote:

blockerbugs/templates/index.html (Diff revision 1)
80
{% block footer %}
80
{% block footer %}
Why limit this to just the index page instead of adding it to the global footer?
Agreed, fixed.

On April 19th, 2013, 4:27 p.m. UTC, Tim Flink wrote:

blockerbugs/templates/index.html (Diff revision 1)
84
                <a class="grayed" href="http://git.fedorahosted.org/cgit/blockerbugs.git">Blocker Tracking App git repo</a>
How about something like: "This application is open source! Get the code (with embedded link to cgit) or look at development plans (with link to fedora-qa trac report 10)"?
Thanks, fixed.

On April 19th, 2013, 4:27 p.m. UTC, Tim Flink wrote:

sass/app.scss (Diff revision 1)
37
  color: $menuBarMainColor;
What's the advantage to greying this out instead of using the link colors that we're using elsewhere in the app?
Initially I thought that the link is not that important information so I greyed the link out. On second thought, let's make it consistent. Fixed.

- Martin


On April 22nd, 2013, 8:47 a.m. UTC, Martin Krizek wrote:

Review request for blockerbugs.
By Martin Krizek.

Updated April 22, 2013, 8:47 a.m.

Bugs: 343
Repository: blockerbugs

Description

This is maybe trivial to have a review for but two things might be discussed:
1. do we want to show the link just on index or on all pages?
2. is the wording of the link ok?

Diffs

  • blockerbugs/templates/layout.html (a0b5ebda3ff61a3fa2647d96ef77037ed0d729d2)
  • blockerbugs/templates/index.html (088962bfcb16c3f0d163366f2235fc557e0d45dc)

View Diff