Review Request 46: New admin interface and builds support

[Martin Krizek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/46/
-----------------------------------------------------------

Review request for blockerbugs.

Repository: blockerbugs

Description
-------

Implement new admin interface with flask-admin
Add build support

Diffs
-----

testing/testfunc_bugmodel.py a50f3458b2154f13736ab1f93cb3d1a86a48fcb1 
  testing/test_controllers.py 702d2a5390e42910176d327461ef628e6bf8b849 
  testing/test_api.py 15ddd7dd03c5d3675fab78c70f2687b838d94b08 
  setup.py 8a55d39674daf9bd240220ed8a147a691aa23a66 
  sass/admin_layout.scss PRE-CREATION 
  requirements.txt 98eab5da9306a101a41dd13708df1900e9fd1018 
  blockerbugs/util/koji_interface.py PRE-CREATION 
  blockerbugs/templates/spin_list.html c455ff4edec0991a453a94cd0e38d959e1757672 
  blockerbugs/templates/admin_layout.html PRE-CREATION 
  blockerbugs/templates/admin/modify_release.html a3bb0d95c49414ff977e82f828ffdd111e105cc6 
  blockerbugs/templates/admin/main.html 251b1df1647e307e89bcda365422f1cee59b9a35 
  blockerbugs/templates/admin/admin_nav.html 34a0c2a966c265ab66166b3170f5f6d507014149 
  blockerbugs/templates/admin/add_spin.html be44830da436e4e87700fe940a7c5197b32d1e82 
  blockerbugs/templates/admin/add_release.html 931001b23f52dd1b75fe0feb8d0311b76fcc907e 
  blockerbugs/static/js/admin.js PRE-CREATION 
  blockerbugs/models/update.py 9660d038720bcecae8e4f7401e09e26bd6589189 
  blockerbugs/models/spin.py fa8e0e9a887f269cf31e850baa90678ff7055b78 
  blockerbugs/models/release.py cca27cff41875528c1ee13d95194de5f237f31d4 
  blockerbugs/models/milestone.py 31667f6467ed111c3594cdd86d1c933f73b7dfc2 
  blockerbugs/models/build.py PRE-CREATION 
  blockerbugs/models/__init__.py 0223fff2996290005bd50412c844979304ce38a2 
  blockerbugs/controllers/users.py 7b6954adc39b23c997033916e1adc17639451fdd 
  blockerbugs/controllers/main.py 44924e096803b5c448dbd84dc5fe0405a97ebc50 
  blockerbugs/controllers/api/utils.py 38144dd48f3190f709a9bafa3a5a425dfdfffbdf 
  blockerbugs/controllers/api/api.py 30de9189473bb8bbeb63b7578e5e21de0a51d2d7 
  blockerbugs/controllers/admin/spin.py PRE-CREATION 
  blockerbugs/controllers/admin/build.py PRE-CREATION 
  blockerbugs/controllers/admin/auth.py PRE-CREATION 
  blockerbugs/controllers/admin/__init__.py PRE-CREATION 
  blockerbugs/controllers/admin.py 4ce6c9f58b5513c280312c8d1dd92c341d259d0a 
  blockerbugs/config.py 03e8b2a92aaaf7328b68c3fa4eb585a189f52186 
  blockerbugs/__init__.py 1bac593a334a848308fdb362deee496a046293e8 
  blockerbugs.spec 083c7c29789e172d48e455413478f376ef3eb099 
  alembic/versions/f9e369bf00d_added_spin_type_cons.py PRE-CREATION 
  alembic/versions/1162fb4d4358_added_build_table.py PRE-CREATION

Diff: http://reviewboard-tflink.rhcloud.com/r/46/diff/

Testing
-------

I've tested on my develop instance.

Thanks,

Ilgiz Islamgulov

[Martin Krizek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/46/
-----------------------------------------------------------

(Updated Aug. 16, 2013, 4:15 p.m.)

Review request for blockerbugs.

Repository: blockerbugs

Description
-------

Implement new admin interface with flask-admin
Add build support

Diffs
-----

testing/testfunc_bugmodel.py a50f3458b2154f13736ab1f93cb3d1a86a48fcb1 
  testing/test_controllers.py 702d2a5390e42910176d327461ef628e6bf8b849 
  testing/test_api.py 15ddd7dd03c5d3675fab78c70f2687b838d94b08 
  setup.py 8a55d39674daf9bd240220ed8a147a691aa23a66 
  sass/admin_layout.scss PRE-CREATION 
  requirements.txt 98eab5da9306a101a41dd13708df1900e9fd1018 
  blockerbugs/util/koji_interface.py PRE-CREATION 
  blockerbugs/templates/spin_list.html c455ff4edec0991a453a94cd0e38d959e1757672 
  blockerbugs/templates/admin_layout.html PRE-CREATION 
  blockerbugs/templates/admin/modify_release.html a3bb0d95c49414ff977e82f828ffdd111e105cc6 
  blockerbugs/templates/admin/main.html 251b1df1647e307e89bcda365422f1cee59b9a35 
  blockerbugs/templates/admin/admin_nav.html 34a0c2a966c265ab66166b3170f5f6d507014149 
  blockerbugs/templates/admin/add_spin.html be44830da436e4e87700fe940a7c5197b32d1e82 
  blockerbugs/templates/admin/add_release.html 931001b23f52dd1b75fe0feb8d0311b76fcc907e 
  blockerbugs/static/js/admin.js PRE-CREATION 
  blockerbugs/models/update.py 9660d038720bcecae8e4f7401e09e26bd6589189 
  blockerbugs/models/spin.py fa8e0e9a887f269cf31e850baa90678ff7055b78 
  blockerbugs/models/release.py cca27cff41875528c1ee13d95194de5f237f31d4 
  blockerbugs/models/milestone.py 31667f6467ed111c3594cdd86d1c933f73b7dfc2 
  blockerbugs/models/build.py PRE-CREATION 
  blockerbugs/models/__init__.py 0223fff2996290005bd50412c844979304ce38a2 
  blockerbugs/controllers/users.py 7b6954adc39b23c997033916e1adc17639451fdd 
  blockerbugs/controllers/main.py 44924e096803b5c448dbd84dc5fe0405a97ebc50 
  blockerbugs/controllers/api/utils.py 38144dd48f3190f709a9bafa3a5a425dfdfffbdf 
  blockerbugs/controllers/api/api.py 30de9189473bb8bbeb63b7578e5e21de0a51d2d7 
  blockerbugs/controllers/admin/spin.py PRE-CREATION 
  blockerbugs/controllers/admin/build.py PRE-CREATION 
  blockerbugs/controllers/admin/auth.py PRE-CREATION 
  blockerbugs/controllers/admin/__init__.py PRE-CREATION 
  blockerbugs/controllers/admin.py 4ce6c9f58b5513c280312c8d1dd92c341d259d0a 
  blockerbugs/config.py 03e8b2a92aaaf7328b68c3fa4eb585a189f52186 
  blockerbugs/__init__.py 1bac593a334a848308fdb362deee496a046293e8 
  blockerbugs.spec 083c7c29789e172d48e455413478f376ef3eb099 
  alembic/versions/f9e369bf00d_added_spin_type_cons.py PRE-CREATION 
  alembic/versions/1162fb4d4358_added_build_table.py PRE-CREATION

Diff: http://reviewboard-tflink.rhcloud.com/r/46/diff/

Testing
-------

I've tested on my develop instance.

Thanks,

Ilgiz Islamgulov

[Martin Krizek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/46/
-----------------------------------------------------------

(Updated Aug. 21, 2013, 9:04 p.m.)

Review request for blockerbugs.

Repository: blockerbugs

Description
-------

Implement new admin interface with flask-admin
Add build support

Diffs (updated)
-----

testing/testfunc_update_sync.py 70c600515ccc5e97ed17b4cadd40d76277794b67 
  testing/testfunc_bugsync.py 496f2994dda81bc82f2e270944a3fb2b391d9d91 
  testing/testfunc_bugmodel.py a50f3458b2154f13736ab1f93cb3d1a86a48fcb1 
  testing/test_controllers.py 702d2a5390e42910176d327461ef628e6bf8b849 
  testing/test_api.py e92dda539117f94f3283f6ce262d65295a5e32c1 
  setup.py 89621b0debb5d368a027a4801de7da62fa961eab 
  sass/admin_layout.scss PRE-CREATION 
  requirements.txt 98eab5da9306a101a41dd13708df1900e9fd1018 
  blockerbugs/util/koji_interface.py PRE-CREATION 
  blockerbugs/templates/spin_list.html c455ff4edec0991a453a94cd0e38d959e1757672 
  blockerbugs/templates/admin_layout.html PRE-CREATION 
  blockerbugs/templates/admin/modify_release.html a3bb0d95c49414ff977e82f828ffdd111e105cc6 
  blockerbugs/templates/admin/main.html 251b1df1647e307e89bcda365422f1cee59b9a35 
  blockerbugs/templates/admin/admin_nav.html 34a0c2a966c265ab66166b3170f5f6d507014149 
  blockerbugs/templates/admin/add_spin.html be44830da436e4e87700fe940a7c5197b32d1e82 
  blockerbugs/templates/admin/add_release.html 931001b23f52dd1b75fe0feb8d0311b76fcc907e 
  blockerbugs/static/js/admin.js PRE-CREATION 
  blockerbugs/models/update.py 9660d038720bcecae8e4f7401e09e26bd6589189 
  blockerbugs/models/spin.py fa8e0e9a887f269cf31e850baa90678ff7055b78 
  blockerbugs/models/release.py cca27cff41875528c1ee13d95194de5f237f31d4 
  blockerbugs/models/milestone.py 31667f6467ed111c3594cdd86d1c933f73b7dfc2 
  blockerbugs/models/build.py PRE-CREATION 
  blockerbugs/models/__init__.py 0223fff2996290005bd50412c844979304ce38a2 
  blockerbugs/controllers/users.py 7b6954adc39b23c997033916e1adc17639451fdd 
  blockerbugs/controllers/main.py 44924e096803b5c448dbd84dc5fe0405a97ebc50 
  blockerbugs/controllers/api/utils.py 38144dd48f3190f709a9bafa3a5a425dfdfffbdf 
  blockerbugs/controllers/api/api.py d6df7d34170da05bd817b12545596f34b43b9da6 
  blockerbugs/controllers/admin/spin.py PRE-CREATION 
  blockerbugs/controllers/admin/build.py PRE-CREATION 
  blockerbugs/controllers/admin/auth.py PRE-CREATION 
  blockerbugs/controllers/admin/__init__.py PRE-CREATION 
  blockerbugs/controllers/admin.py 4ce6c9f58b5513c280312c8d1dd92c341d259d0a 
  blockerbugs/config.py 03e8b2a92aaaf7328b68c3fa4eb585a189f52186 
  blockerbugs/__init__.py b9d7a40e4e9b47624795958212025428e7788b0f 
  blockerbugs.spec cda6d4e4c56cce5b3ab37665b4f1988fc62f29ce 
  alembic/versions/f9e369bf00d_added_spin_type_cons.py PRE-CREATION 
  alembic/versions/1162fb4d4358_added_build_table.py PRE-CREATION

Diff: http://reviewboard-tflink.rhcloud.com/r/46/diff/

Testing
-------

I've tested on my develop instance.

Thanks,

Ilgiz Islamgulov

[Martin Krizek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/46/
-----------------------------------------------------------

(Updated Aug. 22, 2013, 7:01 p.m.)

Review request for blockerbugs.

Changes
-------

spin state\type as property

Repository: blockerbugs

Description
-------

Implement new admin interface with flask-admin
Add build support

Diffs (updated)
-----

testing/testfunc_update_sync.py 70c600515ccc5e97ed17b4cadd40d76277794b67 
  testing/testfunc_bugsync.py 496f2994dda81bc82f2e270944a3fb2b391d9d91 
  testing/testfunc_bugmodel.py a50f3458b2154f13736ab1f93cb3d1a86a48fcb1 
  testing/test_spinmodel.py PRE-CREATION 
  testing/test_controllers.py 702d2a5390e42910176d327461ef628e6bf8b849 
  testing/test_api.py e92dda539117f94f3283f6ce262d65295a5e32c1 
  setup.py 89621b0debb5d368a027a4801de7da62fa961eab 
  sass/admin_layout.scss PRE-CREATION 
  requirements.txt 98eab5da9306a101a41dd13708df1900e9fd1018 
  blockerbugs/util/koji_interface.py PRE-CREATION 
  blockerbugs/templates/spin_list.html c455ff4edec0991a453a94cd0e38d959e1757672 
  blockerbugs/templates/admin_layout.html PRE-CREATION 
  blockerbugs/templates/admin/modify_release.html a3bb0d95c49414ff977e82f828ffdd111e105cc6 
  blockerbugs/templates/admin/main.html 251b1df1647e307e89bcda365422f1cee59b9a35 
  blockerbugs/templates/admin/admin_nav.html 34a0c2a966c265ab66166b3170f5f6d507014149 
  blockerbugs/templates/admin/add_spin.html be44830da436e4e87700fe940a7c5197b32d1e82 
  blockerbugs/templates/admin/add_release.html 931001b23f52dd1b75fe0feb8d0311b76fcc907e 
  blockerbugs/static/js/admin.js PRE-CREATION 
  blockerbugs/models/update.py 9660d038720bcecae8e4f7401e09e26bd6589189 
  blockerbugs/models/spin.py fa8e0e9a887f269cf31e850baa90678ff7055b78 
  blockerbugs/models/release.py cca27cff41875528c1ee13d95194de5f237f31d4 
  blockerbugs/models/milestone.py 31667f6467ed111c3594cdd86d1c933f73b7dfc2 
  blockerbugs/models/build.py PRE-CREATION 
  blockerbugs/models/__init__.py 0223fff2996290005bd50412c844979304ce38a2 
  blockerbugs/controllers/users.py 7b6954adc39b23c997033916e1adc17639451fdd 
  blockerbugs/controllers/main.py 44924e096803b5c448dbd84dc5fe0405a97ebc50 
  blockerbugs/controllers/api/utils.py 38144dd48f3190f709a9bafa3a5a425dfdfffbdf 
  blockerbugs/controllers/api/api.py d6df7d34170da05bd817b12545596f34b43b9da6 
  blockerbugs/controllers/admin/spin.py PRE-CREATION 
  blockerbugs/controllers/admin/build.py PRE-CREATION 
  blockerbugs/controllers/admin/auth.py PRE-CREATION 
  blockerbugs/controllers/admin/__init__.py PRE-CREATION 
  blockerbugs/controllers/admin.py 4ce6c9f58b5513c280312c8d1dd92c341d259d0a 
  blockerbugs/config.py 03e8b2a92aaaf7328b68c3fa4eb585a189f52186 
  blockerbugs/__init__.py b9d7a40e4e9b47624795958212025428e7788b0f 
  blockerbugs.spec cda6d4e4c56cce5b3ab37665b4f1988fc62f29ce 
  alembic/versions/f9e369bf00d_added_spin_type_cons.py PRE-CREATION 
  alembic/versions/1162fb4d4358_added_build_table.py PRE-CREATION

Diff: http://reviewboard-tflink.rhcloud.com/r/46/diff/

Testing
-------

I've tested on my develop instance.

Thanks,

Ilgiz Islamgulov

[Martin Krizek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/46/#review76
-----------------------------------------------------------

blockerbugs.spec
http://reviewboard-tflink.rhcloud.com/r/46/#comment115

koji needs to be added as a requires to the spec

blockerbugs/controllers/admin/spin.py
http://reviewboard-tflink.rhcloud.com/r/46/#comment116

won't this only grab single digits? it's rare but we could have a TC10 or at least I'd rather not prevent double digits

blockerbugs/models/build.py
http://reviewboard-tflink.rhcloud.com/r/46/#comment114

the build model needs a copyright header

blockerbugs/models/spin.py
http://reviewboard-tflink.rhcloud.com/r/46/#comment117

is there a reason for this change in method name and double to single quotes?

blockerbugs/util/koji_interface.py
http://reviewboard-tflink.rhcloud.com/r/46/#comment118

missing gpl header

sass/admin_layout.scss
http://reviewboard-tflink.rhcloud.com/r/46/#comment119

this needs to be compiled and the resultant css added to the patch.

Is there a reason that this couldn't be added to the main css? Are there conflicts in the flask-admin stuff?

testing/test_spinmodel.py
http://reviewboard-tflink.rhcloud.com/r/46/#comment120

this is missing the copyright header

testing/testfunc_bugmodel.py
http://reviewboard-tflink.rhcloud.com/r/46/#comment121

missing copyright header

Some minor nits but overall, looks good to me. can you hold off on merging this into develop for just a bit, though? I'd like to do some more testing first

- Tim Flink

On Aug. 22, 2013, 7:01 p.m., Ilgiz Islamgulov wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-tflink.rhcloud.com/r/46/
>
> (Updated Aug. 22, 2013, 7:01 p.m.)
>
> Review request for blockerbugs.
>
> Repository: blockerbugs
> Description
>
> Implement new admin interface with flask-admin
> Add build support
> Diffs
>
> testing/testfunc_update_sync.py 70c600515ccc5e97ed17b4cadd40d76277794b67 
>   testing/testfunc_bugsync.py 496f2994dda81bc82f2e270944a3fb2b391d9d91 
>   testing/testfunc_bugmodel.py a50f3458b2154f13736ab1f93cb3d1a86a48fcb1 
>   testing/test_spinmodel.py PRE-CREATION 
>   testing/test_controllers.py 702d2a5390e42910176d327461ef628e6bf8b849 
>   testing/test_api.py e92dda539117f94f3283f6ce262d65295a5e32c1 
>   setup.py 89621b0debb5d368a027a4801de7da62fa961eab 
>   sass/admin_layout.scss PRE-CREATION 
>   requirements.txt 98eab5da9306a101a41dd13708df1900e9fd1018 
>   blockerbugs/util/koji_interface.py PRE-CREATION 
>   blockerbugs/templates/spin_list.html c455ff4edec0991a453a94cd0e38d959e1757672 
>   blockerbugs/templates/admin_layout.html PRE-CREATION 
>   blockerbugs/templates/admin/modify_release.html a3bb0d95c49414ff977e82f828ffdd111e105cc6 
>   blockerbugs/templates/admin/main.html 251b1df1647e307e89bcda365422f1cee59b9a35 
>   blockerbugs/templates/admin/admin_nav.html 34a0c2a966c265ab66166b3170f5f6d507014149 
>   blockerbugs/templates/admin/add_spin.html be44830da436e4e87700fe940a7c5197b32d1e82 
>   blockerbugs/templates/admin/add_release.html 931001b23f52dd1b75fe0feb8d0311b76fcc907e 
>   blockerbugs/static/js/admin.js PRE-CREATION 
>   blockerbugs/models/update.py 9660d038720bcecae8e4f7401e09e26bd6589189 
>   blockerbugs/models/spin.py fa8e0e9a887f269cf31e850baa90678ff7055b78 
>   blockerbugs/models/release.py cca27cff41875528c1ee13d95194de5f237f31d4 
>   blockerbugs/models/milestone.py 31667f6467ed111c3594cdd86d1c933f73b7dfc2 
>   blockerbugs/models/build.py PRE-CREATION 
>   blockerbugs/models/__init__.py 0223fff2996290005bd50412c844979304ce38a2 
>   blockerbugs/controllers/users.py 7b6954adc39b23c997033916e1adc17639451fdd 
>   blockerbugs/controllers/main.py 44924e096803b5c448dbd84dc5fe0405a97ebc50 
>   blockerbugs/controllers/api/utils.py 38144dd48f3190f709a9bafa3a5a425dfdfffbdf 
>   blockerbugs/controllers/api/api.py d6df7d34170da05bd817b12545596f34b43b9da6 
>   blockerbugs/controllers/admin/spin.py PRE-CREATION 
>   blockerbugs/controllers/admin/build.py PRE-CREATION 
>   blockerbugs/controllers/admin/auth.py PRE-CREATION 
>   blockerbugs/controllers/admin/__init__.py PRE-CREATION 
>   blockerbugs/controllers/admin.py 4ce6c9f58b5513c280312c8d1dd92c341d259d0a 
>   blockerbugs/config.py 03e8b2a92aaaf7328b68c3fa4eb585a189f52186 
>   blockerbugs/__init__.py b9d7a40e4e9b47624795958212025428e7788b0f 
>   blockerbugs.spec cda6d4e4c56cce5b3ab37665b4f1988fc62f29ce 
>   alembic/versions/f9e369bf00d_added_spin_type_cons.py PRE-CREATION 
>   alembic/versions/1162fb4d4358_added_build_table.py PRE-CREATION
>
> Diff: http://reviewboard-tflink.rhcloud.com/r/46/diff/
> Testing
>
> I've tested on my develop instance.
>
> Thanks,
>
> Ilgiz Islamgulov

[Martin Krizek]

> On Aug. 23, 2013, 6:05 a.m., Tim Flink wrote:
> > blockerbugs/models/spin.py, line 94
> > http://reviewboard-tflink.rhcloud.com/r/46/diff/3/?file=939#file939line94
> > is there a reason for this change in method name and double to single quotes?

As for me str is better choice for this behaviour.
> On Aug. 23, 2013, 6:05 a.m., Tim Flink wrote:
> > sass/admin_layout.scss, line 1
> > http://reviewboard-tflink.rhcloud.com/r/46/diff/3/?file=951#file951line1
> > this needs to be compiled and the resultant css added to the patch.
> >
> > Is there a reason that this couldn't be added to the main css? Are there conflicts in the flask-admin stuff?

got it, thank you

- Ilgiz

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/46/#review76
-----------------------------------------------------------

On Aug. 22, 2013, 7:01 p.m., Ilgiz Islamgulov wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-tflink.rhcloud.com/r/46/
>
> (Updated Aug. 22, 2013, 7:01 p.m.)
>
> Review request for blockerbugs.
>
> Repository: blockerbugs
> Description
>
> Implement new admin interface with flask-admin
> Add build support
> Diffs
>
> testing/testfunc_update_sync.py 70c600515ccc5e97ed17b4cadd40d76277794b67 
>   testing/testfunc_bugsync.py 496f2994dda81bc82f2e270944a3fb2b391d9d91 
>   testing/testfunc_bugmodel.py a50f3458b2154f13736ab1f93cb3d1a86a48fcb1 
>   testing/test_spinmodel.py PRE-CREATION 
>   testing/test_controllers.py 702d2a5390e42910176d327461ef628e6bf8b849 
>   testing/test_api.py e92dda539117f94f3283f6ce262d65295a5e32c1 
>   setup.py 89621b0debb5d368a027a4801de7da62fa961eab 
>   sass/admin_layout.scss PRE-CREATION 
>   requirements.txt 98eab5da9306a101a41dd13708df1900e9fd1018 
>   blockerbugs/util/koji_interface.py PRE-CREATION 
>   blockerbugs/templates/spin_list.html c455ff4edec0991a453a94cd0e38d959e1757672 
>   blockerbugs/templates/admin_layout.html PRE-CREATION 
>   blockerbugs/templates/admin/modify_release.html a3bb0d95c49414ff977e82f828ffdd111e105cc6 
>   blockerbugs/templates/admin/main.html 251b1df1647e307e89bcda365422f1cee59b9a35 
>   blockerbugs/templates/admin/admin_nav.html 34a0c2a966c265ab66166b3170f5f6d507014149 
>   blockerbugs/templates/admin/add_spin.html be44830da436e4e87700fe940a7c5197b32d1e82 
>   blockerbugs/templates/admin/add_release.html 931001b23f52dd1b75fe0feb8d0311b76fcc907e 
>   blockerbugs/static/js/admin.js PRE-CREATION 
>   blockerbugs/models/update.py 9660d038720bcecae8e4f7401e09e26bd6589189 
>   blockerbugs/models/spin.py fa8e0e9a887f269cf31e850baa90678ff7055b78 
>   blockerbugs/models/release.py cca27cff41875528c1ee13d95194de5f237f31d4 
>   blockerbugs/models/milestone.py 31667f6467ed111c3594cdd86d1c933f73b7dfc2 
>   blockerbugs/models/build.py PRE-CREATION 
>   blockerbugs/models/__init__.py 0223fff2996290005bd50412c844979304ce38a2 
>   blockerbugs/controllers/users.py 7b6954adc39b23c997033916e1adc17639451fdd 
>   blockerbugs/controllers/main.py 44924e096803b5c448dbd84dc5fe0405a97ebc50 
>   blockerbugs/controllers/api/utils.py 38144dd48f3190f709a9bafa3a5a425dfdfffbdf 
>   blockerbugs/controllers/api/api.py d6df7d34170da05bd817b12545596f34b43b9da6 
>   blockerbugs/controllers/admin/spin.py PRE-CREATION 
>   blockerbugs/controllers/admin/build.py PRE-CREATION 
>   blockerbugs/controllers/admin/auth.py PRE-CREATION 
>   blockerbugs/controllers/admin/__init__.py PRE-CREATION 
>   blockerbugs/controllers/admin.py 4ce6c9f58b5513c280312c8d1dd92c341d259d0a 
>   blockerbugs/config.py 03e8b2a92aaaf7328b68c3fa4eb585a189f52186 
>   blockerbugs/__init__.py b9d7a40e4e9b47624795958212025428e7788b0f 
>   blockerbugs.spec cda6d4e4c56cce5b3ab37665b4f1988fc62f29ce 
>   alembic/versions/f9e369bf00d_added_spin_type_cons.py PRE-CREATION 
>   alembic/versions/1162fb4d4358_added_build_table.py PRE-CREATION
>
> Diff: http://reviewboard-tflink.rhcloud.com/r/46/diff/
> Testing
>
> I've tested on my develop instance.
>
> Thanks,
>
> Ilgiz Islamgulov

[Martin Krizek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/46/#review77
-----------------------------------------------------------

alembic/versions/1162fb4d4358_added_build_table.py
http://reviewboard-tflink.rhcloud.com/r/46/#comment122

Just curious, why is this needed?

blockerbugs/__init__.py
http://reviewboard-tflink.rhcloud.com/r/46/#comment123

Is this import useful for anything after removing the line below?

blockerbugs/models/build.py
http://reviewboard-tflink.rhcloud.com/r/46/#comment124

I wonder if these strings should be limited in length.

- Martin Krizek

On Aug. 22, 2013, 7:01 p.m., Ilgiz Islamgulov wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-tflink.rhcloud.com/r/46/
>
> (Updated Aug. 22, 2013, 7:01 p.m.)
>
> Review request for blockerbugs.
>
> Repository: blockerbugs
> Description
>
> Implement new admin interface with flask-admin
> Add build support
> Diffs
>
> testing/testfunc_update_sync.py 70c600515ccc5e97ed17b4cadd40d76277794b67 
>   testing/testfunc_bugsync.py 496f2994dda81bc82f2e270944a3fb2b391d9d91 
>   testing/testfunc_bugmodel.py a50f3458b2154f13736ab1f93cb3d1a86a48fcb1 
>   testing/test_spinmodel.py PRE-CREATION 
>   testing/test_controllers.py 702d2a5390e42910176d327461ef628e6bf8b849 
>   testing/test_api.py e92dda539117f94f3283f6ce262d65295a5e32c1 
>   setup.py 89621b0debb5d368a027a4801de7da62fa961eab 
>   sass/admin_layout.scss PRE-CREATION 
>   requirements.txt 98eab5da9306a101a41dd13708df1900e9fd1018 
>   blockerbugs/util/koji_interface.py PRE-CREATION 
>   blockerbugs/templates/spin_list.html c455ff4edec0991a453a94cd0e38d959e1757672 
>   blockerbugs/templates/admin_layout.html PRE-CREATION 
>   blockerbugs/templates/admin/modify_release.html a3bb0d95c49414ff977e82f828ffdd111e105cc6 
>   blockerbugs/templates/admin/main.html 251b1df1647e307e89bcda365422f1cee59b9a35 
>   blockerbugs/templates/admin/admin_nav.html 34a0c2a966c265ab66166b3170f5f6d507014149 
>   blockerbugs/templates/admin/add_spin.html be44830da436e4e87700fe940a7c5197b32d1e82 
>   blockerbugs/templates/admin/add_release.html 931001b23f52dd1b75fe0feb8d0311b76fcc907e 
>   blockerbugs/static/js/admin.js PRE-CREATION 
>   blockerbugs/models/update.py 9660d038720bcecae8e4f7401e09e26bd6589189 
>   blockerbugs/models/spin.py fa8e0e9a887f269cf31e850baa90678ff7055b78 
>   blockerbugs/models/release.py cca27cff41875528c1ee13d95194de5f237f31d4 
>   blockerbugs/models/milestone.py 31667f6467ed111c3594cdd86d1c933f73b7dfc2 
>   blockerbugs/models/build.py PRE-CREATION 
>   blockerbugs/models/__init__.py 0223fff2996290005bd50412c844979304ce38a2 
>   blockerbugs/controllers/users.py 7b6954adc39b23c997033916e1adc17639451fdd 
>   blockerbugs/controllers/main.py 44924e096803b5c448dbd84dc5fe0405a97ebc50 
>   blockerbugs/controllers/api/utils.py 38144dd48f3190f709a9bafa3a5a425dfdfffbdf 
>   blockerbugs/controllers/api/api.py d6df7d34170da05bd817b12545596f34b43b9da6 
>   blockerbugs/controllers/admin/spin.py PRE-CREATION 
>   blockerbugs/controllers/admin/build.py PRE-CREATION 
>   blockerbugs/controllers/admin/auth.py PRE-CREATION 
>   blockerbugs/controllers/admin/__init__.py PRE-CREATION 
>   blockerbugs/controllers/admin.py 4ce6c9f58b5513c280312c8d1dd92c341d259d0a 
>   blockerbugs/config.py 03e8b2a92aaaf7328b68c3fa4eb585a189f52186 
>   blockerbugs/__init__.py b9d7a40e4e9b47624795958212025428e7788b0f 
>   blockerbugs.spec cda6d4e4c56cce5b3ab37665b4f1988fc62f29ce 
>   alembic/versions/f9e369bf00d_added_spin_type_cons.py PRE-CREATION 
>   alembic/versions/1162fb4d4358_added_build_table.py PRE-CREATION
>
> Diff: http://reviewboard-tflink.rhcloud.com/r/46/diff/
> Testing
>
> I've tested on my develop instance.
>
> Thanks,
>
> Ilgiz Islamgulov

[Martin Krizek]

> On Aug. 23, 2013, 12:59 p.m., Martin Krizek wrote:
> > blockerbugs/__init__.py, line 154
> > http://reviewboard-tflink.rhcloud.com/r/46/diff/3/?file=924#file924line154
> > Is this import useful for anything after removing the line below?

this import initialize flask-admin views (in  admin/__inin__.py).
> On Aug. 23, 2013, 12:59 p.m., Martin Krizek wrote:
> > alembic/versions/1162fb4d4358_added_build_table.py, line 35
> > http://reviewboard-tflink.rhcloud.com/r/46/diff/3/?file=921#file921line35
> > Just curious, why is this needed?

this command auto generated by alembic, looks like useless constraint
> On Aug. 23, 2013, 12:59 p.m., Martin Krizek wrote:
> > blockerbugs/models/build.py, line 19
> > http://reviewboard-tflink.rhcloud.com/r/46/diff/3/?file=936#file936line19
> > I wonder if these strings should be limited in length.

you're right

- Ilgiz

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/46/#review77
-----------------------------------------------------------

On Aug. 22, 2013, 7:01 p.m., Ilgiz Islamgulov wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-tflink.rhcloud.com/r/46/
>
> (Updated Aug. 22, 2013, 7:01 p.m.)
>
> Review request for blockerbugs.
>
> Repository: blockerbugs
> Description
>
> Implement new admin interface with flask-admin
> Add build support
> Diffs
>
> testing/testfunc_update_sync.py 70c600515ccc5e97ed17b4cadd40d76277794b67 
>   testing/testfunc_bugsync.py 496f2994dda81bc82f2e270944a3fb2b391d9d91 
>   testing/testfunc_bugmodel.py a50f3458b2154f13736ab1f93cb3d1a86a48fcb1 
>   testing/test_spinmodel.py PRE-CREATION 
>   testing/test_controllers.py 702d2a5390e42910176d327461ef628e6bf8b849 
>   testing/test_api.py e92dda539117f94f3283f6ce262d65295a5e32c1 
>   setup.py 89621b0debb5d368a027a4801de7da62fa961eab 
>   sass/admin_layout.scss PRE-CREATION 
>   requirements.txt 98eab5da9306a101a41dd13708df1900e9fd1018 
>   blockerbugs/util/koji_interface.py PRE-CREATION 
>   blockerbugs/templates/spin_list.html c455ff4edec0991a453a94cd0e38d959e1757672 
>   blockerbugs/templates/admin_layout.html PRE-CREATION 
>   blockerbugs/templates/admin/modify_release.html a3bb0d95c49414ff977e82f828ffdd111e105cc6 
>   blockerbugs/templates/admin/main.html 251b1df1647e307e89bcda365422f1cee59b9a35 
>   blockerbugs/templates/admin/admin_nav.html 34a0c2a966c265ab66166b3170f5f6d507014149 
>   blockerbugs/templates/admin/add_spin.html be44830da436e4e87700fe940a7c5197b32d1e82 
>   blockerbugs/templates/admin/add_release.html 931001b23f52dd1b75fe0feb8d0311b76fcc907e 
>   blockerbugs/static/js/admin.js PRE-CREATION 
>   blockerbugs/models/update.py 9660d038720bcecae8e4f7401e09e26bd6589189 
>   blockerbugs/models/spin.py fa8e0e9a887f269cf31e850baa90678ff7055b78 
>   blockerbugs/models/release.py cca27cff41875528c1ee13d95194de5f237f31d4 
>   blockerbugs/models/milestone.py 31667f6467ed111c3594cdd86d1c933f73b7dfc2 
>   blockerbugs/models/build.py PRE-CREATION 
>   blockerbugs/models/__init__.py 0223fff2996290005bd50412c844979304ce38a2 
>   blockerbugs/controllers/users.py 7b6954adc39b23c997033916e1adc17639451fdd 
>   blockerbugs/controllers/main.py 44924e096803b5c448dbd84dc5fe0405a97ebc50 
>   blockerbugs/controllers/api/utils.py 38144dd48f3190f709a9bafa3a5a425dfdfffbdf 
>   blockerbugs/controllers/api/api.py d6df7d34170da05bd817b12545596f34b43b9da6 
>   blockerbugs/controllers/admin/spin.py PRE-CREATION 
>   blockerbugs/controllers/admin/build.py PRE-CREATION 
>   blockerbugs/controllers/admin/auth.py PRE-CREATION 
>   blockerbugs/controllers/admin/__init__.py PRE-CREATION 
>   blockerbugs/controllers/admin.py 4ce6c9f58b5513c280312c8d1dd92c341d259d0a 
>   blockerbugs/config.py 03e8b2a92aaaf7328b68c3fa4eb585a189f52186 
>   blockerbugs/__init__.py b9d7a40e4e9b47624795958212025428e7788b0f 
>   blockerbugs.spec cda6d4e4c56cce5b3ab37665b4f1988fc62f29ce 
>   alembic/versions/f9e369bf00d_added_spin_type_cons.py PRE-CREATION 
>   alembic/versions/1162fb4d4358_added_build_table.py PRE-CREATION
>
> Diff: http://reviewboard-tflink.rhcloud.com/r/46/diff/
> Testing
>
> I've tested on my develop instance.
>
> Thanks,
>
> Ilgiz Islamgulov

[Martin Krizek]

> On Aug. 23, 2013, 12:59 p.m., Martin Krizek wrote:
> > blockerbugs/models/build.py, line 19
> > http://reviewboard-tflink.rhcloud.com/r/46/diff/3/?file=936#file936line19
> > I wonder if these strings should be limited in length.
>
> Ilgiz Islamgulov wrote:
>     you're right

Could you include that in the patch, please?

Otherwise, it looks good to me.

- Martin

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/46/#review77
-----------------------------------------------------------

On Aug. 28, 2013, 10:20 a.m., Ilgiz Islamgulov wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-tflink.rhcloud.com/r/46/
>
> (Updated Aug. 28, 2013, 10:20 a.m.)
>
> Review request for blockerbugs.
>
> Repository: blockerbugs
> Description
>
> Implement new admin interface with flask-admin
> Add build support
> Diffs
>
> testing/testfunc_update_sync.py 70c600515ccc5e97ed17b4cadd40d76277794b67 
>   testing/testfunc_bugsync.py 496f2994dda81bc82f2e270944a3fb2b391d9d91 
>   testing/testfunc_bugmodel.py a50f3458b2154f13736ab1f93cb3d1a86a48fcb1 
>   testing/test_spinmodel.py PRE-CREATION 
>   testing/test_controllers.py 702d2a5390e42910176d327461ef628e6bf8b849 
>   testing/test_api.py e92dda539117f94f3283f6ce262d65295a5e32c1 
>   setup.py 89621b0debb5d368a027a4801de7da62fa961eab 
>   sass/admin_layout.scss PRE-CREATION 
>   requirements.txt 98eab5da9306a101a41dd13708df1900e9fd1018 
>   blockerbugs/util/koji_interface.py PRE-CREATION 
>   blockerbugs/templates/spin_list.html c455ff4edec0991a453a94cd0e38d959e1757672 
>   blockerbugs/templates/admin_layout.html PRE-CREATION 
>   blockerbugs/templates/admin/modify_release.html a3bb0d95c49414ff977e82f828ffdd111e105cc6 
>   blockerbugs/templates/admin/main.html 251b1df1647e307e89bcda365422f1cee59b9a35 
>   blockerbugs/templates/admin/admin_nav.html 34a0c2a966c265ab66166b3170f5f6d507014149 
>   blockerbugs/templates/admin/add_spin.html be44830da436e4e87700fe940a7c5197b32d1e82 
>   blockerbugs/templates/admin/add_release.html 931001b23f52dd1b75fe0feb8d0311b76fcc907e 
>   blockerbugs/static/js/admin.js PRE-CREATION 
>   blockerbugs/models/update.py 9660d038720bcecae8e4f7401e09e26bd6589189 
>   blockerbugs/models/spin.py fa8e0e9a887f269cf31e850baa90678ff7055b78 
>   blockerbugs/models/release.py cca27cff41875528c1ee13d95194de5f237f31d4 
>   blockerbugs/models/milestone.py 31667f6467ed111c3594cdd86d1c933f73b7dfc2 
>   blockerbugs/models/build.py PRE-CREATION 
>   blockerbugs/models/__init__.py 0223fff2996290005bd50412c844979304ce38a2 
>   blockerbugs/controllers/users.py 7b6954adc39b23c997033916e1adc17639451fdd 
>   blockerbugs/controllers/main.py 44924e096803b5c448dbd84dc5fe0405a97ebc50 
>   blockerbugs/controllers/api/utils.py 38144dd48f3190f709a9bafa3a5a425dfdfffbdf 
>   blockerbugs/controllers/api/api.py d6df7d34170da05bd817b12545596f34b43b9da6 
>   blockerbugs/controllers/admin/spin.py PRE-CREATION 
>   blockerbugs/controllers/admin/build.py PRE-CREATION 
>   blockerbugs/controllers/admin/auth.py PRE-CREATION 
>   blockerbugs/controllers/admin/__init__.py PRE-CREATION 
>   blockerbugs/controllers/admin.py 4ce6c9f58b5513c280312c8d1dd92c341d259d0a 
>   blockerbugs/config.py 03e8b2a92aaaf7328b68c3fa4eb585a189f52186 
>   blockerbugs/__init__.py b9d7a40e4e9b47624795958212025428e7788b0f 
>   blockerbugs.spec cda6d4e4c56cce5b3ab37665b4f1988fc62f29ce 
>   alembic/versions/f9e369bf00d_added_spin_type_cons.py PRE-CREATION 
>   alembic/versions/1162fb4d4358_added_build_table.py PRE-CREATION
>
> Diff: http://reviewboard-tflink.rhcloud.com/r/46/diff/
> Testing
>
> I've tested on my develop instance.
>
> Thanks,
>
> Ilgiz Islamgulov

[Martin Krizek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/46/#review81
-----------------------------------------------------------

When trying to create new release I get:

[view.py:757] 2013-08-26 14:34:04 ERROR   Failed to create model
Traceback (most recent call last):
  File "/home/mkrizek/devel/blockerbugs/env_blockerbugs/lib/python2.7/site-packages/flask_admin/contrib/sqlamodel/view.py", line 750, in create_model
    model = self.model()
TypeError: __init__() takes at least 2 arguments (1 given)

- Martin Krizek

On Aug. 22, 2013, 7:01 p.m., Ilgiz Islamgulov wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-tflink.rhcloud.com/r/46/
>
> (Updated Aug. 22, 2013, 7:01 p.m.)
>
> Review request for blockerbugs.
>
> Repository: blockerbugs
> Description
>
> Implement new admin interface with flask-admin
> Add build support
> Diffs
>
> testing/testfunc_update_sync.py 70c600515ccc5e97ed17b4cadd40d76277794b67 
>   testing/testfunc_bugsync.py 496f2994dda81bc82f2e270944a3fb2b391d9d91 
>   testing/testfunc_bugmodel.py a50f3458b2154f13736ab1f93cb3d1a86a48fcb1 
>   testing/test_spinmodel.py PRE-CREATION 
>   testing/test_controllers.py 702d2a5390e42910176d327461ef628e6bf8b849 
>   testing/test_api.py e92dda539117f94f3283f6ce262d65295a5e32c1 
>   setup.py 89621b0debb5d368a027a4801de7da62fa961eab 
>   sass/admin_layout.scss PRE-CREATION 
>   requirements.txt 98eab5da9306a101a41dd13708df1900e9fd1018 
>   blockerbugs/util/koji_interface.py PRE-CREATION 
>   blockerbugs/templates/spin_list.html c455ff4edec0991a453a94cd0e38d959e1757672 
>   blockerbugs/templates/admin_layout.html PRE-CREATION 
>   blockerbugs/templates/admin/modify_release.html a3bb0d95c49414ff977e82f828ffdd111e105cc6 
>   blockerbugs/templates/admin/main.html 251b1df1647e307e89bcda365422f1cee59b9a35 
>   blockerbugs/templates/admin/admin_nav.html 34a0c2a966c265ab66166b3170f5f6d507014149 
>   blockerbugs/templates/admin/add_spin.html be44830da436e4e87700fe940a7c5197b32d1e82 
>   blockerbugs/templates/admin/add_release.html 931001b23f52dd1b75fe0feb8d0311b76fcc907e 
>   blockerbugs/static/js/admin.js PRE-CREATION 
>   blockerbugs/models/update.py 9660d038720bcecae8e4f7401e09e26bd6589189 
>   blockerbugs/models/spin.py fa8e0e9a887f269cf31e850baa90678ff7055b78 
>   blockerbugs/models/release.py cca27cff41875528c1ee13d95194de5f237f31d4 
>   blockerbugs/models/milestone.py 31667f6467ed111c3594cdd86d1c933f73b7dfc2 
>   blockerbugs/models/build.py PRE-CREATION 
>   blockerbugs/models/__init__.py 0223fff2996290005bd50412c844979304ce38a2 
>   blockerbugs/controllers/users.py 7b6954adc39b23c997033916e1adc17639451fdd 
>   blockerbugs/controllers/main.py 44924e096803b5c448dbd84dc5fe0405a97ebc50 
>   blockerbugs/controllers/api/utils.py 38144dd48f3190f709a9bafa3a5a425dfdfffbdf 
>   blockerbugs/controllers/api/api.py d6df7d34170da05bd817b12545596f34b43b9da6 
>   blockerbugs/controllers/admin/spin.py PRE-CREATION 
>   blockerbugs/controllers/admin/build.py PRE-CREATION 
>   blockerbugs/controllers/admin/auth.py PRE-CREATION 
>   blockerbugs/controllers/admin/__init__.py PRE-CREATION 
>   blockerbugs/controllers/admin.py 4ce6c9f58b5513c280312c8d1dd92c341d259d0a 
>   blockerbugs/config.py 03e8b2a92aaaf7328b68c3fa4eb585a189f52186 
>   blockerbugs/__init__.py b9d7a40e4e9b47624795958212025428e7788b0f 
>   blockerbugs.spec cda6d4e4c56cce5b3ab37665b4f1988fc62f29ce 
>   alembic/versions/f9e369bf00d_added_spin_type_cons.py PRE-CREATION 
>   alembic/versions/1162fb4d4358_added_build_table.py PRE-CREATION
>
> Diff: http://reviewboard-tflink.rhcloud.com/r/46/diff/
> Testing
>
> I've tested on my develop instance.
>
> Thanks,
>
> Ilgiz Islamgulov

[Martin Krizek]

> On Aug. 26, 2013, 1:35 p.m., Martin Krizek wrote:
> > When trying to create new release I get:
> >
> > [view.py:757] 2013-08-26 14:34:04 ERROR   Failed to create model
> > Traceback (most recent call last):
> >   File "/home/mkrizek/devel/blockerbugs/env_blockerbugs/lib/python2.7/site-packages/flask_admin/contrib/sqlamodel/view.py", line 750, in create_model
> >     model = self.model()
> > TypeError: __init__() takes at least 2 arguments (1 given)

I'm unable to reproduce this issue locally - I can create a new database without issue. Were you trying to add a release to an existing database? have you tried removing all .pyc and .pyo files? (find . -name '*.pyc' -delete)?

- Tim

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/46/#review81
-----------------------------------------------------------

On Aug. 22, 2013, 7:01 p.m., Ilgiz Islamgulov wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-tflink.rhcloud.com/r/46/
>
> (Updated Aug. 22, 2013, 7:01 p.m.)
>
> Review request for blockerbugs.
>
> Repository: blockerbugs
> Description
>
> Implement new admin interface with flask-admin
> Add build support
> Diffs
>
> testing/testfunc_update_sync.py 70c600515ccc5e97ed17b4cadd40d76277794b67 
>   testing/testfunc_bugsync.py 496f2994dda81bc82f2e270944a3fb2b391d9d91 
>   testing/testfunc_bugmodel.py a50f3458b2154f13736ab1f93cb3d1a86a48fcb1 
>   testing/test_spinmodel.py PRE-CREATION 
>   testing/test_controllers.py 702d2a5390e42910176d327461ef628e6bf8b849 
>   testing/test_api.py e92dda539117f94f3283f6ce262d65295a5e32c1 
>   setup.py 89621b0debb5d368a027a4801de7da62fa961eab 
>   sass/admin_layout.scss PRE-CREATION 
>   requirements.txt 98eab5da9306a101a41dd13708df1900e9fd1018 
>   blockerbugs/util/koji_interface.py PRE-CREATION 
>   blockerbugs/templates/spin_list.html c455ff4edec0991a453a94cd0e38d959e1757672 
>   blockerbugs/templates/admin_layout.html PRE-CREATION 
>   blockerbugs/templates/admin/modify_release.html a3bb0d95c49414ff977e82f828ffdd111e105cc6 
>   blockerbugs/templates/admin/main.html 251b1df1647e307e89bcda365422f1cee59b9a35 
>   blockerbugs/templates/admin/admin_nav.html 34a0c2a966c265ab66166b3170f5f6d507014149 
>   blockerbugs/templates/admin/add_spin.html be44830da436e4e87700fe940a7c5197b32d1e82 
>   blockerbugs/templates/admin/add_release.html 931001b23f52dd1b75fe0feb8d0311b76fcc907e 
>   blockerbugs/static/js/admin.js PRE-CREATION 
>   blockerbugs/models/update.py 9660d038720bcecae8e4f7401e09e26bd6589189 
>   blockerbugs/models/spin.py fa8e0e9a887f269cf31e850baa90678ff7055b78 
>   blockerbugs/models/release.py cca27cff41875528c1ee13d95194de5f237f31d4 
>   blockerbugs/models/milestone.py 31667f6467ed111c3594cdd86d1c933f73b7dfc2 
>   blockerbugs/models/build.py PRE-CREATION 
>   blockerbugs/models/__init__.py 0223fff2996290005bd50412c844979304ce38a2 
>   blockerbugs/controllers/users.py 7b6954adc39b23c997033916e1adc17639451fdd 
>   blockerbugs/controllers/main.py 44924e096803b5c448dbd84dc5fe0405a97ebc50 
>   blockerbugs/controllers/api/utils.py 38144dd48f3190f709a9bafa3a5a425dfdfffbdf 
>   blockerbugs/controllers/api/api.py d6df7d34170da05bd817b12545596f34b43b9da6 
>   blockerbugs/controllers/admin/spin.py PRE-CREATION 
>   blockerbugs/controllers/admin/build.py PRE-CREATION 
>   blockerbugs/controllers/admin/auth.py PRE-CREATION 
>   blockerbugs/controllers/admin/__init__.py PRE-CREATION 
>   blockerbugs/controllers/admin.py 4ce6c9f58b5513c280312c8d1dd92c341d259d0a 
>   blockerbugs/config.py 03e8b2a92aaaf7328b68c3fa4eb585a189f52186 
>   blockerbugs/__init__.py b9d7a40e4e9b47624795958212025428e7788b0f 
>   blockerbugs.spec cda6d4e4c56cce5b3ab37665b4f1988fc62f29ce 
>   alembic/versions/f9e369bf00d_added_spin_type_cons.py PRE-CREATION 
>   alembic/versions/1162fb4d4358_added_build_table.py PRE-CREATION
>
> Diff: http://reviewboard-tflink.rhcloud.com/r/46/diff/
> Testing
>
> I've tested on my develop instance.
>
> Thanks,
>
> Ilgiz Islamgulov

[Martin Krizek]

> On Aug. 26, 2013, 1:35 p.m., Martin Krizek wrote:
> > When trying to create new release I get:
> >
> > [view.py:757] 2013-08-26 14:34:04 ERROR   Failed to create model
> > Traceback (most recent call last):
> >   File "/home/mkrizek/devel/blockerbugs/env_blockerbugs/lib/python2.7/site-packages/flask_admin/contrib/sqlamodel/view.py", line 750, in create_model
> >     model = self.model()
> > TypeError: __init__() takes at least 2 arguments (1 given)
>
> Tim Flink wrote:
>     I'm unable to reproduce this issue locally - I can create a new database without issue. Were you trying to add a release to an existing database? have you tried removing all .pyc and .pyo files? (find . -name '*.pyc' -delete)?

This issue is fixed in latest new_admin branch.

- Ilgiz

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/46/#review81
-----------------------------------------------------------

On Aug. 22, 2013, 7:01 p.m., Ilgiz Islamgulov wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-tflink.rhcloud.com/r/46/
>
> (Updated Aug. 22, 2013, 7:01 p.m.)
>
> Review request for blockerbugs.
>
> Repository: blockerbugs
> Description
>
> Implement new admin interface with flask-admin
> Add build support
> Diffs
>
> testing/testfunc_update_sync.py 70c600515ccc5e97ed17b4cadd40d76277794b67 
>   testing/testfunc_bugsync.py 496f2994dda81bc82f2e270944a3fb2b391d9d91 
>   testing/testfunc_bugmodel.py a50f3458b2154f13736ab1f93cb3d1a86a48fcb1 
>   testing/test_spinmodel.py PRE-CREATION 
>   testing/test_controllers.py 702d2a5390e42910176d327461ef628e6bf8b849 
>   testing/test_api.py e92dda539117f94f3283f6ce262d65295a5e32c1 
>   setup.py 89621b0debb5d368a027a4801de7da62fa961eab 
>   sass/admin_layout.scss PRE-CREATION 
>   requirements.txt 98eab5da9306a101a41dd13708df1900e9fd1018 
>   blockerbugs/util/koji_interface.py PRE-CREATION 
>   blockerbugs/templates/spin_list.html c455ff4edec0991a453a94cd0e38d959e1757672 
>   blockerbugs/templates/admin_layout.html PRE-CREATION 
>   blockerbugs/templates/admin/modify_release.html a3bb0d95c49414ff977e82f828ffdd111e105cc6 
>   blockerbugs/templates/admin/main.html 251b1df1647e307e89bcda365422f1cee59b9a35 
>   blockerbugs/templates/admin/admin_nav.html 34a0c2a966c265ab66166b3170f5f6d507014149 
>   blockerbugs/templates/admin/add_spin.html be44830da436e4e87700fe940a7c5197b32d1e82 
>   blockerbugs/templates/admin/add_release.html 931001b23f52dd1b75fe0feb8d0311b76fcc907e 
>   blockerbugs/static/js/admin.js PRE-CREATION 
>   blockerbugs/models/update.py 9660d038720bcecae8e4f7401e09e26bd6589189 
>   blockerbugs/models/spin.py fa8e0e9a887f269cf31e850baa90678ff7055b78 
>   blockerbugs/models/release.py cca27cff41875528c1ee13d95194de5f237f31d4 
>   blockerbugs/models/milestone.py 31667f6467ed111c3594cdd86d1c933f73b7dfc2 
>   blockerbugs/models/build.py PRE-CREATION 
>   blockerbugs/models/__init__.py 0223fff2996290005bd50412c844979304ce38a2 
>   blockerbugs/controllers/users.py 7b6954adc39b23c997033916e1adc17639451fdd 
>   blockerbugs/controllers/main.py 44924e096803b5c448dbd84dc5fe0405a97ebc50 
>   blockerbugs/controllers/api/utils.py 38144dd48f3190f709a9bafa3a5a425dfdfffbdf 
>   blockerbugs/controllers/api/api.py d6df7d34170da05bd817b12545596f34b43b9da6 
>   blockerbugs/controllers/admin/spin.py PRE-CREATION 
>   blockerbugs/controllers/admin/build.py PRE-CREATION 
>   blockerbugs/controllers/admin/auth.py PRE-CREATION 
>   blockerbugs/controllers/admin/__init__.py PRE-CREATION 
>   blockerbugs/controllers/admin.py 4ce6c9f58b5513c280312c8d1dd92c341d259d0a 
>   blockerbugs/config.py 03e8b2a92aaaf7328b68c3fa4eb585a189f52186 
>   blockerbugs/__init__.py b9d7a40e4e9b47624795958212025428e7788b0f 
>   blockerbugs.spec cda6d4e4c56cce5b3ab37665b4f1988fc62f29ce 
>   alembic/versions/f9e369bf00d_added_spin_type_cons.py PRE-CREATION 
>   alembic/versions/1162fb4d4358_added_build_table.py PRE-CREATION
>
> Diff: http://reviewboard-tflink.rhcloud.com/r/46/diff/
> Testing
>
> I've tested on my develop instance.
>
> Thanks,
>
> Ilgiz Islamgulov

[Martin Krizek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/46/
-----------------------------------------------------------

(Updated Aug. 28, 2013, 10:20 a.m.)

Review request for blockerbugs.

Changes
-------

fix creating Release, Milestone from admin interface
change succeeds in Spin

Repository: blockerbugs

Description
-------

Implement new admin interface with flask-admin
Add build support

Diffs (updated)
-----

testing/testfunc_update_sync.py 70c600515ccc5e97ed17b4cadd40d76277794b67 
  testing/testfunc_bugsync.py 496f2994dda81bc82f2e270944a3fb2b391d9d91 
  testing/testfunc_bugmodel.py a50f3458b2154f13736ab1f93cb3d1a86a48fcb1 
  testing/test_spinmodel.py PRE-CREATION 
  testing/test_controllers.py 702d2a5390e42910176d327461ef628e6bf8b849 
  testing/test_api.py e92dda539117f94f3283f6ce262d65295a5e32c1 
  setup.py 89621b0debb5d368a027a4801de7da62fa961eab 
  sass/admin_layout.scss PRE-CREATION 
  requirements.txt 98eab5da9306a101a41dd13708df1900e9fd1018 
  blockerbugs/util/koji_interface.py PRE-CREATION 
  blockerbugs/templates/spin_list.html c455ff4edec0991a453a94cd0e38d959e1757672 
  blockerbugs/templates/admin_layout.html PRE-CREATION 
  blockerbugs/templates/admin/modify_release.html a3bb0d95c49414ff977e82f828ffdd111e105cc6 
  blockerbugs/templates/admin/main.html 251b1df1647e307e89bcda365422f1cee59b9a35 
  blockerbugs/templates/admin/admin_nav.html 34a0c2a966c265ab66166b3170f5f6d507014149 
  blockerbugs/templates/admin/add_spin.html be44830da436e4e87700fe940a7c5197b32d1e82 
  blockerbugs/templates/admin/add_release.html 931001b23f52dd1b75fe0feb8d0311b76fcc907e 
  blockerbugs/static/js/admin.js PRE-CREATION 
  blockerbugs/models/update.py 9660d038720bcecae8e4f7401e09e26bd6589189 
  blockerbugs/models/spin.py fa8e0e9a887f269cf31e850baa90678ff7055b78 
  blockerbugs/models/release.py cca27cff41875528c1ee13d95194de5f237f31d4 
  blockerbugs/models/milestone.py 31667f6467ed111c3594cdd86d1c933f73b7dfc2 
  blockerbugs/models/build.py PRE-CREATION 
  blockerbugs/models/__init__.py 0223fff2996290005bd50412c844979304ce38a2 
  blockerbugs/controllers/users.py 7b6954adc39b23c997033916e1adc17639451fdd 
  blockerbugs/controllers/main.py 44924e096803b5c448dbd84dc5fe0405a97ebc50 
  blockerbugs/controllers/api/utils.py 38144dd48f3190f709a9bafa3a5a425dfdfffbdf 
  blockerbugs/controllers/api/api.py d6df7d34170da05bd817b12545596f34b43b9da6 
  blockerbugs/controllers/admin/spin.py PRE-CREATION 
  blockerbugs/controllers/admin/build.py PRE-CREATION 
  blockerbugs/controllers/admin/auth.py PRE-CREATION 
  blockerbugs/controllers/admin/__init__.py PRE-CREATION 
  blockerbugs/controllers/admin.py 4ce6c9f58b5513c280312c8d1dd92c341d259d0a 
  blockerbugs/config.py 03e8b2a92aaaf7328b68c3fa4eb585a189f52186 
  blockerbugs/__init__.py b9d7a40e4e9b47624795958212025428e7788b0f 
  blockerbugs.spec cda6d4e4c56cce5b3ab37665b4f1988fc62f29ce 
  alembic/versions/f9e369bf00d_added_spin_type_cons.py PRE-CREATION 
  alembic/versions/1162fb4d4358_added_build_table.py PRE-CREATION

Diff: http://reviewboard-tflink.rhcloud.com/r/46/diff/

Testing
-------

I've tested on my develop instance.

Thanks,

Ilgiz Islamgulov

[Martin Krizek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/46/
-----------------------------------------------------------

(Updated Aug. 29, 2013, 12:31 p.m.)

Review request for blockerbugs.

Changes
-------

Fix Build table fields type

Repository: blockerbugs

Description
-------

Implement new admin interface with flask-admin
Add build support

Diffs (updated)
-----

testing/testfunc_update_sync.py 70c600515ccc5e97ed17b4cadd40d76277794b67 
  testing/testfunc_bugsync.py 496f2994dda81bc82f2e270944a3fb2b391d9d91 
  testing/testfunc_bugmodel.py a50f3458b2154f13736ab1f93cb3d1a86a48fcb1 
  testing/test_spinmodel.py PRE-CREATION 
  testing/test_controllers.py 702d2a5390e42910176d327461ef628e6bf8b849 
  testing/test_api.py e92dda539117f94f3283f6ce262d65295a5e32c1 
  setup.py 89621b0debb5d368a027a4801de7da62fa961eab 
  sass/admin_layout.scss PRE-CREATION 
  requirements.txt 98eab5da9306a101a41dd13708df1900e9fd1018 
  blockerbugs/util/koji_interface.py PRE-CREATION 
  blockerbugs/templates/spin_list.html c455ff4edec0991a453a94cd0e38d959e1757672 
  blockerbugs/templates/admin_layout.html PRE-CREATION 
  blockerbugs/templates/admin/modify_release.html a3bb0d95c49414ff977e82f828ffdd111e105cc6 
  blockerbugs/templates/admin/main.html 251b1df1647e307e89bcda365422f1cee59b9a35 
  blockerbugs/templates/admin/admin_nav.html 34a0c2a966c265ab66166b3170f5f6d507014149 
  blockerbugs/templates/admin/add_spin.html be44830da436e4e87700fe940a7c5197b32d1e82 
  blockerbugs/templates/admin/add_release.html 931001b23f52dd1b75fe0feb8d0311b76fcc907e 
  blockerbugs/static/js/admin.js PRE-CREATION 
  blockerbugs/models/update.py 9660d038720bcecae8e4f7401e09e26bd6589189 
  blockerbugs/models/spin.py fa8e0e9a887f269cf31e850baa90678ff7055b78 
  blockerbugs/models/release.py cca27cff41875528c1ee13d95194de5f237f31d4 
  blockerbugs/models/milestone.py 31667f6467ed111c3594cdd86d1c933f73b7dfc2 
  blockerbugs/models/build.py PRE-CREATION 
  blockerbugs/models/__init__.py 0223fff2996290005bd50412c844979304ce38a2 
  blockerbugs/controllers/users.py 7b6954adc39b23c997033916e1adc17639451fdd 
  blockerbugs/controllers/main.py 44924e096803b5c448dbd84dc5fe0405a97ebc50 
  blockerbugs/controllers/api/utils.py 38144dd48f3190f709a9bafa3a5a425dfdfffbdf 
  blockerbugs/controllers/api/api.py d6df7d34170da05bd817b12545596f34b43b9da6 
  blockerbugs/controllers/admin/spin.py PRE-CREATION 
  blockerbugs/controllers/admin/build.py PRE-CREATION 
  blockerbugs/controllers/admin/auth.py PRE-CREATION 
  blockerbugs/controllers/admin/__init__.py PRE-CREATION 
  blockerbugs/controllers/admin.py 4ce6c9f58b5513c280312c8d1dd92c341d259d0a 
  blockerbugs/config.py 03e8b2a92aaaf7328b68c3fa4eb585a189f52186 
  blockerbugs/__init__.py b9d7a40e4e9b47624795958212025428e7788b0f 
  blockerbugs.spec cda6d4e4c56cce5b3ab37665b4f1988fc62f29ce 
  alembic/versions/f9e369bf00d_added_spin_type_cons.py PRE-CREATION 
  alembic/versions/1162fb4d4358_added_build_table.py PRE-CREATION

Diff: http://reviewboard-tflink.rhcloud.com/r/46/diff/

Testing
-------

I've tested on my develop instance.

Thanks,

Ilgiz Islamgulov

[Martin Krizek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/46/#review89
-----------------------------------------------------------

alembic/versions/1162fb4d4358_added_build_table.py
http://reviewboard-tflink.rhcloud.com/r/46/#comment132

Sorry, I wasn't probably being clear, I meant whether we should change e.g. sa.Column('version', sa.String(), nullable=True), to sa.Column('version', sa.String(50), nullable=True), and so on.

- Martin Krizek

On Aug. 29, 2013, 12:31 p.m., Ilgiz Islamgulov wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-tflink.rhcloud.com/r/46/
>
> (Updated Aug. 29, 2013, 12:31 p.m.)
>
> Review request for blockerbugs.
>
> Repository: blockerbugs
> Description
>
> Implement new admin interface with flask-admin
> Add build support
> Diffs
>
> testing/testfunc_update_sync.py 70c600515ccc5e97ed17b4cadd40d76277794b67 
>   testing/testfunc_bugsync.py 496f2994dda81bc82f2e270944a3fb2b391d9d91 
>   testing/testfunc_bugmodel.py a50f3458b2154f13736ab1f93cb3d1a86a48fcb1 
>   testing/test_spinmodel.py PRE-CREATION 
>   testing/test_controllers.py 702d2a5390e42910176d327461ef628e6bf8b849 
>   testing/test_api.py e92dda539117f94f3283f6ce262d65295a5e32c1 
>   setup.py 89621b0debb5d368a027a4801de7da62fa961eab 
>   sass/admin_layout.scss PRE-CREATION 
>   requirements.txt 98eab5da9306a101a41dd13708df1900e9fd1018 
>   blockerbugs/util/koji_interface.py PRE-CREATION 
>   blockerbugs/templates/spin_list.html c455ff4edec0991a453a94cd0e38d959e1757672 
>   blockerbugs/templates/admin_layout.html PRE-CREATION 
>   blockerbugs/templates/admin/modify_release.html a3bb0d95c49414ff977e82f828ffdd111e105cc6 
>   blockerbugs/templates/admin/main.html 251b1df1647e307e89bcda365422f1cee59b9a35 
>   blockerbugs/templates/admin/admin_nav.html 34a0c2a966c265ab66166b3170f5f6d507014149 
>   blockerbugs/templates/admin/add_spin.html be44830da436e4e87700fe940a7c5197b32d1e82 
>   blockerbugs/templates/admin/add_release.html 931001b23f52dd1b75fe0feb8d0311b76fcc907e 
>   blockerbugs/static/js/admin.js PRE-CREATION 
>   blockerbugs/models/update.py 9660d038720bcecae8e4f7401e09e26bd6589189 
>   blockerbugs/models/spin.py fa8e0e9a887f269cf31e850baa90678ff7055b78 
>   blockerbugs/models/release.py cca27cff41875528c1ee13d95194de5f237f31d4 
>   blockerbugs/models/milestone.py 31667f6467ed111c3594cdd86d1c933f73b7dfc2 
>   blockerbugs/models/build.py PRE-CREATION 
>   blockerbugs/models/__init__.py 0223fff2996290005bd50412c844979304ce38a2 
>   blockerbugs/controllers/users.py 7b6954adc39b23c997033916e1adc17639451fdd 
>   blockerbugs/controllers/main.py 44924e096803b5c448dbd84dc5fe0405a97ebc50 
>   blockerbugs/controllers/api/utils.py 38144dd48f3190f709a9bafa3a5a425dfdfffbdf 
>   blockerbugs/controllers/api/api.py d6df7d34170da05bd817b12545596f34b43b9da6 
>   blockerbugs/controllers/admin/spin.py PRE-CREATION 
>   blockerbugs/controllers/admin/build.py PRE-CREATION 
>   blockerbugs/controllers/admin/auth.py PRE-CREATION 
>   blockerbugs/controllers/admin/__init__.py PRE-CREATION 
>   blockerbugs/controllers/admin.py 4ce6c9f58b5513c280312c8d1dd92c341d259d0a 
>   blockerbugs/config.py 03e8b2a92aaaf7328b68c3fa4eb585a189f52186 
>   blockerbugs/__init__.py b9d7a40e4e9b47624795958212025428e7788b0f 
>   blockerbugs.spec cda6d4e4c56cce5b3ab37665b4f1988fc62f29ce 
>   alembic/versions/f9e369bf00d_added_spin_type_cons.py PRE-CREATION 
>   alembic/versions/1162fb4d4358_added_build_table.py PRE-CREATION
>
> Diff: http://reviewboard-tflink.rhcloud.com/r/46/diff/
> Testing
>
> I've tested on my develop instance.
>
> Thanks,
>
> Ilgiz Islamgulov

[Martin Krizek]

> On Aug. 30, 2013, 8:18 a.m., Martin Krizek wrote:
> > alembic/versions/1162fb4d4358_added_build_table.py, line 21
> > http://reviewboard-tflink.rhcloud.com/r/46/diff/4-5/?file=966#file966line21
> > Sorry, I wasn't probably being clear, I meant whether we should change e.g. sa.Column('version', sa.String(), nullable=True), to sa.Column('version', sa.String(50), nullable=True), and so on.

I found that koji use Text type for this columns. So as for me we should not limit a length.

- Ilgiz

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/46/#review89
-----------------------------------------------------------

On Aug. 29, 2013, 12:31 p.m., Ilgiz Islamgulov wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-tflink.rhcloud.com/r/46/
>
> (Updated Aug. 29, 2013, 12:31 p.m.)
>
> Review request for blockerbugs.
>
> Repository: blockerbugs
> Description
>
> Implement new admin interface with flask-admin
> Add build support
> Diffs
>
> testing/testfunc_update_sync.py 70c600515ccc5e97ed17b4cadd40d76277794b67 
>   testing/testfunc_bugsync.py 496f2994dda81bc82f2e270944a3fb2b391d9d91 
>   testing/testfunc_bugmodel.py a50f3458b2154f13736ab1f93cb3d1a86a48fcb1 
>   testing/test_spinmodel.py PRE-CREATION 
>   testing/test_controllers.py 702d2a5390e42910176d327461ef628e6bf8b849 
>   testing/test_api.py e92dda539117f94f3283f6ce262d65295a5e32c1 
>   setup.py 89621b0debb5d368a027a4801de7da62fa961eab 
>   sass/admin_layout.scss PRE-CREATION 
>   requirements.txt 98eab5da9306a101a41dd13708df1900e9fd1018 
>   blockerbugs/util/koji_interface.py PRE-CREATION 
>   blockerbugs/templates/spin_list.html c455ff4edec0991a453a94cd0e38d959e1757672 
>   blockerbugs/templates/admin_layout.html PRE-CREATION 
>   blockerbugs/templates/admin/modify_release.html a3bb0d95c49414ff977e82f828ffdd111e105cc6 
>   blockerbugs/templates/admin/main.html 251b1df1647e307e89bcda365422f1cee59b9a35 
>   blockerbugs/templates/admin/admin_nav.html 34a0c2a966c265ab66166b3170f5f6d507014149 
>   blockerbugs/templates/admin/add_spin.html be44830da436e4e87700fe940a7c5197b32d1e82 
>   blockerbugs/templates/admin/add_release.html 931001b23f52dd1b75fe0feb8d0311b76fcc907e 
>   blockerbugs/static/js/admin.js PRE-CREATION 
>   blockerbugs/models/update.py 9660d038720bcecae8e4f7401e09e26bd6589189 
>   blockerbugs/models/spin.py fa8e0e9a887f269cf31e850baa90678ff7055b78 
>   blockerbugs/models/release.py cca27cff41875528c1ee13d95194de5f237f31d4 
>   blockerbugs/models/milestone.py 31667f6467ed111c3594cdd86d1c933f73b7dfc2 
>   blockerbugs/models/build.py PRE-CREATION 
>   blockerbugs/models/__init__.py 0223fff2996290005bd50412c844979304ce38a2 
>   blockerbugs/controllers/users.py 7b6954adc39b23c997033916e1adc17639451fdd 
>   blockerbugs/controllers/main.py 44924e096803b5c448dbd84dc5fe0405a97ebc50 
>   blockerbugs/controllers/api/utils.py 38144dd48f3190f709a9bafa3a5a425dfdfffbdf 
>   blockerbugs/controllers/api/api.py d6df7d34170da05bd817b12545596f34b43b9da6 
>   blockerbugs/controllers/admin/spin.py PRE-CREATION 
>   blockerbugs/controllers/admin/build.py PRE-CREATION 
>   blockerbugs/controllers/admin/auth.py PRE-CREATION 
>   blockerbugs/controllers/admin/__init__.py PRE-CREATION 
>   blockerbugs/controllers/admin.py 4ce6c9f58b5513c280312c8d1dd92c341d259d0a 
>   blockerbugs/config.py 03e8b2a92aaaf7328b68c3fa4eb585a189f52186 
>   blockerbugs/__init__.py b9d7a40e4e9b47624795958212025428e7788b0f 
>   blockerbugs.spec cda6d4e4c56cce5b3ab37665b4f1988fc62f29ce 
>   alembic/versions/f9e369bf00d_added_spin_type_cons.py PRE-CREATION 
>   alembic/versions/1162fb4d4358_added_build_table.py PRE-CREATION
>
> Diff: http://reviewboard-tflink.rhcloud.com/r/46/diff/
> Testing
>
> I've tested on my develop instance.
>
> Thanks,
>
> Ilgiz Islamgulov

[Martin Krizek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/46/
-----------------------------------------------------------

(Updated Sept. 2, 2013, 12:56 p.m.)

Review request for blockerbugs.

Changes
-------

Added basic API auth

Repository: blockerbugs

Description
-------

Implement new admin interface with flask-admin
Add build support

Diffs (updated)
-----

testing/testfunc_update_sync.py 70c600515ccc5e97ed17b4cadd40d76277794b67 
  testing/testfunc_bugsync.py 496f2994dda81bc82f2e270944a3fb2b391d9d91 
  testing/testfunc_bugmodel.py a50f3458b2154f13736ab1f93cb3d1a86a48fcb1 
  testing/test_spinmodel.py PRE-CREATION 
  testing/test_controllers.py 702d2a5390e42910176d327461ef628e6bf8b849 
  testing/test_api.py e92dda539117f94f3283f6ce262d65295a5e32c1 
  setup.py 89621b0debb5d368a027a4801de7da62fa961eab 
  sass/admin_layout.scss PRE-CREATION 
  requirements.txt 98eab5da9306a101a41dd13708df1900e9fd1018 
  blockerbugs/util/koji_interface.py PRE-CREATION 
  blockerbugs/templates/spin_list.html c455ff4edec0991a453a94cd0e38d959e1757672 
  blockerbugs/templates/admin_layout.html PRE-CREATION 
  blockerbugs/templates/admin/modify_release.html a3bb0d95c49414ff977e82f828ffdd111e105cc6 
  blockerbugs/templates/admin/main.html 251b1df1647e307e89bcda365422f1cee59b9a35 
  blockerbugs/templates/admin/generate_api_key.html PRE-CREATION 
  blockerbugs/templates/admin/edit_userinfo.html PRE-CREATION 
  blockerbugs/templates/admin/admin_nav.html 34a0c2a966c265ab66166b3170f5f6d507014149 
  blockerbugs/templates/admin/add_spin.html be44830da436e4e87700fe940a7c5197b32d1e82 
  blockerbugs/templates/admin/add_release.html 931001b23f52dd1b75fe0feb8d0311b76fcc907e 
  blockerbugs/static/js/admin.js PRE-CREATION 
  blockerbugs/models/userinfo.py 069ca9406d6d0e301a2a3a8d9703a940301db0bc 
  blockerbugs/models/update.py 9660d038720bcecae8e4f7401e09e26bd6589189 
  blockerbugs/models/spin.py fa8e0e9a887f269cf31e850baa90678ff7055b78 
  blockerbugs/models/release.py cca27cff41875528c1ee13d95194de5f237f31d4 
  blockerbugs/models/milestone.py 31667f6467ed111c3594cdd86d1c933f73b7dfc2 
  blockerbugs/models/build.py PRE-CREATION 
  blockerbugs/models/__init__.py 0223fff2996290005bd50412c844979304ce38a2 
  blockerbugs/controllers/users.py 7b6954adc39b23c997033916e1adc17639451fdd 
  blockerbugs/controllers/main.py 44924e096803b5c448dbd84dc5fe0405a97ebc50 
  blockerbugs/controllers/api/utils.py 38144dd48f3190f709a9bafa3a5a425dfdfffbdf 
  blockerbugs/controllers/api/errors.py aaab9107521873100043e9026d1a4b4ea9705983 
  blockerbugs/controllers/api/api.py d6df7d34170da05bd817b12545596f34b43b9da6 
  blockerbugs/controllers/admin/spin.py PRE-CREATION 
  blockerbugs/controllers/admin/build.py PRE-CREATION 
  blockerbugs/controllers/admin/auth.py PRE-CREATION 
  blockerbugs/controllers/admin/__init__.py PRE-CREATION 
  blockerbugs/controllers/admin.py 4ce6c9f58b5513c280312c8d1dd92c341d259d0a 
  blockerbugs/config.py 03e8b2a92aaaf7328b68c3fa4eb585a189f52186 
  blockerbugs/__init__.py b9d7a40e4e9b47624795958212025428e7788b0f 
  blockerbugs.spec cda6d4e4c56cce5b3ab37665b4f1988fc62f29ce 
  alembic/versions/f9e369bf00d_added_spin_type_cons.py PRE-CREATION 
  alembic/versions/3b0500a49ea7_added_api_key_hash_t.py PRE-CREATION 
  alembic/versions/1162fb4d4358_added_build_table.py PRE-CREATION

Diff: http://reviewboard-tflink.rhcloud.com/r/46/diff/

Testing
-------

I've tested on my develop instance.

Thanks,

Ilgiz Islamgulov

[Martin Krizek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/46/
-----------------------------------------------------------

(Updated Sept. 5, 2013, 10:41 p.m.)

Review request for blockerbugs.

Changes
-------

Merge latest changes from develop
Minor UI fixes

Repository: blockerbugs

Description
-------

Implement new admin interface with flask-admin
Add build support

Diffs (updated)
-----

testing/testfunc_update_sync.py 70c600515ccc5e97ed17b4cadd40d76277794b67 
  testing/testfunc_bugsync.py 496f2994dda81bc82f2e270944a3fb2b391d9d91 
  testing/testfunc_bugmodel.py a50f3458b2154f13736ab1f93cb3d1a86a48fcb1 
  testing/test_spinmodel.py PRE-CREATION 
  testing/test_controllers.py 702d2a5390e42910176d327461ef628e6bf8b849 
  testing/test_api.py e92dda539117f94f3283f6ce262d65295a5e32c1 
  setup.py 89621b0debb5d368a027a4801de7da62fa961eab 
  sass/admin_layout.scss PRE-CREATION 
  requirements.txt 98eab5da9306a101a41dd13708df1900e9fd1018 
  blockerbugs/util/koji_interface.py PRE-CREATION 
  blockerbugs/templates/spin_list.html c455ff4edec0991a453a94cd0e38d959e1757672 
  blockerbugs/templates/admin_layout.html PRE-CREATION 
  blockerbugs/templates/admin/modify_release.html a3bb0d95c49414ff977e82f828ffdd111e105cc6 
  blockerbugs/templates/admin/main.html 251b1df1647e307e89bcda365422f1cee59b9a35 
  blockerbugs/templates/admin/generate_api_key.html PRE-CREATION 
  blockerbugs/templates/admin/edit_userinfo.html PRE-CREATION 
  blockerbugs/templates/admin/admin_nav.html 34a0c2a966c265ab66166b3170f5f6d507014149 
  blockerbugs/templates/admin/add_spin.html be44830da436e4e87700fe940a7c5197b32d1e82 
  blockerbugs/templates/admin/add_release.html 931001b23f52dd1b75fe0feb8d0311b76fcc907e 
  blockerbugs/static/js/admin.js PRE-CREATION 
  blockerbugs/models/userinfo.py 069ca9406d6d0e301a2a3a8d9703a940301db0bc 
  blockerbugs/models/update.py 9660d038720bcecae8e4f7401e09e26bd6589189 
  blockerbugs/models/spin.py fa8e0e9a887f269cf31e850baa90678ff7055b78 
  blockerbugs/models/release.py cca27cff41875528c1ee13d95194de5f237f31d4 
  blockerbugs/models/milestone.py 31667f6467ed111c3594cdd86d1c933f73b7dfc2 
  blockerbugs/models/build.py PRE-CREATION 
  blockerbugs/models/__init__.py 0223fff2996290005bd50412c844979304ce38a2 
  blockerbugs/controllers/users.py f05ea6b7e0af260545ff3cf340b73d15f55138d1 
  blockerbugs/controllers/main.py a41627485a77daecc07c8d33f41dc5a17e2ebb97 
  blockerbugs/controllers/api/utils.py 38144dd48f3190f709a9bafa3a5a425dfdfffbdf 
  blockerbugs/controllers/api/errors.py aaab9107521873100043e9026d1a4b4ea9705983 
  blockerbugs/controllers/api/api.py d6df7d34170da05bd817b12545596f34b43b9da6 
  blockerbugs/controllers/admin/spin.py PRE-CREATION 
  blockerbugs/controllers/admin/build.py PRE-CREATION 
  blockerbugs/controllers/admin/auth.py PRE-CREATION 
  blockerbugs/controllers/admin/__init__.py PRE-CREATION 
  blockerbugs/controllers/admin.py 4ce6c9f58b5513c280312c8d1dd92c341d259d0a 
  blockerbugs/config.py e9b2fbc83c98a66ce963eec596e0cb90b66f87b0 
  blockerbugs/__init__.py bf0daed0c198868e8d56f444bf9a320c85d65362 
  blockerbugs.spec c5c2409e5ad5fe96c145cf3ec65c8c1778681b6c 
  alembic/versions/f9e369bf00d_added_spin_type_cons.py PRE-CREATION 
  alembic/versions/3b0500a49ea7_added_api_key_hash_t.py PRE-CREATION 
  alembic/versions/1162fb4d4358_added_build_table.py PRE-CREATION

Diff: http://reviewboard-tflink.rhcloud.com/r/46/diff/

Testing
-------

I've tested on my develop instance.

Thanks,

Ilgiz Islamgulov

[Martin Krizek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/46/
-----------------------------------------------------------

(Updated Sept. 13, 2013, 11:21 p.m.)

Review request for blockerbugs.

Changes
-------

Fix flask-admin 1.0.5 support
(flask-admin 1.0.5 is used on el6)

Repository: blockerbugs

Description
-------

Implement new admin interface with flask-admin
Add build support

Diffs (updated)
-----

testing/testfunc_update_sync.py 70c600515ccc5e97ed17b4cadd40d76277794b67 
  testing/testfunc_bugsync.py 496f2994dda81bc82f2e270944a3fb2b391d9d91 
  testing/testfunc_bugmodel.py a50f3458b2154f13736ab1f93cb3d1a86a48fcb1 
  testing/test_spinmodel.py PRE-CREATION 
  testing/test_controllers.py 702d2a5390e42910176d327461ef628e6bf8b849 
  testing/test_api.py e92dda539117f94f3283f6ce262d65295a5e32c1 
  setup.py 89621b0debb5d368a027a4801de7da62fa961eab 
  sass/admin_layout.scss PRE-CREATION 
  requirements.txt 98eab5da9306a101a41dd13708df1900e9fd1018 
  blockerbugs/util/koji_interface.py PRE-CREATION 
  blockerbugs/templates/spin_list.html c455ff4edec0991a453a94cd0e38d959e1757672 
  blockerbugs/templates/admin_layout.html PRE-CREATION 
  blockerbugs/templates/admin/modify_release.html a3bb0d95c49414ff977e82f828ffdd111e105cc6 
  blockerbugs/templates/admin/main.html 251b1df1647e307e89bcda365422f1cee59b9a35 
  blockerbugs/templates/admin/generate_api_key.html PRE-CREATION 
  blockerbugs/templates/admin/edit_userinfo.html PRE-CREATION 
  blockerbugs/templates/admin/admin_nav.html 34a0c2a966c265ab66166b3170f5f6d507014149 
  blockerbugs/templates/admin/add_spin.html be44830da436e4e87700fe940a7c5197b32d1e82 
  blockerbugs/templates/admin/add_release.html 931001b23f52dd1b75fe0feb8d0311b76fcc907e 
  blockerbugs/static/js/admin.js PRE-CREATION 
  blockerbugs/models/userinfo.py 069ca9406d6d0e301a2a3a8d9703a940301db0bc 
  blockerbugs/models/update.py 9660d038720bcecae8e4f7401e09e26bd6589189 
  blockerbugs/models/spin.py fa8e0e9a887f269cf31e850baa90678ff7055b78 
  blockerbugs/models/release.py cca27cff41875528c1ee13d95194de5f237f31d4 
  blockerbugs/models/milestone.py 31667f6467ed111c3594cdd86d1c933f73b7dfc2 
  blockerbugs/models/build.py PRE-CREATION 
  blockerbugs/models/__init__.py 0223fff2996290005bd50412c844979304ce38a2 
  blockerbugs/controllers/users.py f05ea6b7e0af260545ff3cf340b73d15f55138d1 
  blockerbugs/controllers/main.py a41627485a77daecc07c8d33f41dc5a17e2ebb97 
  blockerbugs/controllers/api/utils.py 38144dd48f3190f709a9bafa3a5a425dfdfffbdf 
  blockerbugs/controllers/api/errors.py aaab9107521873100043e9026d1a4b4ea9705983 
  blockerbugs/controllers/api/api.py d6df7d34170da05bd817b12545596f34b43b9da6 
  blockerbugs/controllers/admin/spin.py PRE-CREATION 
  blockerbugs/controllers/admin/build.py PRE-CREATION 
  blockerbugs/controllers/admin/auth.py PRE-CREATION 
  blockerbugs/controllers/admin/__init__.py PRE-CREATION 
  blockerbugs/controllers/admin.py 4ce6c9f58b5513c280312c8d1dd92c341d259d0a 
  blockerbugs/config.py e9b2fbc83c98a66ce963eec596e0cb90b66f87b0 
  blockerbugs/__init__.py bf0daed0c198868e8d56f444bf9a320c85d65362 
  blockerbugs.spec c5c2409e5ad5fe96c145cf3ec65c8c1778681b6c 
  alembic/versions/f9e369bf00d_added_spin_type_cons.py PRE-CREATION 
  alembic/versions/3b0500a49ea7_added_api_key_hash_t.py PRE-CREATION 
  alembic/versions/1162fb4d4358_added_build_table.py PRE-CREATION

Diff: http://reviewboard-tflink.rhcloud.com/r/46/diff/

Testing
-------

I've tested on my develop instance.

Thanks,

Ilgiz Islamgulov

[Martin Krizek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/46/
-----------------------------------------------------------

(Updated Sept. 23, 2013, 7:26 p.m.)

Review request for blockerbugs.

Changes
-------

fixes

Repository: blockerbugs

Description
-------

Implement new admin interface with flask-admin
Add build support

Diffs (updated)
-----

testing/testfunc_update_sync.py 70c600515ccc5e97ed17b4cadd40d76277794b67 
  testing/testfunc_bugsync.py 496f2994dda81bc82f2e270944a3fb2b391d9d91 
  testing/testfunc_bugmodel.py a50f3458b2154f13736ab1f93cb3d1a86a48fcb1 
  testing/test_spinmodel.py PRE-CREATION 
  testing/test_controllers.py 702d2a5390e42910176d327461ef628e6bf8b849 
  testing/test_api.py e92dda539117f94f3283f6ce262d65295a5e32c1 
  setup.py 89621b0debb5d368a027a4801de7da62fa961eab 
  sass/admin_layout.scss PRE-CREATION 
  requirements.txt 98eab5da9306a101a41dd13708df1900e9fd1018 
  blockerbugs/util/koji_interface.py PRE-CREATION 
  blockerbugs/templates/spin_list.html c455ff4edec0991a453a94cd0e38d959e1757672 
  blockerbugs/templates/admin_layout.html PRE-CREATION 
  blockerbugs/templates/admin/spin_edit.html PRE-CREATION 
  blockerbugs/templates/admin/spin_create.html PRE-CREATION 
  blockerbugs/templates/admin/modify_release.html a3bb0d95c49414ff977e82f828ffdd111e105cc6 
  blockerbugs/templates/admin/main.html 251b1df1647e307e89bcda365422f1cee59b9a35 
  blockerbugs/templates/admin/generate_api_key.html PRE-CREATION 
  blockerbugs/templates/admin/edit_userinfo.html PRE-CREATION 
  blockerbugs/templates/admin/admin_nav.html 34a0c2a966c265ab66166b3170f5f6d507014149 
  blockerbugs/templates/admin/add_spin.html be44830da436e4e87700fe940a7c5197b32d1e82 
  blockerbugs/templates/admin/add_release.html 931001b23f52dd1b75fe0feb8d0311b76fcc907e 
  blockerbugs/static/js/admin.js PRE-CREATION 
  blockerbugs/models/userinfo.py 069ca9406d6d0e301a2a3a8d9703a940301db0bc 
  blockerbugs/models/update.py 9660d038720bcecae8e4f7401e09e26bd6589189 
  blockerbugs/models/spin.py fa8e0e9a887f269cf31e850baa90678ff7055b78 
  blockerbugs/models/release.py cca27cff41875528c1ee13d95194de5f237f31d4 
  blockerbugs/models/milestone.py 31667f6467ed111c3594cdd86d1c933f73b7dfc2 
  blockerbugs/models/build.py PRE-CREATION 
  blockerbugs/models/__init__.py 0223fff2996290005bd50412c844979304ce38a2 
  blockerbugs/controllers/users.py f05ea6b7e0af260545ff3cf340b73d15f55138d1 
  blockerbugs/controllers/main.py a41627485a77daecc07c8d33f41dc5a17e2ebb97 
  blockerbugs/controllers/api/utils.py 38144dd48f3190f709a9bafa3a5a425dfdfffbdf 
  blockerbugs/controllers/api/errors.py aaab9107521873100043e9026d1a4b4ea9705983 
  blockerbugs/controllers/api/api.py d6df7d34170da05bd817b12545596f34b43b9da6 
  blockerbugs/controllers/admin/spin.py PRE-CREATION 
  blockerbugs/controllers/admin/build.py PRE-CREATION 
  blockerbugs/controllers/admin/auth.py PRE-CREATION 
  blockerbugs/controllers/admin/__init__.py PRE-CREATION 
  blockerbugs/controllers/admin.py 4ce6c9f58b5513c280312c8d1dd92c341d259d0a 
  blockerbugs/config.py e9b2fbc83c98a66ce963eec596e0cb90b66f87b0 
  blockerbugs/cli.py 7151337aa1e16e571d0cf165c87c3c6f50276b90 
  blockerbugs/__init__.py bf0daed0c198868e8d56f444bf9a320c85d65362 
  blockerbugs.spec c5c2409e5ad5fe96c145cf3ec65c8c1778681b6c 
  alembic/versions/f9e369bf00d_added_spin_type_cons.py PRE-CREATION 
  alembic/versions/3b0500a49ea7_added_api_key_hash_t.py PRE-CREATION 
  alembic/versions/1162fb4d4358_added_build_table.py PRE-CREATION

Diff: http://reviewboard-tflink.rhcloud.com/r/46/diff/

Testing
-------

I've tested on my develop instance.

Thanks,

Ilgiz Islamgulov

[Martin Krizek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/46/
-----------------------------------------------------------

(Updated Sept. 23, 2013, 8:02 p.m.)

Review request for blockerbugs.

Changes
-------

add builds information to spin API endpoint

Repository: blockerbugs

Description
-------

Implement new admin interface with flask-admin
Add build support

Diffs (updated)
-----

testing/testfunc_update_sync.py 70c600515ccc5e97ed17b4cadd40d76277794b67 
  testing/testfunc_bugsync.py 496f2994dda81bc82f2e270944a3fb2b391d9d91 
  testing/testfunc_bugmodel.py a50f3458b2154f13736ab1f93cb3d1a86a48fcb1 
  testing/test_spinmodel.py PRE-CREATION 
  testing/test_controllers.py 702d2a5390e42910176d327461ef628e6bf8b849 
  testing/test_api.py e92dda539117f94f3283f6ce262d65295a5e32c1 
  setup.py 89621b0debb5d368a027a4801de7da62fa961eab 
  sass/admin_layout.scss PRE-CREATION 
  requirements.txt 98eab5da9306a101a41dd13708df1900e9fd1018 
  blockerbugs/util/koji_interface.py PRE-CREATION 
  blockerbugs/templates/spin_list.html c455ff4edec0991a453a94cd0e38d959e1757672 
  blockerbugs/templates/admin_layout.html PRE-CREATION 
  blockerbugs/templates/admin/spin_edit.html PRE-CREATION 
  blockerbugs/templates/admin/spin_create.html PRE-CREATION 
  blockerbugs/templates/admin/modify_release.html a3bb0d95c49414ff977e82f828ffdd111e105cc6 
  blockerbugs/templates/admin/main.html 251b1df1647e307e89bcda365422f1cee59b9a35 
  blockerbugs/templates/admin/generate_api_key.html PRE-CREATION 
  blockerbugs/templates/admin/edit_userinfo.html PRE-CREATION 
  blockerbugs/templates/admin/admin_nav.html 34a0c2a966c265ab66166b3170f5f6d507014149 
  blockerbugs/templates/admin/add_spin.html be44830da436e4e87700fe940a7c5197b32d1e82 
  blockerbugs/templates/admin/add_release.html 931001b23f52dd1b75fe0feb8d0311b76fcc907e 
  blockerbugs/static/js/admin.js PRE-CREATION 
  blockerbugs/models/userinfo.py 069ca9406d6d0e301a2a3a8d9703a940301db0bc 
  blockerbugs/models/update.py 9660d038720bcecae8e4f7401e09e26bd6589189 
  blockerbugs/models/spin.py fa8e0e9a887f269cf31e850baa90678ff7055b78 
  blockerbugs/models/release.py cca27cff41875528c1ee13d95194de5f237f31d4 
  blockerbugs/models/milestone.py 31667f6467ed111c3594cdd86d1c933f73b7dfc2 
  blockerbugs/models/build.py PRE-CREATION 
  blockerbugs/models/__init__.py 0223fff2996290005bd50412c844979304ce38a2 
  blockerbugs/controllers/users.py f05ea6b7e0af260545ff3cf340b73d15f55138d1 
  blockerbugs/controllers/main.py a41627485a77daecc07c8d33f41dc5a17e2ebb97 
  blockerbugs/controllers/api/utils.py 38144dd48f3190f709a9bafa3a5a425dfdfffbdf 
  blockerbugs/controllers/api/errors.py aaab9107521873100043e9026d1a4b4ea9705983 
  blockerbugs/controllers/api/api.py d6df7d34170da05bd817b12545596f34b43b9da6 
  blockerbugs/controllers/admin/spin.py PRE-CREATION 
  blockerbugs/controllers/admin/build.py PRE-CREATION 
  blockerbugs/controllers/admin/auth.py PRE-CREATION 
  blockerbugs/controllers/admin/__init__.py PRE-CREATION 
  blockerbugs/controllers/admin.py 4ce6c9f58b5513c280312c8d1dd92c341d259d0a 
  blockerbugs/config.py e9b2fbc83c98a66ce963eec596e0cb90b66f87b0 
  blockerbugs/cli.py 7151337aa1e16e571d0cf165c87c3c6f50276b90 
  blockerbugs/__init__.py bf0daed0c198868e8d56f444bf9a320c85d65362 
  blockerbugs.spec c5c2409e5ad5fe96c145cf3ec65c8c1778681b6c 
  alembic/versions/f9e369bf00d_added_spin_type_cons.py PRE-CREATION 
  alembic/versions/3b0500a49ea7_added_api_key_hash_t.py PRE-CREATION 
  alembic/versions/1162fb4d4358_added_build_table.py PRE-CREATION

Diff: http://reviewboard-tflink.rhcloud.com/r/46/diff/

Testing
-------

I've tested on my develop instance.

Thanks,

Ilgiz Islamgulov

[Martin Krizek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/46/
-----------------------------------------------------------

(Updated Sept. 25, 2013, 8:11 p.m.)

Review request for blockerbugs.

Changes
-------

mostly fixes

Repository: blockerbugs

Description
-------

Implement new admin interface with flask-admin
Add build support

Diffs (updated)
-----

testing/testfunc_update_sync.py 70c600515ccc5e97ed17b4cadd40d76277794b67 
  testing/testfunc_bugsync.py 496f2994dda81bc82f2e270944a3fb2b391d9d91 
  testing/testfunc_bugmodel.py a50f3458b2154f13736ab1f93cb3d1a86a48fcb1 
  testing/test_spinmodel.py PRE-CREATION 
  testing/test_controllers.py 702d2a5390e42910176d327461ef628e6bf8b849 
  testing/test_api.py e92dda539117f94f3283f6ce262d65295a5e32c1 
  setup.py 89621b0debb5d368a027a4801de7da62fa961eab 
  sass/admin_layout.scss PRE-CREATION 
  requirements.txt 98eab5da9306a101a41dd13708df1900e9fd1018 
  blockerbugs/util/koji_interface.py PRE-CREATION 
  blockerbugs/templates/spin_list.html c455ff4edec0991a453a94cd0e38d959e1757672 
  blockerbugs/templates/admin_layout.html PRE-CREATION 
  blockerbugs/templates/admin/spin_edit.html PRE-CREATION 
  blockerbugs/templates/admin/spin_create.html PRE-CREATION 
  blockerbugs/templates/admin/modify_release.html a3bb0d95c49414ff977e82f828ffdd111e105cc6 
  blockerbugs/templates/admin/main.html 251b1df1647e307e89bcda365422f1cee59b9a35 
  blockerbugs/templates/admin/generate_api_key.html PRE-CREATION 
  blockerbugs/templates/admin/edit_userinfo.html PRE-CREATION 
  blockerbugs/templates/admin/admin_nav.html 34a0c2a966c265ab66166b3170f5f6d507014149 
  blockerbugs/templates/admin/add_spin.html be44830da436e4e87700fe940a7c5197b32d1e82 
  blockerbugs/templates/admin/add_release.html 931001b23f52dd1b75fe0feb8d0311b76fcc907e 
  blockerbugs/static/js/admin.js PRE-CREATION 
  blockerbugs/static/css/admin_layout.css PRE-CREATION 
  blockerbugs/models/userinfo.py 069ca9406d6d0e301a2a3a8d9703a940301db0bc 
  blockerbugs/models/update.py 9660d038720bcecae8e4f7401e09e26bd6589189 
  blockerbugs/models/spin.py fa8e0e9a887f269cf31e850baa90678ff7055b78 
  blockerbugs/models/release.py cca27cff41875528c1ee13d95194de5f237f31d4 
  blockerbugs/models/milestone.py 31667f6467ed111c3594cdd86d1c933f73b7dfc2 
  blockerbugs/models/build.py PRE-CREATION 
  blockerbugs/models/__init__.py 0223fff2996290005bd50412c844979304ce38a2 
  blockerbugs/controllers/users.py f05ea6b7e0af260545ff3cf340b73d15f55138d1 
  blockerbugs/controllers/main.py a41627485a77daecc07c8d33f41dc5a17e2ebb97 
  blockerbugs/controllers/api/utils.py 38144dd48f3190f709a9bafa3a5a425dfdfffbdf 
  blockerbugs/controllers/api/errors.py aaab9107521873100043e9026d1a4b4ea9705983 
  blockerbugs/controllers/api/api.py d6df7d34170da05bd817b12545596f34b43b9da6 
  blockerbugs/controllers/admin/spin.py PRE-CREATION 
  blockerbugs/controllers/admin/build.py PRE-CREATION 
  blockerbugs/controllers/admin/auth.py PRE-CREATION 
  blockerbugs/controllers/admin/__init__.py PRE-CREATION 
  blockerbugs/controllers/admin.py 4ce6c9f58b5513c280312c8d1dd92c341d259d0a 
  blockerbugs/config.py e9b2fbc83c98a66ce963eec596e0cb90b66f87b0 
  blockerbugs/cli.py 7151337aa1e16e571d0cf165c87c3c6f50276b90 
  blockerbugs/__init__.py bf0daed0c198868e8d56f444bf9a320c85d65362 
  blockerbugs.spec c5c2409e5ad5fe96c145cf3ec65c8c1778681b6c 
  alembic/versions/f9e369bf00d_added_spin_type_cons.py PRE-CREATION 
  alembic/versions/3b0500a49ea7_added_api_key_hash_t.py PRE-CREATION 
  alembic/versions/1162fb4d4358_added_build_table.py PRE-CREATION

Diff: http://reviewboard-tflink.rhcloud.com/r/46/diff/

Testing
-------

I've tested on my develop instance.

Thanks,

Ilgiz Islamgulov

[Martin Krizek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/46/#review103
-----------------------------------------------------------

Ship it!

blockerbugs.spec
http://reviewboard-tflink.rhcloud.com/r/46/#comment138

make sure this isn't merged back into develop

blockerbugs/controllers/admin/__init__.py
http://reviewboard-tflink.rhcloud.com/r/46/#comment141

this file needs gpl header

blockerbugs/util/koji_interface.py
http://reviewboard-tflink.rhcloud.com/r/46/#comment140

this needs a gpl header

sass/admin_layout.scss
http://reviewboard-tflink.rhcloud.com/r/46/#comment139

this needs to be recompiled before merging into develop

Overall, looks good. Please fix the last minor issues and get this merged into develop

- Tim Flink

On Sept. 25, 2013, 8:11 p.m., Ilgiz Islamgulov wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-tflink.rhcloud.com/r/46/
>
> (Updated Sept. 25, 2013, 8:11 p.m.)
>
> Review request for blockerbugs.
>
> Repository: blockerbugs
> Description
>
> Implement new admin interface with flask-admin
> Add build support
> Diffs
>
> testing/testfunc_update_sync.py 70c600515ccc5e97ed17b4cadd40d76277794b67 
>   testing/testfunc_bugsync.py 496f2994dda81bc82f2e270944a3fb2b391d9d91 
>   testing/testfunc_bugmodel.py a50f3458b2154f13736ab1f93cb3d1a86a48fcb1 
>   testing/test_spinmodel.py PRE-CREATION 
>   testing/test_controllers.py 702d2a5390e42910176d327461ef628e6bf8b849 
>   testing/test_api.py e92dda539117f94f3283f6ce262d65295a5e32c1 
>   setup.py 89621b0debb5d368a027a4801de7da62fa961eab 
>   sass/admin_layout.scss PRE-CREATION 
>   requirements.txt 98eab5da9306a101a41dd13708df1900e9fd1018 
>   blockerbugs/util/koji_interface.py PRE-CREATION 
>   blockerbugs/templates/spin_list.html c455ff4edec0991a453a94cd0e38d959e1757672 
>   blockerbugs/templates/admin_layout.html PRE-CREATION 
>   blockerbugs/templates/admin/spin_edit.html PRE-CREATION 
>   blockerbugs/templates/admin/spin_create.html PRE-CREATION 
>   blockerbugs/templates/admin/modify_release.html a3bb0d95c49414ff977e82f828ffdd111e105cc6 
>   blockerbugs/templates/admin/main.html 251b1df1647e307e89bcda365422f1cee59b9a35 
>   blockerbugs/templates/admin/generate_api_key.html PRE-CREATION 
>   blockerbugs/templates/admin/edit_userinfo.html PRE-CREATION 
>   blockerbugs/templates/admin/admin_nav.html 34a0c2a966c265ab66166b3170f5f6d507014149 
>   blockerbugs/templates/admin/add_spin.html be44830da436e4e87700fe940a7c5197b32d1e82 
>   blockerbugs/templates/admin/add_release.html 931001b23f52dd1b75fe0feb8d0311b76fcc907e 
>   blockerbugs/static/js/admin.js PRE-CREATION 
>   blockerbugs/static/css/admin_layout.css PRE-CREATION 
>   blockerbugs/models/userinfo.py 069ca9406d6d0e301a2a3a8d9703a940301db0bc 
>   blockerbugs/models/update.py 9660d038720bcecae8e4f7401e09e26bd6589189 
>   blockerbugs/models/spin.py fa8e0e9a887f269cf31e850baa90678ff7055b78 
>   blockerbugs/models/release.py cca27cff41875528c1ee13d95194de5f237f31d4 
>   blockerbugs/models/milestone.py 31667f6467ed111c3594cdd86d1c933f73b7dfc2 
>   blockerbugs/models/build.py PRE-CREATION 
>   blockerbugs/models/__init__.py 0223fff2996290005bd50412c844979304ce38a2 
>   blockerbugs/controllers/users.py f05ea6b7e0af260545ff3cf340b73d15f55138d1 
>   blockerbugs/controllers/main.py a41627485a77daecc07c8d33f41dc5a17e2ebb97 
>   blockerbugs/controllers/api/utils.py 38144dd48f3190f709a9bafa3a5a425dfdfffbdf 
>   blockerbugs/controllers/api/errors.py aaab9107521873100043e9026d1a4b4ea9705983 
>   blockerbugs/controllers/api/api.py d6df7d34170da05bd817b12545596f34b43b9da6 
>   blockerbugs/controllers/admin/spin.py PRE-CREATION 
>   blockerbugs/controllers/admin/build.py PRE-CREATION 
>   blockerbugs/controllers/admin/auth.py PRE-CREATION 
>   blockerbugs/controllers/admin/__init__.py PRE-CREATION 
>   blockerbugs/controllers/admin.py 4ce6c9f58b5513c280312c8d1dd92c341d259d0a 
>   blockerbugs/config.py e9b2fbc83c98a66ce963eec596e0cb90b66f87b0 
>   blockerbugs/cli.py 7151337aa1e16e571d0cf165c87c3c6f50276b90 
>   blockerbugs/__init__.py bf0daed0c198868e8d56f444bf9a320c85d65362 
>   blockerbugs.spec c5c2409e5ad5fe96c145cf3ec65c8c1778681b6c 
>   alembic/versions/f9e369bf00d_added_spin_type_cons.py PRE-CREATION 
>   alembic/versions/3b0500a49ea7_added_api_key_hash_t.py PRE-CREATION 
>   alembic/versions/1162fb4d4358_added_build_table.py PRE-CREATION
>
> Diff: http://reviewboard-tflink.rhcloud.com/r/46/diff/
> Testing
>
> I've tested on my develop instance.
>
> Thanks,
>
> Ilgiz Islamgulov

[Martin Krizek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/46/
-----------------------------------------------------------

(Updated Sept. 26, 2013, 6:44 p.m.)

Review request for blockerbugs.

Changes
-------

merge changes from develop branch

Repository: blockerbugs

Description
-------

Implement new admin interface with flask-admin
Add build support

Diffs (updated)
-----

testing/testfunc_update_sync.py 70c600515ccc5e97ed17b4cadd40d76277794b67 
  testing/testfunc_bugsync.py 496f2994dda81bc82f2e270944a3fb2b391d9d91 
  testing/testfunc_bugmodel.py a50f3458b2154f13736ab1f93cb3d1a86a48fcb1 
  testing/test_spinmodel.py PRE-CREATION 
  testing/test_controllers.py 702d2a5390e42910176d327461ef628e6bf8b849 
  testing/test_api.py e92dda539117f94f3283f6ce262d65295a5e32c1 
  setup.py 89621b0debb5d368a027a4801de7da62fa961eab 
  sass/admin_layout.scss PRE-CREATION 
  requirements.txt 98eab5da9306a101a41dd13708df1900e9fd1018 
  blockerbugs/util/koji_interface.py PRE-CREATION 
  blockerbugs/templates/spin_list.html c455ff4edec0991a453a94cd0e38d959e1757672 
  blockerbugs/templates/admin_layout.html PRE-CREATION 
  blockerbugs/templates/admin/spin_edit.html PRE-CREATION 
  blockerbugs/templates/admin/spin_create.html PRE-CREATION 
  blockerbugs/templates/admin/modify_release.html a3bb0d95c49414ff977e82f828ffdd111e105cc6 
  blockerbugs/templates/admin/main.html 251b1df1647e307e89bcda365422f1cee59b9a35 
  blockerbugs/templates/admin/generate_api_key.html PRE-CREATION 
  blockerbugs/templates/admin/edit_userinfo.html PRE-CREATION 
  blockerbugs/templates/admin/admin_nav.html 34a0c2a966c265ab66166b3170f5f6d507014149 
  blockerbugs/templates/admin/add_spin.html be44830da436e4e87700fe940a7c5197b32d1e82 
  blockerbugs/templates/admin/add_release.html 931001b23f52dd1b75fe0feb8d0311b76fcc907e 
  blockerbugs/static/js/admin.js PRE-CREATION 
  blockerbugs/static/css/admin_layout.css PRE-CREATION 
  blockerbugs/models/userinfo.py 069ca9406d6d0e301a2a3a8d9703a940301db0bc 
  blockerbugs/models/update.py 9660d038720bcecae8e4f7401e09e26bd6589189 
  blockerbugs/models/spin.py fa8e0e9a887f269cf31e850baa90678ff7055b78 
  blockerbugs/models/release.py cca27cff41875528c1ee13d95194de5f237f31d4 
  blockerbugs/models/milestone.py 31667f6467ed111c3594cdd86d1c933f73b7dfc2 
  blockerbugs/models/build.py PRE-CREATION 
  blockerbugs/models/__init__.py 0223fff2996290005bd50412c844979304ce38a2 
  blockerbugs/controllers/users.py f05ea6b7e0af260545ff3cf340b73d15f55138d1 
  blockerbugs/controllers/main.py 9484d3d7ec91add579fd34be57ea32659d999fdd 
  blockerbugs/controllers/api/utils.py 38144dd48f3190f709a9bafa3a5a425dfdfffbdf 
  blockerbugs/controllers/api/errors.py aaab9107521873100043e9026d1a4b4ea9705983 
  blockerbugs/controllers/api/api.py d6df7d34170da05bd817b12545596f34b43b9da6 
  blockerbugs/controllers/admin/spin.py PRE-CREATION 
  blockerbugs/controllers/admin/build.py PRE-CREATION 
  blockerbugs/controllers/admin/auth.py PRE-CREATION 
  blockerbugs/controllers/admin/__init__.py PRE-CREATION 
  blockerbugs/controllers/admin.py 4ce6c9f58b5513c280312c8d1dd92c341d259d0a 
  blockerbugs/config.py e9b2fbc83c98a66ce963eec596e0cb90b66f87b0 
  blockerbugs/__init__.py 5216d521a5f3e557ebc2e42362f495e9d84d1dd5 
  blockerbugs.spec 2d4ccebc13cfbcd1fef80ef1bcc72e3d90b2afb4 
  alembic/versions/f9e369bf00d_added_spin_type_cons.py PRE-CREATION 
  alembic/versions/3b0500a49ea7_added_api_key_hash_t.py PRE-CREATION 
  alembic/versions/1162fb4d4358_added_build_table.py PRE-CREATION

Diff: http://reviewboard-tflink.rhcloud.com/r/46/diff/

Testing
-------

I've tested on my develop instance.

Thanks,

Ilgiz Islamgulov

[Martin Krizek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/46/#review104
-----------------------------------------------------------

blockerbugs.spec
http://reviewboard-tflink.rhcloud.com/r/46/#comment142

this shouldn't be added

blockerbugs/cli.py
http://reviewboard-tflink.rhcloud.com/r/46/#comment143

this should be removed

missed some minor issues

- Tim Flink

On Sept. 26, 2013, 6:44 p.m., Ilgiz Islamgulov wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-tflink.rhcloud.com/r/46/
>
> (Updated Sept. 26, 2013, 6:44 p.m.)
>
> Review request for blockerbugs.
>
> Repository: blockerbugs
> Description
>
> Implement new admin interface with flask-admin
> Add build support
> Diffs
>
> testing/testfunc_update_sync.py 70c600515ccc5e97ed17b4cadd40d76277794b67 
>   testing/testfunc_bugsync.py 496f2994dda81bc82f2e270944a3fb2b391d9d91 
>   testing/testfunc_bugmodel.py a50f3458b2154f13736ab1f93cb3d1a86a48fcb1 
>   testing/test_spinmodel.py PRE-CREATION 
>   testing/test_controllers.py 702d2a5390e42910176d327461ef628e6bf8b849 
>   testing/test_api.py e92dda539117f94f3283f6ce262d65295a5e32c1 
>   setup.py 89621b0debb5d368a027a4801de7da62fa961eab 
>   sass/admin_layout.scss PRE-CREATION 
>   requirements.txt 98eab5da9306a101a41dd13708df1900e9fd1018 
>   blockerbugs/util/koji_interface.py PRE-CREATION 
>   blockerbugs/templates/spin_list.html c455ff4edec0991a453a94cd0e38d959e1757672 
>   blockerbugs/templates/admin_layout.html PRE-CREATION 
>   blockerbugs/templates/admin/spin_edit.html PRE-CREATION 
>   blockerbugs/templates/admin/spin_create.html PRE-CREATION 
>   blockerbugs/templates/admin/modify_release.html a3bb0d95c49414ff977e82f828ffdd111e105cc6 
>   blockerbugs/templates/admin/main.html 251b1df1647e307e89bcda365422f1cee59b9a35 
>   blockerbugs/templates/admin/generate_api_key.html PRE-CREATION 
>   blockerbugs/templates/admin/edit_userinfo.html PRE-CREATION 
>   blockerbugs/templates/admin/admin_nav.html 34a0c2a966c265ab66166b3170f5f6d507014149 
>   blockerbugs/templates/admin/add_spin.html be44830da436e4e87700fe940a7c5197b32d1e82 
>   blockerbugs/templates/admin/add_release.html 931001b23f52dd1b75fe0feb8d0311b76fcc907e 
>   blockerbugs/static/js/admin.js PRE-CREATION 
>   blockerbugs/static/css/admin_layout.css PRE-CREATION 
>   blockerbugs/models/userinfo.py 069ca9406d6d0e301a2a3a8d9703a940301db0bc 
>   blockerbugs/models/update.py 9660d038720bcecae8e4f7401e09e26bd6589189 
>   blockerbugs/models/spin.py fa8e0e9a887f269cf31e850baa90678ff7055b78 
>   blockerbugs/models/release.py cca27cff41875528c1ee13d95194de5f237f31d4 
>   blockerbugs/models/milestone.py 31667f6467ed111c3594cdd86d1c933f73b7dfc2 
>   blockerbugs/models/build.py PRE-CREATION 
>   blockerbugs/models/__init__.py 0223fff2996290005bd50412c844979304ce38a2 
>   blockerbugs/controllers/users.py f05ea6b7e0af260545ff3cf340b73d15f55138d1 
>   blockerbugs/controllers/main.py 9484d3d7ec91add579fd34be57ea32659d999fdd 
>   blockerbugs/controllers/api/utils.py 38144dd48f3190f709a9bafa3a5a425dfdfffbdf 
>   blockerbugs/controllers/api/errors.py aaab9107521873100043e9026d1a4b4ea9705983 
>   blockerbugs/controllers/api/api.py d6df7d34170da05bd817b12545596f34b43b9da6 
>   blockerbugs/controllers/admin/spin.py PRE-CREATION 
>   blockerbugs/controllers/admin/build.py PRE-CREATION 
>   blockerbugs/controllers/admin/auth.py PRE-CREATION 
>   blockerbugs/controllers/admin/__init__.py PRE-CREATION 
>   blockerbugs/controllers/admin.py 4ce6c9f58b5513c280312c8d1dd92c341d259d0a 
>   blockerbugs/config.py e9b2fbc83c98a66ce963eec596e0cb90b66f87b0 
>   blockerbugs/__init__.py 5216d521a5f3e557ebc2e42362f495e9d84d1dd5 
>   blockerbugs.spec 2d4ccebc13cfbcd1fef80ef1bcc72e3d90b2afb4 
>   alembic/versions/f9e369bf00d_added_spin_type_cons.py PRE-CREATION 
>   alembic/versions/3b0500a49ea7_added_api_key_hash_t.py PRE-CREATION 
>   alembic/versions/1162fb4d4358_added_build_table.py PRE-CREATION
>
> Diff: http://reviewboard-tflink.rhcloud.com/r/46/diff/
> Testing
>
> I've tested on my develop instance.
>
> Thanks,
>
> Ilgiz Islamgulov

[Martin Krizek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/46/
-----------------------------------------------------------

(Updated Sept. 26, 2013, 9:45 p.m.)

Review request for blockerbugs.

Changes
-------

update spec file

Repository: blockerbugs

Description
-------

Implement new admin interface with flask-admin
Add build support

Diffs (updated)
-----

testing/testfunc_update_sync.py 70c600515ccc5e97ed17b4cadd40d76277794b67 
  testing/testfunc_bugsync.py 496f2994dda81bc82f2e270944a3fb2b391d9d91 
  testing/testfunc_bugmodel.py a50f3458b2154f13736ab1f93cb3d1a86a48fcb1 
  testing/test_spinmodel.py PRE-CREATION 
  testing/test_controllers.py 702d2a5390e42910176d327461ef628e6bf8b849 
  testing/test_api.py e92dda539117f94f3283f6ce262d65295a5e32c1 
  setup.py 89621b0debb5d368a027a4801de7da62fa961eab 
  sass/admin_layout.scss PRE-CREATION 
  requirements.txt 98eab5da9306a101a41dd13708df1900e9fd1018 
  blockerbugs/util/koji_interface.py PRE-CREATION 
  blockerbugs/templates/spin_list.html c455ff4edec0991a453a94cd0e38d959e1757672 
  blockerbugs/templates/admin_layout.html PRE-CREATION 
  blockerbugs/templates/admin/spin_edit.html PRE-CREATION 
  blockerbugs/templates/admin/spin_create.html PRE-CREATION 
  blockerbugs/templates/admin/modify_release.html a3bb0d95c49414ff977e82f828ffdd111e105cc6 
  blockerbugs/templates/admin/main.html 251b1df1647e307e89bcda365422f1cee59b9a35 
  blockerbugs/templates/admin/generate_api_key.html PRE-CREATION 
  blockerbugs/templates/admin/edit_userinfo.html PRE-CREATION 
  blockerbugs/templates/admin/admin_nav.html 34a0c2a966c265ab66166b3170f5f6d507014149 
  blockerbugs/templates/admin/add_spin.html be44830da436e4e87700fe940a7c5197b32d1e82 
  blockerbugs/templates/admin/add_release.html 931001b23f52dd1b75fe0feb8d0311b76fcc907e 
  blockerbugs/static/js/admin.js PRE-CREATION 
  blockerbugs/static/css/general_foundicons.css d46e3b5b5e9452aadedfbb1bc275934a0cea43ec 
  blockerbugs/static/css/app.css 99b6fbc81b231c7f876f1365cfc63f6eade1217e 
  blockerbugs/static/css/app-foundation.css 852272bf1bd1c629b30933b451daceec31812de7 
  blockerbugs/static/css/admin_layout.css PRE-CREATION 
  blockerbugs/models/userinfo.py 069ca9406d6d0e301a2a3a8d9703a940301db0bc 
  blockerbugs/models/update.py 9660d038720bcecae8e4f7401e09e26bd6589189 
  blockerbugs/models/spin.py fa8e0e9a887f269cf31e850baa90678ff7055b78 
  blockerbugs/models/release.py cca27cff41875528c1ee13d95194de5f237f31d4 
  blockerbugs/models/milestone.py 31667f6467ed111c3594cdd86d1c933f73b7dfc2 
  blockerbugs/models/build.py PRE-CREATION 
  blockerbugs/models/__init__.py 0223fff2996290005bd50412c844979304ce38a2 
  blockerbugs/controllers/users.py f05ea6b7e0af260545ff3cf340b73d15f55138d1 
  blockerbugs/controllers/main.py 9484d3d7ec91add579fd34be57ea32659d999fdd 
  blockerbugs/controllers/api/utils.py 38144dd48f3190f709a9bafa3a5a425dfdfffbdf 
  blockerbugs/controllers/api/errors.py aaab9107521873100043e9026d1a4b4ea9705983 
  blockerbugs/controllers/api/api.py d6df7d34170da05bd817b12545596f34b43b9da6 
  blockerbugs/controllers/admin/spin.py PRE-CREATION 
  blockerbugs/controllers/admin/build.py PRE-CREATION 
  blockerbugs/controllers/admin/auth.py PRE-CREATION 
  blockerbugs/controllers/admin/__init__.py PRE-CREATION 
  blockerbugs/controllers/admin.py 4ce6c9f58b5513c280312c8d1dd92c341d259d0a 
  blockerbugs/config.py e9b2fbc83c98a66ce963eec596e0cb90b66f87b0 
  blockerbugs/__init__.py 5216d521a5f3e557ebc2e42362f495e9d84d1dd5 
  blockerbugs.spec 2d4ccebc13cfbcd1fef80ef1bcc72e3d90b2afb4 
  alembic/versions/f9e369bf00d_added_spin_type_cons.py PRE-CREATION 
  alembic/versions/3b0500a49ea7_added_api_key_hash_t.py PRE-CREATION 
  alembic/versions/1162fb4d4358_added_build_table.py PRE-CREATION

Diff: http://reviewboard-tflink.rhcloud.com/r/46/diff/

Testing
-------

I've tested on my develop instance.

Thanks,

Ilgiz Islamgulov

[Martin Krizek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/46/
-----------------------------------------------------------

(Updated Sept. 26, 2013, 9:53 p.m.)

Status
------

This change has been marked as submitted.

Review request for blockerbugs.

Repository: blockerbugs

Description
-------

Implement new admin interface with flask-admin
Add build support

Diffs
-----

testing/testfunc_update_sync.py 70c600515ccc5e97ed17b4cadd40d76277794b67 
  testing/testfunc_bugsync.py 496f2994dda81bc82f2e270944a3fb2b391d9d91 
  testing/testfunc_bugmodel.py a50f3458b2154f13736ab1f93cb3d1a86a48fcb1 
  testing/test_spinmodel.py PRE-CREATION 
  testing/test_controllers.py 702d2a5390e42910176d327461ef628e6bf8b849 
  testing/test_api.py e92dda539117f94f3283f6ce262d65295a5e32c1 
  setup.py 89621b0debb5d368a027a4801de7da62fa961eab 
  sass/admin_layout.scss PRE-CREATION 
  requirements.txt 98eab5da9306a101a41dd13708df1900e9fd1018 
  blockerbugs/util/koji_interface.py PRE-CREATION 
  blockerbugs/templates/spin_list.html c455ff4edec0991a453a94cd0e38d959e1757672 
  blockerbugs/templates/admin_layout.html PRE-CREATION 
  blockerbugs/templates/admin/spin_edit.html PRE-CREATION 
  blockerbugs/templates/admin/spin_create.html PRE-CREATION 
  blockerbugs/templates/admin/modify_release.html a3bb0d95c49414ff977e82f828ffdd111e105cc6 
  blockerbugs/templates/admin/main.html 251b1df1647e307e89bcda365422f1cee59b9a35 
  blockerbugs/templates/admin/generate_api_key.html PRE-CREATION 
  blockerbugs/templates/admin/edit_userinfo.html PRE-CREATION 
  blockerbugs/templates/admin/admin_nav.html 34a0c2a966c265ab66166b3170f5f6d507014149 
  blockerbugs/templates/admin/add_spin.html be44830da436e4e87700fe940a7c5197b32d1e82 
  blockerbugs/templates/admin/add_release.html 931001b23f52dd1b75fe0feb8d0311b76fcc907e 
  blockerbugs/static/js/admin.js PRE-CREATION 
  blockerbugs/static/css/general_foundicons.css d46e3b5b5e9452aadedfbb1bc275934a0cea43ec 
  blockerbugs/static/css/app.css 99b6fbc81b231c7f876f1365cfc63f6eade1217e 
  blockerbugs/static/css/app-foundation.css 852272bf1bd1c629b30933b451daceec31812de7 
  blockerbugs/static/css/admin_layout.css PRE-CREATION 
  blockerbugs/models/userinfo.py 069ca9406d6d0e301a2a3a8d9703a940301db0bc 
  blockerbugs/models/update.py 9660d038720bcecae8e4f7401e09e26bd6589189 
  blockerbugs/models/spin.py fa8e0e9a887f269cf31e850baa90678ff7055b78 
  blockerbugs/models/release.py cca27cff41875528c1ee13d95194de5f237f31d4 
  blockerbugs/models/milestone.py 31667f6467ed111c3594cdd86d1c933f73b7dfc2 
  blockerbugs/models/build.py PRE-CREATION 
  blockerbugs/models/__init__.py 0223fff2996290005bd50412c844979304ce38a2 
  blockerbugs/controllers/users.py f05ea6b7e0af260545ff3cf340b73d15f55138d1 
  blockerbugs/controllers/main.py 9484d3d7ec91add579fd34be57ea32659d999fdd 
  blockerbugs/controllers/api/utils.py 38144dd48f3190f709a9bafa3a5a425dfdfffbdf 
  blockerbugs/controllers/api/errors.py aaab9107521873100043e9026d1a4b4ea9705983 
  blockerbugs/controllers/api/api.py d6df7d34170da05bd817b12545596f34b43b9da6 
  blockerbugs/controllers/admin/spin.py PRE-CREATION 
  blockerbugs/controllers/admin/build.py PRE-CREATION 
  blockerbugs/controllers/admin/auth.py PRE-CREATION 
  blockerbugs/controllers/admin/__init__.py PRE-CREATION 
  blockerbugs/controllers/admin.py 4ce6c9f58b5513c280312c8d1dd92c341d259d0a 
  blockerbugs/config.py e9b2fbc83c98a66ce963eec596e0cb90b66f87b0 
  blockerbugs/__init__.py 5216d521a5f3e557ebc2e42362f495e9d84d1dd5 
  blockerbugs.spec 2d4ccebc13cfbcd1fef80ef1bcc72e3d90b2afb4 
  alembic/versions/f9e369bf00d_added_spin_type_cons.py PRE-CREATION 
  alembic/versions/3b0500a49ea7_added_api_key_hash_t.py PRE-CREATION 
  alembic/versions/1162fb4d4358_added_build_table.py PRE-CREATION

Diff: http://reviewboard-tflink.rhcloud.com/r/46/diff/

Testing
-------

I've tested on my develop instance.

Thanks,

Ilgiz Islamgulov