----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/45/ -----------------------------------------------------------
Review request for blockerbugs.
Bugs: 357 https://fedorahosted.org/fedora-qa/ticket/357
Repository: blockerbugs
Description -------
commit d86f88d7f9da899ffef44ad617a8a831327b7d80 Author: Martin Krizek mkrizek@redhat.com Date: Mon Aug 12 16:40:16 2013 +0200
Improve asset management
Fixes: #357
I have not minified two js files in milestone_stats.html template as I am not sure it's worth it, any objections?
Diffs -----
requirements.txt 09e0318bc189512f5d324bda8879ad74c4763f95 blockerbugs/templates/layout.html 49cdbd70ef8347965dfca93971449688f9cd6cb0 blockerbugs/__init__.py bd9973579e80fc859f3e8d22c35753fbd024c5f0
Diff: http://reviewboard-tflink.rhcloud.com/r/45/diff/
Testing -------
Loaded pages, seems like css and js work as expected after being minified.
Thanks,
Martin Krizek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/45/#review65 -----------------------------------------------------------
The problem here is how to deploy this in production - there is a python-flask-assets package but it is at 0.7 instead of upstream's 0.8 and there does not appear to be an el6 build either way (branch exists but it's empty).
Once the dep is figured out and the spec updated, we can talk about getting this code in but right now it can't be deployed to production
- Tim Flink
On Aug. 12, 2013, 2:46 p.m., Martin Krizek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/45/
(Updated Aug. 12, 2013, 2:46 p.m.)
Review request for blockerbugs.
Bugs: 357 https://fedorahosted.org/fedora-qa/ticket/357
Repository: blockerbugs
Description
commit d86f88d7f9da899ffef44ad617a8a831327b7d80 Author: Martin Krizek mkrizek@redhat.com Date: Mon Aug 12 16:40:16 2013 +0200
Improve asset management Fixes: #357I have not minified two js files in milestone_stats.html template as I am not sure it's worth it, any objections?
Diffs
requirements.txt 09e0318bc189512f5d324bda8879ad74c4763f95 blockerbugs/templates/layout.html 49cdbd70ef8347965dfca93971449688f9cd6cb0 blockerbugs/__init__.py bd9973579e80fc859f3e8d22c35753fbd024c5f0
Diff: http://reviewboard-tflink.rhcloud.com/r/45/diff/
Testing
Loaded pages, seems like css and js work as expected after being minified.
Thanks,
Martin Krizek
On Aug. 15, 2013, 4:06 p.m., Tim Flink wrote:
The problem here is how to deploy this in production - there is a python-flask-assets package but it is at 0.7 instead of upstream's 0.8 and there does not appear to be an el6 build either way (branch exists but it's empty).
Once the dep is figured out and the spec updated, we can talk about getting this code in but right now it can't be deployed to production
I sent an e-mail to the author of the package asking about the state of the package. We'll see...
- Martin
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/45/#review65 -----------------------------------------------------------
On Aug. 12, 2013, 2:46 p.m., Martin Krizek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/45/
(Updated Aug. 12, 2013, 2:46 p.m.)
Review request for blockerbugs.
Bugs: 357 https://fedorahosted.org/fedora-qa/ticket/357
Repository: blockerbugs
Description
commit d86f88d7f9da899ffef44ad617a8a831327b7d80 Author: Martin Krizek mkrizek@redhat.com Date: Mon Aug 12 16:40:16 2013 +0200
Improve asset management Fixes: #357I have not minified two js files in milestone_stats.html template as I am not sure it's worth it, any objections?
Diffs
requirements.txt 09e0318bc189512f5d324bda8879ad74c4763f95 blockerbugs/templates/layout.html 49cdbd70ef8347965dfca93971449688f9cd6cb0 blockerbugs/__init__.py bd9973579e80fc859f3e8d22c35753fbd024c5f0
Diff: http://reviewboard-tflink.rhcloud.com/r/45/diff/
Testing
Loaded pages, seems like css and js work as expected after being minified.
Thanks,
Martin Krizek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/45/ -----------------------------------------------------------
(Updated Aug. 29, 2013, 10:23 a.m.)
Review request for blockerbugs.
Changes -------
Added python-flask-assets as dependency in the spec file.
Also, updates of the new version of python-flask-assets were send to bodhi -- https://admin.fedoraproject.org/updates/python-flask-assets
Bugs: 357 https://fedorahosted.org/fedora-qa/ticket/357
Repository: blockerbugs
Description -------
commit d86f88d7f9da899ffef44ad617a8a831327b7d80 Author: Martin Krizek mkrizek@redhat.com Date: Mon Aug 12 16:40:16 2013 +0200
Improve asset management
Fixes: #357
I have not minified two js files in milestone_stats.html template as I am not sure it's worth it, any objections?
Diffs (updated) -----
requirements.txt 98eab5da9306a101a41dd13708df1900e9fd1018 blockerbugs/templates/layout.html 49cdbd70ef8347965dfca93971449688f9cd6cb0 blockerbugs/__init__.py b9d7a40e4e9b47624795958212025428e7788b0f blockerbugs.spec cda6d4e4c56cce5b3ab37665b4f1988fc62f29ce
Diff: http://reviewboard-tflink.rhcloud.com/r/45/diff/
Testing -------
Loaded pages, seems like css and js work as expected after being minified.
Thanks,
Martin Krizek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/45/#review100 -----------------------------------------------------------
I attempted to test this on an el6 machine, got a traceback when doing sync. tb added to trac ticket
- Tim Flink
On Aug. 29, 2013, 10:23 a.m., Martin Krizek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/45/
(Updated Aug. 29, 2013, 10:23 a.m.)
Review request for blockerbugs.
Bugs: 357 https://fedorahosted.org/fedora-qa/ticket/357
Repository: blockerbugs
Description
commit d86f88d7f9da899ffef44ad617a8a831327b7d80 Author: Martin Krizek mkrizek@redhat.com Date: Mon Aug 12 16:40:16 2013 +0200
Improve asset management Fixes: #357I have not minified two js files in milestone_stats.html template as I am not sure it's worth it, any objections?
Diffs
requirements.txt 98eab5da9306a101a41dd13708df1900e9fd1018 blockerbugs/templates/layout.html 49cdbd70ef8347965dfca93971449688f9cd6cb0 blockerbugs/__init__.py b9d7a40e4e9b47624795958212025428e7788b0f blockerbugs.spec cda6d4e4c56cce5b3ab37665b4f1988fc62f29ce
Diff: http://reviewboard-tflink.rhcloud.com/r/45/diff/
Testing
Loaded pages, seems like css and js work as expected after being minified.
Thanks,
Martin Krizek
On Sept. 24, 2013, 3:44 p.m., Tim Flink wrote:
I attempted to test this on an el6 machine, got a traceback when doing sync. tb added to trac ticket
Yeah, python-webassets needs to be installed, it's missing in Requires (and in epel repo, it's present in Fedora though), I filed a bug -- https://bugzilla.redhat.com/show_bug.cgi?id=1014147. Also I went ahead and created spec files for jsmin and cssmin (http://mkrizek.fedorapeople.org/) as they were easy enough to package.
- Martin
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/45/#review100 -----------------------------------------------------------
On Aug. 29, 2013, 10:23 a.m., Martin Krizek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/45/
(Updated Aug. 29, 2013, 10:23 a.m.)
Review request for blockerbugs.
Bugs: 357 https://fedorahosted.org/fedora-qa/ticket/357
Repository: blockerbugs
Description
commit d86f88d7f9da899ffef44ad617a8a831327b7d80 Author: Martin Krizek mkrizek@redhat.com Date: Mon Aug 12 16:40:16 2013 +0200
Improve asset management Fixes: #357I have not minified two js files in milestone_stats.html template as I am not sure it's worth it, any objections?
Diffs
requirements.txt 98eab5da9306a101a41dd13708df1900e9fd1018 blockerbugs/templates/layout.html 49cdbd70ef8347965dfca93971449688f9cd6cb0 blockerbugs/__init__.py b9d7a40e4e9b47624795958212025428e7788b0f blockerbugs.spec cda6d4e4c56cce5b3ab37665b4f1988fc62f29ce
Diff: http://reviewboard-tflink.rhcloud.com/r/45/diff/
Testing
Loaded pages, seems like css and js work as expected after being minified.
Thanks,
Martin Krizek
On Sept. 24, 2013, 3:44 p.m., Tim Flink wrote:
I attempted to test this on an el6 machine, got a traceback when doing sync. tb added to trac ticket
Martin Krizek wrote: Yeah, python-webassets needs to be installed, it's missing in Requires (and in epel repo, it's present in Fedora though), I filed a bug -- https://bugzilla.redhat.com/show_bug.cgi?id=1014147. Also I went ahead and created spec files for jsmin and cssmin (http://mkrizek.fedorapeople.org/) as they were easy enough to package.
I can probably fix issues in python-flask-assets and python-webassets so we can have this working until it is officially fixed...
- Martin
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/45/#review100 -----------------------------------------------------------
On Aug. 29, 2013, 10:23 a.m., Martin Krizek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/45/
(Updated Aug. 29, 2013, 10:23 a.m.)
Review request for blockerbugs.
Bugs: 357 https://fedorahosted.org/fedora-qa/ticket/357
Repository: blockerbugs
Description
commit d86f88d7f9da899ffef44ad617a8a831327b7d80 Author: Martin Krizek mkrizek@redhat.com Date: Mon Aug 12 16:40:16 2013 +0200
Improve asset management Fixes: #357I have not minified two js files in milestone_stats.html template as I am not sure it's worth it, any objections?
Diffs
requirements.txt 98eab5da9306a101a41dd13708df1900e9fd1018 blockerbugs/templates/layout.html 49cdbd70ef8347965dfca93971449688f9cd6cb0 blockerbugs/__init__.py b9d7a40e4e9b47624795958212025428e7788b0f blockerbugs.spec cda6d4e4c56cce5b3ab37665b4f1988fc62f29ce
Diff: http://reviewboard-tflink.rhcloud.com/r/45/diff/
Testing
Loaded pages, seems like css and js work as expected after being minified.
Thanks,
Martin Krizek
On Sept. 24, 2013, 3:44 p.m., Tim Flink wrote:
I attempted to test this on an el6 machine, got a traceback when doing sync. tb added to trac ticket
Martin Krizek wrote: Yeah, python-webassets needs to be installed, it's missing in Requires (and in epel repo, it's present in Fedora though), I filed a bug -- https://bugzilla.redhat.com/show_bug.cgi?id=1014147. Also I went ahead and created spec files for jsmin and cssmin (http://mkrizek.fedorapeople.org/) as they were easy enough to package.
Martin Krizek wrote: I can probably fix issues in python-flask-assets and python-webassets so we can have this working until it is officially fixed...
Not sure I understand what's required with python-webassets, that bzid shows up as invalid and I can't find anything filed against python-webassets that talks about epel. Any of the required packages would need to be in epel or at least epel-testing before we deploy to production, though. That's why builds for develop have been slow - I keep hoping that the last build will get done.
- Tim
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/45/#review100 -----------------------------------------------------------
On Aug. 29, 2013, 10:23 a.m., Martin Krizek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/45/
(Updated Aug. 29, 2013, 10:23 a.m.)
Review request for blockerbugs.
Bugs: 357 https://fedorahosted.org/fedora-qa/ticket/357
Repository: blockerbugs
Description
commit d86f88d7f9da899ffef44ad617a8a831327b7d80 Author: Martin Krizek mkrizek@redhat.com Date: Mon Aug 12 16:40:16 2013 +0200
Improve asset management Fixes: #357I have not minified two js files in milestone_stats.html template as I am not sure it's worth it, any objections?
Diffs
requirements.txt 98eab5da9306a101a41dd13708df1900e9fd1018 blockerbugs/templates/layout.html 49cdbd70ef8347965dfca93971449688f9cd6cb0 blockerbugs/__init__.py b9d7a40e4e9b47624795958212025428e7788b0f blockerbugs.spec cda6d4e4c56cce5b3ab37665b4f1988fc62f29ce
Diff: http://reviewboard-tflink.rhcloud.com/r/45/diff/
Testing
Loaded pages, seems like css and js work as expected after being minified.
Thanks,
Martin Krizek
On Sept. 24, 2013, 3:44 p.m., Tim Flink wrote:
I attempted to test this on an el6 machine, got a traceback when doing sync. tb added to trac ticket
Martin Krizek wrote: Yeah, python-webassets needs to be installed, it's missing in Requires (and in epel repo, it's present in Fedora though), I filed a bug -- https://bugzilla.redhat.com/show_bug.cgi?id=1014147. Also I went ahead and created spec files for jsmin and cssmin (http://mkrizek.fedorapeople.org/) as they were easy enough to package.
Martin Krizek wrote: I can probably fix issues in python-flask-assets and python-webassets so we can have this working until it is officially fixed...
Tim Flink wrote: Not sure I understand what's required with python-webassets, that bzid shows up as invalid and I can't find anything filed against python-webassets that talks about epel. Any of the required packages would need to be in epel or at least epel-testing before we deploy to production, though. That's why builds for develop have been slow - I keep hoping that the last build will get done.
https://bugzilla.redhat.com/show_bug.cgi?id=1014147 -- there was a dot in the link above.
It's reported against python-flask-assets. So what needs to be done is to push python-webassets to epel and put it as Requires in the python-flask-assets spec file. Another thing is to send python-jsmin and python-cssmin for a package review.
- Martin
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/45/#review100 -----------------------------------------------------------
On Aug. 29, 2013, 10:23 a.m., Martin Krizek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/45/
(Updated Aug. 29, 2013, 10:23 a.m.)
Review request for blockerbugs.
Bugs: 357 https://fedorahosted.org/fedora-qa/ticket/357
Repository: blockerbugs
Description
commit d86f88d7f9da899ffef44ad617a8a831327b7d80 Author: Martin Krizek mkrizek@redhat.com Date: Mon Aug 12 16:40:16 2013 +0200
Improve asset management Fixes: #357I have not minified two js files in milestone_stats.html template as I am not sure it's worth it, any objections?
Diffs
requirements.txt 98eab5da9306a101a41dd13708df1900e9fd1018 blockerbugs/templates/layout.html 49cdbd70ef8347965dfca93971449688f9cd6cb0 blockerbugs/__init__.py b9d7a40e4e9b47624795958212025428e7788b0f blockerbugs.spec cda6d4e4c56cce5b3ab37665b4f1988fc62f29ce
Diff: http://reviewboard-tflink.rhcloud.com/r/45/diff/
Testing
Loaded pages, seems like css and js work as expected after being minified.
Thanks,
Martin Krizek
On Sept. 24, 2013, 3:44 p.m., Tim Flink wrote:
I attempted to test this on an el6 machine, got a traceback when doing sync. tb added to trac ticket
Martin Krizek wrote: Yeah, python-webassets needs to be installed, it's missing in Requires (and in epel repo, it's present in Fedora though), I filed a bug -- https://bugzilla.redhat.com/show_bug.cgi?id=1014147. Also I went ahead and created spec files for jsmin and cssmin (http://mkrizek.fedorapeople.org/) as they were easy enough to package.
Martin Krizek wrote: I can probably fix issues in python-flask-assets and python-webassets so we can have this working until it is officially fixed...
Tim Flink wrote: Not sure I understand what's required with python-webassets, that bzid shows up as invalid and I can't find anything filed against python-webassets that talks about epel. Any of the required packages would need to be in epel or at least epel-testing before we deploy to production, though. That's why builds for develop have been slow - I keep hoping that the last build will get done.
Martin Krizek wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1014147 -- there was a dot in the link above.
It's reported against python-flask-assets. So what needs to be done is to push python-webassets to epel and put it as Requires in the python-flask-assets spec file. Another thing is to send python-jsmin and python-cssmin for a package review.
I sent python-cssmin and python-jsmin for package review: https://bugzilla.redhat.com/show_bug.cgi?id=1014601 https://bugzilla.redhat.com/show_bug.cgi?id=1014607
- Martin
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/45/#review100 -----------------------------------------------------------
On Aug. 29, 2013, 10:23 a.m., Martin Krizek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/45/
(Updated Aug. 29, 2013, 10:23 a.m.)
Review request for blockerbugs.
Bugs: 357 https://fedorahosted.org/fedora-qa/ticket/357
Repository: blockerbugs
Description
commit d86f88d7f9da899ffef44ad617a8a831327b7d80 Author: Martin Krizek mkrizek@redhat.com Date: Mon Aug 12 16:40:16 2013 +0200
Improve asset management Fixes: #357I have not minified two js files in milestone_stats.html template as I am not sure it's worth it, any objections?
Diffs
requirements.txt 98eab5da9306a101a41dd13708df1900e9fd1018 blockerbugs/templates/layout.html 49cdbd70ef8347965dfca93971449688f9cd6cb0 blockerbugs/__init__.py b9d7a40e4e9b47624795958212025428e7788b0f blockerbugs.spec cda6d4e4c56cce5b3ab37665b4f1988fc62f29ce
Diff: http://reviewboard-tflink.rhcloud.com/r/45/diff/
Testing
Loaded pages, seems like css and js work as expected after being minified.
Thanks,
Martin Krizek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/45/ -----------------------------------------------------------
(Updated Nov. 14, 2013, 3:20 p.m.)
Status ------
This change has been marked as submitted.
Review request for blockerbugs.
Bugs: 357 https://fedorahosted.org/fedora-qa/ticket/357
Repository: blockerbugs
Description -------
commit d86f88d7f9da899ffef44ad617a8a831327b7d80 Author: Martin Krizek mkrizek@redhat.com Date: Mon Aug 12 16:40:16 2013 +0200
Improve asset management
Fixes: #357
I have not minified two js files in milestone_stats.html template as I am not sure it's worth it, any objections?
Diffs -----
requirements.txt 98eab5da9306a101a41dd13708df1900e9fd1018 blockerbugs/templates/layout.html 49cdbd70ef8347965dfca93971449688f9cd6cb0 blockerbugs/__init__.py b9d7a40e4e9b47624795958212025428e7788b0f blockerbugs.spec cda6d4e4c56cce5b3ab37665b4f1988fc62f29ce
Diff: http://reviewboard-tflink.rhcloud.com/r/45/diff/
Testing -------
Loaded pages, seems like css and js work as expected after being minified.
Thanks,
Martin Krizek
qa-devel@lists.fedoraproject.org
-
Martin Krizek