Review Request 38: Add developer login

[Martin Krizek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/38/
-----------------------------------------------------------

Review request for blockerbugs.

Repository: blockerbugs

Description
-------

commit e08c8ee1085bb0beb71b4a5c98c9d2e2497773cb
Author: Martin Krizek 
Date:   Mon Jul 15 11:28:09 2013 +0200

Use fake login only in DEV environment

commit 8f175a28ae43b764e52435d174d73e2dc384bd6b
Author: Martin Krizek 
Date:   Thu Jul 4 11:14:40 2013 +0200

Add developer login

This patch allows a fake login when DEV or TEST is set so we don't
    access FAS server each time we log in.

TODO this will be merged with changes made in other review request dealing with fas-openid migrations.

Diffs
-----

blockerbugs/util/login.py PRE-CREATION 
  blockerbugs/templates/layout.html 8dc6deacd5e7a71757ed2564fb224b3cd92bfad5 
  blockerbugs/controllers/users.py 6f89a0b29143a9c09fcf25d97d875a01b9955fa4 
  blockerbugs/controllers/main.py a8082121576015a86c31bc76ebc17e982062a08b 
  blockerbugs/__init__.py 798fc6ecd562d1e13fbba26f804f74e6da670120

Diff: http://reviewboard-tflink.rhcloud.com/r/38/diff/

Testing
-------

Thanks,

Martin Krizek

[Martin Krizek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/38/#review46
-----------------------------------------------------------

blockerbugs/__init__.py
http://reviewboard-tflink.rhcloud.com/r/38/#comment67

wouldn't it make more sense to have DevLogin here since TEST is used mostly for local integration tests?

blockerbugs/util/login.py
http://reviewboard-tflink.rhcloud.com/r/38/#comment68

I think it would be better to have the dev user have admin privileges instead of no groups

Have you done much testing with FAS when this is enabled? I got a tb on logout when I was poking at actual login (using stg fas). If this code needs fas-openid to work, then maybe we should hold off on merging it to develop until fas-openid is working

- Tim Flink

On July 16, 2013, 12:43 p.m., Martin Krizek wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-tflink.rhcloud.com/r/38/
>
> (Updated July 16, 2013, 12:43 p.m.)
>
> Review request for blockerbugs.
>
> Repository: blockerbugs
> Description
>
> commit e08c8ee1085bb0beb71b4a5c98c9d2e2497773cb
> Author: Martin Krizek 
> Date:   Mon Jul 15 11:28:09 2013 +0200
> Use fake login only in DEV environment
>
> commit 8f175a28ae43b764e52435d174d73e2dc384bd6b
> Author: Martin Krizek 
> Date:   Thu Jul 4 11:14:40 2013 +0200
> Add developer login
>
> This patch allows a fake login when DEV or TEST is set so we don't
> access FAS server each time we log in.
>
> TODO this will be merged with changes made in other review request dealing with fas-openid migrations.
> Diffs
>
> blockerbugs/util/login.py PRE-CREATION 
>   blockerbugs/templates/layout.html 8dc6deacd5e7a71757ed2564fb224b3cd92bfad5 
>   blockerbugs/controllers/users.py 6f89a0b29143a9c09fcf25d97d875a01b9955fa4 
>   blockerbugs/controllers/main.py a8082121576015a86c31bc76ebc17e982062a08b 
>   blockerbugs/__init__.py 798fc6ecd562d1e13fbba26f804f74e6da670120
>
> Diff: http://reviewboard-tflink.rhcloud.com/r/38/diff/
> Testing
>
> Thanks,
>
> Martin Krizek

[Martin Krizek]

> On July 17, 2013, 4:22 p.m., Tim Flink wrote:
> > blockerbugs/util/login.py, line 58
> > http://reviewboard-tflink.rhcloud.com/r/38/diff/1/?file=510#file510line58
> > I think it would be better to have the dev user have admin privileges instead of no groups

Good point. Fixed.
> On July 17, 2013, 4:22 p.m., Tim Flink wrote:
> > blockerbugs/__init__.py, line 25
> > http://reviewboard-tflink.rhcloud.com/r/38/diff/1/?file=506#file506line25
> > wouldn't it make more sense to have DevLogin here since TEST is used mostly for local integration tests?

Instead of DEV or both, DEV and TEST would have DevLogin? In addition to this, though, we need an environment to test fas-bugzilla account association (we can swith to PROD to test when needed that probably).

On July 17, 2013, 4:22 p.m., Martin Krizek wrote:
> > Have you done much testing with FAS when this is enabled? I got a tb on logout when I was poking at actual login (using stg fas). If this code needs fas-openid to work, then maybe we should hold off on merging it to develop until fas-openid is working

Could you point me to the tb? I couldn't reproduce it.

- Martin

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/38/#review46
-----------------------------------------------------------

On July 18, 2013, 9:35 a.m., Martin Krizek wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-tflink.rhcloud.com/r/38/
>
> (Updated July 18, 2013, 9:35 a.m.)
>
> Review request for blockerbugs.
>
> Repository: blockerbugs
> Description
>
> commit e08c8ee1085bb0beb71b4a5c98c9d2e2497773cb
> Author: Martin Krizek 
> Date:   Mon Jul 15 11:28:09 2013 +0200
> Use fake login only in DEV environment
>
> commit 8f175a28ae43b764e52435d174d73e2dc384bd6b
> Author: Martin Krizek 
> Date:   Thu Jul 4 11:14:40 2013 +0200
> Add developer login
>
> This patch allows a fake login when DEV or TEST is set so we don't
> access FAS server each time we log in.
>
> TODO this will be merged with changes made in other review request dealing with fas-openid migrations.
> Diffs
>
> blockerbugs/util/login.py PRE-CREATION 
>   blockerbugs/templates/layout.html 8dc6deacd5e7a71757ed2564fb224b3cd92bfad5 
>   blockerbugs/controllers/users.py 6f89a0b29143a9c09fcf25d97d875a01b9955fa4 
>   blockerbugs/controllers/main.py a8082121576015a86c31bc76ebc17e982062a08b 
>   blockerbugs/__init__.py 798fc6ecd562d1e13fbba26f804f74e6da670120
>
> Diff: http://reviewboard-tflink.rhcloud.com/r/38/diff/
> Testing
>
> Thanks,
>
> Martin Krizek

[Martin Krizek]

On July 17, 2013, 4:22 p.m., Martin Krizek wrote:
> > Have you done much testing with FAS when this is enabled? I got a tb on logout when I was poking at actual login (using stg fas). If this code needs fas-openid to work, then maybe we should hold off on merging it to develop until fas-openid is working
>
> Martin Krizek wrote:
>     Could you point me to the tb? I couldn't reproduce it.

Yes, I'd hold off on merging this until fas-openid is working.

- Martin

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/38/#review46
-----------------------------------------------------------

On July 18, 2013, 9:35 a.m., Martin Krizek wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-tflink.rhcloud.com/r/38/
>
> (Updated July 18, 2013, 9:35 a.m.)
>
> Review request for blockerbugs.
>
> Repository: blockerbugs
> Description
>
> commit e08c8ee1085bb0beb71b4a5c98c9d2e2497773cb
> Author: Martin Krizek 
> Date:   Mon Jul 15 11:28:09 2013 +0200
> Use fake login only in DEV environment
>
> commit 8f175a28ae43b764e52435d174d73e2dc384bd6b
> Author: Martin Krizek 
> Date:   Thu Jul 4 11:14:40 2013 +0200
> Add developer login
>
> This patch allows a fake login when DEV or TEST is set so we don't
> access FAS server each time we log in.
>
> TODO this will be merged with changes made in other review request dealing with fas-openid migrations.
> Diffs
>
> blockerbugs/util/login.py PRE-CREATION 
>   blockerbugs/templates/layout.html 8dc6deacd5e7a71757ed2564fb224b3cd92bfad5 
>   blockerbugs/controllers/users.py 6f89a0b29143a9c09fcf25d97d875a01b9955fa4 
>   blockerbugs/controllers/main.py a8082121576015a86c31bc76ebc17e982062a08b 
>   blockerbugs/__init__.py 798fc6ecd562d1e13fbba26f804f74e6da670120
>
> Diff: http://reviewboard-tflink.rhcloud.com/r/38/diff/
> Testing
>
> Thanks,
>
> Martin Krizek

[Martin Krizek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/38/
-----------------------------------------------------------

(Updated July 18, 2013, 9:35 a.m.)

Review request for blockerbugs.

Repository: blockerbugs

Description
-------

commit e08c8ee1085bb0beb71b4a5c98c9d2e2497773cb
Author: Martin Krizek 
Date:   Mon Jul 15 11:28:09 2013 +0200

Use fake login only in DEV environment

commit 8f175a28ae43b764e52435d174d73e2dc384bd6b
Author: Martin Krizek 
Date:   Thu Jul 4 11:14:40 2013 +0200

Add developer login

This patch allows a fake login when DEV or TEST is set so we don't
    access FAS server each time we log in.

TODO this will be merged with changes made in other review request dealing with fas-openid migrations.

Diffs (updated)
-----

blockerbugs/util/login.py PRE-CREATION 
  blockerbugs/templates/layout.html 8dc6deacd5e7a71757ed2564fb224b3cd92bfad5 
  blockerbugs/controllers/users.py 6f89a0b29143a9c09fcf25d97d875a01b9955fa4 
  blockerbugs/controllers/main.py a8082121576015a86c31bc76ebc17e982062a08b 
  blockerbugs/__init__.py 798fc6ecd562d1e13fbba26f804f74e6da670120

Diff: http://reviewboard-tflink.rhcloud.com/r/38/diff/

Testing
-------

Thanks,

Martin Krizek

[Martin Krizek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/38/#review52
-----------------------------------------------------------

Overall looks pretty good. if we can get the traceback figured out (either fix it or determine that there's something off in my dev env) let's get it merged into develop. We don't have a lot of time before F20 branches, and we did commit to moving over to fas-openid.

It might be a while before a new python-fedora release is made, but the fas-openid code is already hotfixed into infra hosts and I'm planning to do the same to our dev host

- Tim Flink

On July 18, 2013, 9:35 a.m., Martin Krizek wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-tflink.rhcloud.com/r/38/
>
> (Updated July 18, 2013, 9:35 a.m.)
>
> Review request for blockerbugs.
>
> Repository: blockerbugs
> Description
>
> commit e08c8ee1085bb0beb71b4a5c98c9d2e2497773cb
> Author: Martin Krizek 
> Date:   Mon Jul 15 11:28:09 2013 +0200
> Use fake login only in DEV environment
>
> commit 8f175a28ae43b764e52435d174d73e2dc384bd6b
> Author: Martin Krizek 
> Date:   Thu Jul 4 11:14:40 2013 +0200
> Add developer login
>
> This patch allows a fake login when DEV or TEST is set so we don't
> access FAS server each time we log in.
>
> TODO this will be merged with changes made in other review request dealing with fas-openid migrations.
> Diffs
>
> blockerbugs/util/login.py PRE-CREATION 
>   blockerbugs/templates/layout.html 8dc6deacd5e7a71757ed2564fb224b3cd92bfad5 
>   blockerbugs/controllers/users.py 6f89a0b29143a9c09fcf25d97d875a01b9955fa4 
>   blockerbugs/controllers/main.py a8082121576015a86c31bc76ebc17e982062a08b 
>   blockerbugs/__init__.py 798fc6ecd562d1e13fbba26f804f74e6da670120
>
> Diff: http://reviewboard-tflink.rhcloud.com/r/38/diff/
> Testing
>
> Thanks,
>
> Martin Krizek

[Martin Krizek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/38/
-----------------------------------------------------------

(Updated July 30, 2013, 2:04 p.m.)

Review request for blockerbugs.

Changes
-------

Patch updated for openid migration.

Repository: blockerbugs

Description
-------

commit e08c8ee1085bb0beb71b4a5c98c9d2e2497773cb
Author: Martin Krizek 
Date:   Mon Jul 15 11:28:09 2013 +0200

Use fake login only in DEV environment

commit 8f175a28ae43b764e52435d174d73e2dc384bd6b
Author: Martin Krizek 
Date:   Thu Jul 4 11:14:40 2013 +0200

Add developer login

This patch allows a fake login when DEV or TEST is set so we don't
    access FAS server each time we log in.

TODO this will be merged with changes made in other review request dealing with fas-openid migrations.

Diffs (updated)
-----

blockerbugs/util/login.py PRE-CREATION 
  blockerbugs/templates/layout.html 8dc6deacd5e7a71757ed2564fb224b3cd92bfad5 
  blockerbugs/controllers/users.py e14c6c5f0f73404a3a61949c554815f89c2e028d 
  blockerbugs/controllers/main.py 4f23e35558ac3f8ed2ccc5d897b2219e449e7277 
  blockerbugs/__init__.py c4f2c34f5eac713253336d026aa9485259096cb0

Diff: http://reviewboard-tflink.rhcloud.com/r/38/diff/

Testing
-------

Thanks,

Martin Krizek

[Martin Krizek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/38/
-----------------------------------------------------------

(Updated Aug. 5, 2013, 1:48 p.m.)

Review request for blockerbugs.

Changes
-------

Rebased to develop.

Repository: blockerbugs

Description (updated)
-------

commit 4f9c14cc32fe11c008e7901a2310a5e34381301d
Author: Martin Krizek 
Date:   Tue Jul 30 15:47:25 2013 +0200

Migrate dev login to openid

commit 1c145319fb1e4ffe9bb2d5a9b3d3140fbab6606e
Author: Martin Krizek 
Date:   Thu Jul 18 11:32:59 2013 +0200

Add admin privileges to the dev user

commit 815c14ce31d05690f80391063be076f4cfd46286
Author: Martin Krizek 
Date:   Mon Jul 15 11:28:09 2013 +0200

Use fake login only in DEV environment

commit eb518b8f33fe84af9d321caa1c37b431ce809b06
Author: Martin Krizek 
Date:   Thu Jul 4 11:14:40 2013 +0200

Add developer login

This patch allows a fake login when DEV or TEST is set so we don't
    access FAS server each time we log in.

Diffs (updated)
-----

blockerbugs/util/login.py PRE-CREATION 
  blockerbugs/templates/layout.html b92c069824e589f7be789d4d8182f4c42361bb02 
  blockerbugs/controllers/users.py 76b1485e2cabf6cbf8d04497b0cb18e37786a9e6 
  blockerbugs/controllers/main.py 4f23e35558ac3f8ed2ccc5d897b2219e449e7277 
  blockerbugs/__init__.py c4f2c34f5eac713253336d026aa9485259096cb0

Diff: http://reviewboard-tflink.rhcloud.com/r/38/diff/

Testing
-------

Thanks,

Martin Krizek

[Martin Krizek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/38/#review63
-----------------------------------------------------------

Ship it!

Looks good to me

- Tim Flink

On Aug. 5, 2013, 1:48 p.m., Martin Krizek wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-tflink.rhcloud.com/r/38/
>
> (Updated Aug. 5, 2013, 1:48 p.m.)
>
> Review request for blockerbugs.
>
> Repository: blockerbugs
> Description
>
> commit 4f9c14cc32fe11c008e7901a2310a5e34381301d
> Author: Martin Krizek 
> Date:   Tue Jul 30 15:47:25 2013 +0200
> Migrate dev login to openid
>
> commit 1c145319fb1e4ffe9bb2d5a9b3d3140fbab6606e
> Author: Martin Krizek 
> Date:   Thu Jul 18 11:32:59 2013 +0200
> Add admin privileges to the dev user
>
> commit 815c14ce31d05690f80391063be076f4cfd46286
> Author: Martin Krizek 
> Date:   Mon Jul 15 11:28:09 2013 +0200
> Use fake login only in DEV environment
>
> commit eb518b8f33fe84af9d321caa1c37b431ce809b06
> Author: Martin Krizek 
> Date:   Thu Jul 4 11:14:40 2013 +0200
> Add developer login
>
> This patch allows a fake login when DEV or TEST is set so we don't
> access FAS server each time we log in.
>
>
> Diffs
>
> blockerbugs/util/login.py PRE-CREATION 
>   blockerbugs/templates/layout.html b92c069824e589f7be789d4d8182f4c42361bb02 
>   blockerbugs/controllers/users.py 76b1485e2cabf6cbf8d04497b0cb18e37786a9e6 
>   blockerbugs/controllers/main.py 4f23e35558ac3f8ed2ccc5d897b2219e449e7277 
>   blockerbugs/__init__.py c4f2c34f5eac713253336d026aa9485259096cb0
>
> Diff: http://reviewboard-tflink.rhcloud.com/r/38/diff/
> Testing
>
> Thanks,
>
> Martin Krizek

[Martin Krizek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/38/
-----------------------------------------------------------

(Updated Aug. 7, 2013, 7:38 a.m.)

Status
------

This change has been marked as submitted.

Review request for blockerbugs.

Repository: blockerbugs

Description
-------

commit 4f9c14cc32fe11c008e7901a2310a5e34381301d
Author: Martin Krizek 
Date:   Tue Jul 30 15:47:25 2013 +0200

Migrate dev login to openid

commit 1c145319fb1e4ffe9bb2d5a9b3d3140fbab6606e
Author: Martin Krizek 
Date:   Thu Jul 18 11:32:59 2013 +0200

Add admin privileges to the dev user

commit 815c14ce31d05690f80391063be076f4cfd46286
Author: Martin Krizek 
Date:   Mon Jul 15 11:28:09 2013 +0200

Use fake login only in DEV environment

commit eb518b8f33fe84af9d321caa1c37b431ce809b06
Author: Martin Krizek 
Date:   Thu Jul 4 11:14:40 2013 +0200

Add developer login

This patch allows a fake login when DEV or TEST is set so we don't
    access FAS server each time we log in.

Diffs
-----

blockerbugs/util/login.py PRE-CREATION 
  blockerbugs/templates/layout.html b92c069824e589f7be789d4d8182f4c42361bb02 
  blockerbugs/controllers/users.py 76b1485e2cabf6cbf8d04497b0cb18e37786a9e6 
  blockerbugs/controllers/main.py 4f23e35558ac3f8ed2ccc5d897b2219e449e7277 
  blockerbugs/__init__.py c4f2c34f5eac713253336d026aa9485259096cb0

Diff: http://reviewboard-tflink.rhcloud.com/r/38/diff/

Testing
-------

Thanks,

Martin Krizek