----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/18/ -----------------------------------------------------------
Review request for blockerbugs.
Bugs: 343 https://fedorahosted.org/fedora-qa/ticket/343
Repository: blockerbugs
Description -------
This is maybe trivial to have a review for but two things might be discussed: 1. do we want to show the link just on index or on all pages? 2. is the wording of the link ok?
Diffs -----
sass/app.scss 1a4369d0911b77fc411089de0b05c8d5c80e304f blockerbugs/templates/index.html 088962bfcb16c3f0d163366f2235fc557e0d45dc
Diff: http://reviewboard-tflink.rhcloud.com/r/18/diff/
Testing -------
Thanks,
Martin Krizek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/18/#review24 -----------------------------------------------------------
I think that it would be good to put the link in the global footer - I get asked where the source lives on a semi-regular basis and it might be good to make that more obvious :)
Sorry for the delay on this, should have done it a while ago.
blockerbugs/templates/index.html http://reviewboard-tflink.rhcloud.com/r/18/#comment43
Why limit this to just the index page instead of adding it to the global footer?
blockerbugs/templates/index.html http://reviewboard-tflink.rhcloud.com/r/18/#comment44
How about something like: "This application is open source! Get the code (with embedded link to cgit) or look at development plans (with link to fedora-qa trac report 10)"?
sass/app.scss http://reviewboard-tflink.rhcloud.com/r/18/#comment45
If you change the scss, you need to regenerate the css using compass as well.
sass/app.scss http://reviewboard-tflink.rhcloud.com/r/18/#comment46
What's the advantage to greying this out instead of using the link colors that we're using elsewhere in the app?
- Tim Flink
On March 13, 2013, 11:21 a.m., Martin Krizek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/18/
(Updated March 13, 2013, 11:21 a.m.)
Review request for blockerbugs.
Bugs: 343 https://fedorahosted.org/fedora-qa/ticket/343
Repository: blockerbugs
Description
This is maybe trivial to have a review for but two things might be discussed:
- do we want to show the link just on index or on all pages?
- is the wording of the link ok?
Diffs
sass/app.scss 1a4369d0911b77fc411089de0b05c8d5c80e304f blockerbugs/templates/index.html 088962bfcb16c3f0d163366f2235fc557e0d45dc
Diff: http://reviewboard-tflink.rhcloud.com/r/18/diff/
Testing
Thanks,
Martin Krizek
On April 19, 2013, 4:27 p.m., Tim Flink wrote:
sass/app.scss, line 37 http://reviewboard-tflink.rhcloud.com/r/18/diff/1/?file=243#file243line37
What's the advantage to greying this out instead of using the link colors that we're using elsewhere in the app?
Initially I thought that the link is not that important information so I greyed the link out. On second thought, let's make it consistent. Fixed.
On April 19, 2013, 4:27 p.m., Tim Flink wrote:
blockerbugs/templates/index.html, line 84 http://reviewboard-tflink.rhcloud.com/r/18/diff/1/?file=242#file242line84
How about something like: "This application is open source! Get the code (with embedded link to cgit) or look at development plans (with link to fedora-qa trac report 10)"?
Thanks, fixed.
On April 19, 2013, 4:27 p.m., Tim Flink wrote:
blockerbugs/templates/index.html, line 80 http://reviewboard-tflink.rhcloud.com/r/18/diff/1/?file=242#file242line80
Why limit this to just the index page instead of adding it to the global footer?
Agreed, fixed.
- Martin
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/18/#review24 -----------------------------------------------------------
On April 22, 2013, 8:47 a.m., Martin Krizek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/18/
(Updated April 22, 2013, 8:47 a.m.)
Review request for blockerbugs.
Bugs: 343 https://fedorahosted.org/fedora-qa/ticket/343
Repository: blockerbugs
Description
This is maybe trivial to have a review for but two things might be discussed:
- do we want to show the link just on index or on all pages?
- is the wording of the link ok?
Diffs
blockerbugs/templates/layout.html a0b5ebda3ff61a3fa2647d96ef77037ed0d729d2 blockerbugs/templates/index.html 088962bfcb16c3f0d163366f2235fc557e0d45dc
Diff: http://reviewboard-tflink.rhcloud.com/r/18/diff/
Testing
Thanks,
Martin Krizek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/18/ -----------------------------------------------------------
(Updated April 22, 2013, 8:47 a.m.)
Review request for blockerbugs.
Bugs: 343 https://fedorahosted.org/fedora-qa/ticket/343
Repository: blockerbugs
Description -------
This is maybe trivial to have a review for but two things might be discussed: 1. do we want to show the link just on index or on all pages? 2. is the wording of the link ok?
Diffs (updated) -----
blockerbugs/templates/layout.html a0b5ebda3ff61a3fa2647d96ef77037ed0d729d2 blockerbugs/templates/index.html 088962bfcb16c3f0d163366f2235fc557e0d45dc
Diff: http://reviewboard-tflink.rhcloud.com/r/18/diff/
Testing -------
Thanks,
Martin Krizek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/18/#review27 -----------------------------------------------------------
As I'm looking through the template code, why not remove the "last synced with" message that's repeated in almost every page and put it at the milestone_base.html level and combine it with the cgit message?
I don't think it's as important to have the cgit or the sync message in the admin interface and it probably shouldn't be duplicated as much as it is. I can't think of a reason that we wouldn't want the "last synced" message on every public facing page.
blockerbugs/templates/index.html http://reviewboard-tflink.rhcloud.com/r/18/#comment52
I assume this is associated with the layout change in the footer block - question there remains the same
blockerbugs/templates/layout.html http://reviewboard-tflink.rhcloud.com/r/18/#comment51
Why remove this? I usually kept example stuff in the blocks at the layout level so that it's obvious when the block isn't being filled with any meaningful content.
blockerbugs/templates/layout.html http://reviewboard-tflink.rhcloud.com/r/18/#comment50
I'd rather see this combined with the existing "last synced with" footer, not done as a block in the layout or at least renamed to something more obvious than footer_
It took me a minute to realize that this was a new block and not just changing the existing footer block
- Tim Flink
On April 22, 2013, 8:47 a.m., Martin Krizek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/18/
(Updated April 22, 2013, 8:47 a.m.)
Review request for blockerbugs.
Bugs: 343 https://fedorahosted.org/fedora-qa/ticket/343
Repository: blockerbugs
Description
This is maybe trivial to have a review for but two things might be discussed:
- do we want to show the link just on index or on all pages?
- is the wording of the link ok?
Diffs
blockerbugs/templates/layout.html a0b5ebda3ff61a3fa2647d96ef77037ed0d729d2 blockerbugs/templates/index.html 088962bfcb16c3f0d163366f2235fc557e0d45dc
Diff: http://reviewboard-tflink.rhcloud.com/r/18/diff/
Testing
Thanks,
Martin Krizek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/18/ -----------------------------------------------------------
(Updated April 23, 2013, 1:58 p.m.)
Status ------
This change has been marked as submitted.
Review request for blockerbugs.
Bugs: 343 https://fedorahosted.org/fedora-qa/ticket/343
Repository: blockerbugs
Description -------
This is maybe trivial to have a review for but two things might be discussed: 1. do we want to show the link just on index or on all pages? 2. is the wording of the link ok?
Diffs -----
blockerbugs/templates/layout.html a0b5ebda3ff61a3fa2647d96ef77037ed0d729d2 blockerbugs/templates/index.html 088962bfcb16c3f0d163366f2235fc557e0d45dc
Diff: http://reviewboard-tflink.rhcloud.com/r/18/diff/
Testing -------
Thanks,
Martin Krizek
qa-devel@lists.fedoraproject.org
-
Martin Krizek