On March 4, 2013, 3:45 p.m., Martin Krizek wrote:
> blockerbugs/util/bz_interface.py, line 49
> <
http://reviewboard-tflink.rhcloud.com/r/2/diff/3/?file=151#file151line49>
>
> So I gather you rather not load the app to load the url from the config, right?
In that particular code - yeah, I'd rather avoid it. There are no direct dependencies
on the blockerbugs code in there and I'd rather keep it that way. The rest of the BBA
should be passing in a bugzilla url when the interface object is created and getting that
URL from config, though
On March 4, 2013, 3:45 p.m., Martin Krizek wrote:
> blockerbugs/templates/base_nav.html, line 23
> <
http://reviewboard-tflink.rhcloud.com/r/2/diff/3/?file=147#file147line23>
>
> Not necessary anymore with t332 in develop.
Yeah, I forgot that t332 made it to develop already - will update the diff.
On March 4, 2013, 3:45 p.m., Martin Krizek wrote:
> blockerbugs/__init__.py, line 7
> <
http://reviewboard-tflink.rhcloud.com/r/2/diff/3/?file=142#file142line7>
>
> For what?
Good catch - that isn't supposed to be there anymore
On March 4, 2013, 3:45 p.m., Martin Krizek wrote:
> blockerbugs/templates/propose_bug.html, line 145
> <
http://reviewboard-tflink.rhcloud.com/r/2/diff/3/?file=148#file148line145...
>
> Maybe an overkill but we could load the release number dynamically?
Yeah, that shouldn't be too hard to do. The URL structure may change in the future but
we can deal with that if/when it happens
- Tim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/2/#review13
-----------------------------------------------------------
On March 1, 2013, 6:19 a.m., Tim Flink wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/2/
-----------------------------------------------------------
(Updated March 1, 2013, 6:19 a.m.)
Review request for blockerbugs.
Bugs: 334
https://fedorahosted.org/fedora-qa/ticket/334
Repository: blockerbugs
Description
-------
Initial code for blocker submission page
Diffs
-----
testing/test_bugchange.py PRE-CREATION
sync_db.py 590d80adbf86bc9f7c27a4a8a0d46f5570c303f1
setup.py 32cf5b26caac1aced1dde2f0bf29d94bc2bebe83
initialize.py a6cd0a2766aaf88e8d87a4f72d6721075f6a219d
init_f18db.sh c20df66c4b4a8f38ab79a1b61043d26de112f71c
conf/blockerbugs.wsgi dcd819f4c4080546c84bd48f604ae6469d70d98a
blockerbugs/util/bz_interface.py 2bae79db2d3a1206b7de1cee5f005f137ba2d6f3
blockerbugs/util/bug_sync.py 110fbe983a5cf177c35a9966162d0de23cf98d18
blockerbugs/templates/thanks.html PRE-CREATION
blockerbugs/templates/propose_bug.html PRE-CREATION
blockerbugs/templates/base_nav.html f3a89798a9dadf297e722c067ad3795a72ebbf74
blockerbugs/controllers/main.py 21bf27ce593a1398b1a08a6a4bcfc1d34146c027
blockerbugs/controllers/forms.py caae0e5b201fc6d85930246c31159ebbbe4f9ab7
blockerbugs/controllers/admin.py 01196b3d9b7284ebcab8bf1db061ad69f2d5f250
blockerbugs/config.py 75cf777d31e7fc3bfe3256704cd349e3ca88c866
blockerbugs/__init__.py cae54ab562f8a17a4473aa0bc58a73dacf5225f9
Diff:
http://reviewboard-tflink.rhcloud.com/r/2/diff/
Testing
-------
I've done quite a bit of local testing and there is a staging instance available:
https://209.132.184.132/blockerbugs
Thanks,
Tim Flink