----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/20/ -----------------------------------------------------------
Review request for blockerbugs.
Bugs: 374 https://fedorahosted.org/fedora-qa/ticket/374
Repository: blockerbugs
Description -------
This is code to rework logging mechanisms for fedora-infra standards. It changed a bit from martin's original code, so I'm creating a new review request.
Diffs -----
testing/test_updatesync_extract_information.py 1884dabb577515720c19b167a58fdb0559ba273c testing/test_update_sync.py 1bc7b7c9d43bb0f526611aef872ace85918fc3ad sass/app.scss 0f81cbd6d740ff7325ec080c5ccb33ecf642e0b7 runapp.py 736ec65bd25962180559d783a155c7ac1c5da285 conf/settings.py.example 7c45c785fa05c12f2c36f2ca06b99bcd41b318ce conf/blockerbugs.cron.example ddfe8f5661854e76887cd727f187f219c80ffdae blockerbugs/util/update_sync.py f6469da84ce9e60d65521535a07fe511fa668e1e blockerbugs/util/bz_interface.py 7dedce924c2f96110ed98bd311b870e03e617887 blockerbugs/util/bug_sync.py 6e092aa35c04ec9a7a4b03653fddf2cef27e4ba1 blockerbugs/templates/thanks.html f5432900daae6af4d22b3e5abbbc7092df868c4a blockerbugs/templates/layout.html a0b5ebda3ff61a3fa2647d96ef77037ed0d729d2 blockerbugs/static/img/repeater-stg.png 24c56fd10da38d7d6f8a3f684a811bc4b04b56a4 blockerbugs/static/img/blockerbugs-logo-light-stg.png b94f3891dd4726eac435c8a03c2ac0a2daafef39 blockerbugs/static/css/app.css 26e177c1e5c7cec716db5b2bcd428bb4e6a92505 blockerbugs/static/css/app-foundation.css 852272bf1bd1c629b30933b451daceec31812de7 blockerbugs/config.py cecca7c88ef25ee9fd81df0cd2aeb2f84030559f blockerbugs/cli.py 0166b0fddcacc79c81f0f111317df6208c35fb12 blockerbugs/__init__.py cf068ed33799a5426e297ab9ed269c513079f726 blockerbugs.spec 012e980b5d0cf57c09bd9f993b6c21d29c5cc3d8
Diff: http://reviewboard-tflink.rhcloud.com/r/20/diff/
Testing -------
local and dev VM testing, currently running on qa.stg.fedoraproject.org/blockerbugs/ - no issues noticed thus far
Thanks,
Tim Flink
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/20/#review21 -----------------------------------------------------------
blockerbugs/__init__.py http://reviewboard-tflink.rhcloud.com/r/20/#comment38
Could you elaborate on why you use both root_logger and app.logger?
blockerbugs/__init__.py http://reviewboard-tflink.rhcloud.com/r/20/#comment37
Why this is set on root_logger, while everywhere else it is set on specific handler?
blockerbugs/__init__.py http://reviewboard-tflink.rhcloud.com/r/20/#comment36
s/handler/file_handler/
blockerbugs/cli.py http://reviewboard-tflink.rhcloud.com/r/20/#comment39
There are a lot of commented out code in this file, probably delete it?
- Martin Krizek
On April 17, 2013, 5:22 p.m., Tim Flink wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/20/
(Updated April 17, 2013, 5:22 p.m.)
Review request for blockerbugs.
Bugs: 374 https://fedorahosted.org/fedora-qa/ticket/374
Repository: blockerbugs
Description
This is code to rework logging mechanisms for fedora-infra standards. It changed a bit from martin's original code, so I'm creating a new review request.
Diffs
testing/test_updatesync_extract_information.py 1884dabb577515720c19b167a58fdb0559ba273c testing/test_update_sync.py 1bc7b7c9d43bb0f526611aef872ace85918fc3ad sass/app.scss 0f81cbd6d740ff7325ec080c5ccb33ecf642e0b7 runapp.py 736ec65bd25962180559d783a155c7ac1c5da285 conf/settings.py.example 7c45c785fa05c12f2c36f2ca06b99bcd41b318ce conf/blockerbugs.cron.example ddfe8f5661854e76887cd727f187f219c80ffdae blockerbugs/util/update_sync.py f6469da84ce9e60d65521535a07fe511fa668e1e blockerbugs/util/bz_interface.py 7dedce924c2f96110ed98bd311b870e03e617887 blockerbugs/util/bug_sync.py 6e092aa35c04ec9a7a4b03653fddf2cef27e4ba1 blockerbugs/templates/thanks.html f5432900daae6af4d22b3e5abbbc7092df868c4a blockerbugs/templates/layout.html a0b5ebda3ff61a3fa2647d96ef77037ed0d729d2 blockerbugs/static/img/repeater-stg.png 24c56fd10da38d7d6f8a3f684a811bc4b04b56a4 blockerbugs/static/img/blockerbugs-logo-light-stg.png b94f3891dd4726eac435c8a03c2ac0a2daafef39 blockerbugs/static/css/app.css 26e177c1e5c7cec716db5b2bcd428bb4e6a92505 blockerbugs/static/css/app-foundation.css 852272bf1bd1c629b30933b451daceec31812de7 blockerbugs/config.py cecca7c88ef25ee9fd81df0cd2aeb2f84030559f blockerbugs/cli.py 0166b0fddcacc79c81f0f111317df6208c35fb12 blockerbugs/__init__.py cf068ed33799a5426e297ab9ed269c513079f726 blockerbugs.spec 012e980b5d0cf57c09bd9f993b6c21d29c5cc3d8
Diff: http://reviewboard-tflink.rhcloud.com/r/20/diff/
Testing
local and dev VM testing, currently running on qa.stg.fedoraproject.org/blockerbugs/ - no issues noticed thus far
Thanks,
Tim Flink
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/20/#review22 -----------------------------------------------------------
blockerbugs/__init__.py http://reviewboard-tflink.rhcloud.com/r/20/#comment40
because at the point when this code is run, the app.logger is already set up and isn't affected by any changes to the root_logger.
blockerbugs/__init__.py http://reviewboard-tflink.rhcloud.com/r/20/#comment41
becuase it should be set on the root logger as well, and isn't
blockerbugs/__init__.py http://reviewboard-tflink.rhcloud.com/r/20/#comment42
huh, I thought I fixed that. obviously not.
- Tim Flink
On April 17, 2013, 5:22 p.m., Tim Flink wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/20/
(Updated April 17, 2013, 5:22 p.m.)
Review request for blockerbugs.
Bugs: 374 https://fedorahosted.org/fedora-qa/ticket/374
Repository: blockerbugs
Description
This is code to rework logging mechanisms for fedora-infra standards. It changed a bit from martin's original code, so I'm creating a new review request.
Diffs
testing/test_updatesync_extract_information.py 1884dabb577515720c19b167a58fdb0559ba273c testing/test_update_sync.py 1bc7b7c9d43bb0f526611aef872ace85918fc3ad sass/app.scss 0f81cbd6d740ff7325ec080c5ccb33ecf642e0b7 runapp.py 736ec65bd25962180559d783a155c7ac1c5da285 conf/settings.py.example 7c45c785fa05c12f2c36f2ca06b99bcd41b318ce conf/blockerbugs.cron.example ddfe8f5661854e76887cd727f187f219c80ffdae blockerbugs/util/update_sync.py f6469da84ce9e60d65521535a07fe511fa668e1e blockerbugs/util/bz_interface.py 7dedce924c2f96110ed98bd311b870e03e617887 blockerbugs/util/bug_sync.py 6e092aa35c04ec9a7a4b03653fddf2cef27e4ba1 blockerbugs/templates/thanks.html f5432900daae6af4d22b3e5abbbc7092df868c4a blockerbugs/templates/layout.html a0b5ebda3ff61a3fa2647d96ef77037ed0d729d2 blockerbugs/static/img/repeater-stg.png 24c56fd10da38d7d6f8a3f684a811bc4b04b56a4 blockerbugs/static/img/blockerbugs-logo-light-stg.png b94f3891dd4726eac435c8a03c2ac0a2daafef39 blockerbugs/static/css/app.css 26e177c1e5c7cec716db5b2bcd428bb4e6a92505 blockerbugs/static/css/app-foundation.css 852272bf1bd1c629b30933b451daceec31812de7 blockerbugs/config.py cecca7c88ef25ee9fd81df0cd2aeb2f84030559f blockerbugs/cli.py 0166b0fddcacc79c81f0f111317df6208c35fb12 blockerbugs/__init__.py cf068ed33799a5426e297ab9ed269c513079f726 blockerbugs.spec 012e980b5d0cf57c09bd9f993b6c21d29c5cc3d8
Diff: http://reviewboard-tflink.rhcloud.com/r/20/diff/
Testing
local and dev VM testing, currently running on qa.stg.fedoraproject.org/blockerbugs/ - no issues noticed thus far
Thanks,
Tim Flink
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/20/ -----------------------------------------------------------
(Updated April 18, 2013, 3:03 p.m.)
Review request for blockerbugs.
Changes -------
updated with merge from develop and fixes for issues noticed during review
Bugs: 374 https://fedorahosted.org/fedora-qa/ticket/374
Repository: blockerbugs
Description -------
This is code to rework logging mechanisms for fedora-infra standards. It changed a bit from martin's original code, so I'm creating a new review request.
Diffs (updated) -----
sass/app.scss 0f81cbd6d740ff7325ec080c5ccb33ecf642e0b7 conf/settings.py.example 7c45c785fa05c12f2c36f2ca06b99bcd41b318ce conf/blockerbugs.cron.example ddfe8f5661854e76887cd727f187f219c80ffdae blockerbugs/util/update_sync.py 9c46ffc7b3c2f07a73c899165044059447858a48 blockerbugs/util/bz_interface.py 7dedce924c2f96110ed98bd311b870e03e617887 blockerbugs/util/bug_sync.py 6e092aa35c04ec9a7a4b03653fddf2cef27e4ba1 blockerbugs/templates/thanks.html f5432900daae6af4d22b3e5abbbc7092df868c4a blockerbugs/templates/layout.html a0b5ebda3ff61a3fa2647d96ef77037ed0d729d2 blockerbugs/static/img/repeater-stg.png 24c56fd10da38d7d6f8a3f684a811bc4b04b56a4 blockerbugs/static/img/blockerbugs-logo-light-stg.png b94f3891dd4726eac435c8a03c2ac0a2daafef39 blockerbugs/static/css/app.css 26e177c1e5c7cec716db5b2bcd428bb4e6a92505 blockerbugs/static/css/app-foundation.css 852272bf1bd1c629b30933b451daceec31812de7 blockerbugs/config.py cecca7c88ef25ee9fd81df0cd2aeb2f84030559f blockerbugs/cli.py 5cfc306a90515577775ad972fd05c627f906d3b2 blockerbugs/__init__.py aebfe96cc9268f6bbeab3d0bb0c9ae3a4218986b blockerbugs.spec 012e980b5d0cf57c09bd9f993b6c21d29c5cc3d8
Diff: http://reviewboard-tflink.rhcloud.com/r/20/diff/
Testing -------
local and dev VM testing, currently running on qa.stg.fedoraproject.org/blockerbugs/ - no issues noticed thus far
Thanks,
Tim Flink
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/20/#review23 -----------------------------------------------------------
Ship it!
Ship It!
- Martin Krizek
On April 18, 2013, 3:03 p.m., Tim Flink wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/20/
(Updated April 18, 2013, 3:03 p.m.)
Review request for blockerbugs.
Bugs: 374 https://fedorahosted.org/fedora-qa/ticket/374
Repository: blockerbugs
Description
This is code to rework logging mechanisms for fedora-infra standards. It changed a bit from martin's original code, so I'm creating a new review request.
Diffs
sass/app.scss 0f81cbd6d740ff7325ec080c5ccb33ecf642e0b7 conf/settings.py.example 7c45c785fa05c12f2c36f2ca06b99bcd41b318ce conf/blockerbugs.cron.example ddfe8f5661854e76887cd727f187f219c80ffdae blockerbugs/util/update_sync.py 9c46ffc7b3c2f07a73c899165044059447858a48 blockerbugs/util/bz_interface.py 7dedce924c2f96110ed98bd311b870e03e617887 blockerbugs/util/bug_sync.py 6e092aa35c04ec9a7a4b03653fddf2cef27e4ba1 blockerbugs/templates/thanks.html f5432900daae6af4d22b3e5abbbc7092df868c4a blockerbugs/templates/layout.html a0b5ebda3ff61a3fa2647d96ef77037ed0d729d2 blockerbugs/static/img/repeater-stg.png 24c56fd10da38d7d6f8a3f684a811bc4b04b56a4 blockerbugs/static/img/blockerbugs-logo-light-stg.png b94f3891dd4726eac435c8a03c2ac0a2daafef39 blockerbugs/static/css/app.css 26e177c1e5c7cec716db5b2bcd428bb4e6a92505 blockerbugs/static/css/app-foundation.css 852272bf1bd1c629b30933b451daceec31812de7 blockerbugs/config.py cecca7c88ef25ee9fd81df0cd2aeb2f84030559f blockerbugs/cli.py 5cfc306a90515577775ad972fd05c627f906d3b2 blockerbugs/__init__.py aebfe96cc9268f6bbeab3d0bb0c9ae3a4218986b blockerbugs.spec 012e980b5d0cf57c09bd9f993b6c21d29c5cc3d8
Diff: http://reviewboard-tflink.rhcloud.com/r/20/diff/
Testing
local and dev VM testing, currently running on qa.stg.fedoraproject.org/blockerbugs/ - no issues noticed thus far
Thanks,
Tim Flink
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/20/ -----------------------------------------------------------
(Updated April 19, 2013, 4:12 p.m.)
Status ------
This change has been marked as submitted.
Review request for blockerbugs.
Bugs: 374 https://fedorahosted.org/fedora-qa/ticket/374
Repository: blockerbugs
Description -------
This is code to rework logging mechanisms for fedora-infra standards. It changed a bit from martin's original code, so I'm creating a new review request.
Diffs -----
sass/app.scss 0f81cbd6d740ff7325ec080c5ccb33ecf642e0b7 conf/settings.py.example 7c45c785fa05c12f2c36f2ca06b99bcd41b318ce conf/blockerbugs.cron.example ddfe8f5661854e76887cd727f187f219c80ffdae blockerbugs/util/update_sync.py 9c46ffc7b3c2f07a73c899165044059447858a48 blockerbugs/util/bz_interface.py 7dedce924c2f96110ed98bd311b870e03e617887 blockerbugs/util/bug_sync.py 6e092aa35c04ec9a7a4b03653fddf2cef27e4ba1 blockerbugs/templates/thanks.html f5432900daae6af4d22b3e5abbbc7092df868c4a blockerbugs/templates/layout.html a0b5ebda3ff61a3fa2647d96ef77037ed0d729d2 blockerbugs/static/img/repeater-stg.png 24c56fd10da38d7d6f8a3f684a811bc4b04b56a4 blockerbugs/static/img/blockerbugs-logo-light-stg.png b94f3891dd4726eac435c8a03c2ac0a2daafef39 blockerbugs/static/css/app.css 26e177c1e5c7cec716db5b2bcd428bb4e6a92505 blockerbugs/static/css/app-foundation.css 852272bf1bd1c629b30933b451daceec31812de7 blockerbugs/config.py cecca7c88ef25ee9fd81df0cd2aeb2f84030559f blockerbugs/cli.py 5cfc306a90515577775ad972fd05c627f906d3b2 blockerbugs/__init__.py aebfe96cc9268f6bbeab3d0bb0c9ae3a4218986b blockerbugs.spec 012e980b5d0cf57c09bd9f993b6c21d29c5cc3d8
Diff: http://reviewboard-tflink.rhcloud.com/r/20/diff/
Testing -------
local and dev VM testing, currently running on qa.stg.fedoraproject.org/blockerbugs/ - no issues noticed thus far
Thanks,
Tim Flink
qa-devel@lists.fedoraproject.org