September 2018 - quarterback-devel - Fedora Mailing-Lists

[ClusterLabs/libqb] 633f26: logging: Remove linker 'magic' and just use static...

by Chrissie Caulfield

Branch: refs/heads/master Home: https://github.com/ClusterLabs/libqb Commit: 633f2624a7b42eb8e227e8e0e9f584d80ee3ead2 https://github.com/ClusterLabs/libqb/commit/633f2624a7b42eb8e227e8e0e9f58... Author: Chrissie Caulfield <ccaulfie(a)redhat.com> Date: 2018-09-27 (Thu, 27 Sep 2018) Changed paths: M configure.ac M include/qb/qbconfig.h.in M include/qb/qblog.h M lib/Makefile.am M lib/libqb.pc.in M lib/log.c Log Message: ----------- logging: Remove linker 'magic' and just use statics for logging callsites (#322) It is my (and several others') opinion that the linker 'magic' used to maintain callsite data in libqb is hugely over complicated and unnecessarily fragile. It's main purpose seems to have been to improve performance but empirical testing shows this to be tiny at best. The overhead of sprintf makes minor optimisations in this code pointless. With this code removed, libqb allocates callsites using a C static variable at run-time. This sounds bad but in actuality it merely moves the allocation from program load time to the first few milliseconds of program run-time. Applications like corosync and pacemaker spend most of their time in small loops doing the same work over and over again so the overhead doesn't apply and jitter does not occur. We've tested this with corosync and pacemaker under valgrind and massif and the differences are minimal and even then only show up under artificial stress testing. For this change I've bumped the soname up to 20 to indicate this is an incompatible change. I'm open to suggestions as to a release number but am currently thinking of 2.0.0 **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

5 years, 7 months

1
0
0 / 0

[ClusterLabs/libqb] f7d187: log: Remove linker 'magic' and just use static cal...

by Christine Caulfield

Branch: refs/heads/topic-no-ldsection Home: https://github.com/ClusterLabs/libqb Commit: f7d18777cf53a5c8b0786d9e629ee4f85c406be9 https://github.com/ClusterLabs/libqb/commit/f7d18777cf53a5c8b0786d9e629ee... Author: Christine Caulfield <ccaulfie(a)redhat.com> Date: 2018-09-25 (Tue, 25 Sep 2018) Changed paths: M configure.ac M include/qb/qbconfig.h.in M include/qb/qblog.h M lib/Makefile.am M lib/libqb.pc.in M lib/log.c Log Message: ----------- log: Remove linker 'magic' and just use static callsites. Commit: 6fa1c18a46c2cf2ec548371f782ca44fbba63442 https://github.com/ClusterLabs/libqb/commit/6fa1c18a46c2cf2ec548371f782ca... Author: Christine Caulfield <ccaulfie(a)redhat.com> Date: 2018-09-25 (Tue, 25 Sep 2018) Changed paths: M lib/Makefile.am Log Message: ----------- Bump version number Commit: 353981cbb840aa82b4b74613ebd5fedfec0f50ed https://github.com/ClusterLabs/libqb/commit/353981cbb840aa82b4b74613ebd5f... Author: Christine Caulfield <ccaulfie(a)redhat.com> Date: 2018-09-25 (Tue, 25 Sep 2018) Changed paths: M configure.ac Log Message: ----------- config: Remove more unused variables Compare: https://github.com/ClusterLabs/libqb/compare/6a4a4b2c840c...353981cbb840 **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

5 years, 7 months

1
0
0 / 0

[ClusterLabs/libqb] d0ec0a: UPDATED: doc (ABI comparison) and various other fi...

by Chrissie Caulfield

Branch: refs/heads/master Home: https://github.com/ClusterLabs/libqb Commit: d0ec0a6a5727100a1f070c3f487832b99925c74e https://github.com/ClusterLabs/libqb/commit/d0ec0a6a5727100a1f070c3f48783... Author: Chrissie Caulfield <ccaulfie(a)redhat.com> Date: 2018-09-25 (Tue, 25 Sep 2018) Changed paths: M build-aux/abi-check-templ.xml M check M configure.ac M include/qb/qbarray.h M include/qb/qblist.h M include/qb/qblog.h M lib/Makefile.am M tests/Makefile.am A tests/check_list.c M tests/functional/log_client.c M tests/functional/log_interlib.c M tests/functional/log_interlib_client.c M tests/print_ver.c Log Message: ----------- UPDATED: doc (ABI comparison) and various other fixes (#324) * doc: qbarray.h: fix garbled Doxygen markup * build: follow-up for and fine-tuning of a rushed 6d62b64 commit (It made a service as-was, but being afforded more time, this would have accompanied that commit right away, for better understanding, brevity and uniformity.) * build: prune superfluous Makefile declarations within tests directory There was a significant redundancy wrt. build flags and EXTRA_DIST assignment (the latter become redundant as of f6e4042 at latest) spread all over the place (vivat copy&paste). Also, in one instance, CPPFLAGS (used) was confused with CFLAGS (meant). * maint: check abi: fix two issues with abi-compliance-checker/libstdc++ 1. ABICC >= 2 needs to be passed -cxx-incompatible switch because C is no longer a default for this tool (used to be vice versa), plus current version will stop choking on C vs. C++ (our C code with C++ compatibility wrapping being viewed from C++ perspective for the purpose of dumping the declared symbols, which somewhat conflicts with internal masking of the C++ keywords being used as valid C identifiers [yet some instances must not be masked here, see https://github.com/lvc/abi-compliance-checker/issues/64) only if _also_ something like this is applied: https://github.com/lvc/abi-compliance-checker/pull/70 2. since 20246f5, libqb.so no longer poses a symlink to the actual version-qualified shared library, but rather a standalone linker script, which confuses ABICC, so blacklist that file for the scanning purposes explicitly, together with referring to the library through it's basic version qualification (which alone, sadly, is not sufficient as ABICC proceeds to scan whole containing directory despite particular file is specified) * maint: check abi: switch to abi-dumper for creating "ABI dumps" Beside avoiding issues with abi-compliance-checker in the role of ABI dumps producer (see the preceding commit), it also seems to generate more accurate picture (maybe because it expressly requires compiling with debugging information requested). * Low: qblist.h: fix incompatibility with C++ & check it regularly * tests: check_list.c: start zeroing in on the gaps in tests' coverage * tests: print_ver: make preprocessor emit "note" rather than warning IIRC, Chrissie asked about this around inclusion of the test at hand, and it seemed there was no way but to emit a warning to get something output at all. Now it turns wrong, and moreover, we make the code not fixed on GCC specific pragmas, with a bit of luck, "#pragma message" approach is adopted more widely by compilers. Signed-off-by: Jan Pokorný <jpokorny(a)redhat.com> * Replace ck_assert_uint_eq() with ck_assert_int_eq() it's not available in check 0.9 * Proper check for C++ compiler (from Fabio) * add (c) to copyright dates **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

5 years, 7 months

1
0
0 / 0

[ClusterLabs/libqb] e4e41f: add (c) to copyright dates

by Christine Caulfield

Branch: refs/heads/jnpkrn-fix-doc Home: https://github.com/ClusterLabs/libqb Commit: e4e41fc6e2e48566989334deb583f061c9b4e8be https://github.com/ClusterLabs/libqb/commit/e4e41fc6e2e48566989334deb583f... Author: Christine Caulfield <ccaulfie(a)redhat.com> Date: 2018-09-24 (Mon, 24 Sep 2018) Changed paths: M include/qb/qblog.h M tests/check_list.c M tests/functional/log_client.c M tests/functional/log_interlib.c M tests/functional/log_interlib_client.c M tests/print_ver.c Log Message: ----------- add (c) to copyright dates I understand this is not legally needed but at least it makes the files consistent. **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

5 years, 7 months

1
0
0 / 0

[ClusterLabs/libqb] cf6c34: Proper check for C++ compiler (from Fabio)

by Christine Caulfield

Branch: refs/heads/jnpkrn-fix-doc Home: https://github.com/ClusterLabs/libqb Commit: cf6c3463f66a1cc5f28608cb23f63661faeb486f https://github.com/ClusterLabs/libqb/commit/cf6c3463f66a1cc5f28608cb23f63... Author: Christine Caulfield <ccaulfie(a)redhat.com> Date: 2018-09-17 (Mon, 17 Sep 2018) Changed paths: M configure.ac M tests/Makefile.am Log Message: ----------- Proper check for C++ compiler (from Fabio) **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

5 years, 7 months

1
0
0 / 0

[ClusterLabs/libqb] 4aa9d0: C++ compat didn't bail out when compiler wasn't pr...

by Christine Caulfield

Branch: refs/heads/jnpkrn-fix-doc Home: https://github.com/ClusterLabs/libqb Commit: 4aa9d0846fbfdd7f8c77cdaa8d12634c01011980 https://github.com/ClusterLabs/libqb/commit/4aa9d0846fbfdd7f8c77cdaa8d126... Author: Christine Caulfield <ccaulfie(a)redhat.com> Date: 2018-09-14 (Fri, 14 Sep 2018) Changed paths: M tests/Makefile.am Log Message: ----------- C++ compat didn't bail out when compiler wasn't present **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

5 years, 7 months

1
0
0 / 0

[ClusterLabs/libqb] 1754b3: doc: qbarray.h: fix garbled Doxygen markup

by Christine Caulfield

Branch: refs/heads/jnpkrn-fix-doc Home: https://github.com/ClusterLabs/libqb Commit: 1754b394d4aee1f02ba37d9b87d96f1ad240ba4a https://github.com/ClusterLabs/libqb/commit/1754b394d4aee1f02ba37d9b87d96... Author: Jan Pokorný <jpokorny(a)redhat.com> Date: 2018-01-04 (Thu, 04 Jan 2018) Changed paths: M include/qb/qbarray.h Log Message: ----------- doc: qbarray.h: fix garbled Doxygen markup Signed-off-by: Jan Pokorný <jpokorny(a)redhat.com> Commit: d300b7fdaec5183c375a894727f8551bf17c8b56 https://github.com/ClusterLabs/libqb/commit/d300b7fdaec5183c375a894727f85... Author: Jan Pokorný <jpokorny(a)redhat.com> Date: 2018-01-10 (Wed, 10 Jan 2018) Changed paths: M configure.ac M lib/Makefile.am Log Message: ----------- build: follow-up for and fine-tuning of a rushed 6d62b64 commit (It made a service as-was, but being afforded more time, this would have accompanied that commit right away, for better understanding, brevity and uniformity.) Signed-off-by: Jan Pokorný <jpokorny(a)redhat.com> Commit: 1e7c85a17a61e2a9b3b0e51da6cd41aa5e2ece51 https://github.com/ClusterLabs/libqb/commit/1e7c85a17a61e2a9b3b0e51da6cd4... Author: Jan Pokorný <jpokorny(a)redhat.com> Date: 2018-01-10 (Wed, 10 Jan 2018) Changed paths: M tests/Makefile.am Log Message: ----------- build: prune superfluous Makefile declarations within tests directory There was a significant redundancy wrt. build flags and EXTRA_DIST assignment (the latter become redundant as of f6e4042 at latest) spread all over the place (vivat copy&paste). Also, in one instance, CPPFLAGS (used) was confused with CFLAGS (meant). Signed-off-by: Jan Pokorný <jpokorny(a)redhat.com> Commit: e0bc8b191289c1f701e36194a3bee7d1b1ba361d https://github.com/ClusterLabs/libqb/commit/e0bc8b191289c1f701e36194a3bee... Author: Jan Pokorný <jpokorny(a)redhat.com> Date: 2018-01-11 (Thu, 11 Jan 2018) Changed paths: M build-aux/abi-check-templ.xml M check Log Message: ----------- maint: check abi: fix two issues with abi-compliance-checker/libstdc++ 1. ABICC >= 2 needs to be passed -cxx-incompatible switch because C is no longer a default for this tool (used to be vice versa), plus current version will stop choking on C vs. C++ (our C code with C++ compatibility wrapping being viewed from C++ perspective for the purpose of dumping the declared symbols, which somewhat conflicts with internal masking of the C++ keywords being used as valid C identifiers [yet some instances must not be masked here, see https://github.com/lvc/abi-compliance-checker/issues/64) only if _also_ something like this is applied: https://github.com/lvc/abi-compliance-checker/pull/70 2. since 20246f5, libqb.so no longer poses a symlink to the actual version-qualified shared library, but rather a standalone linker script, which confuses ABICC, so blacklist that file for the scanning purposes explicitly, together with referring to the library through it's basic version qualification (which alone, sadly, is not sufficient as ABICC proceeds to scan whole containing directory despite particular file is specified) Signed-off-by: Jan Pokorný <jpokorny(a)redhat.com> Commit: 1646253e138878c68462e26533136560cdef70f9 https://github.com/ClusterLabs/libqb/commit/1646253e138878c68462e26533136... Author: Jan Pokorný <jpokorny(a)redhat.com> Date: 2018-01-11 (Thu, 11 Jan 2018) Changed paths: M check Log Message: ----------- maint: check abi: switch to abi-dumper for creating "ABI dumps" Beside avoiding issues with abi-compliance-checker in the role of ABI dumps producer (see the preceding commit), it also seems to generate more accurate picture (maybe because it expressly requires compiling with debugging information requested). Signed-off-by: Jan Pokorný <jpokorny(a)redhat.com> Commit: 3107df1d18b8e25a823c6d58f8afb2f3065a31a0 https://github.com/ClusterLabs/libqb/commit/3107df1d18b8e25a823c6d58f8afb... Author: Jan Pokorný <jpokorny(a)redhat.com> Date: 2018-01-11 (Thu, 11 Jan 2018) Changed paths: M include/qb/qblist.h M tests/Makefile.am Log Message: ----------- Low: qblist.h: fix incompatibility with C++ & check it regularly Primary trigger was the fact that "./check abi" (via build-aux/generate-docs) choked on that because abi-compliance-checker (ABICC) uses g++ to list symbols in header files playing hide-and-see regarding C identifiers otherwise conflicting with C++ keywords, which is moreover triggered only with -cxx-incompatible switch since ABICC 2.0 (and even then the respective code needs some further tweaking: https://github.com/lvc/abi-compliance-checker/pull/70), and this switch wasn't historically applied. Anyway, this C++ perspective there was likely unprecedented even though libqb no doubt targets such compatiblity. To avoid its breakage within the public headers' scope in the future, arrange for checking it regularly alongside the "auto_check_header" tests (cf. make -C tests check-headers). Signed-off-by: Jan Pokorný <jpokorny(a)redhat.com> Commit: 76345296dab87554e91cc5f22a93522ba6da1780 https://github.com/ClusterLabs/libqb/commit/76345296dab87554e91cc5f22a935... Author: Jan Pokorný <jpokorny(a)redhat.com> Date: 2018-01-11 (Thu, 11 Jan 2018) Changed paths: M tests/Makefile.am A tests/check_list.c Log Message: ----------- tests: check_list.c: start zeroing in on the gaps in tests' coverage Signed-off-by: Jan Pokorný <jpokorny(a)redhat.com> Commit: fb45f6671c1d04017c88567006229e6d3365c663 https://github.com/ClusterLabs/libqb/commit/fb45f6671c1d04017c88567006229... Author: Jan Pokorný <jpokorny(a)redhat.com> Date: 2018-01-21 (Sun, 21 Jan 2018) Changed paths: M tests/print_ver.c Log Message: ----------- tests: print_ver: make preprocessor emit "note" rather than warning IIRC, Chrissie asked about this around inclusion of the test at hand, and it seemed there was no way but to emit a warning to get something output at all. Now it turns wrong, and moreover, we make the code not fixed on GCC specific pragmas, with a bit of luck, "#pragma message" approach is adopted more widely by compilers. Signed-off-by: Jan Pokorný <jpokorny(a)redhat.com> Commit: 8af09bd721b3c5d6ada36d98b7cfcafd0740ead8 https://github.com/ClusterLabs/libqb/commit/8af09bd721b3c5d6ada36d98b7cfc... Author: Christine Caulfield <ccaulfie(a)redhat.com> Date: 2018-09-14 (Fri, 14 Sep 2018) Changed paths: M build-aux/abi-check-templ.xml M check M configure.ac M include/qb/qbarray.h M include/qb/qblist.h M lib/Makefile.am M tests/Makefile.am A tests/check_list.c M tests/print_ver.c Log Message: ----------- Fix tests/Makefile.am conflicts with new master Commit: e354a5f52258b1d25f36dedc034131bc9e695264 https://github.com/ClusterLabs/libqb/commit/e354a5f52258b1d25f36dedc03413... Author: Christine Caulfield <ccaulfie(a)redhat.com> Date: 2018-09-14 (Fri, 14 Sep 2018) Changed paths: M tests/check_list.c Log Message: ----------- Replace ck_assert_uint_eq() with ck_assert_int_eq() it's not available in check 0.9 which is in RHEL7 Compare: https://github.com/ClusterLabs/libqb/compare/1754b394d4ae^...e354a5f52258 **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

5 years, 7 months

1
0
0 / 0

[ClusterLabs/libqb] 4a414f: log: Remove linker 'magic' and just use static cal...

by Christine Caulfield

Branch: refs/heads/topic-no-ldsection Home: https://github.com/ClusterLabs/libqb Commit: 4a414f40b9356fd1182d33d0815800f43ffd6f1b https://github.com/ClusterLabs/libqb/commit/4a414f40b9356fd1182d33d081580... Author: Christine Caulfield <ccaulfie(a)redhat.com> Date: 2018-09-10 (Mon, 10 Sep 2018) Changed paths: M configure.ac M include/qb/qbconfig.h.in M include/qb/qblog.h M lib/Makefile.am M lib/libqb.pc.in M lib/log.c Log Message: ----------- log: Remove linker 'magic' and just use static callsites. Commit: d546fc92199d52350035d7e794a8dd148e77678b https://github.com/ClusterLabs/libqb/commit/d546fc92199d52350035d7e794a8d... Author: Christine Caulfield <ccaulfie(a)redhat.com> Date: 2018-09-10 (Mon, 10 Sep 2018) Changed paths: M lib/Makefile.am Log Message: ----------- Bump version number Commit: 6a4a4b2c840cbccfc18ec217ddeb10342bcf8025 https://github.com/ClusterLabs/libqb/commit/6a4a4b2c840cbccfc18ec217ddeb1... Author: Christine Caulfield <ccaulfie(a)redhat.com> Date: 2018-09-10 (Mon, 10 Sep 2018) Changed paths: M configure.ac Log Message: ----------- config: Remove more unused variables Compare: https://github.com/ClusterLabs/libqb/compare/4a0193a8d274...6a4a4b2c840c **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

5 years, 7 months

1
0
0 / 0

[ClusterLabs/libqb] 4a0193: config: Remove more unused variables

by Christine Caulfield

Branch: refs/heads/topic-no-ldsection Home: https://github.com/ClusterLabs/libqb Commit: 4a0193a8d274359b8f47c200df9f193c9ee742a0 https://github.com/ClusterLabs/libqb/commit/4a0193a8d274359b8f47c200df9f1... Author: Christine Caulfield <ccaulfie(a)redhat.com> Date: 2018-09-10 (Mon, 10 Sep 2018) Changed paths: M configure.ac Log Message: ----------- config: Remove more unused variables **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

5 years, 7 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

quarterback-devel September 2018