[releng] Set obsolete branch to f19.
by Jon Ciesla
commit 8dd97ab912c5d172c30f68a0ec6bc786ca0e7d51
Author: Jon Ciesla <limburgher(a)gmail.com>
Date: Tue Jan 6 10:23:51 2015 -0600
Set obsolete branch to f19.
scripts/process-git-requests/process-git-requests | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/scripts/process-git-requests/process-git-requests b/scripts/process-git-requests/process-git-requests
index 7b719d1..69544ea 100755
--- a/scripts/process-git-requests/process-git-requests
+++ b/scripts/process-git-requests/process-git-requests
@@ -3,7 +3,7 @@ VERSION = "1.0"
# Unfortunately pkgdb can't tell us when we stop accepting branches for the
# oldest supported release, so this needs updating manually.
-OBSOLETE_BRANCH='f18'
+OBSOLETE_BRANCH='f19'
# A bug for testing new types of badly formatted requests exists:
# https://bugzilla.redhat.com/show_bug.cgi?id=622067
9 years, 3 months
[releng] Fix warnings on process-git-request with pkgdb groups
by Kevin Fenzi
commit 75955f51627ff390511aabe3d01d84ca1efbf5d2
Author: Kevin Fenzi <kevin(a)scrye.com>
Date: Mon Jan 5 12:03:20 2015 -0700
Fix warnings on process-git-request with pkgdb groups
scripts/process-git-requests/process-git-requests | 43 +++++++++++++-------
1 files changed, 28 insertions(+), 15 deletions(-)
---
diff --git a/scripts/process-git-requests/process-git-requests b/scripts/process-git-requests/process-git-requests
index ef82af8..7b719d1 100755
--- a/scripts/process-git-requests/process-git-requests
+++ b/scripts/process-git-requests/process-git-requests
@@ -33,7 +33,7 @@ import time
import webbrowser
import socket
from configobj import ConfigObj, flatten_errors
-from fedora.client import AccountSystem, AuthError
+from fedora.client import AccountSystem, AuthError, AppError
from pkgdb2client import PkgDB, PkgDBException
from optparse import OptionParser
from validate import Validator
@@ -496,6 +496,31 @@ def process_no_request(bug, allcomments):
return True
+def check_owner(fas, owner):
+ """Check if owner is a valid FAS account or group.
+
+ If owner is a valid FAS account, also check if owner is a packager.
+ """
+ warnings = []
+ if owner.startswith('group::'):
+ group_name = owner[7:]
+ try:
+ group = fas.group_by_name(group_name)
+ if not group_name.endswith('-sig') and not group['group_type'] == 'pkgdb':
+ warnings.append('WARNING: "%s" is not a valid FAS group.' % group_name)
+ except AppError:
+ warnings.append('WARNING: "%s" could not be found as FAS group.' % group_name)
+ else: # Check if owner is a valid user
+ person = fas.person_by_username(owner)
+ if not 'status' in person:
+ warnings.append('WARNING: "%s" is not a valid FAS account.' % i)
+ else:
+ groups = [g['name'] for g in person.approved_memberships]
+ if not 'packager' in groups:
+ warnings.append('WARNING: "%s" is not in the packager group.' % i)
+ return warnings
+
+
def check_owners(fas, owner, comaintainers, cc_list):
print "Checking owners..."
warnings = []
@@ -503,7 +528,7 @@ def check_owners(fas, owner, comaintainers, cc_list):
for i in [owner] + comaintainers:
for retry in range(1, config['pkgdb.retries'] + 1):
try:
- person = fas.person_by_username(i)
+ warnings.extend(check_owner(fas, i))
except AuthError, e:
if retry >= config['pkgdb.retries']:
break
@@ -513,20 +538,8 @@ def check_owners(fas, owner, comaintainers, cc_list):
else:
break
- if not 'status' in person:
- warnings.append('WARNING: "%s" is not a valid FAS account.' % i)
- break
-
- groups = [g['name'] for g in person.approved_memberships]
-
- if not 'packager' in groups:
- warnings.append('WARNING: "%s" is not in the packager group.' % i)
-
for i in cc_list:
- person = fas.person_by_username(i)
- if not 'status' in person:
- warnings.append('WARNING: "%s" is not a valid FAS account.' % i)
- break
+ warnings.extend(check_owner(fas, i))
return warnings
9 years, 3 months
[releng] process-git-requests: rename i to person
by Till Maas
commit 4980d6c6f7fdf7b4d9860871fed27f15e4c17b3b
Author: Till Maas <opensource(a)till.name>
Date: Thu Jan 1 22:23:11 2015 +0100
process-git-requests: rename i to person
scripts/process-git-requests/process-git-requests | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/scripts/process-git-requests/process-git-requests b/scripts/process-git-requests/process-git-requests
index 068a481..ef82af8 100755
--- a/scripts/process-git-requests/process-git-requests
+++ b/scripts/process-git-requests/process-git-requests
@@ -222,13 +222,13 @@ def edit_package(pkgdb, request):
LOG.info('Edit package %s in pkgdb', request['pkg'])
for retry in range(1, config['pkgdb.retries'] + 1):
try:
- for i in ([request['owner']] + request['comaintainers']):
+ for person in ([request['owner']] + request['comaintainers']):
pkgdb.update_acl(
str(request['pkg']),
request['newbranches'],
['watchcommits', 'watchbugzilla', 'approveacls', 'commit'],
'Approved',
- i)
+ person)
except AuthError, e:
if retry >= config['pkgdb.retries']:
break
9 years, 3 months
#6072: Updates are stuck in Bodhi
by Fedora Release Engineering
#6072: Updates are stuck in Bodhi
---------------------+------------------------
Reporter: cottsay | Owner: rel-eng@…
Type: task | Status: new
Milestone: | Component: other
Keywords: bodhi | Blocked By:
Blocking: |
---------------------+------------------------
== bug description ==
I have some updates in Bodhi that I can't un-push. They have a dependency
problem and have been trumped by another update. They have been sitting in
this funky state for a couple of weeks now.
== fix recommendation ==
Please un-push the updates manually
- https://admin.fedoraproject.org/updates/python-wstool-0.1.5-1.fc21
,python-vcstools-0.1.36-1.fc21,python-catkin-
sphinx-0.2.1-5.20130602gitc00d68b.fc21,python-bloom-0.5.15-1.fc21
- https://admin.fedoraproject.org/updates/python-wstool-0.1.5-1.fc20
,python-vcstools-0.1.36-1.fc20,python-catkin-
sphinx-0.2.1-4.20130602gitc00d68b.fc20,python-bloom-0.5.15-1.fc20
- https://admin.fedoraproject.org/updates/python-wstool-0.1.5-1.fc19
,python-vcstools-0.1.36-1.fc19,python-catkin-
sphinx-0.2.1-3.20130602gitc00d68b.fc19,python-bloom-0.5.15-1.fc19
- https://admin.fedoraproject.org/updates/python-vcstools-0.1.36-1.el6
,python-catkin-sphinx-0.2.1-3.20130602gitc00d68b.el6,python-
bloom-0.5.15-1.el6
- https://admin.fedoraproject.org/updates/python-vcstools-0.1.36-1.el7
,python-catkin-sphinx-0.2.1-3.20130602gitc00d68b.el7,python-
bloom-0.5.15-1.el7
Originally filed at https://fedorahosted.org/fedora-
infrastructure/ticket/4622
--
Ticket URL: <https://fedorahosted.org/rel-eng/ticket/6072>
Fedora Release Engineering <http://fedorahosted.org/rel-eng>
Release Engineering for the Fedora Project
9 years, 3 months
#6068: [EPEL5] Un-retire json-c and lcgdm-dav
by Fedora Release Engineering
#6068: [EPEL5] Un-retire json-c and lcgdm-dav
----------------------+------------------------
Reporter: aalvarez | Owner: rel-eng@…
Type: task | Status: new
Milestone: | Component: epel
Keywords: | Blocked By:
Blocking: |
----------------------+------------------------
Hello,
I would like to take over the epel5 branch of json-c, which have been
removed recently.
The package is active in the other branches (el6, rawhide, ...), so I
don't think a new review is required?
I have contacted the current admin for this package. He agrees on me
taking over, but couldn't add me himself.
Also, I would like to recover the epel5 branch of lcgdm-dav, which was
retires as a consequence of the retirement of json-c. This project is
active in all other branches as well.
Regards.
--
Ticket URL: <https://fedorahosted.org/rel-eng/ticket/6068>
Fedora Release Engineering <http://fedorahosted.org/rel-eng>
Release Engineering for the Fedora Project
9 years, 3 months
