[PATCH 2/2] Reduce the number of calls made by update-critpath

[Pierre-Yves Chibon]

The pkgdb2 API is able to handle queries submitting multiple packages at
once, so there is no need to make a query for each package separately.

In addition this commit makes sure there are packages to change before
trying to do the change and will print a message if there are no packages
to change.
---
 scripts/update-critpath | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/scripts/update-critpath b/scripts/update-critpath
index 41d576b..6801845 100644
--- a/scripts/update-critpath
+++ b/scripts/update-critpath
@@ -127,20 +127,24 @@ def update_critpath(current_critpath, new_critpath, branch):
     # Remove the critpath flag to the package that should not have it
 
     new_no = current_critpath - new_critpath
-    for pkg in new_no:
+    if new_no:
         try:
-            pkgdbclient.update_critpath(pkg, branch, False)
+            pkgdbclient.update_critpath(new_no, branch, False)
         except PkgDBException, err:
             LOG.debug('PkgDBException')
-            print '{0}: {1}'.format(pkg, err)
+            print '{0}'.format(err)
+    else:
+        print 'No packages to which the critpath flag should be removed'
 
     new_yes = new_critpath - current_critpath
-    for pkg in new_yes:
+    if new_yes:
         try:
-            pkgdbclient.update_critpath(pkg, branch, True)
+            pkgdbclient.update_critpath(new_yes, branch, True)
         except PkgDBException, err:
             LOG.debug('PkgDBException')
-            print '{0}: {1}'.format(pkg, err)
+            print '{0}'.format(err)
+    else:
+        print 'No packages to which the critpath flag should be added'
 
 
 def main():
-- 
1.9.3