Proposal : Use OSBS to build the fedora container base image

[Clement Verna]

Hi all,

I would like to get feedbacks on the following proposal. Use OSBS to
build the fedora container base image, indeed OSBS has the capability
to build a base container image using a kickstart file.
To do this OSBS needs a Dockerfile, a kickstart file and an
image-build.conf file stored in dist-git, then OSBS will trigger an
ImageFactory task in Koji in order to build to base image and then it
will build the base container based on the artifacts built in Koji.

Here a the few advantages I see in moving forward with this proposal :

- Use of a single dist-git repo for the base image, allowing use of fedora-ci.
  - Using OSBS will allow us to make use of bodhi updates to release
new versions of the image
  - OSBS deals with multi-arches (we currently use a custom script in
releng to build manifest list)
  - Does not requires releng to run a script to release the images

Before I start looking at the implementation details, I would
appreciate feedbacks.

Thanks
Clément

[Kevin Fenzi]

On 12/3/18 10:38 AM, Clement Verna wrote:
> Hi all,
>
> I would like to get feedbacks on the following proposal. Use OSBS to
> build the fedora container base image, indeed OSBS has the capability
> to build a base container image using a kickstart file.
> To do this OSBS needs a Dockerfile, a kickstart file and an
> image-build.conf file stored in dist-git, then OSBS will trigger an
> ImageFactory task in Koji in order to build to base image and then it
> will build the base container based on the artifacts built in Koji.
>
> Here a the few advantages I see in moving forward with this proposal :
> Use of a single dist-git repo for the base image, allowing use of fedora-ci.
> Using OSBS will allow us to make use of bodhi updates to release
>
> new versions of the image
> OSBS deals with multi-arches (we currently use a custom script in
>
> releng to build manifest list)
> Does not requires releng to run a script to release the images
>
> Before I start looking at the implementation details, I would
> appreciate feedbacks.

+1 here. I always thought doing the container base differently didn't
make much sense.

kevin

[Neal Gompa]

On Mon, Dec 3, 2018 at 1:39 PM Clement Verna  wrote:
> Hi all,
>
> I would like to get feedbacks on the following proposal. Use OSBS to
> build the fedora container base image, indeed OSBS has the capability
> to build a base container image using a kickstart file.
> To do this OSBS needs a Dockerfile, a kickstart file and an
> image-build.conf file stored in dist-git, then OSBS will trigger an
> ImageFactory task in Koji in order to build to base image and then it
> will build the base container based on the artifacts built in Koji.

Is anyone actively maintaining ImageFactory? Because it's still Python
2 only and I haven't seen anyone really working on fixing that, much
less supporting more images easily...

[Dennis Gregorovic]

There has been some progress as Tomas Kopecek added py3 patches to Oz last
year... https://github.com/clalancette/oz/pull/263

Not sure how much effort is needed to add py3 support to ImageFactory
itself.  Copying Tomas as Brendan.  Neither of them maintain IF, but they
have contributed to it in the past and may be able to help.

-- Dennis

On Mon, Dec 3, 2018 at 2:02 PM Neal Gompa  wrote:
> On Mon, Dec 3, 2018 at 1:39 PM Clement Verna 
> wrote:
> > Hi all,
> >
> > I would like to get feedbacks on the following proposal. Use OSBS to
> > build the fedora container base image, indeed OSBS has the capability
> > to build a base container image using a kickstart file.
> > To do this OSBS needs a Dockerfile, a kickstart file and an
> > image-build.conf file stored in dist-git, then OSBS will trigger an
> > ImageFactory task in Koji in order to build to base image and then it
> > will build the base container based on the artifacts built in Koji.
>
> Is anyone actively maintaining ImageFactory? Because it's still Python
> 2 only and I haven't seen anyone really working on fixing that, much
> less supporting more images easily...
>
> --
> 真実はいつも一つ！/ Always, there's only one truth!
> _______________________________________________
> devel mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]
> Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
> https://lists.fedoraproject.org/archives/list/[e-mail]

[Dennis Gregorovic]

Forwarding info I got from Tomas off-line...

"""
oz should be py3-ready according to clancellete (not tested by me). I've
started some work on ImageFactory, but didn't get too far as there were
other priorities. It seemed to be doable (waited on oz in that time), so if
we want to give it some resources (very rough estimation ~1month/man to get
both things running together)

About ImageFactory maintaining - I don't think there is anybody actively
maintaining it, nearest shot is Brendan. Both mailing lists are dead from
2014/2015.

btw, for OSBS it should be no difference while koji builders are still
python2. ImageFactory is running there and needs to be same python version
as kojid (it is used as library, not separate process).
"""

On Wed, Jan 2, 2019 at 2:24 PM Dennis Gregorovic  wrote:
> There has been some progress as Tomas Kopecek added py3 patches to Oz last
> year... https://github.com/clalancette/oz/pull/263
>
> Not sure how much effort is needed to add py3 support to ImageFactory
> itself.  Copying Tomas as Brendan.  Neither of them maintain IF, but they
> have contributed to it in the past and may be able to help.
>
> -- Dennis
>
> On Mon, Dec 3, 2018 at 2:02 PM Neal Gompa  wrote:
> > On Mon, Dec 3, 2018 at 1:39 PM Clement Verna 
> > wrote:
> > > Hi all,
> > >
> > > I would like to get feedbacks on the following proposal. Use OSBS to
> > > build the fedora container base image, indeed OSBS has the capability
> > > to build a base container image using a kickstart file.
> > > To do this OSBS needs a Dockerfile, a kickstart file and an
> > > image-build.conf file stored in dist-git, then OSBS will trigger an
> > > ImageFactory task in Koji in order to build to base image and then it
> > > will build the base container based on the artifacts built in Koji.
> >
> > Is anyone actively maintaining ImageFactory? Because it's still Python
> > 2 only and I haven't seen anyone really working on fixing that, much
> > less supporting more images easily...
> >
> > --
> > 真実はいつも一つ！/ Always, there's only one truth!
> > _______________________________________________
> > devel mailing list -- [e-mail]
> > To unsubscribe send an email to [e-mail]
> > Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
> > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> > List Archives:
> > https://lists.fedoraproject.org/archives/list/[e-mail]
>
> --
> Dennis Gregorovic
> Manager, PnT DevOps
> Red Hat
> [e-mail]    T: +1-978.392.3112    M: +1-617.901.9799

[Neal Gompa]

On Thu, Jan 3, 2019 at 9:54 AM Dennis Gregorovic  wrote:
> Forwarding info I got from Tomas off-line...
>
> """
> oz should be py3-ready according to clancellete (not tested by me). I've started some work on ImageFactory, but didn't get too far as there were other priorities. It seemed to be doable (waited on oz in that time), so if we want to give it some resources (very rough estimation ~1month/man to get both things running together)
>
> About ImageFactory maintaining - I don't think there is anybody actively maintaining it, nearest shot is Brendan. Both mailing lists are dead from 2014/2015.
>
> btw, for OSBS it should be no difference while koji builders are still python2. ImageFactory is running there and needs to be same python version as kojid (it is used as library, not separate process).
> """

The PRs for Koji to move to Python 3 are waiting for their review to
be completed to be merged:

* https://pagure.io/koji/pull-request/1117
* https://pagure.io/koji/pull-request/921
* https://pagure.io/koji/pull-request/891

Basically, as soon as someone gives a crap about it, these can be
finished up, merged, and we can have Koji switched to Python 3.

--
真実はいつも一つ！/ Always, there's only one truth!

[Mohan Boddu]

+1 to the change proposal.

Someone still need to submit updates in bodhi and rel-eng would be happy to
own that task and it is much simpler than what we have today.

On Mon, Dec 3, 2018 at 1:39 PM Clement Verna 
wrote:
> Hi all,
>
> I would like to get feedbacks on the following proposal. Use OSBS to
> build the fedora container base image, indeed OSBS has the capability
> to build a base container image using a kickstart file.
> To do this OSBS needs a Dockerfile, a kickstart file and an
> image-build.conf file stored in dist-git, then OSBS will trigger an
> ImageFactory task in Koji in order to build to base image and then it
> will build the base container based on the artifacts built in Koji.
>
> Here a the few advantages I see in moving forward with this proposal :
> Use of a single dist-git repo for the base image, allowing use of
>
> fedora-ci.
> Using OSBS will allow us to make use of bodhi updates to release
>
> new versions of the image
> OSBS deals with multi-arches (we currently use a custom script in
>
> releng to build manifest list)
> Does not requires releng to run a script to release the images
>
> Before I start looking at the implementation details, I would
> appreciate feedbacks.
>
> Thanks
> Clément
> _______________________________________________
> devel mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]
> Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
> https://lists.fedoraproject.org/archives/list/[e-mail]