rishi opened a new pull-request against the project: `pungi-fedora` that you are following: `` Toolbx: Fix the 'name' label ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1246
rishi commented on the pull-request: `Toolbx: Fix the 'name' label` that you are following: `` Corresponding pull request for `f40`: https://pagure.io/pungi-fedora/pull-request/1247 ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1246
adamwill commented on the pull-request: `Toolbx: Fix the 'name' label` that you are following: `` @ngompa is working on https://pagure.io/pungi-fedora/pull-request/1248 , which wound render all of this pretty much moot anyway, AIUI. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1246
rishi commented on the pull-request: `Toolbx: Fix the 'name' label` that you are following: ``
@ngompa is working on https://pagure.io/pungi-fedora/pull-request/1248 , which would render all of this pretty much moot anyway, AIUI.
Yeah, I am trying to sort out the KIWI builds in parallel. Last time I checked, the KIWI sources of the `fedora-toolbox` image had the same problems that the Kickstart/Pungi based images had during the Fedora 39 cycle, which I fixed at the tail end of the cycle.
It looks like the `fedora-toolbox` images are still being built by Image Factory, not KIWI: ``` $ podman inspect --format '{{ .Comment }}' --type image registry.fedoraproject.org/fedora-toolbox:40 Created by Image Factory ```
... which is why I filed this PR.
I got myself a thin slice of free time to work on the fedora-toolbox images, and I want to take advantage of it to fix everything, so that nothing slips through the cracks. For example, what if something goes wrong and we have to activate the contingency plan and switch back to Image Factory?
I will soon have to context switch away from image maintenance to other things in Toolbx land, so I want to get everything sorted out. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1246
adamwill commented on the pull-request: `Toolbx: Fix the 'name' label` that you are following: ``
Last time I checked, the KIWI sources of the fedora-toolbox image had the same problems that the Kickstart/Pungi based images had during the Fedora 39 cycle, which I fixed at the tail end of the cycle.
What problems are those? ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1246
rishi commented on the pull-request: `Toolbx: Fix the 'name' label` that you are following: ``
Last time I checked, the KIWI sources of the fedora-toolbox image had the same problems that the Kickstart/Pungi based images had during the Fedora 39 cycle, which I fixed at the tail end of the cycle.
What problems are those?
From a quick read of the KIWI sources, I spotted this one: https://pagure.io/fedora-kickstarts/c/30f76d387d9e7f5ce6cfb395a96a392435fd6f...
I have only just [started](https://pagure.io/fedora-kiwi-descriptions/pull-request/20) to build the KIWI sources, so that's all I have right now.
Various people on the Internet tend to treat the `fedora-toolbox` images as some sort of de facto reference, and copy paste them to create their own. That's another reason I try to keep all variants of them (Container/Dockerfile, Kickstarts/Pungi and KIWI) updated, as long as the relevant branches and sources do exist. For example, I stopped updating the Container/Dockerfile after Fedora 39 came out because we [sunset](https://src.fedoraproject.org/container/fedora-toolbox) the repository, except the `f38` branch, which is still useful as a reference for maintaining the RHEL images. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1246
adamwill commented on the pull-request: `Toolbx: Fix the 'name' label` that you are following: `` @ngompa can you please check the above and make sure it's fixed in the kiwi toolbox definitions? ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1246
rishi commented on the pull-request: `Toolbx: Fix the 'name' label` that you are following: ``
@ngompa can you please check the above and make sure it's fixed in the kiwi toolbox definitions?
I was trying to figure this out myself, because I am still learning how to drive the KIWI toolchain properly.
When I look at the [definition](https://pagure.io/fedora-kiwi-descriptions/blob/rawhide/f/teams/cloud/contai...) of the `Container-Toolbox` profile: ``` <preferences profiles="Container-Toolbox"> <type image="oci"> <containerconfig name="fedora-toolbox" tag="rawhide" maintainer="Fedora Project Contributors <devel@lists.fedoraproject.org>" > <subcommand execute="/bin/bash"/> <labels> <label name="org.opencontainers.image.vendor" value="Fedora Project"/> <label name="org.opencontainers.image.url" value="https://fedoraproject.org/"/> <label name="org.opencontainers.image.license" value="MIT"/> <label name="org.opencontainers.image.version" value="rawhide"/> <label name="com.github.containers.toolbox" value="true"/> <!-- Legacy attributes for backward compatibility --> <label name="vendor" value="Fedora Project"/> <label name="license" value="MIT"/> <label name="version" value="rawhide"/> </labels> </containerconfig> </type> <timezone>Etc/UTC</timezone> <locale>en_US</locale> <rpm-locale-filtering>false</rpm-locale-filtering> <rpm-excludedocs>false</rpm-excludedocs> </preferences> ```
... I see `name="fedora-toolbox"` in `containerconfig`, but no such label.
I built the image and imported it into `containers-storage`: ``` $ sudo ./kiwi-build --image-type=oci --image-profile=Container-Toolbox --output-dir ./outdir $ skopeo copy oci-archive:./outdir/Fedora.x86_64-Rawhide.oci.tar.xz containers-storage:localhost/fedora-toolbox-kiwi:41 ```
... and I don't see the aforementioned `name` or any label in `podman inspect --type image`.
I suppose, if there's no `name` label for the KIWI built images, then that's a good state to be in too. The reason I sent this pull request is that, I didn't want the `name` to exit as before, but be set `fedora` and not `fedora-toolbox`. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1246
ngompa commented on the pull-request: `Toolbx: Fix the 'name' label` that you are following: `` `name` is used for storing the image in container storage, it's not a label. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1246
ngompa commented on the pull-request: `Toolbx: Fix the 'name' label` that you are following: `` If we need more labels or want more identifiers, feel free to add them. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1246
ngompa commented on the pull-request: `Toolbx: Fix the 'name' label` that you are following: `` Oh, to make it clear, the reason why it doesn't do anything is because we're not having kiwi do any of the push/upload stuff. So the labels take effect but the name+tag does not really. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1246
rishi commented on the pull-request: `Toolbx: Fix the 'name' label` that you are following: ``
`name` is used for storing the image in container storage, it's not a label.
I see.
If we need more labels or want more identifiers, feel free to add them.
I don't think we need anything new, at least not for Toolbx.
I did notice that the the `version` label gets set to `rawhide` in the KIWI sources, while in the past with both Image Factory and OpenShift Build Service, we always used a numerical version. I was about to send a pull request for that, but then had second thoughts about whether that was by intention.
I started using a number because that's what the Fedora [guidelines](https://docs.fedoraproject.org/en-US/containers/guidelines/creation/) said for Dockerfiles, and it just stayed that way after the port to Kickstarts and Pungi.
Does it impact that tag used to publish the image? eg., `registry.fedoraproject.org/fedora-toolbox:41` versus `fedora-toolbox:rawhide`. Currently, the `toolbox(1)` really expects the former.
Other than that, I don't have any opinion. :) ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1246
ngompa commented on the pull-request: `Toolbx: Fix the 'name' label` that you are following: `` I think we need both identifiers, but I think our releng script that pushes them to registries can actually do that for us. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1246
ngompa commented on the pull-request: `Toolbx: Fix the 'name' label` that you are following: `` The script in question is this one: https://pagure.io/releng/blob/main/f/scripts/sync-latest-container-base-imag... ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1246
rishi commented on the pull-request: `Toolbx: Fix the 'name' label` that you are following: ``
I think we need both identifiers, but I think our releng script that pushes them to registries can actually do that for us.
Having both of these would be definitely good: * registry.fedoraproject.org/fedora-toolbox:41 * registry.fedoraproject.org/fedora-toolbox:rawhide
... because with `rawhide` you don't have to bump the version every six months or so. However, if we really are publishing or want to publish one tag, then it would be good if we kept the number for the sake of backwards compatibility, both for Toolbx and what manual users had gotten used to.
For Toolbx, I always wanted to do a quick query and map `rawhide` to a number. Or we can use `rawhide` directly if there's an image with that tag. Then the corresponding `fedora-toolbox-rawhide` container would remain Rawhide after Branching, which would avoid a lot of confusion.
Whatever we do, the existing `toolbox(1)` code really expects the tag on the registry to be a number. Having only a `rawhide` tag will require code changes. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1246
ngompa commented on the pull-request: `Toolbx: Fix the 'name' label` that you are following: `` The name label has been added to the kiwi descriptions: https://pagure.io/fedora-kiwi-descriptions/c/ac559c73fd88d8085d5f293ac1a10b8... ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1246
rishi commented on the pull-request: `Toolbx: Fix the 'name' label` that you are following: `` It looks like the images that I just pulled are still built by Image Factory: ``` $ podman inspect \ --format '{{ .Comment }}' \ --type image \ registry.fedoraproject.org/fedora-toolbox:41 Created by Image Factory $ podman inspect \ --format '{{ .Comment }}' \ --type image \ registry.fedoraproject.org/fedora-toolbox:40 Created by Image Factory ``` ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1246
adamwill commented on the pull-request: `Toolbx: Fix the 'name' label` that you are following: `` Yes, this is because of https://pagure.io/releng/issue/12013 . I am trying to write a minimal fix for it right now, and cursing that this script is written in bash not python... ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1246
rishi commented on the pull-request: `Toolbx: Fix the 'name' label` that you are following: ``
Yes, this is because of https://pagure.io/releng/issue/12013 . I am trying to write a minimal fix for it right now, and cursing that this script is written in bash not python...
I see. Thanks, @adamwill ! ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1246
ngompa commented on the pull-request: `Toolbx: Fix the 'name' label` that you are following: `` We can close this now, right? We don't use imgfac for container images anymore.
``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1246
kevin closed without merging a pull-request against the project: `pungi-fedora` that you are following.
Closed pull-request:
`` Toolbx: Fix the 'name' label ``
rel-eng@lists.fedoraproject.org
-
Adam Williamson -
Debarshi Ray
-
Kevin Fenzi
-
Neal Gompa