[pungi-fedora] PR #1214: [WIP] Fix the release-candidate script (releng #11673)

[Patrik Polakovič]

patrikp opened a new pull-request against the project: `pungi-fedora` that you are following:
``
[WIP] Fix the release-candidate script (releng #11673)
``

To reply, visit the link below or just reply to this email
https://pagure.io/pungi-fedora/pull-request/1214

[Kevin Fenzi]

kevin commented on the pull-request: `[WIP] Fix the release-candidate script (releng #11673)` that you are following:
``
So, this looks much better to me. ;)

A few small comments:

* Currently we pass something like 'RC_1.3' to the script, without the number. If we expect to pass the number and where we use _s and -s, we need to update our docs and make sure we remember to do that. ;) Perhaps we could just change it to pass 'release' 'Beta or RC' 'version' as 3 arguments? Then we don't have to worry about _ or -s and can process it more easily?

* Might add some more error checking... ie, if someone does pass 'Beta_1.2' error and say they need to provide the number, or if RC or Beta isn't passed error, or if X.Y isn't passed... 
not a big deal, but would be nice to catch such things. :) If we change it to take 3 args, we could also have the error message say what arguments it's expecting where. ;)

* Might also check for if COMPOSE_ID is not there and error, along with STATUS... ie, if I grab this and run it on my laptop I get: 
cat: /mnt/koji/compose/39/latest-Fedora-39/COMPOSE_ID: No such file or directory
===== COMPOSE STATUS =====                                                                    
cat: /mnt/koji/compose/39//STATUS: No such file or directory

Compose is . Proceeding to rsync.

* from the script you have: # ? If multiple composes are run like 1.2, 1.3, add multiple --link-dest arguments below with multiple composes.

To expand on that, it means if we do say a 39_RC-1.1... then do a 39_RC-1.2, you want to add a --link-dest=/srv/pub/alt/stage/39_RC-1.1
so the new 1.2 one hardlinks to the existing 1.1 one thats already there. I'm not 100% sure this is really needed however, as we are hardlinking to development/39 already 
so it should already get the links. So, I think we can drop this part.

Thanks for working on this!
``

To reply, visit the link below or just reply to this email
https://pagure.io/pungi-fedora/pull-request/1214

[Tomáš Hrčka]

humaton closed without merging a pull-request against the project: `pungi-fedora` that you
are following.

Closed pull-request:

``
[WIP] Fix the release-candidate script (releng #11673)
``

https://pagure.io/pungi-fedora/pull-request/1214