[pungi-fedora] PR #799: Remove name from live media tasks

[Mohan Boddu]

mohanboddu opened a new pull-request against the project: `pungi-fedora` that you are
following:
``
Remove name from live media tasks
``

To reply, visit the link below or just reply to this email
https://pagure.io/pungi-fedora/pull-request/799

[Adam Williamson]

adamwill commented on the pull-request: `Remove name from live media tasks` that you are
following:
``
I'm not sure I like that. Changing the subvariant name is pretty close to declaring
this is a different image than it was before (and will need changes to relval at least).
Also the capitalization is different from the old name so the image file names will
*still* be different. I'd argue it's better to keep the subvariant name and let
the file names change than to change the subvariant name to try and make the filenames
match.
``

To reply, visit the link below or just reply to this email
https://pagure.io/pungi-fedora/pull-request/799

[Adam Williamson]

adamwill commented on the pull-request: `Remove name from live media tasks` that you are
following:
``
Ditto with the above. Also I'm not sure it's actually legal to have a - in a
subvariant name. Even if it is it probably shouldn't be.
``

To reply, visit the link below or just reply to this email
https://pagure.io/pungi-fedora/pull-request/799

[Adam Williamson]

adamwill commented on the pull-request: `Remove name from live media tasks` that you are
following:
``
It seems productmd doesn't actually ban `-` in subvariant names, but my old naming
policy did:

https://fedoraproject.org/wiki/User:Adamwill/Draft_fedora_image_naming_po...

and we don't actually have any subvariants with - in them right now, and doing it is
ambiguous, so...can we not? :)
``

To reply, visit the link below or just reply to this email
https://pagure.io/pungi-fedora/pull-request/799

[Adam Williamson]

adamwill commented on the pull-request: `Remove name from live media tasks` that you are
following:
``
See https://pagure.io/pungi-fedora/issue/533 on the python-classroom thing.
``

To reply, visit the link below or just reply to this email
https://pagure.io/pungi-fedora/pull-request/799

[Adam Williamson]

adamwill commented on the pull-request: `Remove name from live media tasks` that you are
following:
``
Looking into this a bit more - it seems this PR was sent in relation to
https://pagure.io/releng/failed-composes/issue/562, but if the assumption was that this
'name' value is *only* used to generate `--title`, I don't think that's
right. It's used to produce other args too. Just ripping it out seems wrong.
``

To reply, visit the link below or just reply to this email
https://pagure.io/pungi-fedora/pull-request/799

[Adam Williamson]

adamwill commented on the pull-request: `Remove name from live media tasks` that you are
following:
``
I think the correct fix would be to patch koji
[here](https://pagure.io/koji/blob/master/f/builder/kojid#_3451). That's where the
`--title` arg is added.
``

To reply, visit the link below or just reply to this email
https://pagure.io/pungi-fedora/pull-request/799

[Lubomír Sedlář]

lsedlar commented on the pull-request: `Remove name from live media tasks` that you are
following:
``
While this change can shorted the configuration, it will not change anything with regards
to the `--title` change. The koji patch will still be required, and it will be sufficient
even without this change.

The main purpose of the name is to map the task to a package in Koji, so if name changes,
a new package will have to be created in Koji. I don't know if that happens
automatically or requires manual intervention.
Example: https://koji.fedoraproject.org/koji/packageinfo?packageID=22090
``

To reply, visit the link below or just reply to this email
https://pagure.io/pungi-fedora/pull-request/799

[Adam Williamson]

adamwill commented on the pull-request: `Remove name from live media tasks` that you are
following:
``
It does also affect the image file name, as I thought, so if we take it out of the config
that'll change (if it even works - is it actually valid to not have this?)
``

To reply, visit the link below or just reply to this email
https://pagure.io/pungi-fedora/pull-request/799

[Mohan Boddu]

mohanboddu commented on the pull-request: `Remove name from live media tasks` that you are
following:
``
>  The main purpose of the name is to map the task to a package in Koji,
> so if name changes, a new package will have to be created in Koji. I don't know if
> that happens automatically or requires manual intervention.
>  
This is a manual step, we add the package to koji.

>  Looking into this a bit more - it seems this PR was sent in relation
> to https://pagure.io/releng/failed-composes/issue/562, but if the assumption was that this
> 'name' value is only used to generate --title, I don't think that's right.
> It's used to produce other args too. Just ripping it out seems wrong.
>  
So, since it affects other stuff, we cannot simply change the `sub_variant` (I thought it
wont be a major thing). I guess what we can do is, add the new package name (as it will
generate with the current config) to koji. That means, the image names will be different,
which means @adamwill has to make some changes to OpenQA, is that okay?

``

To reply, visit the link below or just reply to this email
https://pagure.io/pungi-fedora/pull-request/799

[Adam Williamson]

adamwill commented on the pull-request: `Remove name from live media tasks` that you are
following:
``
What? I can't parse that.

AFAICS, *all* we need to do here is apply your koji patch so koji doesn't produce a
`--title` arg any more. That should be all that needs changing and it should not result in
any changes to image file names *or* metadata. I do not see that we need to change
anything here (in pungi-fedora) at all. Am I missing something?
``

To reply, visit the link below or just reply to this email
https://pagure.io/pungi-fedora/pull-request/799

[Lubomír Sedlář]

lsedlar commented on the pull-request: `Remove name from live media tasks` that you are
following:
``
>  It does also affect the image file name, as I thought, so if we take
> it out of the config that'll change (if it even works - is it actually valid to not
> have this?)
>  
If not specified, Pungi will default to `{release_name}-{subvariant}-Live`, so this could
make the config a little shorter.

>  AFAICS, all we need to do here is apply your koji patch so koji
> doesn't produce a --title arg any more. That should be all that needs changing and it
> should not result in any changes to image file names or metadata. I do not see that we
> need to change anything here (in pungi-fedora) at all. Am I missing something?
>  
I believe this assessment to be correct and not missing anything.
``

To reply, visit the link below or just reply to this email
https://pagure.io/pungi-fedora/pull-request/799

[Mohan Boddu]

mohanboddu commented on the pull-request: `Remove name from live media tasks` that you are
following:
``
>  If not specified, Pungi will default to
> {release_name}-{subvariant}-Live, so this could make the config a little shorter.
>  
Right, but closing this as this is not required anymore.
``

To reply, visit the link below or just reply to this email
https://pagure.io/pungi-fedora/pull-request/799

[Mohan Boddu]

mohanboddu closed without merging a pull-request against the project: `pungi-fedora` that
you
are following.

Closed pull-request:

``
Remove name from live media tasks
``

https://pagure.io/pungi-fedora/pull-request/799