#1674: Freeze Exception request: gallery2

List overview All Threads
Download

newer

older

#1775: request to tag...

#1772: Please tag...

Fedora Release Engineering

28 Apr 2009 28 Apr '09

11:37 a.m.

#1674: Freeze Exception request: gallery2 -----------------------------+---------------------------------------------- Reporter: limb | Owner: rel-eng@lists.fedoraproject.org Type: task | Status: new Milestone: Fedora 11 Final | Component: koji Keywords: | -----------------------------+---------------------------------------------- gallery2-2.3-8.fc11 fixes a pretrans symlink script. The previous, broken version requires user intervention to upgrade. No code or DB changes.

-- Ticket URL: https://fedorahosted.org/rel-eng/ticket/1674 Fedora Release Engineering http://fedorahosted.org/rel-eng Release Engineering for the Fedora Project

Show replies by date

Fedora Release Engineering

28 Apr 28 Apr

11:45 a.m.

#1674: Freeze Exception request: gallery2 ------------------------------+--------------------------------------------- Reporter: limb | Owner: rel-eng@lists.fedoraproject.org Type: task | Status: new Milestone: Fedora 11 Final | Component: koji Resolution: | Keywords: ------------------------------+--------------------------------------------- Comment (by rdieter):

%pretrans is evil, and can easily cause failures on initial anaconda (or other) installs, where there is no "pretrans" environment. I'm not sure if that case can be gracefully handled or not.

-- Ticket URL: https://fedorahosted.org/rel-eng/ticket/1674#comment:1 Fedora Release Engineering http://fedorahosted.org/rel-eng Release Engineering for the Fedora Project

Fedora Release Engineering

11:48 a.m.

So how do we drop a bundled library and use a Required system version? There have been a flurry of bugs requesting this in the last year and I've done things in %pre for gallery and moodle, and only recently have there been complaints.

-- Ticket URL: https://fedorahosted.org/rel-eng/ticket/1674#comment:2 Fedora Release Engineering http://fedorahosted.org/rel-eng Release Engineering for the Fedora Project

Fedora Release Engineering

11:53 a.m.

Wouldn't doing this sort of thing in %pre with $1 conditionals break with cpio issues? https://bugzilla.redhat.com/show_bug.cgi?id=484240

-- Ticket URL: https://fedorahosted.org/rel-eng/ticket/1674#comment:3 Fedora Release Engineering http://fedorahosted.org/rel-eng Release Engineering for the Fedora Project

Fedora Release Engineering

12:01 p.m.

%pre != %pretrans

-- Ticket URL: https://fedorahosted.org/rel-eng/ticket/1674#comment:4 Fedora Release Engineering http://fedorahosted.org/rel-eng Release Engineering for the Fedora Project

Fedora Release Engineering

12:03 p.m.

Sorry, too brief, you may be able to use %pre here... heck, why not just do this in %post?

-- Ticket URL: https://fedorahosted.org/rel-eng/ticket/1674#comment:5 Fedora Release Engineering http://fedorahosted.org/rel-eng Release Engineering for the Fedora Project

Fedora Release Engineering

12:05 p.m.

I originally tried to do this in %pre, and was told to use %pretrans instead, which I'd never heard of. See linked bug, comment #5.

-- Ticket URL: https://fedorahosted.org/rel-eng/ticket/1674#comment:6 Fedora Release Engineering http://fedorahosted.org/rel-eng Release Engineering for the Fedora Project

Fedora Release Engineering

12:09 p.m.

Oh rats, of course, this is the "replace a dir with a symlink" problem here. ok.

I still think the %pretrans scriptlet as-is will fail if chosen for an initial install.

-- Ticket URL: https://fedorahosted.org/rel-eng/ticket/1674#comment:7 Fedora Release Engineering http://fedorahosted.org/rel-eng Release Engineering for the Fedora Project

Fedora Release Engineering

12:11 p.m.

Would %pretrans as is and a $1 conditional in %pre do the trick?

-- Ticket URL: https://fedorahosted.org/rel-eng/ticket/1674#comment:8 Fedora Release Engineering http://fedorahosted.org/rel-eng Release Engineering for the Fedora Project

Fedora Release Engineering

1 May 1 May

8:59 a.m.

* cc: rdieter (added)

Comment:

I've got a -9 coming with another fix, for a dep that was missed. Rex, any further thoughts on this situation?

-- Ticket URL: https://fedorahosted.org/rel-eng/ticket/1674#comment:9 Fedora Release Engineering http://fedorahosted.org/rel-eng Release Engineering for the Fedora Project

Fedora Release Engineering

5 May 5 May

3:52 p.m.

OK, confirmed with folks that %pretrans is to be avoided.

A solution I came up with under some testing, was to use in %files %ghost /path/to/symlink

and a scriptlet (something like) %post if [ -d /path/to/symlink -a ! -L /path/to/symlink ]; then mv /path/to/symlink /path/to/symlink.rpmbak && \ ln -s /path/to/symlink-target /path/to/symlink && \ rm -rf /path/to/symlink.rpmbak fi

I can help do a proof-of-concept implemation in gallery cvs if you want.

-- Ticket URL: https://fedorahosted.org/rel-eng/ticket/1674#comment:10 Fedora Release Engineering http://fedorahosted.org/rel-eng Release Engineering for the Fedora Project

Fedora Release Engineering

7 May 7 May

7:31 a.m.

Sorry for the delay, was on medical AFK.

A POC in CS would be great.

-- Ticket URL: https://fedorahosted.org/rel-eng/ticket/1674#comment:11 Fedora Release Engineering http://fedorahosted.org/rel-eng Release Engineering for the Fedora Project

Fedora Release Engineering

11 May 11 May

9:27 a.m.

I just committed a version implementing the above, and built in rawhide. It seems to work here, I'll build for 11 and 10 and post to the BZ to have others try it.

-- Ticket URL: https://fedorahosted.org/rel-eng/ticket/1674#comment:12 Fedora Release Engineering http://fedorahosted.org/rel-eng Release Engineering for the Fedora Project

Fedora Release Engineering

9:42 a.m.

gallery2-2.3-9.fc11 Should be taggable.

-- Ticket URL: https://fedorahosted.org/rel-eng/ticket/1674#comment:13 Fedora Release Engineering http://fedorahosted.org/rel-eng Release Engineering for the Fedora Project

Fedora Release Engineering

11:03 a.m.

* cc: rdieter (removed)

Comment:

This incarnation is safer thanks, any testing/feedback yet?

-- Ticket URL: https://fedorahosted.org/rel-eng/ticket/1674#comment:14 Fedora Release Engineering http://fedorahosted.org/rel-eng Release Engineering for the Fedora Project

Fedora Release Engineering

11:06 a.m.

Yeah, just ccd you on the BZ.

-- Ticket URL: https://fedorahosted.org/rel-eng/ticket/1674#comment:15 Fedora Release Engineering http://fedorahosted.org/rel-eng Release Engineering for the Fedora Project

Fedora Release Engineering

11:34 a.m.

ok, +1

-- Ticket URL: https://fedorahosted.org/rel-eng/ticket/1674#comment:16 Fedora Release Engineering http://fedorahosted.org/rel-eng Release Engineering for the Fedora Project

Fedora Release Engineering

2:21 p.m.

#1674: Freeze Exception request: gallery2 ------------------------------+--------------------------------------------- Reporter: limb | Owner: rel-eng@lists.fedoraproject.org Type: task | Status: closed Milestone: Fedora 11 Final | Component: koji Resolution: fixed | Keywords: ------------------------------+--------------------------------------------- Changes (by jkeating):

* status: new => closed * resolution: => fixed

Comment:

Moving, tagging, signing.

-- Ticket URL: https://fedorahosted.org/rel-eng/ticket/1674#comment:17 Fedora Release Engineering http://fedorahosted.org/rel-eng Release Engineering for the Fedora Project

Fedora Release Engineering

2:22 p.m.

#1674: Freeze Exception request: gallery2 ------------------------------+--------------------------------------------- Reporter: limb | Owner: rel-eng@lists.fedoraproject.org Type: task | Status: closed Milestone: Fedora 11 Final | Component: koji Resolution: fixed | Keywords: ------------------------------+--------------------------------------------- Comment (by limb):

Um, I got feedback, didn't say it was positive feedback, see https://bugzilla.redhat.com/show_bug.cgi?id=498334

-- Ticket URL: https://fedorahosted.org/rel-eng/ticket/1674#comment:18 Fedora Release Engineering http://fedorahosted.org/rel-eng Release Engineering for the Fedora Project

5629

Age (days ago)

5642

Last active (days ago)

rel-eng@lists.fedoraproject.org

18 comments

1 participants

tags (0)

participants (1)

Fedora Release Engineering