dcavalca opened a new pull-request against the project: `pungi-fedora` that you are following: `` Add FEX-RootFS to the compose ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1381
adamwill commented on the pull-request: `Add FEX-RootFS to the compose` that you are following: `` probably should have `'failable': ['*']`. I'm not sure this needs to be a new variant - I think adding variants requires us to update the sync and 'compose split' scripts? Maybe it can just be part of Everything? ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1381
dcavalca commented on the pull-request: `Add FEX-RootFS to the compose` that you are following: `` Yeah we definitely don't need this to be a variant, I wasn't sure if it was ok to just add to an existing one. Lemme see if I can have it added to Everything. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1381
dcavalca commented on the pull-request: `Add FEX-RootFS to the compose` that you are following: `` Dropped variant and made it failable. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1381
sgallagh commented on the pull-request: `Add FEX-RootFS to the compose` that you are following: `` This won't do anything; you need to make it a section under the `Everything` variant. Right now, it's not going to match anything. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1381
dcavalca commented on the pull-request: `Add FEX-RootFS to the compose` that you are following: `` Moved under `Everything`. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1381
ngompa commented on the pull-request: `Add FEX-RootFS to the compose` that you are following: `` Would it make sense under the container subvariant? ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1381
dcavalca commented on the pull-request: `Add FEX-RootFS to the compose` that you are following: `` I see that the container images set
``` 'target': global_target, 'bundle_name_format': '%N-%v-%I.%A.%T', ```
Not sure if we need these here too. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1381
dcavalca commented on the pull-request: `Add FEX-RootFS to the compose` that you are following: ``
Would it make sense under the container subvariant?
I have no strong preference. These images are conceptually similar to container images in content, but they're produced as filesystem images, not as tarballs. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1381
ngompa commented on the pull-request: `Add FEX-RootFS to the compose` that you are following: ``
I see that the container images set
'target': global_target, 'bundle_name_format': '%N-%v-%I.%A.%T',Not sure if we need these here too.
You probably need the global_target part, but not the bundle_name_format part. The only reason for the format override is because productmd didn't know how to match tarballs that didn't have the extension `.oci.tar.gz`properly. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1381
ngompa commented on the pull-request: `Add FEX-RootFS to the compose` that you are following: ``
Would it make sense under the container subvariant?
I have no strong preference. These images are conceptually similar to container images in content, but they're produced as filesystem images, not as tarballs.
It's fine to put under the Container subvariant then, it may even make sense to configure the FEX image to use the fedora container branding packages too. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1381
dcavalca commented on the pull-request: `Add FEX-RootFS to the compose` that you are following: `` Also now that I think of it, I think we need _both_ the image and the manifest (i.e. [Fedora.x86_64-Rawhide.packages](https://artifacts.dev.testing-farm.io/4bb68661-9054-44ee-8219-2bacaae8c539/w...)), as we use the manifest in the RPM to generate the license tag. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1381
dcavalca commented on the pull-request: `Add FEX-RootFS to the compose` that you are following: `` Moved under Container ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1381
ngompa commented on the pull-request: `Add FEX-RootFS to the compose` that you are following: `` You need to do the bundle format override here and set `'bundle_name_format': '%N-%v-%I.%A'`, since the default is different in `fedora-container.conf` than in `fedora.conf`. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1381
dcavalca commented on the pull-request: `Add FEX-RootFS to the compose` that you are following: ``
You need to do the bundle format override here and set `'bundle_name_format': '%N-%v-%I.%A'`, since the default is different in `fedora-container.conf` than in `fedora.conf`.
Fixed, thanks ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1381
ngompa commented on the pull-request: `Add FEX-RootFS to the compose` that you are following: `` Looks good to me. :thumbsup: ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1381
sgallagh commented on the pull-request: `Add FEX-RootFS to the compose` that you are following: `` Should the fedora-container version also be failable? ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1381
dcavalca commented on the pull-request: `Add FEX-RootFS to the compose` that you are following: ``
Should the fedora-container version also be failable?
Yeah, good call. Fixed. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1381
sgallagh commented on the pull-request: `Add FEX-RootFS to the compose` that you are following: `` OK, that looks good to me now. I'll merge this. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1381
sgallagh merged a pull-request against the project: `pungi-fedora` that you are following.
Merged pull-request:
`` Add FEX-RootFS to the compose ``
rel-eng@lists.fedoraproject.org
-
Adam Williamson -
Davide Cavalca
-
Neal Gompa
-
Stephen Gallagher