rishi opened a new pull-request against the project: `pungi-fedora` that you are following: `` Toolbx: Don't leak DISTTAG and FGC into the container ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1213
rishi commented on the pull-request: `Toolbx: Don't leak DISTTAG and FGC into the container` that you are following: `` This is NOT meant for Fedora 39. It's purely an exploratory change aimed at Fedora 40. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1213
kevin commented on the pull-request: `Toolbx: Don't leak DISTTAG and FGC into the container` that you are following: `` I think this was used when we pulled base images into OSBS to build layered images?
I can't seem to find much about it though...
``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1213
petersen commented on the pull-request: `Toolbx: Don't leak DISTTAG and FGC into the container` that you are following: `` Looks okay to me :-) ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1213
rishi commented on the pull-request: `Toolbx: Don't leak DISTTAG and FGC into the container` that you are following: ``
I think this was used when we pulled base images into OSBS to build layered images?
I can't seem to find much about it though...
Yes, the OSBS built `fedora-toolbox` images had `DISTTAG` and `FGC` defined in them, but they didn't come from the Dockerfile. So, I can only assume that it came from the build system.
Maybe we can try to drop them early in the Fedora 40 cycle and see if there's any fallout? What about the other images? ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1213
rishi commented on the pull-request: `Toolbx: Don't leak DISTTAG and FGC into the container` that you are following: `` A few scratch builds without `DISTTAG` and `FGC`: https://koji.fedoraproject.org/koji/taskinfo?taskID=108081570 https://koji.fedoraproject.org/koji/taskinfo?taskID=108082734 https://koji.fedoraproject.org/koji/taskinfo?taskID=108089874
The `aarch64` have always failed in my attempts to scratch build the `fedora-toolbox` image using Image Factory, with or without this change. It says: ``` ApplianceError: Image status is FAILED: Automated install failed or prompted for input. See the screenshot in the task results for more information ``` ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1213
humaton commented on the pull-request: `Toolbx: Don't leak DISTTAG and FGC into the container` that you are following: `` LGTM ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1213
humaton merged a pull-request against the project: `pungi-fedora` that you are following.
Merged pull-request:
`` Toolbx: Don't leak DISTTAG and FGC into the container ``
rishi commented on the pull-request: `Toolbx: Don't leak DISTTAG and FGC into the container` that you are following: `` Thanks, @humaton ! ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1213
rel-eng@lists.fedoraproject.org
-
Debarshi Ray -
Jens Petersen
-
Kevin Fenzi
-
Tomáš Hrčka