#1309: bodhi refuses to correctly edit update request

[Fedora Release Engineering]

#1309: bodhi refuses to correctly edit update request
----------------------+-----------------------------------------------------
 Reporter:  dnielsen  |       Owner:  [e-mail]
     Type:  task      |      Status:  new                            
Milestone:            |   Component:  other                          
 Keywords:            |  
----------------------+-----------------------------------------------------
 https://admin.fedoraproject.org/updates/F10/FEDORA-2009-2115

We are trying to get some harmless Mono bugs fixed, but when adding the
 mono-addins, mono-zeroconf, ndesk-dbus, ndesk-dbus-glib updates to the
 request. Bodhi will report that it has correctly edited the request, only
 to return to just having banshee.

[Fedora Release Engineering]

#1309: bodhi refuses to correctly edit update request
-----------------------+----------------------------------------------------
  Reporter:  dnielsen  |       Owner:  [e-mail]
      Type:  task      |      Status:  new                            
 Milestone:            |   Component:  other                          
Resolution:            |    Keywords:                                 
-----------------------+----------------------------------------------------
Comment (by jwboyer):

Replying to [ticket:1309 dnielsen]:
> https://admin.fedoraproject.org/updates/F10/FEDORA-2009-2115
>
> We are trying to get some harmless Mono bugs fixed, but when adding the

mono-addins, mono-zeroconf, ndesk-dbus, ndesk-dbus-glib updates to the
 request. Bodhi will report that it has correctly edited the request, only
 to return to just having banshee.

You should file this against bodhi, not rel-eng.

For expediency's sake, and given that the banshee package has already been
 pushed, just create a new update with the mono-zeroconf and ndesk-dbus*
 listed.

[Fedora Release Engineering]

#1309: bodhi refuses to correctly edit update request
-----------------------+----------------------------------------------------
  Reporter:  dnielsen  |       Owner:  [e-mail]
      Type:  task      |      Status:  new                            
 Milestone:            |   Component:  other                          
Resolution:            |    Keywords:                                 
-----------------------+----------------------------------------------------
Comment (by dnielsen):

ah with all these varying places to file things.. to hard to figure out
 the correct place. Regardless, bodhi says the updates already exist
 however searching for them do no reveal any such updates. Mighty strange

[Fedora Release Engineering]

#1309: bodhi refuses to correctly edit update request
-----------------------+----------------------------------------------------
  Reporter:  dnielsen  |       Owner:  [e-mail]
      Type:  task      |      Status:  closed                         
 Milestone:            |   Component:  other                          
Resolution:  fixed     |    Keywords:                                 
-----------------------+----------------------------------------------------
Changes (by lmacken):

* status:  new => closed
  * resolution:  => fixed

Comment:

There were a few stray builds in bodhi that were not associated with any
 updates.  I cleaned these up, and you should be able to edit this update
 now.  Please re-open this ticket if you still have problems.  Thanks!

[Fedora Release Engineering]

#1309: bodhi refuses to correctly edit update request
-----------------------+----------------------------------------------------
  Reporter:  dnielsen  |       Owner:  [e-mail]
      Type:  task      |      Status:  reopened                       
 Milestone:            |   Component:  other                          
Resolution:            |    Keywords:                                 
-----------------------+----------------------------------------------------
Changes (by dnielsen):

* status:  closed => reopened
  * resolution:  fixed =>

Comment:

Still happens, adding any such update makes bodhi claim they already
 exist.

[Fedora Release Engineering]

#1309: bodhi refuses to correctly edit update request
-----------------------+----------------------------------------------------
  Reporter:  dnielsen  |       Owner:  [e-mail]
      Type:  task      |      Status:  reopened                       
 Milestone:            |   Component:  other                          
Resolution:            |    Keywords:                                 
-----------------------+----------------------------------------------------
Comment (by lmacken):

Hmm, sorry about that.  Looking into it now...

[Fedora Release Engineering]

#1309: bodhi refuses to correctly edit update request
-----------------------+----------------------------------------------------
  Reporter:  dnielsen  |       Owner:  [e-mail]
      Type:  task      |      Status:  reopened                       
 Milestone:            |   Component:  other                          
Resolution:            |    Keywords:                                 
-----------------------+----------------------------------------------------
Comment (by lmacken):

Ok, the stray builds were there again, and I just wiped them out... please
 give it another shot.

I think the core of this problem is a bug that occurs when editing the
 builds of an existing update.  I've seen it happen a few times in the
 past, but I haven't been able to track it down.

What did you do to get to this point?  Were you just trying to add new
 builds to an existing update that was in testing?

Thank you for your patience with this issue.  Hopefully we can resolve it
 soon.

[Fedora Release Engineering]

#1309: bodhi refuses to correctly edit update request
-----------------------+----------------------------------------------------
  Reporter:  dnielsen  |       Owner:  [e-mail]
      Type:  task      |      Status:  reopened                       
 Milestone:            |   Component:  other                          
Resolution:            |    Keywords:                                 
-----------------------+----------------------------------------------------
Comment (by salimma):

Here's the timeline, as far as I remembered it:

- update containing ndesk-dbus, ndesk-dbus-glib, mono-addins created on
 Bodhi
 - edited to add mono-zeroconf
 - I noticed that this causes an ABI breakage for banshee. At this point
 the karma was at +2.
   Commented to ask dnielsen to unrequest the push, and filed a request to
 put mono-zeroconf on
   -override to build against (#1305)
 - built Banshee, tried to edit the ticket, and getting a 500 error
   I commented this on the Bugzilla ticket
 (https://bugzilla.redhat.com/show_bug.cgi?id=487155)
 - dnielsen reported having problems with Bodhi as well. the update then
 suddenly contained only
   Banshee -- not sure about the details here

[Fedora Release Engineering]

#1309: bodhi refuses to correctly edit update request
-----------------------+----------------------------------------------------
  Reporter:  dnielsen  |       Owner:  [e-mail]
      Type:  task      |      Status:  reopened                       
 Milestone:            |   Component:  other                          
Resolution:            |    Keywords:                                 
-----------------------+----------------------------------------------------
Comment (by lmacken):

So I think I tracked down the issue.  The builds that you are trying to
 add to this update (mono-addins-0.3.1-3.fc10.2, mono-
 zeroconf-0.7.6-4.fc10, ndesk-dbus-glib-0.4.1-4.fc10, ndesk-
 dbus-0.6.1a-4.fc10) were already tagged as dist-f10-updates-testing.  I
 think that when editing an update, bodhi is failing to properly handle
 this case.  I think I found the flawed logic in bodhi's save method, and
 will look into fixing this.

[Fedora Release Engineering]

#1309: bodhi refuses to correctly edit update request
-----------------------+----------------------------------------------------
  Reporter:  dnielsen  |       Owner:  [e-mail]
      Type:  task      |      Status:  reopened                       
 Milestone:            |   Component:  other                          
Resolution:            |    Keywords:                                 
-----------------------+----------------------------------------------------
Comment (by lmacken):

I believe I may have just fixed this issue in bodhi
 [https://fedorahosted.org/bodhi/changeset/d0478c546b8c42ab56f701916e613a38e4f...
 changeset d0478c546b8c42ab56f701916e613a38e4fecb60].

[Fedora Release Engineering]

#1309: bodhi refuses to correctly edit update request
-----------------------+----------------------------------------------------
  Reporter:  dnielsen  |       Owner:  [e-mail]
      Type:  task      |      Status:  reopened                       
 Milestone:            |   Component:  other                          
Resolution:            |    Keywords:                                 
-----------------------+----------------------------------------------------
Comment (by salimma):

I'm trying to push a new update now, but hit an error:

mono-zeroconf-0.7.6-4.fc10 not tagged as an update candidate

Could it be re-tagged? Thanks.

[Fedora Release Engineering]

#1309: bodhi refuses to correctly edit update request
-----------------------+----------------------------------------------------
  Reporter:  dnielsen  |       Owner:  [e-mail]
      Type:  task      |      Status:  reopened                       
 Milestone:            |   Component:  other                          
Resolution:            |    Keywords:                                 
-----------------------+----------------------------------------------------
Comment (by lmacken):

mono-zeroconf-0.7.6-4.fc10 was tagged with both dist-f10-override and
 dist-f10-updates-candidate.  Looks like bodhi should be smart enough to
 handle this scenario, but in the mean time I removed the override tag.

[Fedora Release Engineering]

#1309: bodhi refuses to correctly edit update request
-----------------------+----------------------------------------------------
  Reporter:  dnielsen  |       Owner:  [e-mail]
      Type:  task      |      Status:  closed                         
 Milestone:            |   Component:  other                          
Resolution:  fixed     |    Keywords:                                 
-----------------------+----------------------------------------------------
Changes (by lmacken):

* status:  reopened => closed
  * resolution:  => fixed

Comment:

This issue seems to be resolved.  Please reopen this ticket if that is not
 the case, or file bodhi issues here: http://bodhi.fedorahosted.org --
 Thanks!