[pungi-fedora] Issue #1342: Kiwi-built lives go to images/ (not iso/), have type "iso" instead of "live"
adamwill reported a new issue against the project: `pungi-fedora` that you are following: `` We got our first Kiwi-built lives in recent Rawhide composes, but there are a couple of problems:
1. They wind up in the images/ subdirectory, not the iso/ subdirectory as they should, see e.g. https://kojipkgs.fedoraproject.org/compose/rawhide/Fedora-Rawhide-20240828.n... 2. In the images metadata, their type is "iso". It should be "live". (The *format* is also "iso", which is correct.)
@ngompa @kevin ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/issue/1342
adamwill added a new comment to an issue you are following: `` Oh, and one more: the `bootable` property is set `false`, it should be `true`. (I don't know of anything that reads this, but hey, let's be correct). ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/issue/1342
lsedlar added a new comment to an issue you are following: `` This needs changes directly in Pungi. It now sets the location and `bootable` property with no option to change it from the configuration. Deciding between iso/ and images/ directories seems easy, but how can bootability be detected? ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/issue/1342
adamwill added a new comment to an issue you are following: `` How do we do it for the existing live images? ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/issue/1342
lsedlar added a new comment to an issue you are following: `` Those are all bootable. All phases hardcode some value for all produced images, with the exception of DVDs, where Pungi is actually creating them and thus knows what the result is. For anything created by a dedicated Koji task, there's a default value. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/issue/1342
ngompa added a new comment to an issue you are following: `` Kiwi does not produce non-bootable ISOs (at least not intentionally). ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/issue/1342
ngompa added a new comment to an issue you are following: `` Insofar as the type goes, @kevin and I figured out that pungi was propagating the kiwi image build type into the the pungi type data, so I sent a PR to productmd to recognize it. If we _don't_ want to do that, then we need some way of telling pungi what type it is without breaking kiwibuild. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/issue/1342
ngompa added a new comment to an issue you are following: `` Perhaps one way to resolve this is to rename `type` for kiwibuild to `build_type` and use `type` for the pungi/productmd type? ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/issue/1342
lsedlar added a new comment to an issue you are following: ``
Kiwi does not produce non-bootable ISOs (at least not intentionally).
That's good to know. We could do this: https://pagure.io/pungi/pull-request/1782 If it's an ISO, it's bootable and goes to `iso/`. Otherwise, put it to `images/` and list as not-bootable.
The kiwi documentation suggests that any ISO is going to be of the `live` variety. If it can't do netinst or dvd, we could simply default to `live` for any ISO produced by kiwi. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/issue/1342
ngompa added a new comment to an issue you are following: `` kiwi can produce what are known as "installisos" for the `oem` type, such that it will produce _both_ a disk image and a wrapper iso file that will contain a simple installer to flash the image from a usb stick or dvd to a disk. So it is possible to have non-live ISO files. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/issue/1342
ngompa added a new comment to an issue you are following: `` I have also been looking into producing netinst ISOs with kiwi, though that is a bit further away from _right now_, and it is possible to produce install dvds if you have a way to merge an offline repo and its configuration into a netinst ISO. So I don't necessarily want to assume that in the future we won't make those too. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/issue/1342
adamwill added a new comment to an issue you are following: `` I believe merging Neal's productmd PR was wrong. It is not correct for any image to have `iso` as its "type". We should not accept kiwi doing that, we should fix the kiwi pipeline so that does not happen. The types need to be correct.
I don't really care about the details of how that is managed between kiwi and pungi and koji, but I'm going to be pretty firm about the end result: live ISOs need to have type `live` and format `iso`, and should be bootable `true`. It's not acceptable to break productmd's expectations to make life convenient for kiwi, doing that makes it pointless to have metadata in the first place.
For bonus points the mechanism should be flexible enough that we can potentially also do a live ISO with a special type like `live-kiwi`, as we do for osbuild with `live-osbuild`; this makes it easier to consider moving existing live images to be built with Kiwi as it allows for a transition period where we build the image with *both* tools for a while, until we're confident the image built with Kiwi is good enough to usurp the existing image and take the `live` type. Adding types like *that* to productmd is legitimate IMO. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/issue/1342
ngompa added a new comment to an issue you are following: `` Then pungi needs to change to decouple kiwi's build types from product types. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/issue/1342
adamwill added a new comment to an issue you are following: `` To illustrate why we have the difference between "format" and "type", consider that we have both a Server DVD ISO and a Server network install ISO, and a Workstation live ISO and a Workstation network install ISO. The "type" concept is what differentiates between these. If we just called them all "ISO" you could not programatically distinguish between those pairs without parsing the filename, and avoiding having to do that is the point of having metadata.
It's acceptable for type and format to be the same for an image if the format effectively *defines* the type - you couldn't have another image of the same type but in a different format. This is clearly not the case for the ISO format. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/issue/1342
lsedlar added a new comment to an issue you are following: `` https://pagure.io/pungi/pull-request/1782 is updated to make it possible to set the desired type explicitly in the config file. The osbuild phase already has this functionality, so there's some precedent for naming. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/issue/1342
lsedlar added a new comment to an issue you are following: `` Commit [d9d21d3c](https://pagure.io/pungi-fedora/c/d9d21d3c) relates to this ticket ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/issue/1342
adamwill added a new comment to an issue you are following: `` lsedlar also built the pungi fix as 4.7.0-3 - thanks. Updates are available for all releases - https://bodhi.fedoraproject.org/updates/?packages=pungi . ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/issue/1342
The status of the issue: `Kiwi-built lives go to images/ (not iso/), have type "iso" instead of "live"` of project: `pungi-fedora` has been updated to: Closed as Fixed by adamwill.
adamwill added a new comment to an issue you are following: `` https://pagure.io/pungi-fedora/pull-request/1338 and https://bodhi.fedoraproject.org/updates/FEDORA-2024-8003545aeb are the outstanding bits now, AIUI, to apply the fix to F41. But I think we can close this as the images are only enabled at all in Rawhide ATM, and Rawhide is fixed. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/issue/1342
rel-eng@lists.fedoraproject.org
-
Adam Williamson -
Lubomír Sedlář
-
Neal Gompa