[pungi-fedora] PR #263: Fix docker_label keyword and fix label caps

[Adam Miller]

maxamillion opened a new pull-request against the project: `pungi-fedora` that you are
following:
``
Fix docker_label keyword and fix label caps
``

To reply, visit the link below or just reply to this email
https://pagure.io/pungi-fedora/pull-request/263

[Dennis Gilmore]

ausil commented on the pull-request: `Fix docker_label keyword and fix label caps` that
you are following:
``
fedora-beta.conf needs to not change. it is there for a historical record of the beta
compose config
``

To reply, visit the link below or just reply to this email
https://pagure.io/pungi-fedora/pull-request/263

[Mohan Boddu]

mohanboddu commented on the pull-request: `Fix docker_label keyword and fix label caps`
that you are following:
``
@maxamillion are you sure these are correct? since the docs has what we use
https://docs.pagure.org/pungi/configuration.html#id25 and the RC failed when I used the
values from this PR
https://koji.fedoraproject.org/koji/taskinfo?taskID=20290824
``

To reply, visit the link below or just reply to this email
https://pagure.io/pungi-fedora/pull-request/263

[Adam Miller]

maxamillion commented on the pull-request: `Fix docker_label keyword and fix label caps`
that you are following:
``
Yeah, so it wasn't working previously and I assumed that was because the configuration
key was incorrect as it is `docker_labels` in the pungi config but `docker_label` in the
[imagefactory
code](https://github.com/redhat-imaging/imagefactory/blob/master/imagefac....
I also couldn't find either value in the pungi code base so it didn't appear as
though that key was being altered before being passed to the imagefactor plugin. I'll
debug.
``

To reply, visit the link below or just reply to this email
https://pagure.io/pungi-fedora/pull-request/263

[Adam Miller]

maxamillion commented on the pull-request: `Fix docker_label keyword and fix label caps`
that you are following:
``
I found the issue, it turns out that my fix was almost correct. However that dict needs to
actually be passed as a string because the python string output of a dict uses single
quotes (`'`) even if you define the dict using double quotes (`"`), and single
quotes are invalid json. Also in here is an unicode entry (`u"MIT"`) for the
dict, which is also not valid json. I'll update the related PRs.
``

To reply, visit the link below or just reply to this email
https://pagure.io/pungi-fedora/pull-request/263

[Dusty Mabe]

dustymabe commented on the pull-request: `Fix docker_label keyword and fix label caps`
that you are following:
``
I would only change fedora-docker.conf for f26 branch 
``

To reply, visit the link below or just reply to this email
https://pagure.io/pungi-fedora/pull-request/263

[Dennis Gilmore]

ausil merged a pull-request against the project: `pungi-fedora` that you are following.

Merged pull-request:

``
Fix docker_label keyword and fix label caps
``

https://pagure.io/pungi-fedora/pull-request/263